GNU bug report logs - #50717
[PATCH] Shepherd: Add respawn-limit paramter to service class.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50717 in the body.
You can then email your comments to 50717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Subject: [PATCH] Shepherd: Add respawn-limit paramter to service class.
Date: Tue, 21 Sep 2021 00:42:14 -0700

[Message part 1 (text/plain, inline)]

Hello Guix devs,

This patch to GNU Shepherd removes the hard-coded respawn limit and
makes it a configurable option.
The respawn limit works generally the same way as before, allowing N
respawns in M seconds:

#:respawn-limit '(N . M)

We can disable respawns by setting N to 0, which will abort the service
after the first crash. Likewise, we can always respawn by setting

#:respawn-limit #f


Sincerely,
Ryan Sundberg

[0001-service-Add-respawn-limit-paramter-to-the-service-cl.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 50717 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ryan Sundberg <ryan <at> arctype.co>
Cc: 50717 <at> debbugs.gnu.org
Subject: Re: bug#50717: [PATCH] Shepherd: Add respawn-limit paramter to
 service class.
Date: Fri, 01 Oct 2021 10:11:20 +0000

Hello Ryan,

> We can disable respawns by setting N to 0, which will abort the service
> after the first crash. Likewise, we can always respawn by setting
>
> #:respawn-limit #f

Looks nice, thanks for the patch. I have the following error while
applying it though:

--8<---------------cut here---------------start------------->8---
Applying: service: Add respawn-limit paramter to the service class.
error: corrupt patch at line 52
--8<---------------cut here---------------end--------------->8---

Could you try to send it with git-send-email?

It would also be nice to add unit tests dedicated to this new feature and
update the documentation.

Thanks,

Mathieu

Message #13 received at 50717-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Sundberg <ryan <at> arctype.co>
Cc: 50717-done <at> debbugs.gnu.org
Subject: Re: [bug#50717] [PATCH] Shepherd: Add respawn-limit paramter to
 service class.
Date: Tue, 02 Jan 2024 23:31:59 +0100

Hi Ryan,

Ryan Sundberg <ryan <at> arctype.co> skribis:

> This patch to GNU Shepherd removes the hard-coded respawn limit and
> makes it a configurable option.
> The respawn limit works generally the same way as before, allowing N
> respawns in M seconds:
>
> #:respawn-limit '(N . M)

This is was eventually implemented (independently, oops!) in commit
93baa23baee1e0c62d46d9fd041fc1dabc081f26 (June 2023), which made it in
0.10.2.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.