GNU bug report logs - #50724
[PATCH 1/3] gnu: Add python-charset-normalizer.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50724 in the body.
You can then email your comments to 50724 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/3] gnu: Add python-charset-normalizer.
Date: Tue, 21 Sep 2021 21:19:06 +0200

* gnu/packages/python-xyz.scm (python-charset-normalizer): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 88c89ed201..7239fa1584 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11819,6 +11819,27 @@ automatically detect a wide range of file encodings.")
 (define-public python2-chardet
   (package-with-python2 python-chardet))
 
+(define-public python-charset-normalizer
+  (package
+    (name "python-charset-normalizer")
+    (version "2.0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "charset-normalizer" version))
+       (sha256
+        (base32 "0rr3iv2xw4rz5ijnfqk229fw85cq6p6rhqqsilm0ldzncblfg63h"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/ousret/charset_normalizer")
+    (synopsis "Universal Charset Detector, alternative to Chardet")
+    (description "This library helps you read text from an unknown charset
+encoding.  Motivated by @code{chardet}, it tries to resolve the issue by
+taking a new approach.  All IANA character set names for which the Python core
+library provides codecs are supported.")
+    (license license:expat)))
+
 (define-public python-docopt
   (package
     (name "python-docopt")
-- 
2.30.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 50724 <at> debbugs.gnu.org,
	guix-patches <at> gnu.org
Subject: [PATCH 2/3] gnu: Add python-platformdirs.
Date: Tue, 21 Sep 2021 21:22:11 +0200

* gnu/packages/python-xyz.scm (python-platformdirs): New variable.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7239fa1584..908e9dbff6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -26799,3 +26799,29 @@ services' API.  It includes a pre-defined set of classes for API resources
 that initialize themselves dynamically from API responses which makes it
 compatible with a wide range of versions of the Stripe API.")
     (license license:expat)))
+
+(define-public python-platformdirs
+  (package
+    (name "python-platformdirs")
+    (version "2.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "platformdirs" version))
+       (sha256
+        (base32 "07hq5qrp7pqj63iczg01wbf5ii6f0ncd0dq5mzkdhsslmg9slbb3"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-appdirs" ,python-appdirs)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-mock" ,python-pytest-mock)))
+    (home-page "https://github.com/platformdirs/platformdirs")
+    (synopsis "Determine the appropriate platform-specific dirs, e.g. \"user
+data dir\"")
+    (description "When writing applications, finding the right location to
+store user data and configuration varies per platform.  Even for
+single-platform apps, there may by plenty of nuances in figuring out the right
+location.  This small Python module determines the appropriate
+platform-specific directories, e.g. the \"user data dir\".")
+    (license license:expat)))
-- 
2.30.2

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 50724 <at> debbugs.gnu.org,
	guix-patches <at> gnu.org
Subject: [PATCH 3/3] gnu: Add python-zeep.
Date: Tue, 21 Sep 2021 21:22:12 +0200

* gnu/packages/python-web.scm (python-zeep): New variable.
---
 gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 302e5d6459..10507240e1 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -6234,3 +6234,45 @@ communicate with Microsoft Azure Storage services.")
 or tags from HTML snippets, extract base url from HTML snippets, translate entites
 on HTML strings, among other things.")
     (license license:bsd-3)))
+
+(define-public python-zeep
+  (package
+    (name "python-zeep")
+    (version "4.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "zeep" version))
+       (sha256
+        (base32 "1ranr4hkjd2kbbhxa3is1qlgkankj3sml5gla6bqs0kbvpmg4rsq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-attrs" ,python-attrs)
+       ("python-cached-property" ,python-cached-property)
+       ("python-isodate" ,python-isodate)
+       ("python-lxml" ,python-lxml)
+       ("python-platformdirs" ,python-platformdirs)
+       ("python-pytz" ,python-pytz)
+       ("python-requests" ,python-requests)
+       ("python-requests-file" ,python-requests-file)
+       ("python-requests-toolbelt" ,python-requests-toolbelt)))
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ;;("python-flake8" ,python-flake8)
+       ;; ("python-flake8-blind-except" ,python-flake8-blind-except)
+       ;; ("python-flake8-debugger" ,python-flake8-debugger)
+       ;; ("python-flake8-imports" ,python-flake8-imports)
+       ("python-freezegun" ,python-freezegun)
+       ;;("python-isort" ,python-isort)
+       ("python-mock" ,python-mock)
+       ("python-pretend" ,python-pretend)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-asyncio" ,python-pytest-asyncio)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-httpx" ,python-pytest-httpx)
+       ("python-requests-mock" ,python-requests-mock)))
+    (home-page "http://docs.python-zeep.org")
+    (synopsis "Fast and modern Python SOAP client")
+    (description "This package provides a fast and modern Python SOAP client
+based on lxml and requests.")
+    (license license:expat)))
-- 
2.30.2

Message #20 received at 50724 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 50724 <at> debbugs.gnu.org
Subject: Re: [bug#50724] [PATCH 2/3] gnu: Add python-platformdirs.
Date: Tue, 21 Sep 2021 22:12:04 +0200

[Message part 1 (text/plain, inline)]

On Tue, Sep 21 2021, Hartmut Goebel wrote:

> * gnu/packages/python-xyz.scm (python-platformdirs): New variable.
> ---
>  gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7239fa1584..908e9dbff6 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -26799,3 +26799,29 @@ services' API.  It includes a pre-defined set of classes for API resources
>  that initialize themselves dynamically from API responses which makes it
>  compatible with a wide range of versions of the Stripe API.")
>      (license license:expat)))
> +
> +(define-public python-platformdirs
> +  (package
> +    (name "python-platformdirs")
> +    (version "2.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "platformdirs" version))
> +       (sha256
> +        (base32 "07hq5qrp7pqj63iczg01wbf5ii6f0ncd0dq5mzkdhsslmg9slbb3"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-appdirs" ,python-appdirs)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pytest-cov" ,python-pytest-cov)
> +       ("python-pytest-mock" ,python-pytest-mock)))
> +    (home-page "https://github.com/platformdirs/platformdirs")
> +    (synopsis "Determine the appropriate platform-specific dirs, e.g. \"user
> +data dir\"")

The example is also mentioned in the description, so I would drop the
“e.g. ...” part.  Also, I would write “directories” instead of “dirs”,
just for the sake of clarity.

> +    (description "When writing applications, finding the right location to
> +store user data and configuration varies per platform.  Even for
> +single-platform apps, there may by plenty of nuances in figuring out the right
> +location.  This small Python module determines the appropriate
> +platform-specific directories, e.g. the \"user data dir\".")

Use ``'' instead of "", see the Texinfo manual on quote characters.

  <https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html#Inserting-Quote-Characters>

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 50724 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 50724 <at> debbugs.gnu.org
Subject: Re: [bug#50724] [PATCH 3/3] gnu: Add python-zeep.
Date: Tue, 21 Sep 2021 22:16:27 +0200

[Message part 1 (text/plain, inline)]

On Tue, Sep 21 2021, Hartmut Goebel wrote:

> * gnu/packages/python-web.scm (python-zeep): New variable.
> ---
>  gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 302e5d6459..10507240e1 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -6234,3 +6234,45 @@ communicate with Microsoft Azure Storage services.")
>  or tags from HTML snippets, extract base url from HTML snippets, translate entites
>  on HTML strings, among other things.")
>      (license license:bsd-3)))
> +
> +(define-public python-zeep
> +  (package
> +    (name "python-zeep")
> +    (version "4.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "zeep" version))
> +       (sha256
> +        (base32 "1ranr4hkjd2kbbhxa3is1qlgkankj3sml5gla6bqs0kbvpmg4rsq"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-attrs" ,python-attrs)
> +       ("python-cached-property" ,python-cached-property)
> +       ("python-isodate" ,python-isodate)
> +       ("python-lxml" ,python-lxml)
> +       ("python-platformdirs" ,python-platformdirs)
> +       ("python-pytz" ,python-pytz)
> +       ("python-requests" ,python-requests)
> +       ("python-requests-file" ,python-requests-file)
> +       ("python-requests-toolbelt" ,python-requests-toolbelt)))
> +    (native-inputs
> +     `(("python-coverage" ,python-coverage)
> +       ;;("python-flake8" ,python-flake8)
> +       ;; ("python-flake8-blind-except" ,python-flake8-blind-except)
> +       ;; ("python-flake8-debugger" ,python-flake8-debugger)
> +       ;; ("python-flake8-imports" ,python-flake8-imports)
> +       ("python-freezegun" ,python-freezegun)
> +       ;;("python-isort" ,python-isort)

Why are some of these inputs commented out?

> +       ("python-mock" ,python-mock)
> +       ("python-pretend" ,python-pretend)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pytest-asyncio" ,python-pytest-asyncio)
> +       ("python-pytest-cov" ,python-pytest-cov)
> +       ("python-pytest-httpx" ,python-pytest-httpx)

‘python-pytest-httpx’ doesn’t seem to exist; which commit are you basing
these patches off of?  My checkout is based off of commit
5966d48d1c9e48b7098845193469f5b5fe07d540.

This is why people should be using the ‘--base’ flag when invoking ‘git
format-patch’.  :-)

> +       ("python-requests-mock" ,python-requests-mock)))
> +    (home-page "http://docs.python-zeep.org")

Why not HTTPS?

> +    (synopsis "Fast and modern Python SOAP client")
> +    (description "This package provides a fast and modern Python SOAP client
> +based on lxml and requests.")

I would use @code{python-lxml} and @code{python-requests} to make it
clear that these are packages and not just regular words.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 50724 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Xinglu Chen <public <at> yoctocell.xyz>, 50724 <at> debbugs.gnu.org
Subject: Re: [bug#50724] [PATCH 3/3] gnu: Add python-zeep.
Date: Thu, 23 Sep 2021 19:09:57 +0200

Hi Xinglu,
> ‘python-pytest-httpx’ doesn’t seem to exist; which commit are you basing

Ups, Sorry for wasting your time by submitting an incomplete patch. I 
withdrew the patch.

I cherry-picked this patch from another pile of patches, which contains 
python-pytest-httpx. Anyhow packaging python-pytest-httpx ended up in 
updating many other packages, updating which is to touchy for me.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #29 received at 50724 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Xinglu Chen <public <at> yoctocell.xyz>, 50724 <at> debbugs.gnu.org
Subject: Re: [bug#50724] [PATCH 2/3] gnu: Add python-platformdirs.
Date: Thu, 23 Sep 2021 19:11:22 +0200

Hi Xinglu,

thanks for the fast review.

I adjusted python-platformdirs as you recommended and pushed both 
python-charset-normalizer and python-platformdirs as 
a24ae17e230d8d1f8b036c298e68fdcb08edff62

The python-zeep I withdrew.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          |h.goebel <at> crazy-compilers.com                |
|www.crazy-compilers.com  | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.