GNU bug report logs - #50740
[PATCH] gnu: Add wmname.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50740 in the body.
You can then email your comments to 50740 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: guix-patches <at> gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Subject: [PATCH] gnu: Add wmname.
Date: Wed, 22 Sep 2021 16:28:31 +0000

* gnu/packages/suckless.scm (wmname): New variable.
---
 gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..314d8d5e44 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -488,6 +488,36 @@ few minutes.")
     (home-page "https://tools.suckless.org/sent")
     (license license:x11)))
 
+(define-public wmname
+  (package
+    (name "wmname")
+    (version "0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/tools/wmname-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "1i82ilhbk36hspc2j0fbpg27wjj7xnvzpv1ppgf6fccina4d36jm"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "PREFIX=" %output))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)))) ; No configure script
+    (inputs
+     `(("libx11" ,libx11)))
+    (home-page "https://tools.suckless.org/x/wmname/")
+    (synopsis "Print or set the window manager name")
+    (description "wmname prints/sets the window manager name property of the
+root window similar to how hostname(1) behaves.  It is useful for fixing
+problems with JDK versions and other broken programs assuming a reparenting
+window manager for instance.")
+    (license license:x11)))
+
 (define-public xbattmon
   (package
     (name "xbattmon")
-- 
2.33.0

Message #8 received at 50740 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 50740 <at> debbugs.gnu.org
Subject: Re: [bug#50740] [PATCH] gnu: Add wmname.
Date: Wed, 22 Sep 2021 16:42:09 -0700

Hello,

Thanks for your patch.  I have a couple small suggestions, but otherwise it looks
good to me!

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> writes:

> * gnu/packages/suckless.scm (wmname): New variable.
> ---
>  gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index b24eced379..314d8d5e44 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -488,6 +488,36 @@ few minutes.")
>      (home-page "https://tools.suckless.org/sent")
>      (license license:x11)))
>  
> +(define-public wmname
> +  (package
> +    (name "wmname")
> +    (version "0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dl.suckless.org/tools/wmname-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32 "1i82ilhbk36hspc2j0fbpg27wjj7xnvzpv1ppgf6fccina4d36jm"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f

Please always comment "#:tests? #f", even if it's just "no test
suite"/"no tests".

> +       #:make-flags
> +       (list (string-append "CC=" ,(cc-for-target))
> +             (string-append "PREFIX=" %output))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)))) ; No configure script
> +    (inputs
> +     `(("libx11" ,libx11)))
> +    (home-page "https://tools.suckless.org/x/wmname/")
> +    (synopsis "Print or set the window manager name")
> +    (description "wmname prints/sets the window manager name property of the
> +root window similar to how hostname(1) behaves.  It is useful for fixing
> +problems with JDK versions and other broken programs assuming a reparenting
> +window manager for instance.")

Consider:

    (description "@command{wmname} prints/sets the window manager name
property of the root window, similar to how @command{hostname} behaves.  It is
useful for fixing problems with JDK versions and other broken programs, such
as those which assume a reparenting window manager.")


> +    (license license:x11)))

Though the license header *says* "MIT/X Consortium", the actual license
text looks like expat to me [0].

* Package review checklist (WIP)
Lack of a check is not proof of noncompliance.

1. [ ] Package builds (guix build package)
     [X] x86_64  [ ] aarch64  [ ] armhf     [ ] powerpc64le
     [ ] i686    [ ] i586     [ ] mips64le
2. [ ] Build is reproducible (guix build --rounds=n package)
3. [ ] Tests enabled (if available) or disabled with in-source comment
4. [ ] No extraneous dependencies (guix size package)
5. [ ] No unnecessary pre-built binaries/blobs
6. [ ] Dependencies unvendored when available in Guix
7. [ ] Cross-compile friendly (cc-for-target, patches with inputs)
8. [ ] License matches source
9. [ ] No problematic lints (guix lint package)
10. [ ] Formatting follows guidelines
    - [ ] Lines wrap at 80 characters
    - [ ] Indentation passes etc/indent-code.el
    - [ ] Two spaces used between sentences

For new packages:
1. [ ] Source url is robust
   * mirror:// used with url-fetch when possible
   * No auto-generated archives from source repo (prefer cloning)
2. [ ] Synopsis is short, descriptive, and meaningful to a wide audience
3. [ ] Description is objective, takes 5-10 lines, uses full sentences,
   and provides the information users need to decide whether the
   software fits their needs.


[0] https://en.wikipedia.org/wiki/MIT_License

--
Sarah

Message #11 received at 50740 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 50740 <at> debbugs.gnu.org
Subject: Re: [bug#50740] [PATCH] gnu: Add wmname.
Date: Wed, 22 Sep 2021 16:50:04 -0700

Hi,

Sarah Morgensen <iskarian <at> mgsn.dev> writes:

>
> Though the license header *says* "MIT/X Consortium", the actual license
> text looks like expat to me [0].
>
> * Package review checklist (WIP)
> Lack of a check is not proof of noncompliance.
>
> 1. [ ] Package builds (guix build package)
>      [X] x86_64  [ ] aarch64  [ ] armhf     [ ] powerpc64le
>      [ ] i686    [ ] i586     [ ] mips64le
> 2. [ ] Build is reproducible (guix build --rounds=n package)
> 3. [ ] Tests enabled (if available) or disabled with in-source comment
> 4. [ ] No extraneous dependencies (guix size package)
> 5. [ ] No unnecessary pre-built binaries/blobs
> 6. [ ] Dependencies unvendored when available in Guix
> 7. [ ] Cross-compile friendly (cc-for-target, patches with inputs)
> 8. [ ] License matches source
> 9. [ ] No problematic lints (guix lint package)
> 10. [ ] Formatting follows guidelines
>     - [ ] Lines wrap at 80 characters
>     - [ ] Indentation passes etc/indent-code.el
>     - [ ] Two spaces used between sentences
>
> For new packages:
> 1. [ ] Source url is robust
>    * mirror:// used with url-fetch when possible
>    * No auto-generated archives from source repo (prefer cloning)
> 2. [ ] Synopsis is short, descriptive, and meaningful to a wide audience
> 3. [ ] Description is objective, takes 5-10 lines, uses full sentences,
>    and provides the information users need to decide whether the
>    software fits their needs.

Apologies for unintentionally including an empty copy of this.  I'm
still tweaking my Emacs bindings :)

--
Sarah

Message #14 received at 50740 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 50740 <at> debbugs.gnu.org
Subject: Re: [bug#50740] [PATCH] gnu: Add wmname.
Date: Thu, 23 Sep 2021 14:16:26 +0000 (UTC)

Hi, Sarah,

Sep 23, 2021 02:42:19 Sarah Morgensen <iskarian <at> mgsn.dev>:

> Hello,
>
> Thanks for your patch.  I have a couple small suggestions, but otherwise it looks
> good to me!

Thank you for the corrections! I will come back with a V2 at the beginning of the next week, as I will not be having access to a computer for the next few days. I hope that isn't a problem.

Cheers,
Sergiu

Message #17 received at 50740 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: 50740 <at> debbugs.gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>,
 Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: [PATCH v2] gnu: Add wmname.
Date: Tue, 28 Sep 2021 20:17:24 +0000

* gnu/packages/suckless.scm (wmname): New variable.
---

I applied the changes suggested by Sarah and added a copyright line. I left
the license set to license:x11 because I saw that other suckless packages that
seem to have the same license still use license:x11 (such as dwm).

 gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..4ca353ad51 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2017 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2018–2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
+;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -488,6 +489,36 @@ few minutes.")
     (home-page "https://tools.suckless.org/sent")
     (license license:x11)))
 
+(define-public wmname
+  (package
+    (name "wmname")
+    (version "0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/tools/wmname-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "1i82ilhbk36hspc2j0fbpg27wjj7xnvzpv1ppgf6fccina4d36jm"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "PREFIX=" %output))
+       #:phases                         ; no tests
+       (modify-phases %standard-phases
+         (delete 'configure))))         ; no configure script
+    (inputs
+     `(("libx11" ,libx11)))
+    (home-page "https://tools.suckless.org/x/wmname/")
+    (synopsis "Print or set the window manager name")
+    (description "@command{wmname} prints/sets the window manager name
+property of the root window similar to how @command{hostname} behaves.  It is
+useful for fixing problems with JDK versions and other broken programs
+assuming a reparenting window manager for instance.")
+    (license license:x11)))
+
 (define-public xbattmon
   (package
     (name "xbattmon")
-- 
2.33.0

Message #20 received at 50740 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 50740 <at> debbugs.gnu.org
Subject: Re: [bug#50740] [PATCH v2] gnu: Add wmname.
Date: Tue, 28 Sep 2021 18:23:59 -0700

Hello,

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> writes:

> * gnu/packages/suckless.scm (wmname): New variable.
> ---
>
> I applied the changes suggested by Sarah and added a copyright line. I left
> the license set to license:x11 because I saw that other suckless packages that
> seem to have the same license still use license:x11 (such as dwm).

Thanks for sending an updated patch.

Regarding licensing...

Just because other people are doing something doesn't mean it's the
right answer :)  But if we don't trust interpreting the license text
ourselves, let's check with a third party source:

It looks like the fsf wiki lists wmname as expat [0].

In fact, I checked a few other suckless packages which we list as x11,
and the fsf wiki also lists them as expat instead: dwm [1], dmenu [2],
ST [3].

So those are incorrect.  I suppose I'll open a bug for that.

[0] https://directory.fsf.org/wiki/Wmname#tab=Details
[1] https://directory.fsf.org/wiki/Dwm#tab=Details
[2] https://directory.fsf.org/wiki/Dmenu#tab=Details
[3] https://directory.fsf.org/wiki/ST#tab=Details

--
Sarah

Message #25 received at 50740-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 50740-done <at> debbugs.gnu.org, Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: Re: bug#50740: [PATCH] gnu: Add wmname.
Date: Wed, 13 Oct 2021 10:45:20 +0200

Hi,

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> skribis:

> * gnu/packages/suckless.scm (wmname): New variable.

I changed the license to ‘expat’ as Sarah rightfully suggested and
applied it.

Thank you, and thanks Sarah for the careful review!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.