GNU bug report logs - #50757
[PATCH] gnu: Add babeltrace.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Olivier Dion <olivier.dion@HIDDEN>; Keywords: patch moreinfo; dated Thu, 23 Sep 2021 13:12:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Ludovic Courtès <ludo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 50757 <at> debbugs.gnu.org:


Received: (at 50757) by debbugs.gnu.org; 23 Sep 2021 19:30:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 23 15:30:14 2021
Received: from localhost ([127.0.0.1]:55917 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mTUQ9-0003Hc-O5
	for submit <at> debbugs.gnu.org; Thu, 23 Sep 2021 15:30:14 -0400
Received: from out2.migadu.com ([188.165.223.204]:56337)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1mTUQ6-0003HM-Ar
 for 50757 <at> debbugs.gnu.org; Thu, 23 Sep 2021 15:30:12 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1632425409;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=3KMjTzqfRvEYFtN9XAFk2Ms0vtOfdliYSv14JPGS5JM=;
 b=j3VN6fh8T6fowDxit9OQ9GU6dRKy/NV55io9g3sLl2p96WDBXk3hU3oyIo5QyvCHaOiu5f
 6s8SGS6rm2TtGXvcW6i4zR3Cc60wP1WYrec8n/KAn5kIB1umvpi0cl/VSQ72XOa07hlshC
 Rj6f9CZX0pa+8RmjKWaP+RBrD/O+G4c=
From: Sarah Morgensen <iskarian@HIDDEN>
To: Olivier Dion <olivier.dion@HIDDEN>
Subject: Re: [bug#50757] [PATCH] gnu: Add babeltrace.
References: <20210923124113.3269-1-olivier.dion@HIDDEN>
Date: Thu, 23 Sep 2021 12:30:06 -0700
In-Reply-To: <20210923124113.3269-1-olivier.dion@HIDDEN> (Olivier Dion's
 message of "Thu, 23 Sep 2021 08:41:13 -0400 (5 hours, 59 minutes, 55
 seconds ago)")
Message-ID: <86k0j7ks3l.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 50757
Cc: 50757 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Thank you for your patch.  This looks like an interesting tool!  I
test-compiled this, and I have a couple comments.

Olivier Dion <olivier.dion@HIDDEN> writes:

> * gnu/packages/linux.scm (babeltrace): New variable.
>
> Signed-off-by: Olivier Dion <olivier.dion@HIDDEN>

"We" don't used signed-off-by like this (signed-off-by is used by the
committer who is pushing your patch); you can leave it out.

> ---
>  gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 9bb90e599e..dcfea9cc6c 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -131,6 +131,7 @@
>    #:use-module (gnu packages sdl)
>    #:use-module (gnu packages serialization)
>    #:use-module (gnu packages slang)
> +  #:use-module (gnu packages sphinx)
>    #:use-module (gnu packages sqlite)
>    #:use-module (gnu packages texinfo)
>    #:use-module (gnu packages tls)
> @@ -8051,6 +8052,40 @@ enable and disable specific instrumentation points=
, and writes event records
>  to ring buffers shared with a consumer daemon.")
>      (license license:lgpl2.1+)))
>=20=20
> +(define-public babeltrace
> +  (package
> +    (name "babeltrace")
> +    (version "2.0.3")

2.0.4 is available; is there a particular reason for using 2.0.3?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://www.efficios.com/files/babelt=
race/babeltrace2-"
> +                                  version ".tar.bz2"))
> +              (sha256
> +               (base32 "1804pyq7fz6rkcz4r1abkkn0pfnss13m6fd8if32s42l4laj=
adm5"))))
> +
> +    (build-system gnu-build-system)
> +
> +    (propagated-inputs
> +     `(("elfutils" ,elfutils)))

Is there a reason why this is propagated?  It seems like babeltrace uses
it for the libraries and headers only, so it should probably be in 'inputs'.

> +
> +    (native-inputs
> +     `(("asciidoc" ,asciidoc)
> +       ("bison" ,bison)
> +       ("flex" ,flex)
> +       ("glib" ,glib)

  guix gc --references /gnu/store/mm02i199mwwqgazk6fphz6rka8ga4fh6-babeltra=
ce-2.0.3

says that babeltrace retains a reference to glib, so it should probably
be a regular input as well.

> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-3)
> +       ("python-sphinx" ,python-sphinx)
> +       ("xmltoman" ,xmltoman)))
> +
> +    (home-page "https://babeltrace.org/")
> +    (synopsis "Babeltrace /=CB=88b=C3=A6b=C9=99ltre=C9=AAs/ is an open-s=
ource trace manipulation toolkit.")
> +    (description "Babeltrace 2 is the reference parser implementation of=
 the
> +Common Trace Format (CTF), a versatile trace format produced by various
> +tracers and tools such as LTTng and barectf. The Babeltrace 2 library an=
d its
> +Python bindings can read and write CTF traces.")

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix lint babeltrace
/home/sarah/guix-apply/gnu/packages/linux.scm:8170:17: babeltrace@HIDDEN: se=
ntences in description should be followed by two spaces; possible infractio=
n at 174
/home/sarah/guix-apply/gnu/packages/linux.scm:8169:14: babeltrace@HIDDEN: no=
 period allowed at the end of the synopsis
/home/sarah/guix-apply/gnu/packages/linux.scm:8169:14: babeltrace@HIDDEN: sy=
nopsis should not start with the package name
--8<---------------cut here---------------end--------------->8---

Synopses should reduce to a noun; open-source is implied by its
inclusion in Guix; the pronunciation is more suited to the description,
but may not be necessary at all.

Consider: "Trace manipulation toolkit" or "Trace manipulation toolkit
with Python bindings" (depending on what the focus should be on)

In the description, it may be worth mentioning that it provides the
command-line tool "@command{babeltrace2}"; consider referencing the
manual page for wording.

You could even start with something like:

"Babeltrace 2 is a framework for viewing, converting, transforming, and
analyzing traces.  It is also the reference parser implementation of the
Common Trace Format (CTF), produced by tools such as LTTng and barectf.
This package provides a library with a C API, Python 3 bindings, and the
command-line tool @command{babeltrace2}."

That's just an example though!  It could definitly be improved.

Hope that helps,
--
Sarah




Information forwarded to guix-patches@HIDDEN:
bug#50757; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Sep 2021 13:11:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 23 09:11:28 2021
Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mTOVc-00048q-FP
	for submit <at> debbugs.gnu.org; Thu, 23 Sep 2021 09:11:28 -0400
Received: from lists.gnu.org ([209.51.188.17]:57978)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <olivier.dion@HIDDEN>) id 1mTO2d-0003GW-Cm
 for submit <at> debbugs.gnu.org; Thu, 23 Sep 2021 08:41:34 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53726)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <olivier.dion@HIDDEN>)
 id 1mTO2b-0003tC-RG
 for guix-patches@HIDDEN; Thu, 23 Sep 2021 08:41:31 -0400
Received: from smtp.polymtl.ca ([132.207.4.11]:44011)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <olivier.dion@HIDDEN>)
 id 1mTO2Z-0005G5-9I
 for guix-patches@HIDDEN; Thu, 23 Sep 2021 08:41:29 -0400
Received: from laura.hitronhub.home (modemcable094.169-200-24.mc.videotron.ca
 [24.200.169.94]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18NCfGNw008592
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); 
 Thu, 23 Sep 2021 08:41:24 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18NCfGNw008592
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca;
 s=default; t=1632400885;
 bh=RFH/SXt6du6KOvhFLOk+LlMp2ouUjtVF1rU6egq40ho=;
 h=From:To:Cc:Subject:Date:From;
 b=ZoHjBmpXlinRq6F6dp9Thh69SsPoulBaAhTsOVJjub9YaLHuvdAJkr8o/ZjfgY5N3
 7hKaUJBpTVOHHeyvf2rlHbrzPGn96Ni0LrNceUj/DZhaNEHb4al7RBz1K/ZfMvyVdI
 sSLF7Bo/Od/38sbQPx5PsHh+d67rowgRmAMo4NH8=
From: Olivier Dion <olivier.dion@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add babeltrace.
Date: Thu, 23 Sep 2021 08:41:13 -0400
Message-Id: <20210923124113.3269-1-olivier.dion@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at
 Thu, 23 Sep 2021 12:41:16 +0000
Received-SPF: pass client-ip=132.207.4.11;
 envelope-from=olivier.dion@HIDDEN; helo=smtp.polymtl.ca
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 23 Sep 2021 09:11:26 -0400
Cc: Olivier Dion <olivier.dion@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/linux.scm (babeltrace): New variable.

Signed-off-by: Olivier Dion <olivier.dion@HIDDEN>
---
 gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 9bb90e599e..dcfea9cc6c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -131,6 +131,7 @@
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages serialization)
   #:use-module (gnu packages slang)
+  #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages tls)
@@ -8051,6 +8052,40 @@ enable and disable specific instrumentation points, and writes event records
 to ring buffers shared with a consumer daemon.")
     (license license:lgpl2.1+)))
 
+(define-public babeltrace
+  (package
+    (name "babeltrace")
+    (version "2.0.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.efficios.com/files/babeltrace/babeltrace2-"
+                                  version ".tar.bz2"))
+              (sha256
+               (base32 "1804pyq7fz6rkcz4r1abkkn0pfnss13m6fd8if32s42l4lajadm5"))))
+
+    (build-system gnu-build-system)
+
+    (propagated-inputs
+     `(("elfutils" ,elfutils)))
+
+    (native-inputs
+     `(("asciidoc" ,asciidoc)
+       ("bison" ,bison)
+       ("flex" ,flex)
+       ("glib" ,glib)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python-3)
+       ("python-sphinx" ,python-sphinx)
+       ("xmltoman" ,xmltoman)))
+
+    (home-page "https://babeltrace.org/")
+    (synopsis "Babeltrace /ˈbæbəltreɪs/ is an open-source trace manipulation toolkit.")
+    (description "Babeltrace 2 is the reference parser implementation of the
+Common Trace Format (CTF), a versatile trace format produced by various
+tracers and tools such as LTTng and barectf. The Babeltrace 2 library and its
+Python bindings can read and write CTF traces.")
+    (license license:expat)))
+
 (define-public kexec-tools
   (package
     (name "kexec-tools")
-- 
2.33.0





Acknowledgement sent to Olivier Dion <olivier.dion@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#50757; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 13 Oct 2021 09:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.