GNU bug report logs - #50762
diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines

Previous Next

To reply to this bug, email your comments to 50762 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: diff-update-on-the-fly doesn't update hunk headers while
 regexp-replacing lines
Date: Thu, 23 Sep 2021 18:56:48 +0300

As title says. I think due to this bug it would make sense to have diff-update-on-the-fly set to nil by default.

# Steps to reproduce

1. In Emacs repo, `git checkout 72f8a9dd08132119a` (arbitrary commit for the sake of testcase) 
2. Create a patch from Emacs repo with `git format-patch -1 --stdout > /tmp/1.patch`, open it.
3. Note that 1st hunk has value `-2883,10 +2883,13`
4. Use regexp-replace aka `C-M-%` with `(.*^J\+.* → line1` (please replace ^J here with C-q C-j)
5. When asked for matches, press `!`, so all lines are replaced
6. Look at the first hunk again

## Expected

It changes its value to recalculation that should be happening

## Actual

It still has the older value, no recalculation has happened.

Message #8 received at 50762 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: 50762 <at> debbugs.gnu.org
Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers
 while regexp-replacing lines
Date: Thu, 22 May 2025 11:25:48 +0300

[Message part 1 (text/plain, inline)]

Seems fixed on master.  I don't know when exactly it was fixed, I was
running all that time with diff-update-on-the-fly set to nil.  But just
as I was writing a workaround patch (attached for history purposes, in
case it might be useful at some point, but right now it isn't), I
tested and it turns out both query-replace-regexp as well as delete-
matching-lines result in hunks being updated on the fly.

So bug has been fixed, the report can be closed.

[1.patch (text/x-patch, attachment)]

Message #13 received at 50762-done <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: 50762-done <at> debbugs.gnu.org
Date: Thu, 22 May 2025 11:46:46 +0300

Thus, closing

Message #16 received at 50762-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 50762-done <at> debbugs.gnu.org
Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers
 while regexp-replacing lines
Date: Thu, 22 May 2025 12:51:26 +0300

> From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
> Date: Thu, 22 May 2025 11:25:48 +0300
> 
> Seems fixed on master.  I don't know when exactly it was fixed, I was
> running all that time with diff-update-on-the-fly set to nil.  But just
> as I was writing a workaround patch (attached for history purposes, in
> case it might be useful at some point, but right now it isn't), I
> tested and it turns out both query-replace-regexp as well as delete-
> matching-lines result in hunks being updated on the fly.
> 
> So bug has been fixed, the report can be closed.

Thanks.  I closed the bug, but please note that you could close it
yourself (and if you were afraid to close by mistake, then reopening
is also easy).

Message #19 received at 50762-done <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50762-done <at> debbugs.gnu.org
Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers
 while regexp-replacing lines
Date: Thu, 22 May 2025 12:52:25 +0300

On Thu, 2025-05-22 at 12:51 +0300, Eli Zaretskii wrote:
> > From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
> > Date: Thu, 22 May 2025 11:25:48 +0300
> > 
> > Seems fixed on master.  I don't know when exactly it was fixed, I
> > was
> > running all that time with diff-update-on-the-fly set to nil.  But
> > just
> > as I was writing a workaround patch (attached for history purposes,
> > in
> > case it might be useful at some point, but right now it isn't), I
> > tested and it turns out both query-replace-regexp as well as
> > delete-
> > matching-lines result in hunks being updated on the fly.
> > 
> > So bug has been fixed, the report can be closed.
> 
> Thanks.  I closed the bug, but please note that you could close it
> yourself (and if you were afraid to close by mistake, then reopening
> is also easy).

Thank you! I did close it though 😊

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.