GNU logs - #50768, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#50768] [PATCH] installer: Reorder file system type listbox.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 23 Sep 2021 18:00:02 +0000
Resent-Message-ID: <handler.50768.B.16324199962845 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 50768 <at> debbugs.gnu.org
From: Tobias Geerinckx-Rice <me@HIDDEN>
Date: Thu, 23 Sep 2021 19:59:50 +0200
Message-Id: <20210923175950.13586-1-me@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

Recommending ext4 over btrfs is probably ill-advised nowadays.  See the
regular bug reports about running out of /gnu/store directory entries,
for which the documented fix then breaks booting with GRUB.

Instead, just list regular file systems alphabetically.  We can bikeshed
bcachefs later ;-)

Move second-class file systems like NTFS to their own section at the end
of the list.

* gnu/packages/package-management.scm (run-fs-type-page): Reorder the
LISTBOX-ITEMS.
---
 gnu/installer/newt/partition.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm
index ea524eb4c3..70c11ed8ad 100644
--- a/gnu/installer/newt/partition.scm
+++ b/gnu/installer/newt/partition.scm
@@ -119,31 +119,35 @@ Be careful, all data on the disk will be lost.")
                          '(extended)))))
     (run-listbox-selection-page
      #:info-text (G_ "Please select a partition type.")
      #:title (G_ "Partition type")
      #:listbox-items items
      #:listbox-item->text symbol->string
      #:sort-listbox-items? #f
      #:button-text (G_ "Exit")
      #:button-callback-procedure button-exit-action)))

 (define (run-fs-type-page)
   "Run a page asking the user to select a file-system type."
   (run-listbox-selection-page
    #:info-text (G_ "Please select the file-system type for this partition.")
    #:title (G_ "File-system type")
-   #:listbox-items '(ext4 btrfs fat16 fat32 jfs ntfs xfs swap)
+   #:listbox-items '(btrfs ext4 jfs xfs
+                           swap
+                           ;; These lack basic Unix features.  Their only use
+                           ;; on GNU is for interoperation, e.g., with UEFI.
+                           fat32 fat16 ntfs)
    #:listbox-item->text user-fs-type-name
    #:sort-listbox-items? #f
    #:button-text (G_ "Exit")
    #:button-callback-procedure button-exit-action))

 (define (inform-can-create-partition? user-partition)
   "Return #t if it is possible to create USER-PARTITION. This is determined by
 calling CAN-CREATE-PARTITION? procedure. If an exception is raised, catch it
 an inform the user with an appropriate error-page and return #f."
   (guard (c ((max-primary-exceeded? c)
             (run-error-page
              (G_ "Primary partitions count exceeded.")
              (G_ "Creation error"))
             #f)
            ((extended-creation-error? c)
-- 
2.33.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me@HIDDEN>
Subject: bug#50768: Acknowledgement ([PATCH] installer: Reorder file
 system type listbox.)
Message-ID: <handler.50768.B.16324199962845.ack <at> debbugs.gnu.org>
References: <20210923175950.13586-1-me@HIDDEN>
X-Gnu-PR-Message: ack 50768
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 50768 <at> debbugs.gnu.org
Date: Thu, 23 Sep 2021 18:00:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 50768 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
50768: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50768
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#50768] [PATCH] installer: Reorder file system type listbox.
References: <20210923175950.13586-1-me@HIDDEN>
In-Reply-To: <20210923175950.13586-1-me@HIDDEN>
Resent-From: John Kehayias <john.kehayias@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 24 Sep 2021 21:25:01 +0000
Resent-Message-ID: <handler.50768.B50768.163251866524377 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "50768 <at> debbugs.gnu.org" <50768 <at> debbugs.gnu.org>
Reply-To: John Kehayias <john.kehayias@HIDDEN>
Date: Fri, 24 Sep 2021 21:24:11 +0000
From: John Kehayias <john.kehayias@HIDDEN>
Message-ID: <pxd7sSLhOfpPrh49sK8ZtDxYICwmDaVoEvqP_zzgUY9GSD94VFdwAC8PHrbL95keWsKLaxsr-Y5bCVyD0wpmCgix0hXjNb1RjofYr0xssBg=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

On this front, a related issue has been ext4 and large directories in Guix.=
 Namely, that /gnu/store/.links quickly has many, many files (I'm at 9.9 mi=
llion right now). This leads to warnings on ext4 and usually one will find =
that enabling large_dir will increase the file directory cap. Unfortunately=
, that is not compatible with Grub. This is what happened to me and was a b=
it of a mess (I reinstalled with Btrfs), and I know you (Tobias) also saw t=
his in this thread: https://lists.gnu.org/archive/html/help-guix/2020-06/ms=
g00015.html

So to the patch at hand, I'm wondering if we should make a note of this in =
file system selection in the installer (and in the manual in a few places).=
 I don't know the actual ramifications of getting those directory full warn=
ings in ext4, but I can see it easily leading to a problem booting a system=
 with large_dir, as happened to me. I've submitted a bug to Grub, though th=
is is well known, without response in plans to support a 4-year-old ext4 op=
tion. Since we expect Guix to have this huge directory, at least currently,=
 I think we could avoid this issue with some warnings.

Sorry if this is a little astray for this patch, but thought it would be go=
od to bring up.

Thanks,
John

Message sent to guix-patches@HIDDEN:

Subject: [bug#50768] [PATCH] installer: Reorder file system type listbox.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 13 Oct 2021 08:59:01 +0000
Resent-Message-ID: <handler.50768.B50768.163411548115513 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 50768 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20210923175950.13586-1-me@HIDDEN>
Date: Wed, 13 Oct 2021 10:57:47 +0200
In-Reply-To: <20210923175950.13586-1-me@HIDDEN> (Tobias Geerinckx-Rice's
 message of "Thu, 23 Sep 2021 19:59:50 +0200")
Message-ID: <87lf2xs3n8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Tobias Geerinckx-Rice <me@HIDDEN> skribis:

> Recommending ext4 over btrfs is probably ill-advised nowadays.  See the
> regular bug reports about running out of /gnu/store directory entries,
> for which the documented fix then breaks booting with GRUB.

I=E2=80=99ve seen Keyras mention such a problem here, but again, I have not=
 seen
=E2=80=9Cregular bug reports=E2=80=9D.  Are there open bug reports about ex=
t4 issues?

What I do regularly see is rants about ext4 :-), which might be
justified, but in my many years with a store I have never had problems
with ext4.  Also, the deduplication code gracefully handles ENOSPC on
/gnu/store/.links.

> Instead, just list regular file systems alphabetically.  We can bikeshed
> bcachefs later ;-)
>
> Move second-class file systems like NTFS to their own section at the end
> of the list.
>
> * gnu/packages/package-management.scm (run-fs-type-page): Reorder the
> LISTBOX-ITEMS.

Otherwise LGTM, thanks!

Ludo=E2=80=99.

Last modified: Wed, 13 Oct 2021 09:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.