GNU bug report logs - #50779
28.0.50; Tab bar doesn't respond to mouse clicks

Previous Next

Package: emacs;

Reported by: Daniel Semyonov <daniel <at> dsemy.com>

Date: Fri, 24 Sep 2021 13:54:02 UTC

Severity: normal

Found in version 28.0.50

Done: Daniel Semyonov <daniel <at> dsemy.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50779 in the body.
You can then email your comments to 50779 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Fri, 24 Sep 2021 13:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Daniel Semyonov <daniel <at> dsemy.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 24 Sep 2021 13:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Fri, 24 Sep 2021 16:53:33 +0300
Note: tested only in a Wayland session (sway) with pgtk.

The tab bar doesn't respond to any mouse clicks (switching tabs by clicking
them doesn't work, creating a new tab by clicking the "+" doesn't work,
etc.).
However, the tab line (tab-line-mode) does seem to work (although I only
did minimal testing since I don't use it normally).

Recipe:
1. emacs -Q
2. M-x tab-bar-mode
3. Click on any tab or button in the tab bar.

Thanks!

Daniel


In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2021-09-22 built on coldharbour
Repository revision: 625530a85191d9b73e3db18bc16e6795c4cd62a6
Repository branch: feature/pgtk
Windowing system distributor 'System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-pgtk --without-x --prefix=/opt/Emacs'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG
SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  emms-mode-line-mode: t
  emms-playing-time-display-mode: t
  emms-playing-time-mode: t
  pdf-occur-global-minor-mode: t
  show-paren-mode: t
  electric-pair-mode: t
  repeat-mode: t
  delete-selection-mode: t
  vcomplete-mode: t
  swsw-mode: t
  global-auto-revert-mode: t
  display-time-mode: t
  minibuffer-electric-default-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tab-bar-mode: t
  file-name-shadow-mode: t
  context-menu-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/daniel/etc/emacs/elpa/transient-0.3.6/transient hides /opt/Emacs/share/emacs/28.0.50/lisp/transient

Features:
(cl-extra smiley gnus-cite gnus-async gnus-bcklg gnus-agent gnus-srvr
gnus-score score-mode nnvirtual nntp gnus-ml gnus-msg disp-table nndoc
gnus-cache gnus-dup gnus-art mm-uu mml2015 mm-view mml-smime smime dig
gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601
gnus-spec gnus-int gnus-range gnus-win gnus nnheader mm-archive gnutls
network-stream url-cache crm debbugs-gnu add-log debbugs soap-client
url-http url-auth url-gw nsm rng-xsd rng-dt rng-util xsd-regexp shadow
sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa derived
epg rfc6068 epg-config gnus-util rmail rmail-loaddefs mm-decode
mm-bodies mm-encode mailabbrev gmm-utils mailheader sendmail mail-utils
time-date checkdoc lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr help-mode flymake-proc flymake project warnings
thingatpt flyspell ispell display-line-numbers noutline outline
easy-mmode init-interfaces grep init-web elpher-eww-emulation
init-volume init-emms emms-mode-line emms-playing-time emms-player-mpv
emms-player-simple emms-info-opusinfo emms-info emms-later-do emms
emms-compat init-battery battery dbus cal-julian solar cal-dst cal-menu
calendar cal-loaddefs xml init-programs pdf-occur ibuf-ext ibuffer
ibuffer-loaddefs tablist tablist-filter semantic/wisent/comp
semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util
semantic semantic/tag semantic/lex semantic/fw mode-local find-func
cedet pdf-isearch let-alist pdf-misc imenu pdf-tools compile comint
ansi-color ring pdf-view bookmark text-property-search jka-compr
pdf-cache pdf-info tq pdf-util advice image-mode exif dired
dired-loaddefs init-shell init-pass auth-source-pass init-programming
paren elec-pair init-ui format-spec repeat edmacro kmacro delsel
vcomplete swsw autorevert filenotify time minibuf-eldef init-personal
pcase init-base server finder-inf package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv info cus-edit pp
cus-load wid-edit cl-loaddefs cl-lib iso-transl tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/pgtk-win pgtk-win term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit pgtk lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 634672 63249)
 (symbols 48 29287 5)
 (strings 32 164773 22808)
 (string-bytes 1 4508770)
 (vectors 16 54421)
 (vector-slots 8 828983 31882)
 (floats 8 3015 1248)
 (intervals 56 418 466)
 (buffers 992 22))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Fri, 24 Sep 2021 15:47:03 GMT) Full text and rfc822 format available.

Message #8 received at 50779 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: 50779 <at> debbugs.gnu.org
Subject: Re: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Fri, 24 Sep 2021 18:34:55 +0300
> Note: tested only in a Wayland session (sway) with pgtk.
>
> The tab bar doesn't respond to any mouse clicks (switching tabs by clicking
> them doesn't work, creating a new tab by clicking the "+" doesn't work,
> etc.).
> However, the tab line (tab-line-mode) does seem to work (although I only
> did minimal testing since I don't use it normally).
>
> Recipe:
> 1. emacs -Q
> 2. M-x tab-bar-mode
> 3. Click on any tab or button in the tab bar.

Looking at the logs of the branch feature/pgtk shows that the last time
it was updated from master was:

  2021-07-25 Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs into feature/pgtk

This means the branch feature/pgtk is out of sync?  Recently we changed
how tab-bar mouse clicks are processed in master.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Fri, 24 Sep 2021 20:38:02 GMT) Full text and rfc822 format available.

Message #11 received at 50779 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50779 <at> debbugs.gnu.org
Subject: Re: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Fri, 24 Sep 2021 23:37:20 +0300

On 24 September 2021 18:34:55 GMT+03:00, Juri Linkov <juri <at> linkov.net> wrote:
>Looking at the logs of the branch feature/pgtk shows that the last time
>it was updated from master was:
>
>  2021-07-25 Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs into feature/pgtk
>
>This means the branch feature/pgtk is out of sync?  Recently we changed
>how tab-bar mouse clicks are processed in master.

I manually merged (using Magit) changes from master and rebuilt two days ago. Maybe this is a new issue then?

(Sorry if this message has weird formatting, I sent it from my phone).

Daniel






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Sat, 25 Sep 2021 19:16:02 GMT) Full text and rfc822 format available.

Message #14 received at 50779 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: 50779 <at> debbugs.gnu.org
Subject: Re: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Sat, 25 Sep 2021 21:56:37 +0300
>>Looking at the logs of the branch feature/pgtk shows that the last time
>>it was updated from master was:
>>
>>  2021-07-25 Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs into feature/pgtk
>>
>>This means the branch feature/pgtk is out of sync?  Recently we changed
>>how tab-bar mouse clicks are processed in master.
>
> I manually merged (using Magit) changes from master and rebuilt two days ago.
> Maybe this is a new issue then?

I briefly looked at code in the feature/pgtk branch, and indeed
there are many tab-related functions duplicated with old code
that doesn't use our recent changes in master.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Wed, 01 Dec 2021 01:23:02 GMT) Full text and rfc822 format available.

Message #17 received at 50779 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: 50779 <at> debbugs.gnu.org
Subject: Re: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Wed, 01 Dec 2021 09:21:58 +0800
Daniel Semyonov <daniel <at> dsemy.com> writes:

> Note: tested only in a Wayland session (sway) with pgtk.
>
> The tab bar doesn't respond to any mouse clicks (switching tabs by clicking
> them doesn't work, creating a new tab by clicking the "+" doesn't work,
> etc.).
> However, the tab line (tab-line-mode) does seem to work (although I only
> did minimal testing since I don't use it normally).
>
> Recipe:
> 1. emacs -Q
> 2. M-x tab-bar-mode
> 3. Click on any tab or button in the tab bar.
>
> Thanks!
>
> Daniel

I tried to fix this.  Please pull latest feature/pgtk and test, thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50779; Package emacs. (Wed, 01 Dec 2021 20:39:02 GMT) Full text and rfc822 format available.

Message #20 received at 50779 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 50779 <at> debbugs.gnu.org
Subject: Re: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Wed, 01 Dec 2021 22:38:08 +0200
>>>>> Po Lu writes:

    > I tried to fix this.  Please pull latest feature/pgtk and test,
    > thanks.

Seems to work, thanks!




Reply sent to Daniel Semyonov <daniel <at> dsemy.com>:
You have taken responsibility. (Mon, 06 Dec 2021 19:43:02 GMT) Full text and rfc822 format available.

Notification sent to Daniel Semyonov <daniel <at> dsemy.com>:
bug acknowledged by developer. (Mon, 06 Dec 2021 19:43:02 GMT) Full text and rfc822 format available.

Message #25 received at 50779-done <at> debbugs.gnu.org (full text, mbox):

From: Daniel Semyonov <daniel <at> dsemy.com>
To: 50779-done <at> debbugs.gnu.org
Subject: bug#50779: 28.0.50; Tab bar doesn't respond to mouse clicks
Date: Mon, 06 Dec 2021 21:42:11 +0200
Fixed by Po Lu, confirmed to work on two computers affected by this bug
under both X and Wayland.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 04 Jan 2022 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 74 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.