GNU bug report logs - #50818
28.0.50; .eln files need to be executable on Cygwin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50818 in the body.
You can then email your comments to 50818 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; .eln files need to be executable on Cygwin
Date: Sun, 26 Sep 2021 11:03:53 -0400

An installed emacs built with native compilation won't start on Cygwin because 
the executable permissions have been removed from the .eln files.  This is done 
in the install-eln target of the top-level Makefile.in, which installs the .eln 
files with 644 permissions even though they were created with executable 
permissions.

The failure is in Cygwin's dlopen, which calls the windows function 
GetModuleHandleExW.

Would it hurt anything on other platforms if the .eln files were installed with 
755 permissions?  If so, I can submit a patch that does this just on Cygwin.

Ken

Message #8 received at 50818 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 50818 <at> debbugs.gnu.org
Subject: Re: bug#50818: 28.0.50; .eln files need to be executable on Cygwin
Date: Sun, 26 Sep 2021 19:04:20 +0300

> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Sun, 26 Sep 2021 11:03:53 -0400
> 
> An installed emacs built with native compilation won't start on Cygwin because 
> the executable permissions have been removed from the .eln files.  This is done 
> in the install-eln target of the top-level Makefile.in, which installs the .eln 
> files with 644 permissions even though they were created with executable 
> permissions.

Is what we do different from any other package the installs DLLs?

> Would it hurt anything on other platforms if the .eln files were installed with 
> 755 permissions?  If so, I can submit a patch that does this just on Cygwin.

Please define a new INSTALL_ELN macro for that purpose.

Thanks.

Message #11 received at 50818 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <akrl <at> sdf.org>
Cc: 50818 <at> debbugs.gnu.org
Subject: Re: bug#50818: 28.0.50; .eln files need to be executable on Cygwin
Date: Sun, 26 Sep 2021 12:57:24 -0400

On 9/26/2021 12:04 PM, Eli Zaretskii wrote:
>> From: Ken Brown <kbrown <at> cornell.edu>
>> Date: Sun, 26 Sep 2021 11:03:53 -0400
>>
>> An installed emacs built with native compilation won't start on Cygwin because
>> the executable permissions have been removed from the .eln files.  This is done
>> in the install-eln target of the top-level Makefile.in, which installs the .eln
>> files with 644 permissions even though they were created with executable
>> permissions.
> 
> Is what we do different from any other package the installs DLLs?

Yes.  DLLs are always installed with 755 permissions.  Packages that install 
DLLs typically use libtool, which just does the right thing.  I can't recall 
offhand seeing a hand-written Makefile rule for installing a DLL, but I assume 
it would use INSTALL or INSTALL_PROGRAM rather than INSTALL_DATA.  It seems 
strange to me to see INSTALL_DATA used for installing a library, but I'm not 
really familiar with what's typically done on GNU/Linux, for example
>> Would it hurt anything on other platforms if the .eln files were installed with
>> 755 permissions?  If so, I can submit a patch that does this just on Cygwin.
> 
> Please define a new INSTALL_ELN macro for that purpose.

OK.  But I'd like to hear first (maybe from Andrea?) whether there's a reason 
for this to be Cygwin-specific, and whether INSTALL_DATA is in fact typically 
used for installing libraries on other platforms.

Ken

Message #14 received at 50818 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Andrea Corallo <akrl <at> sdf.org>
Cc: 50818 <at> debbugs.gnu.org
Subject: Re: bug#50818: 28.0.50; .eln files need to be executable on Cygwin
Date: Mon, 27 Sep 2021 14:52:15 -0400

[Message part 1 (text/plain, inline)]

On 9/26/2021 12:57 PM, Ken Brown wrote:
> On 9/26/2021 12:04 PM, Eli Zaretskii wrote:
>> Please define a new INSTALL_ELN macro for that purpose.
> 
> OK.  But I'd like to hear first (maybe from Andrea?) whether there's a reason 
> for this to be Cygwin-specific, and whether INSTALL_DATA is in fact typically 
> used for installing libraries on other platforms.

I decide to go ahead with a Cygwin-specific patch (attached).  If Andrea or 
someone else decides this would be good for all platforms, they can do that later.

OK to push?

Ken

[0001-Make-.eln-files-executable-on-Cygwin.patch (text/plain, attachment)]

Message #17 received at 50818 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 50818 <at> debbugs.gnu.org, akrl <at> sdf.org
Subject: Re: bug#50818: 28.0.50; .eln files need to be executable on Cygwin
Date: Mon, 27 Sep 2021 22:12:41 +0300

> From: Ken Brown <kbrown <at> cornell.edu>
> Cc: 50818 <at> debbugs.gnu.org
> Date: Mon, 27 Sep 2021 14:52:15 -0400
> 
> I decide to go ahead with a Cygwin-specific patch (attached).  If Andrea or 
> someone else decides this would be good for all platforms, they can do that later.
> 
> OK to push?

Yes, please.

Message #22 received at 50818-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50818-done <at> debbugs.gnu.org, akrl <at> sdf.org
Subject: Re: bug#50818: 28.0.50; .eln files need to be executable on Cygwin
Date: Mon, 27 Sep 2021 15:26:35 -0400

On 9/27/2021 3:12 PM, Eli Zaretskii wrote:
>> From: Ken Brown <kbrown <at> cornell.edu>
>> Cc: 50818 <at> debbugs.gnu.org
>> Date: Mon, 27 Sep 2021 14:52:15 -0400
>>
>> I decide to go ahead with a Cygwin-specific patch (attached).  If Andrea or
>> someone else decides this would be good for all platforms, they can do that later.
>>
>> OK to push?
> 
> Yes, please.

Done. Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.