GNU bug report logs - #50832
[PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50832 in the body.
You can then email your comments to 50832 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: akater <nuclearspace <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: [PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation
Date: Sun, 26 Sep 2021 22:52:35 +0000

[Message part 1 (text/plain, inline)]

This indentation does not work in lisp-mode, and it shouldn't.

In fact, lisp-mode-tests.el is a very confusing file name, and some
tests in it use emacs-lisp-mode while some use lisp-mode.

[0001-Fix-cl-flet-indentation-test.patch (text/x-diff, inline)]

From e4821f07cce362d4be4f16ca9aec84822694464a Mon Sep 17 00:00:00 2001
From: akater <nuclearspace <at> gmail.com>
Date: Sun, 26 Sep 2021 22:29:56 +0000
Subject: [PATCH] ; Fix cl-flet indentation test

---
 test/lisp/emacs-lisp/lisp-mode-tests.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el b/test/lisp/emacs-lisp/lisp-mode-tests.el
index 5e533b370e..64e1581d1e 100644
--- a/test/lisp/emacs-lisp/lisp-mode-tests.el
+++ b/test/lisp/emacs-lisp/lisp-mode-tests.el
@@ -333,7 +333,7 @@ defconst lisp-mode-tests--correctly-indented-sexp "\
 (ert-deftest test-cl-flet-indentation ()
   (should (equal
            (with-temp-buffer
-             (lisp-mode)
+             (emacs-lisp-mode)
              (insert "(cl-flet ((bla (x)\n(* x x)))\n(bla 42))")
              (indent-region (point-min) (point-max))
              (buffer-string))
-- 
2.32.0

Message #8 received at 50832 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: akater <nuclearspace <at> gmail.com>
Cc: 50832 <at> debbugs.gnu.org
Subject: Re: bug#50832: [PATCH] 28.0.50; Wrong mode in test-cl-flet-indentation
Date: Mon, 27 Sep 2021 05:58:34 +0200

akater <nuclearspace <at> gmail.com> writes:

> This indentation does not work in lisp-mode, and it shouldn't.
>
> In fact, lisp-mode-tests.el is a very confusing file name, and some
> tests in it use emacs-lisp-mode while some use lisp-mode.

Indeed.  I've now fixed the test and moved it to the right file.

(That emacs-lisp-mode lives in progmodes/elisp-mode.el and that
lisp-mode lives in emacs-lisp/lisp-mode.el doesn't help with the
confusion.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.