GNU bug report logs - #50843
[PATCHES] Stackage update to 18.10.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50843 in the body.
You can then email your comments to 50843 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: guix-patches <at> gnu.org
Subject: [PATCHES] Stackage update to 18.10.
Date: Mon, 27 Sep 2021 13:14:00 +0200

Hi everyone,

I just pushed to the wip-haskell branch (it’s based on master),
which now contains various changes to haskell-build-system as well
as an update to Stackage 18.10 or the latest Hackage package version
where applicable. CI is currently building the changes[1], but from
local building I know all but three packages using haskell-build-system
build. These are ngless, cabal-install and idris. I need your help to
fix them!  There are also packages that cannot be updated via `guix
refresh` currently. They have been left mostly untouched.

I was also thinking about unconditionally adding
--allow-newer/--allow-older to haskell-build-system, so patching
.cabal-files is not necessary any more. Thoughs?

Let’s use this issue to track/review the changes and provide feedback
on them.

Thank you very much,
Lars

[1] https://ci.guix.gnu.org/eval/23961

Message #8 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: rekado <at> elephly.net, philip <at> munksgaard.me, public <at> yoctocell.xyz,
 50843 <at> debbugs.gnu.org
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Mon, 27 Sep 2021 18:31:57 +0000

Hi Lars and everyone,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, September 27th, 2021 at 7:14 AM, Lars-Dominik Braun wrote:

> Hi everyone,
>
> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them! There are also packages that cannot be updated via `guix refresh`
> currently. They have been left mostly untouched.
>
> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?
>
> Let’s use this issue to track/review the changes and provide feedback
> on them.
>

Great work, thanks! I'll take a look at the package failures to see if there's anything I can do, though might be beyond my limited Haskell knowledge.

As for the --allow-newer/older, I don't have enough experience to know if that will cause any problems. I know you frequently see it to work around some dependency versions (e.g. cabal files not updated, not a problem in actual build done), but of course better to have the dependencies properly specified and available. But if it generally makes more things work with less work, I'm for it. We could disable it where needed, but since we sort of pin versions with Stackage we'd only have to check on updates, right?

Anyway, great work, looking forward to adding some more Haskell packages with the new Stackage.

John

Message #11 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: rekado <at> elephly.net, philip <at> munksgaard.me, public <at> yoctocell.xyz,
 50843 <at> debbugs.gnu.org
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Wed, 29 Sep 2021 14:02:52 +0200

Hi,

> Great work, thanks! I'll take a look at the package failures to see if there's anything I can do, though might be beyond my limited Haskell knowledge.
another one that is broken is ruby-pandoc-ruby, which causes ~10
dependents to fail.

> As for the --allow-newer/older, I don't have enough experience to know if that will cause any problems.
It seems this option only works with cabal, but not plain
Setup.hs. Bummer.

Cheers,
Lars

Message #14 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Lars-Dominik Braun <lars <at> 6xq.net>, 50843 <at> debbugs.gnu.org
Cc: john.kehayias <at> protonmail.com, rekado <at> elephly.net, philip <at> munksgaard.me
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Fri, 01 Oct 2021 19:24:34 +0200

[Message part 1 (text/plain, inline)]

On Mon, Sep 27 2021, Lars-Dominik Braun wrote:

> Hi everyone,
>
> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them!  There are also packages that cannot be updated via `guix
> refresh` currently. They have been left mostly untouched.
>
> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?
>
> Let’s use this issue to track/review the changes and provide feedback
> on them.

Below is a list of questions/things-that-should-be-fixed that I found.

* What exacty does the TODO comment for ‘ghc-hsyaml’ mean?  The
  ‘native-inputs’ comment should also be removed if tests aren’t
  enabled.  This applies to ‘ghc-stmonadtrans’ as well

* The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.

I noticed that a lot of new packages have been auto-generated and added
as-is, without checking licenses and fixing descriptions.  I have
attached a patch that fixes these (I hope I didn’t miss any packages).

[0001-fixup-gnu-Update-Haskell-ecosystem.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: john.kehayias <at> protonmail.com, rekado <at> elephly.net, philip <at> munksgaard.me,
 50843 <at> debbugs.gnu.org
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Sat, 2 Oct 2021 11:45:11 +0200

Hi,

> * What exacty does the TODO comment for ‘ghc-hsyaml’ mean?  The
>   ‘native-inputs’ comment should also be removed if tests aren’t
>   enabled.  This applies to ‘ghc-stmonadtrans’ as well
it means enabling tests/native-inputs creates a package dependency loop
somewhere in the graph. I’d keep the commented out native-inputs
though. Otherwise whoever wants to fix this has to add them again from
scratch. Unless there are other reasons to remove them?

> * The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.
You’re right, fixed.

> I noticed that a lot of new packages have been auto-generated and added
> as-is, without checking licenses and fixing descriptions.  I have
> attached a patch that fixes these (I hope I didn’t miss any packages).
Sorry, I ran out of time at the end and couldn’t fix them. I fixed
some brackets and pushed it, thank you for doing this tedious work.

Cheers,
Lars

Message #20 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: john.kehayias <at> protonmail.com, rekado <at> elephly.net, philip <at> munksgaard.me,
 50843 <at> debbugs.gnu.org
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Sun, 03 Oct 2021 13:35:25 +0200

[Message part 1 (text/plain, inline)]

On Sat, Oct 02 2021, Lars-Dominik Braun wrote:

> Hi,
>
>> * What exacty does the TODO comment for ‘ghc-hsyaml’ mean?  The
>>   ‘native-inputs’ comment should also be removed if tests aren’t
>>   enabled.  This applies to ‘ghc-stmonadtrans’ as well
> it means enabling tests/native-inputs creates a package dependency loop
> somewhere in the graph. I’d keep the commented out native-inputs
> though. Otherwise whoever wants to fix this has to add them again from
> scratch. Unless there are other reasons to remove them?

Ah, that makes sense.

>> * The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.
> You’re right, fixed.
>
>> I noticed that a lot of new packages have been auto-generated and added
>> as-is, without checking licenses and fixing descriptions.  I have
>> attached a patch that fixes these (I hope I didn’t miss any packages).
> Sorry, I ran out of time at the end and couldn’t fix them. I fixed
> some brackets and pushed it, thank you for doing this tedious work.

You are welcome!  :-)

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Lars-Dominik Braun <lars <at> 6xq.net>, 50843 <at> debbugs.gnu.org
Cc: john.kehayias <at> protonmail.com, rekado <at> elephly.net, philip <at> munksgaard.me,
 public <at> yoctocell.xyz
Subject: Re: [bug#50843] [PATCHES] Stackage update to 18.10.
Date: Mon, 04 Oct 2021 09:27:50 +0200

Hi,

On Mon, 27 Sep 2021 at 13:14, Lars-Dominik Braun <lars <at> 6xq.net> wrote:

> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them!  There are also packages that cannot be updated via `guix
> refresh` currently. They have been left mostly untouched.

Thanks for working on that. :-)


> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?

What do you mean?

Cheers,
simon

Message #28 received at 50843-done <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: 50843-done <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>, rekado <at> elephly.net,
 philip <at> munksgaard.me, public <at> yoctocell.xyz
Subject: Re: [PATCHES] Stackage update to 18.10.
Date: Fri, 8 Oct 2021 09:28:06 +0200

Hi everyone,

I merged the branch wip-haskell into master as
fe56213027d9828c61fa06211458a23f32431e0b and following.

Let’s hope we can follow Stackage more closely in the future.

Cheers,
Lars

Message #31 received at 50843-done <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Lars-Dominik Braun <lars <at> 6xq.net>, 50843-done <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>, rekado <at> elephly.net,
 philip <at> munksgaard.me
Subject: Re: bug#50843: [PATCHES] Stackage update to 18.10.
Date: Fri, 08 Oct 2021 15:53:16 +0200

[Message part 1 (text/plain, inline)]

On Fri, Oct 08 2021, Lars-Dominik Braun wrote:

> Hi everyone,
>
> I merged the branch wip-haskell into master as
> fe56213027d9828c61fa06211458a23f32431e0b and following.
>
> Let’s hope we can follow Stackage more closely in the future.

Great!  Thank you for the work!  \o/  

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 50843-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: rekado <at> elephly.net, philip <at> munksgaard.me, Lars-Dominik Braun <lars <at> 6xq.net>,
 50843-done <at> debbugs.gnu.org
Subject: Re: bug#50843: [PATCHES] Stackage update to 18.10.
Date: Fri, 08 Oct 2021 14:23:51 +0000

Yes, great work, thank you!

Message #37 received at 50843 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars-Dominik Braun <lars <at> 6xq.net>,  50843 <at> debbugs.gnu.org
Subject: Re: bug#50843: [PATCHES] Stackage update to 18.10.
Date: Sat, 09 Oct 2021 00:47:52 +0200

Hi,

> I merged the branch wip-haskell into master as
> fe56213027d9828c61fa06211458a23f32431e0b and following.

Yay, congrats!  \o/

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.