GNU bug report logs - #50853
python-feedparser

Previous Next

To reply to this bug, email your comments to 50853 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lio Novelli <lio <at> kompot.si>
To: bug-guix <at> gnu.org
Subject: python-feedparser
Date: Mon, 27 Sep 2021 20:24:26 +0200

Feedparser module is missing sgmllib dependency:

    >>> import feedparser
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File
        "/home/len/.guix-profile/lib/python3.8/site-packages/feedparser/__init__.py",
        line 28, in <module> from .api import parse File
        "/home/len/.guix-profile/lib/python3.8/site-packages/feedparser/api.py",
        line 36, in <module> from .html import _BaseHTMLProcessor File
        "/home/len/.guix-profile/lib/python3.8/site-packages/feedparser/html.py",
        line 31, in <module> from .sgml import * File
        "/home/len/.guix-profile/lib/python3.8/site-packages/feedparser/sgml.py",
        line 30, in <module> import sgmllib ModuleNotFoundError: No
           module named 'sgmllib'

From https://pypi.org/project/sgmllib3k/

https://github.com/conda-forge/sgmllib3k-feedstock

I'll try to provide the patch but this will be my first one and I'm
having some issues getting through (understanding) guix documentation
on submitting bugs and patches.

Message #8 received at 50853 <at> debbugs.gnu.org (full text, mbox):

From: Lio Novelli <lio <at> kompot.si>
To: 50853 <at> debbugs.gnu.org
Subject: python-feedparser
Date: Mon, 27 Sep 2021 22:00:13 +0200

[Message part 1 (text/plain, inline)]

This patch provides a bit more than just bugfix:
 - Add two python package definitions sgmllib3k, sgqlc
 - updates python-feedparser

[0001-Add-two-python-package-definitions-sgmllib3k-sgqlc-a.patch (text/x-patch, attachment)]

Message #11 received at 50853 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Lio Novelli <lio <at> kompot.si>, 50853 <at> debbugs.gnu.org
Subject: Re: python-feedparser
Date: Tue, 09 Nov 2021 13:28:29 +0000

Em seg, 2021-09-27 às 22:00 +0200, Lio Novelli escreveu:
> This patch provides a bit more than just bugfix:
>  - Add two python package definitions sgmllib3k, sgqlc
>  - updates python-feedparser

Hi,

Could you format these patches with git-format-patch and submit as a
series of 4 to guix-patches <at> gnu.org ?

My suggestion is:

1. Add python-sgmllib3k.
2. Add python-sgqlc.
3. Add dependency on python-sgmllib3k for python-feedparser.
4. Update python-feedparser.

See commit messages in git log for examples on how to write commit
messages for these changes.

> +    (synopsis "A quick and dirty port of python2-sgmllib old
> module.")

Synopses should not end with full stop. You can use guix lint to check
for common linting mistakes.

> +    (description
> +     "An easy to use GraphQL client.")

Descriptions should be full sentences. e.g. "This package provides an
easy to use GraphQL client.".

See Submitting Patches in the documentation for more info:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.