GNU bug report logs - #50886
28.0.50; [PATCH] Update modus-themes to version 1.6.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50886 in the body.
You can then email your comments to 50886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Update modus-themes to version 1.6.0
Date: Wed, 29 Sep 2021 11:48:39 +0300

[Message part 1 (text/plain, inline)]

Dear maintainers,

Please find attached the latest version of the modus-themes.  Hopefully
this is just in time to make it past the emacs-28 branch cut.

The changes are fairly minor, all things considered.  A detailed log is
available on my website (no JS required):
<https://protesilaos.com/codelog/2021-09-29-modus-themes-1-6-0/>.

Thanks again for your time and efforts.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

[0001-Update-modus-themes-to-version-1.6.0.patch (text/x-patch, attachment)]

Message #8 received at 50886 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 50886 <at> debbugs.gnu.org
Subject: Re: bug#50886: 28.0.50; [PATCH] Update modus-themes to version 1.6.0
Date: Wed, 29 Sep 2021 11:05:57 +0200

Protesilaos Stavrou <info <at> protesilaos.com> writes:

>                                                               Hopefully
> this is just in time to make it past the emacs-28 branch cut.

My 2¢: upgrading Modus to 1.6.0 over 1.5.0 in Emacs 28 would be highly
desirable, since IIUC 1.6.0 includes

- fixes for the obsoletions introduced in 1.5.0[1],
- support for the ansi-color faces introduced in bug#50179[2].

Thank you all for your time.


[1] https://gitlab.com/protesilaos/modus-themes/-/merge_requests/47
[2] https://gitlab.com/protesilaos/modus-themes/-/issues/236

Message #11 received at 50886 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 50886 <at> debbugs.gnu.org
Subject: Re: bug#50886: 28.0.50; [PATCH] Update modus-themes to version 1.6.0
Date: Wed, 29 Sep 2021 04:16:32 -0700

tags 50886 fixed
close 50886 28.1
thanks

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Please find attached the latest version of the modus-themes.  Hopefully
> this is just in time to make it past the emacs-28 branch cut.
>
> The changes are fairly minor, all things considered.  A detailed log is
> available on my website (no JS required):
> <https://protesilaos.com/codelog/2021-09-29-modus-themes-1-6-0/>.

Thanks!  LGTM, so I've pushed it to master as commit 7c79eea51d.

BTW, if there are any minor fixes you want to make, such as face changes
and what have you, I think it'll be fine merging them even after the
emacs-28 branch is cut.  The maintainers (Eli and Lars) will have the
final say of course.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.