GNU bug report logs - #50896
emacs-beancount broken, moved to its own project

Previous Next

Package: guix;

Reported by: Christine Lemmer-Webber <cwebber <at> dustycloud.org>

Date: Wed, 29 Sep 2021 18:06:02 UTC

Severity: normal

Done: Christine Lemmer-Webber <cwebber <at> dustycloud.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50896 in the body.
You can then email your comments to 50896 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#50896; Package guix. (Wed, 29 Sep 2021 18:06:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christine Lemmer-Webber <cwebber <at> dustycloud.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 29 Sep 2021 18:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christine Lemmer-Webber <cwebber <at> dustycloud.org>
To: bug-guix <at> gnu.org
Subject: emacs-beancount broken, moved to its own project
Date: Wed, 29 Sep 2021 14:03:20 -0400
[Message part 1 (text/plain, inline)]
Hello... emacs-beancount is broken because it's no longer just bundled
in beancount.  However, I've attached a fix.

If nobody has any problem with this I'll just push it up to master.
Since it's a leaf package, and the current state is "it's broken" I
figure it's probably fine to push, but since it's a significant
refactoring thought I'd ask for a review before I did so.

[0001-gnu-emacs-beancount-Restructure-package-now-independ.patch (text/x-patch, inline)]
From e6f150f3eb3f3f63455c2a21a9490690b59216f2 Mon Sep 17 00:00:00 2001
From: Christine Lemmer-Webber <cwebber <at> dustycloud.org>
Date: Wed, 29 Sep 2021 12:46:01 -0400
Subject: [PATCH] gnu: emacs-beancount: Restructure package, now independent of
 beancount.

* gnu/packages/finance.scm (emacs-beancount): Restructure package, now
independent of beancount and in its own git repository.  Note that there is no
version number for the now independent code tree, so unfortunately this might
look like a "version downgrade" to some users as it switched from being
beancount's revision number to being a git-derived version number.
---
 gnu/packages/finance.scm | 41 ++++++++++++++++++++++------------------
 1 file changed, 23 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 4aaab58906..e554d93535 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1643,25 +1643,30 @@ define financial transaction records in a text file, read them in memory,
 generate a variety of reports from them, and provides a web interface.")
     (license license:gpl2)))
 
-;; The beancount source ships with elisp in a subdirectory
 (define-public emacs-beancount
-  (package
-    (inherit beancount)
-    (name "emacs-beancount")
-    (build-system emacs-build-system)
-    (arguments
-     `(#:tests? #f ;no tests
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'install 'chdir-emacs
-           (lambda _
-             (chdir "editors/emacs")
-             #t)))))
-    (inputs '())
-    (native-inputs '())
-    (synopsis "Emacs mode for beancount")
-    (description
-      "Emacs-beancount is an Emacs mode for the Beancount accounting tool.")))
+  (let ((commit "dbafe6a73d90c1f64d457b356b9dbb43499f70d5")
+        (revision "0"))
+    (package
+      (name "emacs-beancount")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/beancount/beancount-mode")
+               (commit commit)))
+         (sha256
+          (base32
+           "0v9bws2gv5b00x829p7hrcxqgdp7iwxvv1vhfjka81qrw6w1fvjw"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (license license:gpl3+)
+      (home-page "https://github.com/beancount/beancount-mode")
+      (inputs '())
+      (native-inputs '())
+      (synopsis "Emacs mode for beancount")
+      (description
+       "Emacs-beancount is an Emacs mode for the Beancount accounting tool."))))
 
 (define-public hledger-web
   (package
-- 
2.33.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#50896; Package guix. (Wed, 29 Sep 2021 19:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 50896 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Christine Lemmer-Webber <cwebber <at> dustycloud.org>
Cc: 50896 <at> debbugs.gnu.org
Subject: Re: bug#50896: emacs-beancount broken, moved to its own project
Date: Wed, 29 Sep 2021 21:30:05 +0200
Hello,

Christine Lemmer-Webber <cwebber <at> dustycloud.org> writes:

> +  (let ((commit "dbafe6a73d90c1f64d457b356b9dbb43499f70d5")
> +        (revision "0"))

I suggest to mention in a comment that upstream has not made any release
yet.

> +    (package
> +      (name "emacs-beancount")
> +      (version (git-version "0.0.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/beancount/beancount-mode")
> +               (commit commit)))
> +         (sha256
> +          (base32
> +           "0v9bws2gv5b00x829p7hrcxqgdp7iwxvv1vhfjka81qrw6w1fvjw"))
> +         (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (license license:gpl3+)

Nitpick: usually, license field is at the end of the package definition.

> +      (home-page "https://github.com/beancount/beancount-mode")
> +      (inputs '())
> +      (native-inputs '())

You can remove inputs and native-inputs fields, since they are empty.

> +      (synopsis "Emacs mode for beancount")

Nitpick: beancount -> Beancount

> +      (description
> +       "Emacs-beancount is an Emacs mode for the Beancount accounting
> tool."))))

Otherwise, LGTM!

Regards,
-- 
Nicolas Goaziou




Reply sent to Christine Lemmer-Webber <cwebber <at> dustycloud.org>:
You have taken responsibility. (Wed, 13 Oct 2021 03:36:02 GMT) Full text and rfc822 format available.

Notification sent to Christine Lemmer-Webber <cwebber <at> dustycloud.org>:
bug acknowledged by developer. (Wed, 13 Oct 2021 03:36:02 GMT) Full text and rfc822 format available.

Message #13 received at 50896-done <at> debbugs.gnu.org (full text, mbox):

From: Christine Lemmer-Webber <cwebber <at> dustycloud.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 50896-done <at> debbugs.gnu.org
Subject: Re: bug#50896: emacs-beancount broken, moved to its own project
Date: Tue, 12 Oct 2021 23:34:20 -0400
Thank you... did all the above and pushed!  The emacs-beancount package
is sensibly alive again!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Nov 2021 12:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 139 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.