GNU bug report logs - #50930
[PATCH] gnu: Add guile-pipe

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50930 in the body.
You can then email your comments to 50930 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add guile-pipe
Date: Fri, 1 Oct 2021 04:21:25 -0400

Hi Guix,

Here's guile-pipe.

https://github.com/joshwalters/guile-pipe

guile-pipe is currently available from GuixRUs channel as guile-pipe-guixrus

https://git.sr.ht/~whereiseveryone/guixrus

all best,

jgart

Message #8 received at 50930 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 50930 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add guile-pipe.
Date: Fri,  1 Oct 2021 04:30:28 -0400

* gnu/packages/guile-xyz.scm (guile-pipe): New variable.
---
 gnu/packages/guile-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 7188058b42..f5c5ccd8da 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -256,6 +256,32 @@ more.")
     (home-page "https://www.gnu.org/software/artanis/")
     (license (list license:gpl3+ license:lgpl3+)))) ;dual license
 
+(define-public guile-pipe
+  (let ((commit "0746ec38d19d844dff0c6f62f209b2b6c8d8872e")
+        (revision "0"))
+    (package
+      (name "guile-pipe")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/joshwalters/guile-pipe")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
+      (build-system guile-build-system)
+      (native-inputs
+       `(("guile" ,guile-3.0)))
+      (home-page "https://github.com/joshwalters/guile-pipe")
+      (synopsis "Guile pipe macros for functional chaining")
+      (description
+"Guile pipe macros for functional chaining, similar to the UNIX pipe
+@command{|} operator.  Provides identical functionality to Clojure's function
+threading macros @command{->} and @command{->>}.")
+      (license license:gpl3+))))
+
 (define-public guile-f-scm
   (package
     (name "guile-f-scm")
-- 
2.33.0

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 50930 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [bug#50930] [PATCH] gnu: Add guile-pipe.
Date: Fri, 01 Oct 2021 16:04:20 +0200

[Message part 1 (text/plain, inline)]

On Fri, Oct 01 2021, jgart via Guix-patches via wrote:

> * gnu/packages/guile-xyz.scm (guile-pipe): New variable.
> ---
>  gnu/packages/guile-xyz.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 7188058b42..f5c5ccd8da 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -256,6 +256,32 @@ more.")
>      (home-page "https://www.gnu.org/software/artanis/")
>      (license (list license:gpl3+ license:lgpl3+)))) ;dual license
>  
> +(define-public guile-pipe
> +  (let ((commit "0746ec38d19d844dff0c6f62f209b2b6c8d8872e")
> +        (revision "0"))

There should be a comment stating why a commit and not a tag is used.
In this case it seems that upstream is lacking tags.

> +    (package
> +      (name "guile-pipe")
> +      (version (git-version "0.0.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/joshwalters/guile-pipe")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
> +      (build-system guile-build-system)
> +      (native-inputs
> +       `(("guile" ,guile-3.0)))
> +      (home-page "https://github.com/joshwalters/guile-pipe")
> +      (synopsis "Guile pipe macros for functional chaining")
> +      (description
> +"Guile pipe macros for functional chaining, similar to the UNIX pipe
> +@command{|} operator.  Provides identical functionality to Clojure's function
> +threading macros @command{->} and @command{->>}.")

s/@command/@code/

The description should consist of full sentences (see “16.4.4 Synopses
and Descriptions” in the manual); both sentences are lacking a subject.
I suggest:

  This package provides macros for functional chaining in Guile, similar
  to UNIX pipes (@code{|}) and Clojure's threading macros (@code{->} and
  @code{->>}).
  

[signature.asc (application/pgp-signature, inline)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50930 <at> debbugs.gnu.org, jgart via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#50930] [PATCH] gnu: Add guile-pipe.
Date: Fri, 1 Oct 2021 10:33:25 -0400

On Fri, 01 Oct 2021 16:04:20 +0200 Xinglu Chen <public <at> yoctocell.xyz> wrote:
Hi Xinglu,

Thanks for the review! It is much appreciated. I submitted the patches again 
with your changes.

all best,

jgart

Message #23 received at 50930 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 50930 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add guile-pipe.
Date: Fri,  1 Oct 2021 10:33:38 -0400

* gnu/packages/guile-xyz.scm (guile-pipe): New variable.
---
 gnu/packages/guile-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 7188058b42..5484371f3b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -256,6 +256,33 @@ more.")
     (home-page "https://www.gnu.org/software/artanis/")
     (license (list license:gpl3+ license:lgpl3+)))) ;dual license
 
+;; There are no releases yet of this package.
+(define-public guile-pipe
+  (let ((commit "0746ec38d19d844dff0c6f62f209b2b6c8d8872e")
+        (revision "0"))
+    (package
+      (name "guile-pipe")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/joshwalters/guile-pipe")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
+      (build-system guile-build-system)
+      (native-inputs
+       `(("guile" ,guile-3.0)))
+      (home-page "https://github.com/joshwalters/guile-pipe")
+      (synopsis "Guile pipe macros for functional chaining")
+      (description
+"This package provides macros for functional chaining in Guile, similar
+ to UNIX pipes (@code{|}), Clojure's threading macros (@code{->} and
+ @code{->>}).")
+      (license license:gpl3+))))
+
 (define-public guile-f-scm
   (package
     (name "guile-f-scm")
-- 
2.33.0

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 50930 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [bug#50930] [PATCH] gnu: Add guile-pipe.
Date: Fri, 01 Oct 2021 18:49:47 +0200

[Message part 1 (text/plain, inline)]

On Fri, Oct 01 2021, jgart via Guix-patches via wrote:

> * gnu/packages/guile-xyz.scm (guile-pipe): New variable.
> ---
>  gnu/packages/guile-xyz.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 7188058b42..5484371f3b 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -256,6 +256,33 @@ more.")
>      (home-page "https://www.gnu.org/software/artanis/")
>      (license (list license:gpl3+ license:lgpl3+)))) ;dual license
>  
> +;; There are no releases yet of this package.
> +(define-public guile-pipe
> +  (let ((commit "0746ec38d19d844dff0c6f62f209b2b6c8d8872e")
> +        (revision "0"))
> +    (package
> +      (name "guile-pipe")
> +      (version (git-version "0.0.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/joshwalters/guile-pipe")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
> +      (build-system guile-build-system)
> +      (native-inputs
> +       `(("guile" ,guile-3.0)))
> +      (home-page "https://github.com/joshwalters/guile-pipe")
> +      (synopsis "Guile pipe macros for functional chaining")
> +      (description
> +"This package provides macros for functional chaining in Guile, similar
> + to UNIX pipes (@code{|}), Clojure's threading macros (@code{->} and
> + @code{->>}).")

The indentation of the string is a bit off, sorry for not noticing this
earlier!  Whoever commits this (I am not a committer) can probably fixup
this, so you don’t have to resend a v3 just for this minor change.  The
rest LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 50930-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 50930-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add guile-pipe.
Date: Fri, 01 Oct 2021 20:30:12 +0200

Am Freitag, den 01.10.2021, 10:33 -0400 schrieb jgart:
> * gnu/packages/guile-xyz.scm (guile-pipe): New variable.
> [...]
Pushed with a fix to the indentation

> +      (description
> +"This package provides macros for functional chaining in Guile,
> similar
> + to UNIX pipes (@code{|}), Clojure's threading macros (@code{->} and
> + @code{->>}).")
here :)

Message #37 received at 50930-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 50930-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add guile-pipe.
Date: Fri, 1 Oct 2021 16:24:20 -0400

On Fri, 01 Oct 2021 20:30:12 +0200 Liliana Marie Prikler <liliana.prikler <at> gmail.com> wrote:
> Pushed with a fix to the indentation

Thank you Liliana

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.