GNU bug report logs - #50938
[PATCH] etc: Do not clean guix-gc.timer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50938 in the body.
You can then email your comments to 50938 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matthew James Kraai <kraai <at> ftbfs.org>
To: guix-patches <at> gnu.org
Cc: Matthew James Kraai <kraai <at> ftbfs.org>
Subject: [PATCH] etc: Do not clean guix-gc.timer
Date: Fri,  1 Oct 2021 07:37:06 -0700

* nix/local.mk (dist_systemdservice_DATA): New.
(nodist_systemdservice_DATA): Remove guix-gc.timer.
(EXTRA_DIST): Remove guix-gc.timer.
---
 nix/local.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/nix/local.mk b/nix/local.mk
index d6b4d7faeb..b0cce85cab 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -150,12 +150,13 @@ noinst_HEADERS =						\
 
 # The '.service' files for systemd.
 systemdservicedir = $(libdir)/systemd/system
+dist_systemdservice_DATA =			\
+  etc/guix-gc.timer
 nodist_systemdservice_DATA =			\
   etc/gnu-store.mount				\
   etc/guix-daemon.service			\
   etc/guix-publish.service			\
-  etc/guix-gc.service				\
-  etc/guix-gc.timer
+  etc/guix-gc.service
 
 etc/%.mount: etc/%.mount.in	\
 			 $(top_builddir)/config.status
@@ -219,7 +220,6 @@ EXTRA_DIST +=					\
   etc/guix-publish.service.in			\
   etc/guix-publish.conf.in			\
   etc/guix-gc.service.in			\
-  etc/guix-gc.timer				\
   etc/init.d/guix-daemon.in			\
   etc/openrc/guix-daemon.in
 
-- 
2.33.0

Message #8 received at 50938 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Matthew James Kraai <kraai <at> ftbfs.org>
Cc: 50938 <at> debbugs.gnu.org
Subject: Re: bug#50938: [PATCH] etc: Do not clean guix-gc.timer
Date: Sat, 02 Oct 2021 17:04:38 +0000

Hello,

> -  etc/guix-gc.timer

Commit 8579304e8f4deaca33b816b2d56af1d814a03bde already removes
guix-gc.timer from the nodist_systemdservice_DATA list.

>    etc/guix-gc.service.in			\
> -  etc/guix-gc.timer				\
>    etc/init.d/guix-daemon.in			\
>    etc/openrc/guix-daemon.in

Why should we move guix-gc.timer from EXTRA_DIST to
dist_systemdservice_DATA?

Thanks,

Mathieu

Message #11 received at 50938 <at> debbugs.gnu.org (full text, mbox):

From: Matthew James Kraai <kraai <at> ftbfs.org>
To: 50938 <at> debbugs.gnu.org
Subject: Fwd: bug#50938: [PATCH] etc: Do not clean guix-gc.timer
Date: Sat, 2 Oct 2021 13:27:16 -0700

[Message part 1 (text/plain, inline)]

-------- Forwarded Message --------
Subject: 	Re: bug#50938: [PATCH] etc: Do not clean guix-gc.timer
Date: 	Sat, 2 Oct 2021 13:26:04 -0700
From: 	Matthew James Kraai <kraai <at> ftbfs.org>
To: 	Mathieu Othacehe <othacehe <at> gnu.org>



Hi,

On 10/2/21 10:04 AM, Mathieu Othacehe wrote:
> Hello,
>
>> - etc/guix-gc.timer
> Commit 8579304e8f4deaca33b816b2d56af1d814a03bde already removes
> guix-gc.timer from the nodist_systemdservice_DATA list.
>
>> etc/guix-gc.service.in \
>> - etc/guix-gc.timer \
>> etc/init.d/guix-daemon.in \
>> etc/openrc/guix-daemon.in
> Why should we move guix-gc.timer from EXTRA_DIST to
> dist_systemdservice_DATA?

I think it has to be in dist_systemdservice_DATA in order to be 
installed.  Is that not the case?

Matt

[Message part 2 (text/html, inline)]

Message #16 received at 50938-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Matthew James Kraai <kraai <at> ftbfs.org>
Cc: 50938-done <at> debbugs.gnu.org
Subject: Re: bug#50938: [PATCH] etc: Do not clean guix-gc.timer
Date: Sun, 03 Oct 2021 19:39:39 +0000

Hey Matt,

> I think it has to be in dist_systemdservice_DATA in order to be
> installed.  Is that not the case?

Looks like having this file in the EXTRA_DIST list is enough to have it
installed. I think we can close this one.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.