GNU bug report logs - #50952
[PATCH] gnu: Add naev.

Previous Next

Package: guix-patches;

Reported by: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Date: Fri, 1 Oct 2021 20:33:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50952 in the body.
You can then email your comments to 50952 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#50952; Package guix-patches. (Fri, 01 Oct 2021 20:33:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 01 Oct 2021 20:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add naev.
Date: Fri, 01 Oct 2021 22:32:02 +0200
[Message part 1 (text/plain, inline)]
Hello,

Here comes a patch for the Naev game.

Regards,
-- 
Nicolas Goaziou
[0001-gnu-Add-naev.patch (text/x-diff, inline)]
From 00610d682ebf6653144d63e4cd09e9d896f3bf5c Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Fri, 1 Oct 2021 22:29:19 +0200
Subject: [PATCH] gnu: Add naev.

* gnu/packages/games.scm (naev): New variable.
---
 gnu/packages/games.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index dabbbe6ea1..b3ea7de5dd 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7998,6 +7998,66 @@ ncurses for text display.")
     (home-page "http://frotz.sourceforge.net")
     (license license:gpl2+)))
 
+(define-public naev
+  (package
+    (name "naev")
+    (version "0.8.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/naev/naev")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "02rk2fv2nhx5xsi0cariisamab3dpncwps4q3i3ki0y27xpwxzfx"))))
+    (build-system meson-build-system)
+    (arguments
+     ;; XXX: Do not add debugging symbols, which cause the build to fail.
+     `(#:configure-flags (list "--buildtype=release")
+       #:tests? #f            ;sole test fails with a missing "/dev/dri" error
+       #:meson ,meson-0.55))
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("freetype" ,freetype)
+       ("glpk" ,glpk)
+       ("libpng" ,libpng)
+       ("libvorbis" ,libvorbis)
+       ("libwebp" ,libwebp)
+       ("libxml2" ,libxml2)
+       ("luajit" ,luajit)
+       ("openal" ,openal)
+       ("openblas" ,openblas)
+       ("physfs" ,physfs)
+       ("sdl" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer)))
+       ("suitesparse" ,suitesparse)))
+    (home-page "https://naev.org/")
+    (synopsis "Game about space exploration, trade and combat")
+    (description
+     "Naev is a 2d action/rpg space game that combines elements from
+the action, RPG and simulation genres.  You pilot a spaceship from
+a top-down perspective, and are more or less free to do what you want.
+As the genre name implies, you’re able to trade and engage in combat
+at will.  Beyond that, there’s an ever-growing number of story-line
+missions, equipment, and ships; even the galaxy itself grows larger
+with each release.  For the literacy-inclined, there are large amounts
+of lore accompanying everything from planets to equipment.")
+    (license (list license:gpl3
+                   license:public-domain
+                   license:expat        ;edtaa3func.c
+                   license:bsd-2        ;distance_field.c
+                   license:bsd-3        ;perlin.c
+                   ;; Assets.
+                   license:silofl1.1
+                   license:gpl2+
+                   license:cc0
+                   license:cc-by3.0
+                   license:cc-by-sa3.0
+                   license:cc-by4.0
+                   license:cc-by-sa4.0))))
+
 (define-public frotz-dumb-terminal
   (package
     (name "frotz-dumb-terminal")
-- 
2.33.0


Information forwarded to guix-patches <at> gnu.org:
bug#50952; Package guix-patches. (Sat, 30 Oct 2021 17:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 50952 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 50952 <at> debbugs.gnu.org
Subject: Re: bug#50952: [PATCH] gnu: Add naev.
Date: Sat, 30 Oct 2021 19:08:33 +0200
Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>>From 00610d682ebf6653144d63e4cd09e9d896f3bf5c Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Fri, 1 Oct 2021 22:29:19 +0200
> Subject: [PATCH] gnu: Add naev.
>
> * gnu/packages/games.scm (naev): New variable.

[...]

> +    (build-system meson-build-system)
> +    (arguments
> +     ;; XXX: Do not add debugging symbols, which cause the build to fail.

That sounds weird.  Perhaps ‘--buildtype=release’ does something beyond
removing ‘-g’, which would explain that it doesn’t fail?

Otherwise LGTM!

Ludo’.




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 02 Nov 2021 20:34:01 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
bug acknowledged by developer. (Tue, 02 Nov 2021 20:34:02 GMT) Full text and rfc822 format available.

Message #13 received at 50952-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 50952-done <at> debbugs.gnu.org
Subject: Re: bug#50952: [PATCH] gnu: Add naev.
Date: Tue, 02 Nov 2021 21:33:46 +0100
Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

>> Subject: [PATCH] gnu: Add naev.
>>
>> * gnu/packages/games.scm (naev): New variable.
>
> [...]
>
>> +    (build-system meson-build-system)
>> +    (arguments
>> +     ;; XXX: Do not add debugging symbols, which cause the build to fail.
>
> That sounds weird.  Perhaps ‘--buildtype=release’ does something beyond
> removing ‘-g’, which would explain that it doesn’t fail?

I couldn't spot anything suspicious in the code base. However, upstream
mention that "--buildtype=release" should be used for a regular
installation.

> Otherwise LGTM!

Pushed. Thank you!

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.