GNU bug report logs - #50997
[PATCH] doc: Fix 'setuid-program' example.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50997 in the body.
You can then email your comments to 50997 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>
Subject: [PATCH] doc: Fix 'setuid-program' example.
Date: Sun,  3 Oct 2021 20:10:24 +0200

The '#$' doesn't belong there, and will cause ‘unbound variable’ errors.

Reported-By: ss2 (on IRC)

* doc/guix.texi (Setuid Programs): Remove #$ from example.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 6436e83a7c..4bc5e2cbab 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -32903,7 +32903,7 @@ designated like this:
 
 @example
 (setuid-program
-  (program (file-append #$shadow "/bin/passwd")))
+  (program (file-append shadow "/bin/passwd")))
 @end example
 
 @deftp {Data Type} setuid-program

base-commit: fa4130e7fe96fc884adcf0d30d222c6bbe26e1e9
prerequisite-patch-id: 1f7f1597b9c85b2b1f9db1044d193bcf6ec8650e
prerequisite-patch-id: 588ca94b9c4603424094a9cc2854c4f9bc83c7e4
prerequisite-patch-id: 82b4951463e8979d1c4cd15e1ca6a36308b21b51
prerequisite-patch-id: 75cdb9eb6b038adfb605253163b94efd51e0276c
prerequisite-patch-id: 35140f4f2873d0b9f4fc8caca6ec2e013ecb830a
prerequisite-patch-id: ed97d14afd166e7b6cac37e3aa87a85246f7e320
prerequisite-patch-id: 3f3d43f5583dce32af7d4e9925771e581c3cc5ee
prerequisite-patch-id: e8f735697c0535afe9335448b16e3e1f308de362
prerequisite-patch-id: eaf1f67c4c07482fb4da81525cbd5dcb1ea2194e
prerequisite-patch-id: 9a15aa08fbbbf110ba76409dcc2a3ab5e0764806
prerequisite-patch-id: 675a3c516f47dfcbaf61d5ad41ca7f3babdd3f20
prerequisite-patch-id: ac188cb61957c9639d0ac125c941950afbdba9c7
prerequisite-patch-id: f3f1f02944a4aa9635ce7094bfda254315d990b3
prerequisite-patch-id: 5eee450b2221d67fbda1e6581d16628394c912a7
prerequisite-patch-id: bad535152857928abf624dc49dc2b27718d3885e
prerequisite-patch-id: 623edc835c2c5dfd8c83dcf32e650cfebea42aa0
prerequisite-patch-id: c0f50259e7fc09455f77dca31113b0b55e955220
prerequisite-patch-id: 9c7c0929a48b103b6b69626dbc86d7744f2f40ad
prerequisite-patch-id: 8f8c2af0b856f56c7798a3b79ba90b073bbb382f
prerequisite-patch-id: 7d88402829a8967c23650dffe115a94ae26433da
prerequisite-patch-id: ffb3d6215a89195f6e0f274f2f119c1f7b65259a
prerequisite-patch-id: 54eec153e523b58c3670c48afda9ef50ec44eb8e
prerequisite-patch-id: bc5dfc06e9d67d10a37fbd7ba61939907d93ca7c
prerequisite-patch-id: f85cc1c9eac0d44f40afe2a547ac3d866769f685
prerequisite-patch-id: 0db9692e872bf73242cfec6f8aa390abe14d08f1
prerequisite-patch-id: 36431a656d29e90e8eb218730c64807e2477c9d7
prerequisite-patch-id: 6817d73f5e42ccd33b19642ea4ef62814ad2b10e
prerequisite-patch-id: 9146aec4a40f7da60a4c64643a9aa0e405567b04
prerequisite-patch-id: ff2daf978d58ec12c25dcbce4e7ee010d337cd54
prerequisite-patch-id: c88d74073fcd5d1ff19a4a9338b0df63b648d98a
prerequisite-patch-id: 3032f2193b95d5cb625e33daec015f3354f01903
prerequisite-patch-id: e3f352a6e56902bce8d04d4c5725c9829563b47b
-- 
2.33.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] doc: Fix 'setuid-program' example.
Date: Sun, 03 Oct 2021 20:13:30 +0200

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op zo 03-10-2021 om 20:10 [+0200]:
> The '#$' doesn't belong there, and will cause ‘unbound variable’ errors.
> 
> Reported-By: ss2 (on IRC)

There are some complications, let's wait with applying ...

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 50997 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 50997 <at> debbugs.gnu.org
Subject: Re: [bug#50997] [PATCH] doc: Fix 'setuid-program' example.
Date: Sun, 03 Oct 2021 22:10:23 +0200

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op zo 03-10-2021 om 20:13 [+0200]:
> Maxime Devos schreef op zo 03-10-2021 om 20:10 [+0200]:
> > The '#$' doesn't belong there, and will cause ‘unbound variable’ errors.
> > 
> > Reported-By: ss2 (on IRC)
> 
> There are some complications, let's wait with applying ...

The patch turned out to be good after all.  The complication was some misplaced parentheses.

> Greetings,
> Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 50997-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 50997-done <at> debbugs.gnu.org
Subject: Re: [bug#50997] [PATCH] doc: Fix 'setuid-program' example.
Date: Mon, 04 Oct 2021 13:48:16 +0200

[Message part 1 (text/plain, inline)]

Maxime,

Maxime Devos 写道：
> The '#$' doesn't belong there, and will cause ‘unbound variable’ 
> errors.

Yep.  Pushed as 5fec14807f027e62e1c74f8d15ce8b97fed54e58.  Thanks!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.