GNU bug report logs - #51029
28.0.60; ibuffer-shrink-to-fit: Symbol’s value as variable is void: ibuffer-auto-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51029 in the body.
You can then email your comments to 51029 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.60; ibuffer-shrink-to-fit: Symbol’s value
 as variable is void: ibuffer-auto-mode
Date: Tue, 05 Oct 2021 12:55:33 +0300

*** Steps to reproduce:

1. emacs -Q
2. Optionally: (require 'ibuffer)
3. (setq ibuffer-default-shrink-to-minimum-size t)
4. M-x ibuffer


*** Result:

*Messages*

Updating buffer list...
Formats have changed, recompiling...done
Updating buffer list...done
ibuffer-shrink-to-fit: Symbol’s value as variable is void: ibuffer-auto-mode


*Backtrace*

Debugger entered--Lisp error: (void-variable ibuffer-auto-mode)
  buffer-local-value(ibuffer-auto-mode #<buffer *Ibuffer*>)
  ibuffer-shrink-to-fit()
  ibuffer-update(nil)
  ibuffer(nil)
  funcall-interactively(ibuffer nil)
  call-interactively(ibuffer record nil)
  command-execute(ibuffer record)
  execute-extended-command(nil "ibuffer" #("ibu" 0 2 (fontified t) 2 3 (fontified nil)))
  funcall-interactively(execute-extended-command nil "ibuffer" #("ibu" 0 2 (fontified t) 2 3 (fontified nil)))
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)


In GNU Emacs 28.0.60 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G9216))
 of 2021-10-01
Repository revision: 5ee5a90213f6a6cac31fc849af6bf152756292e3
Repository branch: emacs-28
Windowing system distributor 'Apple', version 10.3.1671
System Description:  Mac OS X 10.14.6

Message #8 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Y. E." <yet <at> ego.team>
Cc: 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; ibuffer-shrink-to-fit: Symbol’s value as variable is void: ibuffer-auto-mode
Date: Tue, 5 Oct 2021 17:39:09 -0400

close 51029 28.1
thanks

Y. E. <yet <at> ego.team> writes:

> *** Steps to reproduce:
>
> 1. emacs -Q
> 2. Optionally: (require 'ibuffer)
> 3. (setq ibuffer-default-shrink-to-minimum-size t)
> 4. M-x ibuffer

Thank you for the very clear and easily reproducible bug report!

I have now fixed this on the emacs-28 branch (commit ead5c5cc51).
This fix will be a part of the upcoming Emacs 28.1.

Please verify that this fix works for you, but for now I'm closing this
bug report.  If you see anything that is wrong, please reply to this
email (use "Reply to all" in your email client) and we can reopen the
bug report.  You could also just report a new bug.

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Kangas <stefan <at> marxist.se>
Subject: 28.0.60; Follow-up to Bug#51029: ibuffer-shrink-to-fit does not
 call fit-window-to-buffer
Date: Wed, 06 Oct 2021 22:45:51 +0300

This is a follow-up to Bug#51029.
It seems there's more to fix.

Steps to reproduce:

1. emacs -Q
2. (setq ibuffer-default-shrink-to-minimum-size t)
3. M-x ibuffer-other-window
4. *Ibuffer* isn't shrinked

[Because ibuffer-auto-mode is not bound and hence fit-window-to-buffer
is not called.]

Thank you.

Message #16 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Y. E." <yet <at> ego.team>, 51029 <at> debbugs.gnu.org
Subject: Re: 28.0.60; Follow-up to Bug#51029: ibuffer-shrink-to-fit does not
 call fit-window-to-buffer
Date: Wed, 6 Oct 2021 19:00:32 -0400

reopen 51029
thanks

Y. E. <yet <at> ego.team> writes:

> This is a follow-up to Bug#51029.
> It seems there's more to fix.
>
> Steps to reproduce:
>
> 1. emacs -Q
> 2. (setq ibuffer-default-shrink-to-minimum-size t)
> 3. M-x ibuffer-other-window
> 4. *Ibuffer* isn't shrinked
>
> [Because ibuffer-auto-mode is not bound and hence fit-window-to-buffer
> is not called.]

Thanks for following up on this.  So the fix I installed avoided the
backtrace, but it didn't lead to the behavior you want, i.e. the one
promised by `ibuffer-default-shrink-to-minimum-size'.

From reading the code it seems here that the intention is that
`ibuffer-default-shrink-to-minimum-size' should only work when
`ibuffer-auto-mode' is also enabled?  But that is not documented, is it?

Does anyone know how any of this is actually supposed to work?

Message #21 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Kangas <stefan <at> marxist.se>, "Y. E." <yet <at> ego.team>,
 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; Follow-up to Bug#51029: ibuffer-shrink-to-fit
 does not call fit-window-to-buffer
Date: Thu, 7 Oct 2021 11:07:31 +0200

[Message part 1 (text/plain, inline)]

>> 1. emacs -Q
>> 2. (setq ibuffer-default-shrink-to-minimum-size t)
>> 3. M-x ibuffer-other-window
>> 4. *Ibuffer* isn't shrinked
>>
>> [Because ibuffer-auto-mode is not bound and hence fit-window-to-buffer
>> is not called.]
>
> Thanks for following up on this.  So the fix I installed avoided the
> backtrace, but it didn't lead to the behavior you want, i.e. the one
> promised by `ibuffer-default-shrink-to-minimum-size'.
>
>>From reading the code it seems here that the intention is that
> `ibuffer-default-shrink-to-minimum-size' should only work when
> `ibuffer-auto-mode' is also enabled?  But that is not documented, is it?
>
> Does anyone know how any of this is actually supposed to work?

I suppose the attached would fix it.

martin

[ibuffer.el.diff (text/x-patch, attachment)]

Message #24 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: martin rudalics <rudalics <at> gmx.at>, "Y. E." <yet <at> ego.team>,
 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; Follow-up to Bug#51029: ibuffer-shrink-to-fit
 does not call fit-window-to-buffer
Date: Thu, 7 Oct 2021 10:48:23 -0400

tags 51029 + patch
thanks

martin rudalics <rudalics <at> gmx.at> writes:

>  > Does anyone know how any of this is actually supposed to work?
>
> I suppose the attached would fix it.

Thanks.

Y. E., could you please check if this patch fixes the issue for you?

Message #27 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: rudalics <at> gmx.at, yet <at> ego.team, 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; Follow-up to Bug#51029: ibuffer-shrink-to-fit
 does not call fit-window-to-buffer
Date: Sat, 09 Oct 2021 11:25:41 +0300

> > I suppose the attached would fix it.

> Y. E., could you please check if this patch fixes the issue for you?

Yes, the patch works fine for me, thank you.

Message #32 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Y. E." <yet <at> ego.team>
Cc: rudalics <at> gmx.at, 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; ibuffer-shrink-to-fit: Symbol’s value as variable is void: ibuffer-auto-mode
Date: Mon, 11 Oct 2021 07:32:14 -0700

Y. E. <yet <at> ego.team> writes:

>> > I suppose the attached would fix it.
>
>> Y. E., could you please check if this patch fixes the issue for you?
>
> Yes, the patch works fine for me, thank you.

Martin, could you install the patch on emacs-28 or master according to
what you think is best?  Thanks.

Message #35 received at 51029 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Kangas <stefan <at> marxist.se>, "Y. E." <yet <at> ego.team>
Cc: 51029 <at> debbugs.gnu.org
Subject: Re: bug#51029: 28.0.60; ibuffer-shrink-to-fit: Symbol’s value as variable is void: ibuffer-auto-mode
Date: Mon, 11 Oct 2021 19:06:39 +0200

close 51029 28.1
quit

> Martin, could you install the patch on emacs-28 or master according to
> what you think is best?  Thanks.

Installed on the release branch to avoid a regression wrt Emacs 27.
Closing this bug, hopefully.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.