GNU bug report logs - #51046
[PATCH] gnu: Add rdate.

Previous Next

Package: guix-patches;

Reported by: phodina <phodina <at> protonmail.com>

Date: Tue, 5 Oct 2021 22:46:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51046 in the body.
You can then email your comments to 51046 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51046; Package guix-patches. (Tue, 05 Oct 2021 22:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to phodina <phodina <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 05 Oct 2021 22:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add rdate.
Date: Tue, 05 Oct 2021 22:45:29 +0000
* gnu/packages/time.scm (rdate): New variable.

diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
index df4b8ac6f5..351c990ce1 100644
--- a/gnu/packages/time.scm
+++ b/gnu/packages/time.scm
@@ -470,6 +470,30 @@ datetime type.")
 (define-public python2-aniso8601
   (package-with-python2 python-aniso8601))

+(define-public rdate
+  (let ((commit "91d84610e3695e90a884e2953908e95a856a9b74")
+        (revision "1"))
+    (package
+      (name "rdate")
+      (version (git-version "1.4" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/njh/rdate")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "002ryjq8gj1ml5la4v6dr3bh1zw5kxwy65rpziq8d2ccccarhv59"))))
+      (build-system gnu-build-system)
+      (native-inputs `(("autoconf" ,autoconf)
+                       ("automake" ,automake)))
+      (synopsis "Get date and time based on RFC 868")
+      (description "@code{rdate} connects to an RFC 868 time server over a TCP/IP
+network, printing the returned time and/or setting the system clock.")
+      (home-page "https://www.aelius.com/njh/rdate/")
+      (license license:gpl2))))
+
 (define-public datefudge
   (package
     (name "datefudge")
--
2.32.0




Information forwarded to guix-patches <at> gnu.org:
bug#51046; Package guix-patches. (Thu, 07 Mar 2024 19:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 51046 <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: 51046 <at> debbugs.gnu.org
Cc: phodina <at> protonmail.com, Juliana Sims <juli <at> incana.org>
Subject: [PATCH v2] gnu: Add rdate.
Date: Thu,  7 Mar 2024 14:43:06 -0500
Hello!

It's been quite some time since this patch was submitted, and it still works!
It needed two small changes -- adding the autotools module and using a different
license symbol format -- so I've gone ahead and made those changes. I also took
the liberty of updating the inputs to the new format. There are no semantic
changes to the patch itself.

Thanks again for submitting this!
Juli

* gnu/packages/time.scm (rdate): New variable.

Change-Id: I12217c62fe17a93bdb5364f807804eea7fc57a23
---
 gnu/packages/time.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
index b0d800da949..14b02352d6f 100644
--- a/gnu/packages/time.scm
+++ b/gnu/packages/time.scm
@@ -40,6 +40,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages time)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -549,6 +550,30 @@ (define-public python-aniso8601
      "This package contains a library for parsing ISO 8601 datetime strings.")
     (license bsd-3)))
 
+(define-public rdate
+  (let ((commit "91d84610e3695e90a884e2953908e95a856a9b74")
+        (revision "1"))
+    (package
+      (name "rdate")
+      (version (git-version "1.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/njh/rdate")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "002ryjq8gj1ml5la4v6dr3bh1zw5kxwy65rpziq8d2ccccarhv59"))))
+      (build-system gnu-build-system)
+      (native-inputs (list autoconf automake))
+      (synopsis "Get date and time based on RFC 868")
+      (description
+       "@code{rdate} connects to an RFC 868 time server over a TCP/IP network,
+printing the returned time and/or setting the system clock.")
+      (home-page "https://www.aelius.com/njh/rdate/")
+      (license gpl2))))
+
 (define-public datefudge
   (package
     (name "datefudge")

base-commit: 7f2f1bcddae64c48f793cde15c21617fa706c157
-- 
2.41.0





Reply sent to Andreas Enge <andreas <at> enge.fr>:
You have taken responsibility. (Fri, 08 Mar 2024 09:45:02 GMT) Full text and rfc822 format available.

Notification sent to phodina <phodina <at> protonmail.com>:
bug acknowledged by developer. (Fri, 08 Mar 2024 09:45:02 GMT) Full text and rfc822 format available.

Message #13 received at 51046-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 51046-done <at> debbugs.gnu.org
Subject: Close
Date: Fri, 8 Mar 2024 10:43:44 +0100
Thanks, phodina, for the patch, and Juliana, for undigging and
reviewing it! Given that the package looks unmaintained, I was a bit
hesitant, but since it still builds, why not add it; I took the liberty
to not wait for QA to build it out.

Before pushing, I changed the licence to gpl2+. Indeed, if later versions
are not explicitly excluded ("v2 only"), the GPL itself contains a clause
that implies "or later":

9. The Free Software Foundation may publish revised and/or new versions
of the General Public License from time to time.  Such new versions will
be similar in spirit to the present version, but may differ in detail to
address new problems or concerns.
Each version is given a distinguishing version number.  If the Program
specifies a version number of this License which applies to it and "any
later version", you have the option of following the terms and conditions
either of that version or of any later version published by the Free
Software Foundation.  If the Program does not specify a version number of
this License, you may choose any version ever published by the Free Software
Foundation.

Here it is also explicitly given in the source,
for instance there:
   https://github.com/njh/rdate/blob/main/src/rdate.c

Andreas





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 05 Apr 2024 11:24:25 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.