GNU bug report logs - #51108
[PATCH] import: pypi: Support 'input-changes'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51108 in the body.
You can then email your comments to 51108 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: pypi: Support 'input-changes'.
Date: Sat, 09 Oct 2021 12:21:15 +0200

* guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.
---
 guix/import/pypi.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index b7859c8341..52835cf44d 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -532,7 +532,8 @@ (define pypi-package?
 (define (latest-release package)
   "Return an <upstream-source> for the latest release of PACKAGE."
   (let* ((pypi-name    (guix-package->pypi-name package))
-         (pypi-package (pypi-fetch pypi-name)))
+         (pypi-package (pypi-fetch pypi-name))
+         (name (package-name package)))
     (and pypi-package
          (guard (c ((missing-source-error? c) #f))
            (let* ((info    (pypi-project-info pypi-package))
@@ -540,9 +541,12 @@ (define (latest-release package)
                   (url     (distribution-url
                             (latest-source-release pypi-package))))
              (upstream-source
-              (package (package-name package))
+              (package name)
               (version version)
-              (urls (list url))))))))
+              (urls (list url))
+              (input-changes
+               (changed-inputs name
+                               (pypi->guix-package pypi-name)))))))))
 
 (define %pypi-updater
   (upstream-updater

base-commit: fd8ea9abf5b4ded096b7ccadb5e36fde4bac0867
-- 
2.33.0

Message #10 received at 51108-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 51108-done <at> debbugs.gnu.org
Subject: Re: bug#51108: [PATCH] import: pypi: Support 'input-changes'.
Date: Fri, 15 Oct 2021 23:22:07 +0200

Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> * guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.

[...]

> +              (input-changes
> +               (changed-inputs name
> +                               (pypi->guix-package pypi-name)))))))))

This was bogus (it passes the package name of instead of the package
itself).  I fixed it and pushed as
50d2900e7621aed7aea99884b6d9b41c389167d9.  It works with:

  ./pre-inst-env guix refresh python-notebook -u

Let me know if anything’s amiss!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.