GNU bug report logs - #51113
[PATCH] gnu: Add snooze.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: jgart <jgart@HIDDEN>; Keywords: patch; dated Sun, 10 Oct 2021 07:54:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 51113 <at> debbugs.gnu.org:


Received: (at 51113) by debbugs.gnu.org; 13 Oct 2021 19:28:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 13 15:28:56 2021
Received: from localhost ([127.0.0.1]:33517 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1majvs-0008R2-Kl
	for submit <at> debbugs.gnu.org; Wed, 13 Oct 2021 15:28:56 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57795)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1majvr-0008QY-Hc
 for 51113 <at> debbugs.gnu.org; Wed, 13 Oct 2021 15:28:56 -0400
Received: (Authenticated sender: admin@HIDDEN)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47E67FF802;
 Wed, 13 Oct 2021 19:28:48 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
To: jgart via Guix-patches via <guix-patches@HIDDEN>
Subject: Re: [bug#51113] [PATCH] gnu: Add snooze.
References: <20211010075339.22230-1-jgart@HIDDEN>
Date: Wed, 13 Oct 2021 21:28:48 +0200
In-Reply-To: <20211010075339.22230-1-jgart@HIDDEN> (jgart via Guix-patches
 via's message of "Sun, 10 Oct 2021 03:53:39 -0400")
Message-ID: <87mtnc7mhb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51113
Cc: jgart <jgart@HIDDEN>, 51113 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

jgart via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/suckless.scm (snooze): New variable.

Thank you. Some comments follow.

> +    (arguments
> +     `(#:tests? #f

Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.

> +       #:make-flags
> +       (list (string-append "CC=" ,(cc-for-target))
> +             (string-append "DESTDIR=" %output)
> +             "PREFIX=")

It may be worth explaining in a comment why PREFIX is reset.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (home-page "https://github.com/leahneukirchen/snooze")
> +    (synopsis "Run a command at a particular time")
> +    (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")

I would remove "new" from the description.

Otherwise, LGTM. Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches@HIDDEN:
bug#51113; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Oct 2021 19:28:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 13 15:28:56 2021
Received: from localhost ([127.0.0.1]:33515 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1majvs-0008R0-Dl
	for submit <at> debbugs.gnu.org; Wed, 13 Oct 2021 15:28:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:43760)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1majvr-0008Qk-AA
 for submit <at> debbugs.gnu.org; Wed, 13 Oct 2021 15:28:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47908)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>)
 id 1majvr-0001is-0r
 for guix-patches@HIDDEN; Wed, 13 Oct 2021 15:28:55 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34955)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>)
 id 1majvo-0003Gj-Rn
 for guix-patches@HIDDEN; Wed, 13 Oct 2021 15:28:54 -0400
Received: (Authenticated sender: admin@HIDDEN)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47E67FF802;
 Wed, 13 Oct 2021 19:28:48 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
To: jgart via Guix-patches via <guix-patches@HIDDEN>
Subject: Re: [bug#51113] [PATCH] gnu: Add snooze.
References: <20211010075339.22230-1-jgart@HIDDEN>
Date: Wed, 13 Oct 2021 21:28:48 +0200
In-Reply-To: <20211010075339.22230-1-jgart@HIDDEN> (jgart via Guix-patches
 via's message of "Sun, 10 Oct 2021 03:53:39 -0400")
Message-ID: <87mtnc7mhb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=217.70.183.199;
 envelope-from=mail@HIDDEN; helo=relay9-d.mail.gandi.net
X-Spam_score_int: -6
X-Spam_score: -0.7
X-Spam_bar: /
X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: jgart <jgart@HIDDEN>, 51113 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

Hello,

jgart via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/suckless.scm (snooze): New variable.

Thank you. Some comments follow.

> +    (arguments
> +     `(#:tests? #f

Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.

> +       #:make-flags
> +       (list (string-append "CC=" ,(cc-for-target))
> +             (string-append "DESTDIR=" %output)
> +             "PREFIX=")

It may be worth explaining in a comment why PREFIX is reset.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (home-page "https://github.com/leahneukirchen/snooze")
> +    (synopsis "Run a command at a particular time")
> +    (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")

I would remove "new" from the description.

Otherwise, LGTM. Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches@HIDDEN:
bug#51113; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Oct 2021 07:53:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 10 03:53:58 2021
Received: from localhost ([127.0.0.1]:54403 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mZTeg-0008EG-Hm
	for submit <at> debbugs.gnu.org; Sun, 10 Oct 2021 03:53:58 -0400
Received: from lists.gnu.org ([209.51.188.17]:47608)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1mZTef-0008E9-Ku
 for submit <at> debbugs.gnu.org; Sun, 10 Oct 2021 03:53:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39824)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1mZTef-00083f-Cz
 for guix-patches@HIDDEN; Sun, 10 Oct 2021 03:53:57 -0400
Received: from mx1.dismail.de ([78.46.223.134]:13240)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1mZTec-00024h-V2
 for guix-patches@HIDDEN; Sun, 10 Oct 2021 03:53:57 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id 3e34bb08
 for <guix-patches@HIDDEN>; Sun, 10 Oct 2021 09:53:49 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc
 :subject:date:message-id:mime-version:content-transfer-encoding;
 s=20190914; bh=qhiMq1qWm8tzygjbw0UybLsA5P726w7CpQrmoHMOJ30=; b=
 lE9UA/ArujoCsvFl96f9OPTx1fEQgmioQ1VVrpTB/2qIbnAbzUrFCoqbH4pk+hEn
 BDCFs4ILvfk/8wzeBhKD2tgQ9RkrJ/aD7v08WH4fTTdft6cK9T0pBrlW63HNlYfs
 e3I2rAZrXWA1XuDa7nLMpaJfCpCoByI0VE+eTIj7ckwh9pTJUPYVwIcRA8NAP0do
 LMqAw1F3wH/awe+++JZUjYJWEZkOuXnd0UiY9TfNnwHFJpXuomaJzKFyyPs7CFHN
 LRBhHi+24eYW2bC2Zpcn4ZHfboqxIrfOLLEJyeWPkVXrFX2G9Lx4DavCH0UjhKAG
 uMOcMpJWuPOP2pKW1xOcQg==
Received: from smtp1.dismail.de (<unknown> [10.240.26.11])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id 1dc979d3
 for <guix-patches@HIDDEN>; Sun, 10 Oct 2021 09:53:49 +0200 (CEST)
Received: from smtp1.dismail.de (localhost [127.0.0.1])
 by smtp1.dismail.de (OpenSMTPD) with ESMTP id 10017320
 for <guix-patches@HIDDEN>; Sun, 10 Oct 2021 09:53:49 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 96048cd2
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sun, 10 Oct 2021 09:53:48 +0200 (CEST)
From: jgart <jgart@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add snooze.
Date: Sun, 10 Oct 2021 03:53:39 -0400
Message-Id: <20211010075339.22230-1-jgart@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@HIDDEN;
 helo=mx1.dismail.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: jgart <jgart@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/suckless.scm (snooze): New variable.
---
 gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..1643c89990 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -873,6 +873,37 @@ It is a front end for ii-like chat programs.  It uses @code{tail -f} to get the
 chat output in the background.")
       (license license:isc))))
 
+(define-public snooze
+  (package
+    (name "snooze")
+    (version "0.5")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/leahneukirchen/snooze")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "DESTDIR=" %output)
+             "PREFIX=")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))
+    (home-page "https://github.com/leahneukirchen/snooze")
+    (synopsis "Run a command at a particular time")
+    (description
+"@command{snooze} is a new tool for waiting until a particular time and then
+running a command.")
+    (license license:cc0)))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.33.0





Acknowledgement sent to jgart <jgart@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#51113; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 13 Oct 2021 19:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.