GNU bug report logs -
#51113
[PATCH] gnu: Add snooze.
Previous Next
Reported by: jgart <jgart <at> dismail.de>
Date: Sun, 10 Oct 2021 07:54:02 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51113 in the body.
You can then email your comments to 51113 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Sun, 10 Oct 2021 07:54:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
jgart <jgart <at> dismail.de>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Sun, 10 Oct 2021 07:54:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/suckless.scm (snooze): New variable.
---
gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..1643c89990 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -873,6 +873,37 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the
chat output in the background.")
(license license:isc))))
+(define-public snooze
+ (package
+ (name "snooze")
+ (version "0.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/leahneukirchen/snooze")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "DESTDIR=" %output)
+ "PREFIX=")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/leahneukirchen/snooze")
+ (synopsis "Run a command at a particular time")
+ (description
+"@command{snooze} is a new tool for waiting until a particular time and then
+running a command.")
+ (license license:cc0)))
+
(define-public scron
(package
(name "scron")
--
2.33.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Wed, 13 Oct 2021 19:29:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
> * gnu/packages/suckless.scm (snooze): New variable.
Thank you. Some comments follow.
> + (arguments
> + `(#:tests? #f
Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "DESTDIR=" %output)
> + "PREFIX=")
It may be worth explaining in a comment why PREFIX is reset.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://github.com/leahneukirchen/snooze")
> + (synopsis "Run a command at a particular time")
> + (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")
I would remove "new" from the description.
Otherwise, LGTM. Could you send an updated patch?
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Wed, 13 Oct 2021 19:29:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Wed, 13 Oct 2021 21:31:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 51113 <at> debbugs.gnu.org (full text, mbox):
Hi Nicolas, thanks for reviewing the patch.
Here's a new patch with your suggestions.
* gnu/packages/suckless.scm (snooze): New variable.
---
gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..d207a2300b 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -873,6 +873,39 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the
chat output in the background.")
(license license:isc))))
+(define-public snooze
+ (package
+ (name "snooze")
+ (version "0.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/leahneukirchen/snooze")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; There are no tests.
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "DESTDIR=" %output)
+ ;; Set prefix path to root of package path in store instead
+ ;; of /usr/local.
+ (string-append "PREFIX=" %output))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/leahneukirchen/snooze")
+ (synopsis "Run a command at a particular time")
+ (description
+"@command{snooze} is a tool for waiting until a particular time and then
+running a command.")
+ (license license:cc0)))
+
(define-public scron
(package
(name "scron")
--
2.33.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Tue, 19 Oct 2021 06:17:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 51113 <at> debbugs.gnu.org (full text, mbox):
On Wed, 13 Oct 2021 21:28:48 +0200 Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> Hello,
>
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
>
> > * gnu/packages/suckless.scm (snooze): New variable.
>
> Thank you. Some comments follow.
>
> > + (arguments
> > + `(#:tests? #f
>
> Could you add a comment explaining why tests are disabled? I assume
> upstream does not provide any.
>
> > + #:make-flags
> > + (list (string-append "CC=" ,(cc-for-target))
> > + (string-append "DESTDIR=" %output)
> > + "PREFIX=")
>
> It may be worth explaining in a comment why PREFIX is reset.
>
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'configure))))
> > + (home-page "https://github.com/leahneukirchen/snooze")
> > + (synopsis "Run a command at a particular time")
> > + (description
> > +"@command{snooze} is a new tool for waiting until a particular time and then
> > +running a command.")
>
> I would remove "new" from the description.
>
> Otherwise, LGTM. Could you send an updated patch?
Hi Nicolas,
I forgot to CC you.
The updated patch is above. Thank you for taking the time to review the patch.
all best,
jgart
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
:
You have taken responsibility.
(Thu, 21 Oct 2021 22:14:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
jgart <jgart <at> dismail.de>
:
bug acknowledged by developer.
(Thu, 21 Oct 2021 22:14:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 51113-done <at> debbugs.gnu.org (full text, mbox):
Hello,
jgart <jgart <at> dismail.de> writes:
> Hi Nicolas, thanks for reviewing the patch.
>
> Here's a new patch with your suggestions.
>
> * gnu/packages/suckless.scm (snooze): New variable.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Tue, 26 Oct 2021 22:29:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 51113 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Christopher, jgart, Nicolas,
Christopher Howard 写道:
> the path to the binary is malformed:
Indeed it was.
DESTDIR does not mean ‘final destination’; it's meant as a
temporary install-time ‘staging’ directory whose contents are
expected to move back to / later. For example, ‘make install
DESTDIR=/tmp/my-package-manager-output && cd
/tmp/my-package-manager-output && tar cf foo.pkg .’. Guix does
not use this packaging method.
Setting DESTDIR in Guix is almost always a bug. The few places in
Guix where it is used are using it as a hack around buggy build
systems. It just happens to work (because, well, the build
system's buggy).
When reviewing patches, I find the ‘tree’ command very useful to
immediately spot such weirdness. Much more so than ‘ls -R’.
YMMV.
Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add.
Thanks!
T G-R
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51113
; Package
guix-patches
.
(Wed, 27 Oct 2021 00:04:02 GMT)
Full text and
rfc822 format available.
Message #28 received at 51113 <at> debbugs.gnu.org (full text, mbox):
On Wed, 27 Oct 2021 00:13:47 +0200 Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
> Christopher, jgart, Nicolas,
>
> Christopher Howard 写道:
> > the path to the binary is malformed:
>
> Indeed it was.
>
> DESTDIR does not mean ‘final destination’; it's meant as a
> temporary install-time ‘staging’ directory whose contents are
> expected to move back to / later. For example, ‘make install
> DESTDIR=/tmp/my-package-manager-output && cd
> /tmp/my-package-manager-output && tar cf foo.pkg .’. Guix does
> not use this packaging method.
>
> Setting DESTDIR in Guix is almost always a bug. The few places in
> Guix where it is used are using it as a hack around buggy build
> systems. It just happens to work (because, well, the build
> system's buggy).
>
> Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add.
>
> Thanks!
>
> T G-R
> When reviewing patches, I find the ‘tree’ command very useful to
> immediately spot such weirdness. Much more so than ‘ls -R’.
> YMMV.
I use nnn or another file manager like broot sometimes but this one escaped me.
Thanks for fixing that. I was actually going to send a patch fix for it but had
not found the time. I noticed it after the patch was accepted.
Thanks!
all best,
jgart
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 24 Nov 2021 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 125 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.