GNU bug report logs - #51120
[PATCH] gnu: emacs-org-roam: Reference dot with absolute path.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51120 in the body.
You can then email your comments to 51120 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: emacs-org-roam: Reference dot with absolute path.
Date: Mon, 11 Oct 2021 00:47:12 +0530

* gnu/packages/emacs-xyz.scm (emacs-org-roam)[inputs]: Add graphviz.
[arguments]: Add patch-exec-paths phase substituting absolute store path to
dot.
---
 gnu/packages/emacs-xyz.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 582cfe4552..b12f861376 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -153,6 +153,7 @@
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages graphviz)
   #:use-module (gnu packages haskell-apps)
   #:use-module (gnu packages ibus)
   #:use-module (gnu packages java)
@@ -28370,6 +28371,13 @@ snippets for Emacs.")
                            (rename-file f (basename f)))
                          el-files))
              #t))
+         (add-after 'move-source-files 'patch-exec-paths
+           (lambda* (#:key inputs #:allow-other-keys)
+             (make-file-writable "org-roam-graph.el")
+             (emacs-substitute-variables "org-roam-graph.el"
+               ("org-roam-graph-executable"
+                (string-append (assoc-ref inputs "graphviz")
+                               "/bin/dot")))))
          (add-after 'install 'install-image
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
@@ -28382,6 +28390,8 @@ snippets for Emacs.")
                  (invoke "makeinfo" "-o" "org-roam.info" "org-roam.texi")
                  (install-file "org-roam.info"
                                (string-append out "/share/info")))))))))
+       (inputs
+        `(("graphviz" ,graphviz)))
        (native-inputs
         `(("texinfo" ,texinfo)))
        (propagated-inputs
-- 
2.33.0

Message #8 received at 51120 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 51120 <at> debbugs.gnu.org
Subject: Re: [bug#51120] [PATCH] gnu: emacs-org-roam: Reference dot with
 absolute path.
Date: Wed, 13 Oct 2021 21:29:54 +0200

Hello,

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-roam)[inputs]: Add graphviz.
> [arguments]: Add patch-exec-paths phase substituting absolute store path to
> dot.

LGTM!

Regards,
-- 
Nicolas Goaziou

Message #13 received at 51120-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 51120-done <at> debbugs.gnu.org
Subject: Re: [bug#51120] [PATCH] gnu: emacs-org-roam: Reference dot with
 absolute path.
Date: Sat, 16 Oct 2021 03:00:38 +0530

[Message part 1 (text/plain, inline)]

Thanks, Nicolas! I've pushed this to master.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.