GNU bug report logs - #51139
29.0.50; MH-E and edmacro byte-compile warnings in nox builds

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Mon, 11 Oct 2021 21:18:01 UTC

Severity: minor

Tags: patch

Found in versions 29.0.50, 28.0.60

Fixed in version 29.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51139 in the body.
You can then email your comments to 51139 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to daveg <at> synaptics.com, wohler <at> newt.com, bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Mon, 11 Oct 2021 21:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Basil L. Contovounesios" <contovob <at> tcd.ie>:
New bug report received and forwarded. Copy sent to daveg <at> synaptics.com, wohler <at> newt.com, bug-gnu-emacs <at> gnu.org. (Mon, 11 Oct 2021 21:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
Date: Mon, 11 Oct 2021 22:17:19 +0100
[Message part 1 (text/plain, inline)]
Severity: minor
Tags: patch

I see the following byte-compilation warnings in --without-x builds:

--8<---------------cut here---------------start------------->8---
In edmacro-fix-menu-commands:
edmacro.el:622:34: Warning: reference to free variable
    ‘mouse-wheel-down-event’
edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’
edmacro.el:623:34: Warning: reference to free variable
    ‘mouse-wheel-right-event’
edmacro.el:624:34: Warning: reference to free variable
    ‘mouse-wheel-left-event’

In end of data:
mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not
    known to be defined.
mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is
    not known to be defined.
In mh-logo-display:
mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-folder-buttons-init:
mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-letter-buttons-init:
mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path'
In end of data:
mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’
    is not known to be defined.
In end of data:
mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’
    is not known to be defined.
--8<---------------cut here---------------end--------------->8---

The MH-E warnings are seen on master, whereas the edmacro ones are also
on emacs-28 (details of both configurations follow my signature).

I assume the warnings are not important enough to install anything on
emacs-28, so I attach a patch against master for both sets of warnings.
WDYT?

Thanks,

-- 
Basil

[0001-Fix-byte-compilation-warnings-in-nox-builds.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2021-10-11 built on tia
Repository revision: 2810fe6bfca182e4376d818b5510507d5ff7e1b5
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-nox
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=no --without-x'

Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm gv subr-x
byte-opt bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)

In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu)
 of 2021-10-11 built on tia
Repository revision: b3d0f53b296a0876ec7a55ae840868e65ed54e14
Repository branch: emacs-28
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-28-nox
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=no --without-x'

Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv
bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)

bug Marked as found in versions 28.0.60. Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Mon, 11 Oct 2021 21:26:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Mon, 11 Oct 2021 21:50:02 GMT) Full text and rfc822 format available.

Message #10 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 51139 <at> debbugs.gnu.org
Cc: Dave Gillespie <daveg <at> synaptics.com>, Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in
 nox builds
Date: Mon, 11 Oct 2021 22:49:24 +0100
[Message part 1 (text/plain, inline)]
Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:

> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?

Heh, no sooner had I submitted the patch than it already had conflicts
against master after the following change:

Remove redundant calls to 'mh-do-in-gnu-emacs'
76d75df8e7 2021-10-11 22:57:43 +0200
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=76d75df8e7

So I've respun it in the attached.

-- 
Basil

[0001-Fix-byte-compilation-warnings-in-nox-builds.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 00:22:01 GMT) Full text and rfc822 format available.

Message #13 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 51139 <at> debbugs.gnu.org, Dave Gillespie <daveg <at> synaptics.com>,
 Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50;
 MH-E and edmacro byte-compile warnings in nox builds
Date: Mon, 11 Oct 2021 17:21:36 -0700
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:
>
>> I assume the warnings are not important enough to install anything on
>> emacs-28, so I attach a patch against master for both sets of warnings.
>> WDYT?

I guess warnings are indeed not important enough for emacs-28,
especially if they only affect nox builds.  But I'll leave that to the
maintainers to decide.

> Heh, no sooner had I submitted the patch than it already had conflicts
> against master after the following change:

I only hope you don't need to re-spin it again after my most recent
push...

> So I've respun it in the attached.

Thanks, LGTM, but maybe someone else wants to take a look as well.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 12:42:02 GMT) Full text and rfc822 format available.

Message #16 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51139 <at> debbugs.gnu.org, Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in
 nox builds
Date: Tue, 12 Oct 2021 13:41:11 +0100
Stefan Kangas [2021-10-11 17:21 -0700] wrote:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Heh, no sooner had I submitted the patch than it already had conflicts
>> against master after the following change:
>
> I only hope you don't need to re-spin it again after my most recent
> push...

Where would the fun in that be ;).  The patch still applies cleanly at
the time of writing.

It looks like your changes have dropped support for old Emacs versions,
though, meaning I can safely incorporate bound-and-true-p in the patch.

>> So I've respun it in the attached.
>
> Thanks, LGTM, but maybe someone else wants to take a look as well.

Thanks, I'll give this a bit more time to ferment (and foment) before
pushing.

-- 
Basil




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 12:47:01 GMT) Full text and rfc822 format available.

Message #19 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 51139 <at> debbugs.gnu.org, Dave Gillespie <daveg <at> synaptics.com>,
 Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in
 nox builds
Date: Tue, 12 Oct 2021 14:46:11 +0200
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?

Looks good to me (but in master).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 13:07:01 GMT) Full text and rfc822 format available.

Message #22 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 51139 <at> debbugs.gnu.org, daveg <at> synaptics.com, wohler <at> newt.com
Subject: Re: bug#51139: 29.0.50;
 MH-E and edmacro byte-compile warnings in nox builds
Date: Tue, 12 Oct 2021 16:06:08 +0300
> Cc: Dave Gillespie <daveg <at> synaptics.com>, Bill Wohler <wohler <at> newt.com>
> Date: Mon, 11 Oct 2021 22:17:19 +0100
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I see the following byte-compilation warnings in --without-x builds:
> 
> --8<---------------cut here---------------start------------->8---
> In edmacro-fix-menu-commands:
> edmacro.el:622:34: Warning: reference to free variable
>     ‘mouse-wheel-down-event’
> edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’
> edmacro.el:623:34: Warning: reference to free variable
>     ‘mouse-wheel-right-event’
> edmacro.el:624:34: Warning: reference to free variable
>     ‘mouse-wheel-left-event’
> 
> In end of data:
> mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not
>     known to be defined.
> mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is
>     not known to be defined.
> In mh-logo-display:
> mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path'
> In mh-tool-bar-folder-buttons-init:
> mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path'
> In mh-tool-bar-letter-buttons-init:
> mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path'
> In end of data:
> mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’
>     is not known to be defined.
> In end of data:
> mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’
>     is not known to be defined.
> --8<---------------cut here---------------end--------------->8---
> 
> The MH-E warnings are seen on master, whereas the edmacro ones are also
> on emacs-28 (details of both configurations follow my signature).
> 
> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?

It's okay to install trivial changes on emacs-28 to shut up those
warnings.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 16:00:03 GMT) Full text and rfc822 format available.

Message #25 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 51139 <at> debbugs.gnu.org, Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50;
 MH-E and edmacro byte-compile warnings in nox builds
Date: Tue, 12 Oct 2021 08:59:02 -0700
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> It looks like your changes have dropped support for old Emacs versions,
> though, meaning I can safely incorporate bound-and-true-p in the patch.

Yup, MH-E is no longer distributed separately from Emacs according to:

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51056#14




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Tue, 12 Oct 2021 21:52:02 GMT) Full text and rfc822 format available.

Message #28 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51139 <at> debbugs.gnu.org, Dave Gillespie <daveg <at> synaptics.com>,
 Bill Wohler <wohler <at> newt.com>
Subject: Re: bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in
 nox builds
Date: Tue, 12 Oct 2021 22:51:28 +0100
close 51139 29.1
quit

Lars Ingebrigtsen [2021-10-12 14:46 +0200] wrote:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> I assume the warnings are not important enough to install anything on
>> emacs-28, so I attach a patch against master for both sets of warnings.
>> WDYT?
>
> Looks good to me (but in master).

Thanks, done.

Fix byte-compilation warnings in nox builds
bcb43fbc95 2021-10-12 22:32:03 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bcb43fbc95

-- 
Basil




bug marked as fixed in version 29.1, send any further explanations to 51139 <at> debbugs.gnu.org and "Basil L. Contovounesios" <contovob <at> tcd.ie> Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Tue, 12 Oct 2021 21:52:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51139; Package emacs. (Sun, 24 Oct 2021 22:58:01 GMT) Full text and rfc822 format available.

Message #33 received at 51139 <at> debbugs.gnu.org (full text, mbox):

From: Bill Wohler <wohler <at> newt.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 51139 <at> debbugs.gnu.org,
 Dave Gillespie <daveg <at> synaptics.com>
Subject: Re: bug#51139: 29.0.50;
 MH-E and edmacro byte-compile warnings in nox builds
Date: Sun, 24 Oct 2021 15:57:37 -0700
Stefan Kangas <stefan <at> marxist.se> wrote:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
> 
> > Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:
> >
> >> I assume the warnings are not important enough to install anything on
> >> emacs-28, so I attach a patch against master for both sets of warnings.
> >> WDYT?
> 
> I guess warnings are indeed not important enough for emacs-28,
> especially if they only affect nox builds.  But I'll leave that to the
> maintainers to decide.
> 
> > Heh, no sooner had I submitted the patch than it already had conflicts
> > against master after the following change:
> 
> I only hope you don't need to re-spin it again after my most recent
> push...
> 
> > So I've respun it in the attached.
> 
> Thanks, LGTM, but maybe someone else wants to take a look as well.

LGTM too, and so far MH-E on master is still working... Thanks all!

-- 
Bill Wohler <wohler <at> newt.com> aka <Bill.Wohler <at> nasa.gov>
http://www.newt.com/wohler/, GnuPG ID:610BD9AD




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 22 Nov 2021 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 127 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.