GNU bug report logs - #51226
29.0.50; `align' doc string is unclear

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51226 in the body.
You can then email your comments to 51226 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; `align' doc string is unclear
Date: Fri, 15 Oct 2021 12:04:01 +0200

`align' doesn't mention the prefix arg in the doc string, but in certain
modes, different alignment rules are picked based on what prefix you
give to the command.  For instance, text mode:

    ;; With a numeric prefix argument, or C-u, space delimited text
    ;; tables will be aligned.
    (text-column
     (regexp   . "\\(^\\|\\S-\\)\\([ \t]+\\)\\(\\S-\\|$\\)")
     (group    . 2)
     (modes    . align-text-modes)
     (repeat   . t)
     (run-if   . ,(lambda ()
                    (and current-prefix-arg
                         (not (eq '- current-prefix-arg))))))

    ;; With a negative prefix argument, lists of dollar figures will
    ;; be aligned.
    (text-dollar-figure
     (regexp   . "\\$?\\(\\s-+[0-9]+\\)\\.")
     (modes    . align-text-modes)
     (justify  . t)
     (run-if   . ,(lambda ()
                    (eq '- current-prefix-arg))))

It's also not clear why `M-x align' in text modes do nothing -- you
have to give it a prefix to make it do anything.




-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #8 received at 51226 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, John Wiegley <johnw <at> gnu.org>
Cc: 51226 <at> debbugs.gnu.org
Subject: Re: bug#51226: 29.0.50; `align' doc string is unclear
Date: Fri, 15 Oct 2021 14:00:07 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Fri, 15 Oct 2021 12:04:01 +0200
> 
> 
> `align' doesn't mention the prefix arg in the doc string, but in certain
> modes, different alignment rules are picked based on what prefix you
> give to the command.  For instance, text mode:
> 
>     ;; With a numeric prefix argument, or C-u, space delimited text
>     ;; tables will be aligned.
>     (text-column
>      (regexp   . "\\(^\\|\\S-\\)\\([ \t]+\\)\\(\\S-\\|$\\)")
>      (group    . 2)
>      (modes    . align-text-modes)
>      (repeat   . t)
>      (run-if   . ,(lambda ()
>                     (and current-prefix-arg
>                          (not (eq '- current-prefix-arg))))))
> 
>     ;; With a negative prefix argument, lists of dollar figures will
>     ;; be aligned.
>     (text-dollar-figure
>      (regexp   . "\\$?\\(\\s-+[0-9]+\\)\\.")
>      (modes    . align-text-modes)
>      (justify  . t)
>      (run-if   . ,(lambda ()
>                     (eq '- current-prefix-arg))))
> 
> It's also not clear why `M-x align' in text modes do nothing -- you
> have to give it a prefix to make it do anything.

John, could you help us out here by explaining this stuff?

Message #11 received at 51226 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: John Wiegley <johnw <at> gnu.org>, 51226 <at> debbugs.gnu.org
Subject: Re: bug#51226: 29.0.50; `align' doc string is unclear
Date: Tue, 19 Oct 2021 22:39:50 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> It's also not clear why `M-x align' in text modes do nothing -- you
>> have to give it a prefix to make it do anything.
>
> John, could you help us out here by explaining this stuff?

I've now clarified this in the doc string (i.e., that `C-u' has an
effect), and I've also made `M-x align' (without a prefix) actually do
something in text-mode.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.