X-Loop: help-debbugs@HIDDEN Subject: bug#51235: resolve old FIXME in PCRE implementation to allow more than 1 expression Resent-From: Carlo Arenas <carenas@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-grep@HIDDEN Resent-Date: Sat, 16 Oct 2021 07:29:01 +0000 Resent-Message-ID: <handler.51235.B.163436931216509 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 51235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: 51235 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-grep@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.163436931216509 (code B ref -1); Sat, 16 Oct 2021 07:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Oct 2021 07:28:32 +0000 Received: from localhost ([127.0.0.1]:40870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mbe7L-0004I8-Jq for submit <at> debbugs.gnu.org; Sat, 16 Oct 2021 03:28:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:45652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <carenas@HIDDEN>) id 1mbdgC-0003c3-Ms for submit <at> debbugs.gnu.org; Sat, 16 Oct 2021 03:00:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <carenas@HIDDEN>) id 1mbdgC-0005ip-Cl for bug-grep@HIDDEN; Sat, 16 Oct 2021 03:00:28 -0400 Received: from mail-ua1-x932.google.com ([2607:f8b0:4864:20::932]:44900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <carenas@HIDDEN>) id 1mbdg9-0007VR-6U for bug-grep@HIDDEN; Sat, 16 Oct 2021 03:00:27 -0400 Received: by mail-ua1-x932.google.com with SMTP id r22so11552110uat.11 for <bug-grep@HIDDEN>; Sat, 16 Oct 2021 00:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=eRehyyP6uBKg6k9gHXl0wxw3ZsgU/7MJ6KYkdUiVFaI=; b=Vfvzj6zAzY0oeKd2vNrCprELOxqQAmrjd3NVK9k4HwuOexZCA0b5MLGfHmTmBQG6Gc L6Yy7MCH3hcswMC94sZi/AmKTobrEVRpsUSii9WA0243ZFn1tpw6E1psen7RVKK0CAUF ooLUX3vGPYMI5MyPzRXtzkXHOzeEnXJfDbD71iSYTbjromhZsAtXzwi3qKo/ZWurao7j n6Cripxd+Sxqe6YDF6BSNjto9nrCNdLcKZ2RvUtue7HJSbPXSUIuSFUYHyqKqv8TJ7e+ Efnzsidk64QdEN7leoJytRaqA8Z75xbaSzFF+OOcSyNf2+5ZlFmyLsNnBFdQ6hKZcIy6 2KQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=eRehyyP6uBKg6k9gHXl0wxw3ZsgU/7MJ6KYkdUiVFaI=; b=paxVj2PPG08JrSah7hBnQtbOwOlu8MuHw5BCGcvq1PhVcY7FksToNpgsEqxbl88lmo /O+8Ot4zkxV4aLNZqAIqykkWMS/k1N2H/CjdMq3+T3fOBwrsVL5dPBn/N4F7ruLRxn8H WvVwHSncJpgg7CvWBLpEU7DUcz7LC8iaovw2yEEb/59GmYp2hWS6oUwiaPjIKe6U+pQg /FRfvc0p0poNGTsHSyGPNwoKbJzxZykQbTtnSLNNHmEk8jTb73sQZWp7n39UYnOnWms0 Tj+buayxuCfPcUAqMZITdY31crVOzqu5XpmTDEtZalnXYhM5ME5xti0RxA4N07vTCblV Pomw== X-Gm-Message-State: AOAM530+0OsqvylXqA8OKFFoJJQqYEouKA5bcYNT83Vl5iq6CB+qJzVN lF/vF3mxI5TlqiBbDWcGwWW8YbJlDA35cUbRXedKzYzw/nY= X-Google-Smtp-Source: ABdhPJxNg/8zC1N/BomhbDeXNKa+qhakxr59xypOZC5vp2unIiryliDF2ilw3jKoAyvumyFTy99siYjVDYJ9q9acvLE= X-Received: by 2002:ab0:1447:: with SMTP id c7mr16770303uae.2.1634367623645; Sat, 16 Oct 2021 00:00:23 -0700 (PDT) MIME-Version: 1.0 From: Carlo Arenas <carenas@HIDDEN> Date: Sat, 16 Oct 2021 00:00:12 -0700 Message-ID: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000a3e1db05ce72dd9b" Received-SPF: pass client-ip=2607:f8b0:4864:20::932; envelope-from=carenas@HIDDEN; helo=mail-ua1-x932.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Sat, 16 Oct 2021 03:28:30 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --000000000000a3e1db05ce72dd9b Content-Type: text/plain; charset="UTF-8" With this patch, multiple expressions (from -e or -f) are now acceptable with -P for easier side by side comparison with the other supported engines. Alternatively, multiple expressions could be compiled and run sequentially for matching, but I suspect the added compilation time is likely higher, and JIT might be able to run the alteration fast enough for most cases. Hopefully this tiny change is better than the status quo, though. Carlo --000000000000a3e1db05ce72dd9b Content-Type: application/octet-stream; name="0001-pcre-allow-more-than-1-regular-expression.patch" Content-Disposition: attachment; filename="0001-pcre-allow-more-than-1-regular-expression.patch" Content-Transfer-Encoding: base64 Content-ID: <f_kutg9loj0> X-Attachment-Id: f_kutg9loj0 RnJvbSA4YWI1MmNjMWIwYzkzNDE4YjE0M2M1MWY3OTJiMTQ3MDI4OTE5OGRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Q2FybG89MjBNYXJjZWxvPTIwQXJlbmFzPTIw QmVsPUMzPUIzbj89IDxjYXJlbmFzQGdtYWlsLmNvbT4KRGF0ZTogRnJpLCAxNSBPY3QgMjAyMSAy Mzo0NDo0NiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHBjcmU6IGFsbG93IG1vcmUgdGhhbiAxIHJl Z3VsYXIgZXhwcmVzc2lvbgpNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxh aW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQXMgc2hv d24gaW4gdGhlIEZJWE1FIHRoYXQgd2FzIGluY2x1ZGVkIHdpdGggdGhlIGZpcnN0IHZlcnNpb24g b2YKdGhlIGNvZGU7IGdyZXAgd2lsbCBkaWUgaWYgbW9yZSB0aGFuIG9uZSAtZSBvcHRpb24gd2Fz IHVzZWQuCgpNYWtlIHRoZSBtaW5pbWFsIGNoYW5nZSBwb3NzaWJsZSwgdG8gY29udmVydCB0aGUg cGF0dGVybiBzY3JpcHQKaW50byBhbiBhbHRlcm5hdGlvbiwgYW5kIHRoaXMgd2F5IHJlbW92ZSB0 aGUgcmVzdHJpY3Rpb24uCgpTaWduZWQtb2ZmLWJ5OiBDYXJsbyBNYXJjZWxvIEFyZW5hcyBCZWzD s24gPGNhcmVuYXNAZ21haWwuY29tPgotLS0KIHNyYy9wY3Jlc2VhcmNoLmMgfCA4ICsrKystLS0t CiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3NyYy9wY3Jlc2VhcmNoLmMgYi9zcmMvcGNyZXNlYXJjaC5jCmluZGV4IDNiZGFlZTku LjI5NWQ2MDUgMTAwNjQ0Ci0tLSBhL3NyYy9wY3Jlc2VhcmNoLmMKKysrIGIvc3JjL3BjcmVzZWFy Y2guYwpAQCAtMTI2LDcgKzEyNiw3IEBAIFBjb21waWxlIChjaGFyICpwYXR0ZXJuLCBpZHhfdCBz aXplLCByZWdfc3ludGF4X3QgaWdub3JlZCwgYm9vbCBleGFjdCkKICAgY2hhciAqcmUgPSB4bm1h bGxvYyAoNCwgc2l6ZSArIChmaXhfbGVuX21heCArIDQgLSAxKSAvIDQpOwogICBpbnQgZmxhZ3Mg PSBQQ1JFX0RPTExBUl9FTkRPTkxZIHwgKG1hdGNoX2ljYXNlID8gUENSRV9DQVNFTEVTUyA6IDAp OwogICBjaGFyICpwYXRsaW0gPSBwYXR0ZXJuICsgc2l6ZTsKLSAgY2hhciAqbiA9IHJlOworICBj aGFyICpuOwogICBjaGFyIGNvbnN0ICpwOwogICBjaGFyIGNvbnN0ICpwbnVsOwogICBzdHJ1Y3Qg cGNyZV9jb21wICpwYyA9IHhjYWxsb2MgKDEsIHNpemVvZiAoKnBjKSk7CkBAIC0xMzgsMTAgKzEz OCwxMCBAQCBQY29tcGlsZSAoY2hhciAqcGF0dGVybiwgaWR4X3Qgc2l6ZSwgcmVnX3N5bnRheF90 IGlnbm9yZWQsIGJvb2wgZXhhY3QpCiAgICAgICBmbGFncyB8PSBQQ1JFX1VURjg7CiAgICAgfQog Ci0gIC8qIEZJWE1FOiBSZW1vdmUgdGhpcyByZXN0cmljdGlvbi4gICovCi0gIGlmIChyYXdtZW1j aHIgKHBhdHRlcm4sICdcbicpICE9IHBhdGxpbSkKLSAgICBkaWUgKEVYSVRfVFJPVUJMRSwgMCwg XygidGhlIC1QIG9wdGlvbiBvbmx5IHN1cHBvcnRzIGEgc2luZ2xlIHBhdHRlcm4iKSk7CisgIGZv ciAobiA9IHBhdHRlcm47IChuID0gcmF3bWVtY2hyIChuLCAnXG4nKSkgPCBwYXRsaW07IG4rKykK KyAgICAqbiA9ICd8JzsKIAorICBuID0gcmU7CiAgICpuID0gJ1wwJzsKICAgaWYgKG1hdGNoX3dv cmRzKQogICAgIHN0cmNweSAobiwgd3ByZWZpeCk7Ci0tIAoyLjMzLjAuMTE1NS5nYmRiNzFhYzA3 OAoK --000000000000a3e1db05ce72dd9b--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Carlo Arenas <carenas@HIDDEN> Subject: bug#51235: Acknowledgement (resolve old FIXME in PCRE implementation to allow more than 1 expression) Message-ID: <handler.51235.B.163436931216509.ack <at> debbugs.gnu.org> References: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> X-Gnu-PR-Message: ack 51235 X-Gnu-PR-Package: grep Reply-To: 51235 <at> debbugs.gnu.org Date: Sat, 16 Oct 2021 07:29:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-grep@HIDDEN If you wish to submit further information on this problem, please send it to 51235 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 51235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51235 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#51235: resolve old FIXME in PCRE implementation to allow more than 1 expression Resent-From: Paul Eggert <eggert@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-grep@HIDDEN Resent-Date: Sat, 16 Oct 2021 07:51:02 +0000 Resent-Message-ID: <handler.51235.B51235.163437061526965 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 51235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Carlo Arenas <carenas@HIDDEN> Cc: 51235 <at> debbugs.gnu.org Received: via spool by 51235-submit <at> debbugs.gnu.org id=B51235.163437061526965 (code B ref 51235); Sat, 16 Oct 2021 07:51:02 +0000 Received: (at 51235) by debbugs.gnu.org; 16 Oct 2021 07:50:15 +0000 Received: from localhost ([127.0.0.1]:40906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mbeSM-00070r-TU for submit <at> debbugs.gnu.org; Sat, 16 Oct 2021 03:50:15 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eggert@HIDDEN>) id 1mbeSL-00070a-AD for 51235 <at> debbugs.gnu.org; Sat, 16 Oct 2021 03:50:13 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 523C11600EA; Sat, 16 Oct 2021 00:50:06 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1-OAsFCobqB4; Sat, 16 Oct 2021 00:50:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B1FB61600FD; Sat, 16 Oct 2021 00:50:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HmU7-K8P-8vz; Sat, 16 Oct 2021 00:50:05 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9057B1600EA; Sat, 16 Oct 2021 00:50:05 -0700 (PDT) References: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> From: Paul Eggert <eggert@HIDDEN> Organization: UCLA Computer Science Department Message-ID: <650a2109-d55f-a903-a14e-57328302330b@HIDDEN> Date: Sat, 16 Oct 2021 00:50:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.4 (---) On 10/16/21 12:00 AM, Carlo Arenas wrote: > With this patch, multiple expressions (from -e or -f) are now > acceptable with -P for easier side by side comparison with the other > supported engines. Surely this mishandles shell commands like this one: grep -P '[ a]' which should be an error, but with that patch would not be an error.
X-Loop: help-debbugs@HIDDEN Subject: bug#51235: resolve old FIXME in PCRE implementation to allow more than 1 expression Resent-From: Carlo Arenas <carenas@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-grep@HIDDEN Resent-Date: Sat, 16 Oct 2021 16:16:01 +0000 Resent-Message-ID: <handler.51235.B51235.163440094428784 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 51235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Paul Eggert <eggert@HIDDEN> Cc: 51235 <at> debbugs.gnu.org Received: via spool by 51235-submit <at> debbugs.gnu.org id=B51235.163440094428784 (code B ref 51235); Sat, 16 Oct 2021 16:16:01 +0000 Received: (at 51235) by debbugs.gnu.org; 16 Oct 2021 16:15:44 +0000 Received: from localhost ([127.0.0.1]:42874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mbmLX-0007UA-3T for submit <at> debbugs.gnu.org; Sat, 16 Oct 2021 12:15:43 -0400 Received: from mail-ua1-f51.google.com ([209.85.222.51]:44634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <carenas@HIDDEN>) id 1mbfWg-0000EB-4r for 51235 <at> debbugs.gnu.org; Sat, 16 Oct 2021 04:58:47 -0400 Received: by mail-ua1-f51.google.com with SMTP id r22so11862437uat.11 for <51235 <at> debbugs.gnu.org>; Sat, 16 Oct 2021 01:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FIOmhFRn5Fp3QbpM3Zx1P/jOUIMe3PTWTys6sOsgvZM=; b=LoNis5d6q5GzjH2NsrginmGGq3/ns1ZwDhapP1t7qyN8LGSyj3MPe5g1ppks/f1ZaZ jYNPu4dRXPtuNFt56p3IYPIE5MNxVvCeA2kSrZnPLF98UNujaOGUTHpTixt6Dy39aizB Wvz0mIbskFv7UBzizQd9mq05O+k6DnnsP0wS0GHK6TDMYrdpW6KmnEgtzrMuVHQDprJ1 3dx9dgiS1aPaHByCoIKEE624cWysCYpIG2AepvqQ/mqOCMRJFKLiieY71C41n3A07fuU CoC2IKkh9QzGXjbTlyrZ2ZGTjIfYNQYg5Wab6AdXQLY16vbCrEEAKEVVCt1nm3YPtUIu 9+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FIOmhFRn5Fp3QbpM3Zx1P/jOUIMe3PTWTys6sOsgvZM=; b=66JPw2wJ7B/oY2T6rBrbOZcNBVLrTTT30Azw8YY+oIUFfOz+esz9LZGRXCpiObnufN s+oFkjxqqvYBu6PSxbTLFRIl4jRCFBmEYZ4Hm+94uT449o86dclQSebQTBeerQDX2kXo qBwCr0ha3msCrOdyP11dJdaaBeKbAeCSX2r7FYAN8KHizUBnC+YpG527qtiq6L2xlME8 7FuNIAsaRXXSBIdIHxcO4KsbdEA00zwve2g2TdreMo8iQO5+zuOyp+b7w4+XNE1qAdsW At3JV8O1h6cgoaaDXhL7w9PHb+dRvN/LOG/AgoHIkZnxZkfXBn8XxeT6V+nFLxOzsnYP ssLw== X-Gm-Message-State: AOAM533SAIbBX1KpnnDx00Ih6HnExek1BqBhLymc+BiiHOY/DejeCdHG ekdfCcDVcJQ7Vk4ApH3hHWi0DKUxrtpaZ7VzjUMfVUyZpgEO1Q== X-Google-Smtp-Source: ABdhPJzkOpHq5hYH6/qb9JlUw6/aVbBMSMNpzGRgmz//TUZpG44IAda1RZI14/CjioyPMIi+IJ0X9A+ZxbxohsdSz1A= X-Received: by 2002:a67:fb42:: with SMTP id e2mr17890166vsr.46.1634374720433; Sat, 16 Oct 2021 01:58:40 -0700 (PDT) MIME-Version: 1.0 References: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> <650a2109-d55f-a903-a14e-57328302330b@HIDDEN> In-Reply-To: <650a2109-d55f-a903-a14e-57328302330b@HIDDEN> From: Carlo Arenas <carenas@HIDDEN> Date: Sat, 16 Oct 2021 01:58:29 -0700 Message-ID: <CAPUEspiyrCBEmU8Wbs7p-=u33fV1RjPy7PCmp4=eh8JFkU5fAw@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Sat, 16 Oct 2021 12:15:42 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Oct 16, 2021 at 12:50 AM Paul Eggert <eggert@HIDDEN> wrote: > > On 10/16/21 12:00 AM, Carlo Arenas wrote: > > With this patch, multiple expressions (from -e or -f) are now > > acceptable with -P for easier side by side comparison with the other > > supported engines. > > Surely this mishandles shell commands like this one: > > grep -P '[ > a]' > > which should be an error, but with that patch would not be an error. of course, but ironically without the patch, the error isn't correct either: $ grep -P '[ > a]' grep: the -P option only supports a single pattern I would say that for a 4 line patch with negative byte count, it is worth the trade. But if you feel so strongly against it, doing the one that compiles every line independently and that will catch that problem wouldn't be that difficult, but I would rather do it as a follow up, and is definitely going to be bigger. Carlo
X-Loop: help-debbugs@HIDDEN Subject: bug#51235: resolve old FIXME in PCRE implementation to allow more than 1 expression Resent-From: Paul Eggert <eggert@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-grep@HIDDEN Resent-Date: Sat, 16 Oct 2021 16:47:01 +0000 Resent-Message-ID: <handler.51235.B51235.163440280931700 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 51235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Carlo Arenas <carenas@HIDDEN> Cc: 51235 <at> debbugs.gnu.org Received: via spool by 51235-submit <at> debbugs.gnu.org id=B51235.163440280931700 (code B ref 51235); Sat, 16 Oct 2021 16:47:01 +0000 Received: (at 51235) by debbugs.gnu.org; 16 Oct 2021 16:46:49 +0000 Received: from localhost ([127.0.0.1]:42916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mbmpd-0008FE-3M for submit <at> debbugs.gnu.org; Sat, 16 Oct 2021 12:46:49 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eggert@HIDDEN>) id 1mbmpa-0008Ez-OA for 51235 <at> debbugs.gnu.org; Sat, 16 Oct 2021 12:46:47 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 99D3C160068; Sat, 16 Oct 2021 09:46:40 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 60Mjv1fe-MjX; Sat, 16 Oct 2021 09:46:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E13EF16010F; Sat, 16 Oct 2021 09:46:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id u35yqEnMBbHL; Sat, 16 Oct 2021 09:46:37 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 969F0160068; Sat, 16 Oct 2021 09:46:37 -0700 (PDT) References: <CAPUEspirs17Q8wJ3VR3NgakcK0V=t2VsgOJN1L6cRVTSXR-upw@HIDDEN> <650a2109-d55f-a903-a14e-57328302330b@HIDDEN> <CAPUEspiyrCBEmU8Wbs7p-=u33fV1RjPy7PCmp4=eh8JFkU5fAw@HIDDEN> From: Paul Eggert <eggert@HIDDEN> Organization: UCLA Computer Science Department Message-ID: <22881e0c-4a98-9090-18c9-e96d968b408f@HIDDEN> Date: Sat, 16 Oct 2021 09:46:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <CAPUEspiyrCBEmU8Wbs7p-=u33fV1RjPy7PCmp4=eh8JFkU5fAw@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.4 (---) On 10/16/21 1:58 AM, Carlo Arenas wrote: > without the patch, the error isn't correct either: >=20 > $ grep -P '[ >> a]' > grep: the -P option only supports a single pattern I don't offhand see what's wrong with the diagnostic, as the PATTERNS=20 operand is documented to be one that "contains one or more patterns=20 separated by newlines". > doing the one that compiles > every line independently and that will catch that problem wouldn't be > that difficult, but I would rather do it as a follow up, and is > definitely going to be bigger. Yes, that sounds better. Please keep the followup in this thread. Also,=20 I hope you'd be willing to assign copyright to the FSF as I assume these=20 changes will be nontrivial. I will send you paperwork info about that=20 via separate mail offlist.
Received: (at control) by debbugs.gnu.org; 24 Nov 2021 02:44:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 21:44:02 2021 Received: from localhost ([127.0.0.1]:52631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mpiGQ-0000KX-8A for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:44:02 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eggert@HIDDEN>) id 1mpiGO-0000K5-Ih for control <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:44:00 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 422FC1600BC for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:43:55 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xI7BcqTbRiB5 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:43:54 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A6B2A1600D3 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:43:54 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xTWB_C-1I-wh for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:43:54 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 832D31600BC for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:43:54 -0800 (PST) Message-ID: <68c207b0-df68-4508-5deb-64c1336e3e91@HIDDEN> Date: Tue, 23 Nov 2021 18:43:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: GNU bug control <control <at> debbugs.gnu.org> From: Paul Eggert <eggert@HIDDEN> Subject: 51235 needs more info Organization: UCLA Computer Science Department Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) tags 51235 moreinfo tags 51186 notabug close 51186
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.