GNU logs - #51256, boring messages

Message sent to bug-grep@HIDDEN:

Subject: bug#51256: grep --ignore-case --color does not always color the matches
Resent-From: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-grep@HIDDEN
Resent-Date: Mon, 18 Oct 2021 04:00:03 +0000
Resent-Message-ID: <handler.51256.B.163452957832585 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 51256 <at> debbugs.gnu.org
Cc: 39678 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Date: Mon, 18 Oct 2021 00:02:36 +0200
Message-ID: <CAJkqNs1AV05yqKSbch7rL8YX+=bjbfeUMWOyLN7V87K2U-2oTA@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000aecb8205ce93967e"
Received-SPF: pass client-ip=2607:f8b0:4864:20::936;
 envelope-from=tomasz.dziendzielski@HIDDEN; helo=mail-ua1-x936.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Sun, 17 Oct 2021 23:59:07 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--000000000000aecb8205ce93967e
Content-Type: multipart/alternative; boundary="000000000000aecb7f05ce93967c"

--000000000000aecb7f05ce93967c
Content-Type: text/plain; charset="UTF-8"

Hello,
I did some investigation and it seems the problem with "\a" is not that the
output is not colored but that it's printed at all while it should not be.
It's being printed even when re_search in EGexecute doesn't return a match.
As a result the for loop in print_line_middle is not being run - this means
the "a" output that you see is not from the matched string but from the
rest of the line. To fix this I suggest to return NULL from
print_line_middle if `b` variable equals NULL - which means the loop was
not executed.

I'm sending the patch with the fix in the attachment.

Best regards,
Tomasz Dziendzielski

--000000000000aecb7f05ce93967c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div class=3D"gmail_quote" dir=3D"auto"><div dir=3D"ltr" =
class=3D"gmail_attr">Hello,</div><div dir=3D"ltr" class=3D"gmail_attr">I di=
d some investigation and it seems the problem
 with &quot;\a&quot; is not that the output is not colored but that it&#39;=
s printed=20
at all while it should not be. It&#39;s being printed even when re_search i=
n
 EGexecute  doesn&#39;t return a match. As a result the for loop in=20
print_line_middle is not being run - this means the &quot;a&quot; output th=
at you=20
see is not from the matched string but from the rest of the line. To fix
 this I suggest to return NULL from print_line_middle if `b` variable=20
equals NULL - which means the loop was not executed.</div><div dir=3D"ltr" =
class=3D"gmail_attr"><br></div><div dir=3D"ltr" class=3D"gmail_attr">I&#39;=
m sending the patch with the fix in the attachment.</div><div dir=3D"ltr" c=
lass=3D"gmail_attr"><br></div><div dir=3D"ltr" class=3D"gmail_attr">Best re=
gards,</div><div dir=3D"ltr" class=3D"gmail_attr">Tomasz Dziendzielski</div=
></div></div>

--000000000000aecb7f05ce93967c--

--000000000000aecb8205ce93967e
Content-Type: application/octet-stream; 
	name="0001-grep-Don-t-print-line-if-matcher-returned-nothing.patch"
Content-Disposition: attachment; 
	filename="0001-grep-Don-t-print-line-if-matcher-returned-nothing.patch"
Content-Transfer-Encoding: base64
Content-ID: <17c9046ad63139915c91>
X-Attachment-Id: 17c9046ad63139915c91

RnJvbSAwNzgwNTI1OWI5YmYzZTE2Nzg0N2ExY2Y1MzA4YjZjNTQwMThiNzA5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hc3ogRHppZW5kemllbHNraSA8dG9tYXN6LmR6aWVuZHpp
ZWxza2lAZ21haWwuY29tPgpEYXRlOiBTdW4sIDE3IE9jdCAyMDIxIDIxOjQ3OjI4ICswMjAwClN1
YmplY3Q6IFtQQVRDSF0gZ3JlcDogRG9uJ3QgcHJpbnQgbGluZSBpZiBtYXRjaGVyIHJldHVybmVk
IG5vdGhpbmcKCkl0IGNhbiBoYXBwZW4gdGhhdCByZV9zZWFyY2ggaW4gRUdleGVjdXRlIGZhaWxz
IGFuZCByZXR1cm5zIG5vdGhpbmcgc28KZm9yIGxvb3AgaW4gcHJpbnRfbGluZV9taWRkbGUgcnVu
cyB6ZXJvIHRpbWVzIGJ1dCBzdGlsbCBzdGlsbCByZXR1cm5zCnRyYXNoIHVuZGVyIGBjdXJgIHZh
cmlhYmxlLCBzbyBncmVwIHRoaW5rcyBpdCBtYXRjaGVkIHNvbWV0aGluZyBhbmQgdGhlbgpyZXR1
cm5zIHdob2xlIGxpbmUuCgpGaXhlcyBidWcgMzk2NzguIElzc3VlIHdhcyB0aGF0IHNlY29uZCBv
ZiBiZWxvdyBjb21tYW5kcyBkaWQgbm90IGNvbG9yCnRoZSAiYSIgY2hhcmFjdGVyOgp8IGVjaG8g
YSB8IGdyZXAgLWkgLS1jb2xvciAnXEEnCnwgZWNobyBhIHwgZ3JlcCAtaSAtLWNvbG9yICdcYScK
YnV0IGluIGZhY3QgaXQgc2hvdWxkbid0IGV2ZW4gcHJpbnQgaXQgaW4gdGhlIGZpcnN0IHBsYWNl
LCBzaW5jZSBnbnVsaWIKcmVnZXggZG9lc24ndCBtYXRjaCBpdC4KCiogc3JjL2dyZXAuYzogcHJp
bnRfbGluZV9taWRkbGU6IFJldHVybiBOVUxMIGlmIG1hdGNoIG5vdCBmb3VuZCBhbmQgZm9yCmxv
b3Agbm90IGV4ZWN1dGVkCgpTaWduZWQtb2ZmLWJ5OiBUb21hc3ogRHppZW5kemllbHNraSA8dG9t
YXN6LmR6aWVuZHppZWxza2lAZ21haWwuY29tPgotLS0KIHNyYy9ncmVwLmMgfCA0ICsrKy0KIDEg
ZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg
YS9zcmMvZ3JlcC5jIGIvc3JjL2dyZXAuYwppbmRleCBhNTUxOTRjZjFhYTkwNzJlY2MzN2ExMzU3
NGJjNTg4MTY3ZWU1ZDk0Li5iMzcyZTM0MTVjY2JmNmY4OTYwMzlhNmQ3MmJkNmMzNDk4ZDhjMjY5
IDEwMDY0NAotLS0gYS9zcmMvZ3JlcC5jCisrKyBiL3NyYy9ncmVwLmMKQEAgLTEyMTMsNyArMTIx
Myw3IEBAIHByaW50X2xpbmVfbWlkZGxlIChjaGFyICpiZWcsIGNoYXIgKmxpbSwKICAgcHRyZGlm
Zl90IG1hdGNoX29mZnNldDsKICAgY2hhciAqY3VyOwogICBjaGFyICptaWQgPSBOVUxMOwotICBj
aGFyICpiOworICBjaGFyICpiID0gTlVMTDsKIAogICBmb3IgKGN1ciA9IGJlZzsKICAgICAgICAo
Y3VyIDwgbGltCkBAIC0xMjY5LDYgKzEyNjksOCBAQCBwcmludF9saW5lX21pZGRsZSAoY2hhciAq
YmVnLCBjaGFyICpsaW0sCiAgICAgY3VyID0gbGltOwogICBlbHNlIGlmIChtaWQpCiAgICAgY3Vy
ID0gbWlkOworICBlbHNlIGlmIChiID09IE5VTEwpCisgICAgcmV0dXJuIE5VTEw7CiAKICAgcmV0
dXJuIGN1cjsKIH0KLS0gCjIuMzMuMAoK
--000000000000aecb8205ce93967e--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Subject: bug#51256: Acknowledgement (grep --ignore-case --color does not
 always color the matches)
Message-ID: <handler.51256.B.163452957832585.ack <at> debbugs.gnu.org>
References: <CAJkqNs1AV05yqKSbch7rL8YX+=bjbfeUMWOyLN7V87K2U-2oTA@HIDDEN>
X-Gnu-PR-Message: ack 51256
X-Gnu-PR-Package: grep
Reply-To: 51256 <at> debbugs.gnu.org
Date: Mon, 18 Oct 2021 04:00:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-grep@HIDDEN

If you wish to submit further information on this problem, please
send it to 51256 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
51256: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51256
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Nov 2021 02:49:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 21:49:03 2021
Received: from localhost ([127.0.0.1]:52646 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpiLH-0002hz-0A
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:49:03 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59122)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1mpiLF-0002hT-GB
 for control <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:49:01 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3266C1600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:56 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id mHZgbilLoN65 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 95E731600D3
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id SdIurAsfsNu2 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6AFE21600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Message-ID: <b3d30ec8-2d59-5270-539c-58128517095f@HIDDEN>
Date: Tue, 23 Nov 2021 18:48:55 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Content-Language: en-US
To: GNU bug control <control <at> debbugs.gnu.org>
From: Paul Eggert <eggert@HIDDEN>
Subject: merge Tomasz Dziendzielski bug report
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 51255 51256 51257

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Nov 2021 02:51:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 21:51:49 2021
Received: from localhost ([127.0.0.1]:52657 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpiNx-0002nD-I3
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:51:49 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1mpiNu-0002mw-Gi
 for control <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:51:47 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 141971600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:41 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id hx6hSX0lQO07 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 76CB41600D3
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id o-YwJATAgPit for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4775D1600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Message-ID: <b26198b9-df76-ab71-b8c8-d9adfd47b5ca@HIDDEN>
Date: Tue, 23 Nov 2021 18:51:39 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Content-Language: en-US
To: GNU bug control <control <at> debbugs.gnu.org>
From: Paul Eggert <eggert@HIDDEN>
Subject: more grep bug merging
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 39678 51257

Last modified: Wed, 24 Nov 2021 03:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.