GNU logs - #51257, boring messages

Message sent to bug-grep@HIDDEN:

Subject: bug#51257: grep --ignore-case --color does not always color the matches
Resent-From: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-grep@HIDDEN
Resent-Date: Mon, 18 Oct 2021 04:00:03 +0000
Resent-Message-ID: <handler.51257.B.163452958632620 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 51257 <at> debbugs.gnu.org
Cc: 39678 <at> debbugs.gnu.org
Content-Type: multipart/mixed; boundary="------------77RGBoYuUJoxVSEgbyGMIsAF"
Message-ID: <c4eab445-486e-7f5c-dc4f-91ede51156ce@HIDDEN>
Date: Mon, 18 Oct 2021 00:26:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Content-Language: en-US
From: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Received-SPF: pass client-ip=2a00:1450:4864:20::129;
 envelope-from=tomasz.dziendzielski@HIDDEN; helo=mail-lf1-x129.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Sun, 17 Oct 2021 23:59:07 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

This is a multi-part message in MIME format.
--------------77RGBoYuUJoxVSEgbyGMIsAF
Content-Type: multipart/alternative;
 boundary="------------bMg9yKCcp6UtuX6QbFlW0Aew"

--------------bMg9yKCcp6UtuX6QbFlW0Aew
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,
I did some investigation and it seems the problem with '\a' is not that the output is not colored but that it's printed at all while it should not be. It's being printed even when re_search in EGexecute doesn't return a match. As a result the for loop in print_line_middle is not being run - this means the 'a' output that you see is not from the matched string but from the rest of the line. To fix this I suggest to return NULL from print_line_middle if 'b' variable equals NULL - which means the loop was not executed.

I'm sending the patch with the fix in the attachment.

Best regards,
Tomasz Dziendzielski
--------------bMg9yKCcp6UtuX6QbFlW0Aew
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div dir="auto">
      <div class="gmail_quote" dir="auto">
        <div dir="ltr" class="gmail_attr">Hello,</div>
        <div dir="ltr" class="gmail_attr">I did some investigation and
          it seems the problem with '\a' is not that the output is not
          colored but that it's printed at all while it should not be.
          It's being printed even when re_search in EGexecute doesn't
          return a match. As a result the for loop in print_line_middle
          is not being run - this means the 'a' output that you see is
          not from the matched string but from the rest of the line. To
          fix this I suggest to return NULL from print_line_middle if
          'b' variable equals NULL - which means the loop was not
          executed.</div>
        <div dir="ltr" class="gmail_attr"><br>
        </div>
        <div dir="ltr" class="gmail_attr">I'm sending the patch with the
          fix in the attachment.</div>
        <div dir="ltr" class="gmail_attr"><br>
        </div>
        <div dir="ltr" class="gmail_attr">Best regards,</div>
        <div dir="ltr" class="gmail_attr">Tomasz Dziendzielski</div>
      </div>
    </div>
  </body>
</html>
--------------bMg9yKCcp6UtuX6QbFlW0Aew--

--------------77RGBoYuUJoxVSEgbyGMIsAF
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-grep-Don-t-print-line-if-matcher-returned-nothing.patch"
Content-Disposition: attachment;
 filename*0="0001-grep-Don-t-print-line-if-matcher-returned-nothing.patch"
Content-Transfer-Encoding: base64

RnJvbSAwNzgwNTI1OWI5YmYzZTE2Nzg0N2ExY2Y1MzA4YjZjNTQwMThiNzA5IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hc3ogRHppZW5kemllbHNraSA8dG9tYXN6LmR6
aWVuZHppZWxza2lAZ21haWwuY29tPgpEYXRlOiBTdW4sIDE3IE9jdCAyMDIxIDIxOjQ3OjI4
ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ3JlcDogRG9uJ3QgcHJpbnQgbGluZSBpZiBtYXRj
aGVyIHJldHVybmVkIG5vdGhpbmcKCkl0IGNhbiBoYXBwZW4gdGhhdCByZV9zZWFyY2ggaW4g
RUdleGVjdXRlIGZhaWxzIGFuZCByZXR1cm5zIG5vdGhpbmcgc28KZm9yIGxvb3AgaW4gcHJp
bnRfbGluZV9taWRkbGUgcnVucyB6ZXJvIHRpbWVzIGJ1dCBzdGlsbCBzdGlsbCByZXR1cm5z
CnRyYXNoIHVuZGVyIGBjdXJgIHZhcmlhYmxlLCBzbyBncmVwIHRoaW5rcyBpdCBtYXRjaGVk
IHNvbWV0aGluZyBhbmQgdGhlbgpyZXR1cm5zIHdob2xlIGxpbmUuCgpGaXhlcyBidWcgMzk2
NzguIElzc3VlIHdhcyB0aGF0IHNlY29uZCBvZiBiZWxvdyBjb21tYW5kcyBkaWQgbm90IGNv
bG9yCnRoZSAiYSIgY2hhcmFjdGVyOgp8IGVjaG8gYSB8IGdyZXAgLWkgLS1jb2xvciAnXEEn
CnwgZWNobyBhIHwgZ3JlcCAtaSAtLWNvbG9yICdcYScKYnV0IGluIGZhY3QgaXQgc2hvdWxk
bid0IGV2ZW4gcHJpbnQgaXQgaW4gdGhlIGZpcnN0IHBsYWNlLCBzaW5jZSBnbnVsaWIKcmVn
ZXggZG9lc24ndCBtYXRjaCBpdC4KCiogc3JjL2dyZXAuYzogcHJpbnRfbGluZV9taWRkbGU6
IFJldHVybiBOVUxMIGlmIG1hdGNoIG5vdCBmb3VuZCBhbmQgZm9yCmxvb3Agbm90IGV4ZWN1
dGVkCgpTaWduZWQtb2ZmLWJ5OiBUb21hc3ogRHppZW5kemllbHNraSA8dG9tYXN6LmR6aWVu
ZHppZWxza2lAZ21haWwuY29tPgotLS0KIHNyYy9ncmVwLmMgfCA0ICsrKy0KIDEgZmlsZSBj
aGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9z
cmMvZ3JlcC5jIGIvc3JjL2dyZXAuYwppbmRleCBhNTUxOTRjZjFhYTkwNzJlY2MzN2ExMzU3
NGJjNTg4MTY3ZWU1ZDk0Li5iMzcyZTM0MTVjY2JmNmY4OTYwMzlhNmQ3MmJkNmMzNDk4ZDhj
MjY5IDEwMDY0NAotLS0gYS9zcmMvZ3JlcC5jCisrKyBiL3NyYy9ncmVwLmMKQEAgLTEyMTMs
NyArMTIxMyw3IEBAIHByaW50X2xpbmVfbWlkZGxlIChjaGFyICpiZWcsIGNoYXIgKmxpbSwK
ICAgcHRyZGlmZl90IG1hdGNoX29mZnNldDsKICAgY2hhciAqY3VyOwogICBjaGFyICptaWQg
PSBOVUxMOwotICBjaGFyICpiOworICBjaGFyICpiID0gTlVMTDsKIAogICBmb3IgKGN1ciA9
IGJlZzsKICAgICAgICAoY3VyIDwgbGltCkBAIC0xMjY5LDYgKzEyNjksOCBAQCBwcmludF9s
aW5lX21pZGRsZSAoY2hhciAqYmVnLCBjaGFyICpsaW0sCiAgICAgY3VyID0gbGltOwogICBl
bHNlIGlmIChtaWQpCiAgICAgY3VyID0gbWlkOworICBlbHNlIGlmIChiID09IE5VTEwpCisg
ICAgcmV0dXJuIE5VTEw7CiAKICAgcmV0dXJuIGN1cjsKIH0KLS0gCjIuMzMuMAoK
--------------77RGBoYuUJoxVSEgbyGMIsAF--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tomasz Dziendzielski <tomasz.dziendzielski@HIDDEN>
Subject: bug#51257: Acknowledgement (grep --ignore-case --color does not
 always color the matches)
Message-ID: <handler.51257.B.163452958632620.ack <at> debbugs.gnu.org>
References: <c4eab445-486e-7f5c-dc4f-91ede51156ce@HIDDEN>
X-Gnu-PR-Message: ack 51257
X-Gnu-PR-Package: grep
Reply-To: 51257 <at> debbugs.gnu.org
Date: Mon, 18 Oct 2021 04:00:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-grep@HIDDEN

If you wish to submit further information on this problem, please
send it to 51257 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
51257: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51257
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Nov 2021 02:49:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 21:49:03 2021
Received: from localhost ([127.0.0.1]:52646 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpiLH-0002hz-0A
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:49:03 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59122)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1mpiLF-0002hT-GB
 for control <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:49:01 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3266C1600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:56 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id mHZgbilLoN65 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 95E731600D3
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id SdIurAsfsNu2 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6AFE21600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:48:55 -0800 (PST)
Message-ID: <b3d30ec8-2d59-5270-539c-58128517095f@HIDDEN>
Date: Tue, 23 Nov 2021 18:48:55 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Content-Language: en-US
To: GNU bug control <control <at> debbugs.gnu.org>
From: Paul Eggert <eggert@HIDDEN>
Subject: merge Tomasz Dziendzielski bug report
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 51255 51256 51257

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Nov 2021 02:51:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 21:51:49 2021
Received: from localhost ([127.0.0.1]:52657 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpiNx-0002nD-I3
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:51:49 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1mpiNu-0002mw-Gi
 for control <at> debbugs.gnu.org; Tue, 23 Nov 2021 21:51:47 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 141971600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:41 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id hx6hSX0lQO07 for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 76CB41600D3
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id o-YwJATAgPit for <control <at> debbugs.gnu.org>;
 Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4775D1600BC
 for <control <at> debbugs.gnu.org>; Tue, 23 Nov 2021 18:51:40 -0800 (PST)
Message-ID: <b26198b9-df76-ab71-b8c8-d9adfd47b5ca@HIDDEN>
Date: Tue, 23 Nov 2021 18:51:39 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Content-Language: en-US
To: GNU bug control <control <at> debbugs.gnu.org>
From: Paul Eggert <eggert@HIDDEN>
Subject: more grep bug merging
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 39678 51257

Last modified: Wed, 24 Nov 2021 03:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.