GNU bug report logs - #51298
29.0.50; Tab bar buttons won't highlight after the mouse is released outside the tab bar

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51298 in the body.
You can then email your comments to 51298 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Tab bar buttons won't highlight after the mouse is
 released outside the tab bar
Date: Wed, 20 Oct 2021 09:02:30 +0800

When moving the mouse pointer over the Tab Bar "new tab" button, the
button appears to have a raised relief highlight.  But after clicking
down on the button and moving the pointer outside the button before
depressing the mouse button to cancel the tab creation, the new tab
button will no longer highlight unless it's clicked again.

In GNU Emacs 29.0.50 (build 643, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-10-20 built on limity
Repository revision: b611da8cd3cf5501ef58a34688029f525c5ad69b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101002
System Description: Fedora 34 (Workstation Edition)

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
GTK3 ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  tab-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils seq gv
byte-opt bytecomp byte-compile cconv time-date subr-x cl-loaddefs cl-lib
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 53275 9464)
 (symbols 48 6639 1)
 (strings 32 20246 1640)
 (string-bytes 1 670408)
 (vectors 16 13791)
 (vector-slots 8 185757 12718)
 (floats 8 24 38)
 (intervals 56 224 1)
 (buffers 992 10))

Message #8 received at 51298 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51298 <at> debbugs.gnu.org
Subject: Re: bug#51298: 29.0.50; Tab bar buttons won't highlight after the
 mouse is released outside the tab bar
Date: Wed, 20 Oct 2021 09:58:46 +0300

> When moving the mouse pointer over the Tab Bar "new tab" button, the
> button appears to have a raised relief highlight.  But after clicking
> down on the button and moving the pointer outside the button before
> depressing the mouse button to cancel the tab creation, the new tab
> button will no longer highlight unless it's clicked again.

The same problem exists when clicking down the tab close button "x".
Patches welcome.

Message #11 received at 51298 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 51298 <at> debbugs.gnu.org
Subject: Re: bug#51298: 29.0.50; Tab bar buttons won't highlight after the
 mouse is released outside the tab bar
Date: Wed, 20 Oct 2021 15:40:05 +0800

[Message part 1 (text/plain, inline)]

Juri Linkov <juri <at> linkov.net> writes:

> Patches welcome.

Thanks, please test.  The issue was because f->last_tab_bar_item
wouldn't be cleared when the mouse click was dropped outside the tab
bar.

[0001-Fix-tab-bar-item-highlight-when-a-mouse-click-is-dro.patch (text/x-patch, attachment)]

Message #14 received at 51298 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 51298 <at> debbugs.gnu.org
Subject: Re: bug#51298: 29.0.50; Tab bar buttons won't highlight after the
 mouse is released outside the tab bar
Date: Wed, 20 Oct 2021 15:59:36 +0800

[Message part 1 (text/plain, inline)]

BTW, I'm attaching another patch that makes the tab bar behave closer to
other programs.  I've explained the behaviour in the commit message.

WDYT?

[0001-Display-a-tab-bar-item-as-sunken-when-appropriate.patch (text/x-patch, attachment)]

Message #19 received at 51298 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51298 <at> debbugs.gnu.org
Subject: Re: bug#51298: 29.0.50; Tab bar buttons won't highlight after the
 mouse is released outside the tab bar
Date: Wed, 20 Oct 2021 19:43:07 +0300

tags 51298 fixed
thanks

> BTW, I'm attaching another patch that makes the tab bar behave closer to
> other programs.  I've explained the behaviour in the commit message.
>
> WDYT?

Thank you for the patches, everything works as it should,
so I pushed both patches.  The second patch didn't apply
cleanly (the difference was in #ifndef HAVE_NS),
so I have to add it manually, but this is not a problem.

Message #24 received at 51298 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: Po Lu <luangruo <at> yahoo.com>, 51298 <at> debbugs.gnu.org
Subject: Re: bug#51298: 29.0.50; Tab bar buttons won't highlight after the
 mouse is released outside the tab bar
Date: Fri, 22 Apr 2022 17:59:58 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Thank you for the patches, everything works as it should,
> so I pushed both patches.  The second patch didn't apply
> cleanly (the difference was in #ifndef HAVE_NS),
> so I have to add it manually, but this is not a problem.

This bug report was marked as fixed, but wasn't closed, so I'm doing
that now.  (Skimming the thread, it seems like all issues raised were
addressed.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.