GNU bug report logs - #51351
[PATCH] gnu: pplacer: Fix build.

Previous Next

Package: guix-patches;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Sat, 23 Oct 2021 14:31:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51351 in the body.
You can then email your comments to 51351 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Sat, 23 Oct 2021 14:31:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Lepiller <julien <at> lepiller.eu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 23 Oct 2021 14:31:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: pplacer: Fix build.
Date: Sat, 23 Oct 2021 16:30:08 +0200
[Message part 1 (text/plain, inline)]
Hi Guix!

This patch series fixes pplacer. I noticed ocaml4.07-re was failing to
build, and others also failed, so this series fixes them, and pplacer.
[0001-gnu-Add-ocaml4.07-re.patch (text/x-patch, attachment)]
[0002-gnu-Add-ocaml4.07-alcotest.patch (text/x-patch, attachment)]
[0003-gnu-ocaml-lwt-Remove-unneeded-input.patch (text/x-patch, attachment)]
[0004-gnu-Add-ocaml4.07-bisect-ppx.patch (text/x-patch, attachment)]
[0005-gnu-ocaml4.07-odoc-Fix-inputs.patch (text/x-patch, attachment)]
[0006-gnu-pplacer-Fix-build.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Thu, 11 Nov 2021 17:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 51351 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 51351 <at> debbugs.gnu.org
Cc: Julien Lepiller <julien <at> lepiller.eu>
Subject: [PATCH] gnu: pplacer: Fix build.
Date: Thu, 11 Nov 2021 17:47:37 +0000
Hi Julien,

thank you for the patches.  These look good to me.

Unfortunately, there seems to be no newer version of pplacer that 
would work with more recent versions of ocaml.

-- 
Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Mon, 15 Nov 2021 13:25:02 GMT) Full text and rfc822 format available.

Message #11 received at 51351 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 51351 <at> debbugs.gnu.org
Subject: Re: [bug#51351] [PATCH] gnu: pplacer: Fix build.
Date: Mon, 15 Nov 2021 14:22:07 +0100
Hi,

On Thu, 11 Nov 2021 at 17:47, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> thank you for the patches.  These look good to me.

The series also LGTM.

> Unfortunately, there seems to be no newer version of pplacer that would work
> with more recent versions of ocaml.

Yeah, a similar issue as packages depending on Python2 (for instance
’gess’) is going to happen.

From my point of view, the best is to move this not-updated package to
the channel guix-past.  The Data Service [1] is not very helpful but it
should be the entry point to reach commit with working (built) packages.

1: <https://data.guix.gnu.org/repository/1/branch/master/package/pplacer/output-history>


Cheers,
simon




Information forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Mon, 15 Nov 2021 13:41:02 GMT) Full text and rfc822 format available.

Message #14 received at 51351 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 51351 <at> debbugs.gnu.org
Subject: Re: [bug#51351] [PATCH] gnu: pplacer: Fix build.
Date: Mon, 15 Nov 2021 15:39:35 +0200
[Message part 1 (text/plain, inline)]
On Sat, Oct 23, 2021 at 04:30:08PM +0200, Julien Lepiller wrote:
> From b77fb136a6f1e4ecceb0ddbd2a0318af80721d50 Mon Sep 17 00:00:00 2001
> Message-Id: <b77fb136a6f1e4ecceb0ddbd2a0318af80721d50.1634999221.git.julien <at> lepiller.eu>
> In-Reply-To: <5a85894ee405d2fbe909b61fb3817aa44d6a08df.1634999221.git.julien <at> lepiller.eu>
> References: <5a85894ee405d2fbe909b61fb3817aa44d6a08df.1634999221.git.julien <at> lepiller.eu>
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Sat, 23 Oct 2021 15:26:54 +0200
> Subject: [PATCH 2/6] gnu: Add ocaml4.07-alcotest.
> 
> * gnu/packages/ocaml.scm (ocaml4.07-alcotest): New variable.
> ---
>  gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 412e9e339d..a8f5faaf1d 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -2268,6 +2268,7 @@ (define-public ocaml-alcotest
>         ("ocaml-stdlib-shims" ,ocaml-stdlib-shims)
>         ("ocaml-uuidm" ,ocaml-uuidm)
>         ("ocaml-uutf" ,ocaml-uutf)))
> +    (properties `((ocaml4.07-variant . ,(delay ocaml4.07-alcotest))))
>      (home-page "https://github.com/mirage/alcotest")
>      (synopsis "Lightweight OCaml test framework")
>      (description "Alcotest exposes simple interface to perform unit tests.  It
> @@ -2278,6 +2279,30 @@ (define-public ocaml-alcotest
>  simple (yet expressive) query language to select the tests to run.")
>      (license license:isc)))
>  
> +(define-public ocaml4.07-alcotest
> +  (package-with-ocaml4.07
> +    (package
> +      (inherit ocaml-alcotest)
> +      (version "1.0.1")
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/mirage/alcotest")
> +                      (commit version)))
> +                (file-name (git-file-name "ocaml-alcotest" version))
> +                (sha256
> +                 (base32
> +                  "1frwi185z4aadmaf0vp8xk5227nyg7nmh28ijj5l7ncjr5slvhz8"))))

This package builds just fine without the changes to arguments.

> +      (arguments
> +       `(#:test-target "."
> +         #:package "alcotest"
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'fix-dune-version
> +             (lambda _
> +               (delete-file "dune-project"))))))
> +      (properties '()))))
> +
>  (define-public ocaml-ppx-tools
>    (package
>      (name "ocaml-ppx-tools")
> -- 
> 2.33.0
> 


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Mon, 15 Nov 2021 13:42:01 GMT) Full text and rfc822 format available.

Message #17 received at 51351 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 51351 <at> debbugs.gnu.org
Subject: Re: [bug#51351] [PATCH] gnu: pplacer: Fix build.
Date: Mon, 15 Nov 2021 15:40:35 +0200
[Message part 1 (text/plain, inline)]
On Sat, Oct 23, 2021 at 04:30:08PM +0200, Julien Lepiller wrote:
> From 5a85894ee405d2fbe909b61fb3817aa44d6a08df Mon Sep 17 00:00:00 2001
> Message-Id: <5a85894ee405d2fbe909b61fb3817aa44d6a08df.1634999221.git.julien <at> lepiller.eu>
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Sat, 23 Oct 2021 15:22:11 +0200
> Subject: [PATCH 1/6] gnu: Add ocaml4.07-re.
> 
> * gnu/packages/ocaml.scm (ocaml4.07-re): New variable.
> ---
>  gnu/packages/ocaml.scm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 660bc44bc7..412e9e339d 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -3353,6 +3353,7 @@ (define-public ocaml-re
>       `(("ocaml-seq" ,ocaml-seq)))
>      (native-inputs
>       `(("ounit" ,ocaml-ounit)))
> +    (properties `((ocaml4.07-variant . ,(delay ocaml4.07-re))))
>      (home-page "https://github.com/ocaml/ocaml-re/")
>      (synopsis "Regular expression library for OCaml")
>      (description "Pure OCaml regular expressions with:
> @@ -3365,6 +3366,19 @@ (define-public ocaml-re
>  @end enumerate")
>      (license license:expat)))
>  

The alternate option I came up with was dropping this down to 1.9.0.

> +(define-public ocaml4.07-re
> +  (package-with-ocaml4.07
> +    (package
> +      (inherit ocaml-re)
> +      (arguments
> +       `(#:test-target "."
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'fix-dune-version
> +             (lambda _
> +               (delete-file "dune-project"))))))
> +      (properties '()))))
> +
>  (define-public ocaml-ocplib-endian
>    (package
>      (name "ocaml-ocplib-endian")
> -- 
> 2.33.0
> 


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#51351; Package guix-patches. (Mon, 15 Nov 2021 13:44:02 GMT) Full text and rfc822 format available.

Message #20 received at 51351 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 51351 <at> debbugs.gnu.org
Subject: Re: [bug#51351] [PATCH] gnu: pplacer: Fix build.
Date: Mon, 15 Nov 2021 15:42:37 +0200
[Message part 1 (text/plain, inline)]
On Sat, Oct 23, 2021 at 04:30:08PM +0200, Julien Lepiller wrote:
> From e7413cc1b1759ad7049b044d3e6743f572ced836 Mon Sep 17 00:00:00 2001
> Message-Id: <e7413cc1b1759ad7049b044d3e6743f572ced836.1634999221.git.julien <at> lepiller.eu>
> In-Reply-To: <5a85894ee405d2fbe909b61fb3817aa44d6a08df.1634999221.git.julien <at> lepiller.eu>
> References: <5a85894ee405d2fbe909b61fb3817aa44d6a08df.1634999221.git.julien <at> lepiller.eu>
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Sat, 23 Oct 2021 15:27:56 +0200
> Subject: [PATCH 4/6] gnu: Add ocaml4.07-bisect-ppx.
> 
> * gnu/packages/ocaml.scm (ocaml4.07-bisect-ppx): New variable.
> ---
>  gnu/packages/ocaml.scm | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 43011a0aab..87429b92ac 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -6625,7 +6625,8 @@ (define-public ocaml-bisect-ppx
>      (arguments
>       ;; Tests require ocamlformat which would lead to circular dependencies
>       '(#:tests? #f))
> -    (properties '((upstream-name . "bisect_ppx")))
> +    (properties `((upstream-name . "bisect_ppx")
> +                  (ocaml4.07-variant . ,(delay ocaml4.07-bisect-ppx))))
>      (home-page "https://github.com/aantron/bisect_ppx")
>      (synopsis "Code coverage for OCaml")
>      (description "Bisect_ppx helps you test thoroughly.  It is a small
> @@ -6637,6 +6638,33 @@ (define-public ocaml-bisect-ppx
>  then run the Bisect_ppx report tool on the generated visitation files.")
>      (license license:mpl2.0)))
>  
> +(define-public ocaml4.07-bisect-ppx
> +  (package-with-ocaml4.07
> +    (package
> +      (inherit ocaml-bisect-ppx)

I tried 2.4.1.

> +      (version "2.4.0")
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/aantron/bisect_ppx")
> +               (commit version)))
> +         (file-name (git-file-name "ocaml-bisect-ppx" version))
> +         (sha256
> +          (base32
> +           "1njs8xc108rrpx5am5zhhcn6vjva7rsphm8034qp5lgyvnhfgh7q"))))
> +      (propagated-inputs

With 2.4.1 the only change I had to make was to add
ocaaml-ppx-tools-versioned. And of course the properties change.

> +       `(("ocaml-migrate-parsetree" ,ocaml-migrate-parsetree)
> +         ("ocaml-ppx-tools-versioned" ,ocaml-ppx-tools-versioned)
> +         ,@(package-propagated-inputs ocaml-bisect-ppx)))
> +      (native-inputs
> +       `(("ocaml-ounit2" ,ocaml-ounit2)))
> +      (arguments
> +       `(#:test-target "."
> +         ;; tests require git and network
> +         #:tests? #f))
> +      (properties '()))))
> +
>  (define-public ocaml-odoc
>    (package
>      (name "ocaml-odoc")
> -- 
> 2.33.0
> 


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Tue, 16 Nov 2021 13:49:02 GMT) Full text and rfc822 format available.

Notification sent to Julien Lepiller <julien <at> lepiller.eu>:
bug acknowledged by developer. (Tue, 16 Nov 2021 13:49:02 GMT) Full text and rfc822 format available.

Message #25 received at 51351-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 51351-done <at> debbugs.gnu.org
Subject: Re: [bug#51351] [PATCH] gnu: pplacer: Fix build.
Date: Tue, 16 Nov 2021 15:47:41 +0200
[Message part 1 (text/plain, inline)]
On Sat, Oct 23, 2021 at 04:30:08PM +0200, Julien Lepiller wrote:
> Hi Guix!
> 
> This patch series fixes pplacer. I noticed ocaml4.07-re was failing to
> build, and others also failed, so this series fixes them, and pplacer.

I ended up pushing this patch set for you. Thanks!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 15 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.