GNU bug report logs - #51356
[PATCH] gnu: ocaml4.07-merlin: Remove package.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51356 in the body.
You can then email your comments to 51356 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ocaml4.07-merlin: Remove package.
Date: Sat, 23 Oct 2021 19:33:04 +0200

* gnu/packages/ocaml.scm (ocaml4.07-merlin): Remove package.
---
 gnu/packages/ocaml.scm | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index f0c46a9b4b..f640acca35 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -4650,34 +4650,6 @@ (define-public ocaml-merlin
 Atom.")
     (license license:expat)))
 
-;; ocaml-merlin 3.4.2 can not be built with old version of dune used in
-;; package-with-ocaml4.07
-(define-public ocaml4.07-merlin
-  (package-with-ocaml4.07
-   (package
-     (inherit ocaml-merlin)
-     (name "ocaml-merlin")
-     (version "3.2.2")
-     (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-              (url "https://github.com/ocaml/merlin")
-              (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "15ssgmwdxylbwhld9p1cq8x6kadxyhll5bfyf11dddj6cldna3hb"))))
-     (build-system dune-build-system)
-     (inputs
-      `(("ocaml-yojson" ,ocaml-yojson)))
-     (native-inputs
-      `(("ocaml-findlib" ,ocaml-findlib)))
-     (arguments
-      `(#:package "merlin"
-        ;; Errors in tests in version 3.2.2
-        #:tests? #f)))))
-
 (define-public ocaml4.07-gsl
   (package
     (name "ocaml4.07-gsl")
-- 
2.33.0

Message #8 received at 51356 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 51356 <at> debbugs.gnu.org
Subject: Re: [bug#51356] [PATCH] gnu: ocaml4.07-merlin: Remove package.
Date: Mon, 15 Nov 2021 14:12:34 +0100

Hi Julien,

On Sat, 23 Oct 2021 at 19:33, Julien Lepiller <julien <at> lepiller.eu> wrote:
> * gnu/packages/ocaml.scm (ocaml4.07-merlin): Remove package.
> ---
>  gnu/packages/ocaml.scm | 28 ----------------------------
>  1 file changed, 28 deletions(-)

LGTM. :-)


Cheers,
simon

Message #13 received at 51356-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 51356-done <at> debbugs.gnu.org
Subject: Re: [bug#51356] [PATCH] gnu: ocaml4.07-merlin: Remove package.
Date: Fri, 19 Nov 2021 04:06:08 +0100

Pushed to master as 188e3e2e6878346b0bdc8b46084f458abe86826c.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.