GNU bug report logs - #51400
--check, --rounds and --keep-failed used together produce empty store items

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 26 Oct 2021 02:18:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 25 22:18:25 2021
Received: from localhost ([127.0.0.1]:44739 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mfC2j-0002Ht-9O
	for submit <at> debbugs.gnu.org; Mon, 25 Oct 2021 22:18:25 -0400
Received: from lists.gnu.org ([209.51.188.17]:45242)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1mfC2h-0002Hl-6H
 for submit <at> debbugs.gnu.org; Mon, 25 Oct 2021 22:18:23 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41752)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1mfC2f-0003mQ-9E
 for bug-guix@HIDDEN; Mon, 25 Oct 2021 22:18:23 -0400
Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]:46676)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1mfC2d-00044f-Nj
 for bug-guix@HIDDEN; Mon, 25 Oct 2021 22:18:20 -0400
Received: by mail-qk1-x72c.google.com with SMTP id h20so13617947qko.13
 for <bug-guix@HIDDEN>; Mon, 25 Oct 2021 19:18:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:subject:date:message-id:mime-version;
 bh=EX7IXGqY1/ZdvjYKqjQKLYMsDOwhphDc03n/f1uErGU=;
 b=MKd1C6jCywGQP8GEurig3AHVWua/LXTnalc7ERXOJ25MgQeoGCVayfqYm95FNUHs+9
 tsWsWCP1a0FJOyEwOb53ywjmWFs4+K6xNu/Vcsg6cb58n8WGsHNv5++eBK7UCjncXwDF
 SDu9AjKOHMXLZRIgRYQ06Tb4x1k7vCV6SH+yLsYvFuyd+kgMCEWjEbKb7VXzhupuVcj3
 SyBj1sNkJYf+DZS7udTMnv1ZyE6+XNx5+4GIkYjrxKpN88XfGG5FfxHCFbevBRtizcMb
 tW8ygqmP6QSmEUV5NZkPQa9XlqiLskxjYNgmuAuNoinTFVP09PUGGteYwSYUWlLCrl6+
 qQqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:mime-version;
 bh=EX7IXGqY1/ZdvjYKqjQKLYMsDOwhphDc03n/f1uErGU=;
 b=HeLdIi3UzRI9DHtwvebvusLSqt1+l9odEnI5kMrKgybYpyAcCdvJhphzqRPWzcBRqN
 ZDzrUY7FX+ub4dHhOeo7LCKUezt62F9S14dJ6SlDzuNV+sLv2lF4iXC50T6HI/3B2iBi
 ZU/fqhzYGcCgyR2Vb/anEHJn5X6rwi096g4heTr2PLPTvhgNGzmBSnN7xvPBLDiKHMtg
 Rf0AqDUjjm/ORUgd7Hk5dBBqP9QqHW6vi65eYGwVQk0dtsHqd/xmhRV5cWwJiYRK+okK
 CkSgZau4aDtC/t44S0bEp4uiWiPrceJ0iyJyZ9EYrKoIFufkNMxBJTqyxjDVbWi/Xf9Q
 kxPg==
X-Gm-Message-State: AOAM532372paXKdQr54VYwlq1S4cr0TbnndvwfkciMk6hbbEz4RuePuH
 0EVgLWtkPPOrwAyv+t7Ie3po5gu5eU0=
X-Google-Smtp-Source: ABdhPJwnyq2vA+ehlLMwJJPQELZqHqfIuMELYvlEozhDIrVLPW7ru7jE4Ew4Unp0kmeqMULMF2PBmw==
X-Received: by 2002:a05:620a:1707:: with SMTP id
 az7mr16590090qkb.276.1635214698068; 
 Mon, 25 Oct 2021 19:18:18 -0700 (PDT)
Received: from hurd (dsl-10-133-98.b2b2c.ca. [72.10.133.98])
 by smtp.gmail.com with ESMTPSA id d23sm9431245qtm.11.2021.10.25.19.18.17
 for <bug-guix@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 25 Oct 2021 19:18:17 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: bug-guix <bug-guix@HIDDEN>
Subject: --check, --rounds and --keep-failed used together produce empty
 store items
Date: Mon, 25 Oct 2021 22:18:16 -0400
Message-ID: <87y26gfs0n.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::72c;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qk1-x72c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello,

While debugging while guix substitution would fail with a "corrupt input
while restoring ..."  error message, I saw in the guix-substitute strace
output that it was attempting to substitute a nonexistent store item.

I then narrowed the production of such broken store item to using the
following guix build options together:

--8<---------------cut here---------------start------------->8---
$ guix build hello --check --rounds=2 --keep-failed
[...]
successfully built /gnu/store/260bk0ch4np4h2yz5yqhf8hjbsyhwpmr-hello-2.10.drv
successfully built /gnu/store/260bk0ch4np4h2yz5yqhf8hjbsyhwpmr-hello-2.10.drv
/gnu/store/81bdcd5x4v50i28h98bfkvvkx9cky63w-hello-2.10

stat /gnu/store/81bdcd5x4v50i28h98bfkvvkx9cky63w-hello-2.10
stat: cannot statx '/gnu/store/81bdcd5x4v50i28h98bfkvvkx9cky63w-hello-2.10': No such file or directory
--8<---------------cut here---------------end--------------->8---

That's bad, especially since a subsequent 'guix build hello' doesn't fix
it (it keeps the corrupted cached item, even with --check!).

One needs to run

$ guix gc -D /gnu/store/81bdcd5x4v50i28h98bfkvvkx9cky63w-hello-2.10
$ guix build hello

to recover :-/.

This bug was probably exposed via
0fa0e8df60b0b005a8d9499562464c5a66218a5b, which enabled using --check
along with --rounds.

Thanks,

Maxim