GNU logs - #51427, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 27 Oct 2021 03:50:02 +0000
Resent-Message-ID: <handler.51427.B.163530657612481 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 51427 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Tue, 26 Oct 2021 23:49:18 -0400
Message-Id: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::f2b;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qv1-xf2b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Deleting unused links can be a very costly operation, especially on rotative
hard drives.  As removing single store items is often used for experimentation
rather than for cleaning purposes, this change allows it to run without the
links cleanup.

* nix/libstore/gc.cc (LocalStore::collectGarbage): Do not clean up links when
the specified action is GCOptions::gcDeleteSpecific.
---
 nix/libstore/gc.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
index e1d0765154..7d872d8cc1 100644
--- a/nix/libstore/gc.cc
+++ b/nix/libstore/gc.cc
@@ -771,7 +771,7 @@ void LocalStore::collectGarbage(const GCOptions & options, GCResults & results)
     deleteGarbage(state, state.trashDir);

     /* Clean up the links directory. */
-    if (options.action == GCOptions::gcDeleteDead || options.action == GCOptions::gcDeleteSpecific) {
+    if (options.action == GCOptions::gcDeleteDead) {
         printMsg(lvlError, format("deleting unused links..."));
         removeUnusedLinks(state);
     }
-- 
2.33.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: bug#51427: Acknowledgement ([PATCH] nix: libstore: Do not remove
 unused links when deleting specific items.)
Message-ID: <handler.51427.B.163530657612481.ack <at> debbugs.gnu.org>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
X-Gnu-PR-Message: ack 51427
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 51427 <at> debbugs.gnu.org
Date: Wed, 27 Oct 2021 03:50:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 51427 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
51427: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51427
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 28 Oct 2021 14:17:01 +0000
Resent-Message-ID: <handler.51427.B51427.16354305938926 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
Date: Thu, 28 Oct 2021 16:16:22 +0200
In-Reply-To: <20211027034918.4591-1-maxim.cournoyer@HIDDEN> (Maxim
 Cournoyer's message of "Tue, 26 Oct 2021 23:49:18 -0400")
Message-ID: <87o8795j61.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> Deleting unused links can be a very costly operation, especially on rotat=
ive
> hard drives.  As removing single store items is often used for experiment=
ation
> rather than for cleaning purposes, this change allows it to run without t=
he
> links cleanup.
>
> * nix/libstore/gc.cc (LocalStore::collectGarbage): Do not clean up links =
when
> the specified action is GCOptions::gcDeleteSpecific.
> ---
>  nix/libstore/gc.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
> index e1d0765154..7d872d8cc1 100644
> --- a/nix/libstore/gc.cc
> +++ b/nix/libstore/gc.cc
> @@ -771,7 +771,7 @@ void LocalStore::collectGarbage(const GCOptions & opt=
ions, GCResults & results)
>      deleteGarbage(state, state.trashDir);
>=20=20
>      /* Clean up the links directory. */
> -    if (options.action =3D=3D GCOptions::gcDeleteDead || options.action =
=3D=3D GCOptions::gcDeleteSpecific) {
> +    if (options.action =3D=3D GCOptions::gcDeleteDead) {

I believe the effect is that =E2=80=98guix gc -D /gnu/store/=E2=80=A6-disk-=
image=E2=80=99 would
remove nothing: /gnu/store/.links would still contain a copy of that big
disk image, so as a result, you=E2=80=99ve freed zero bytes.

Am I right?

Perhaps what we could do is, upon =E2=80=98gcDeleteSpecific=E2=80=99, only =
look at the
relevant entry in .links instead of traversing all of them.

WDYT?

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 Oct 2021 08:51:02 +0000
Resent-Message-ID: <handler.51427.B51427.163567022529882 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org
Message-ID: <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sun, 31 Oct 2021 09:50:15 +0100
In-Reply-To: <87o8795j61.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Am Donnerstag, den 28.10.2021, 16:16 +0200 schrieb Ludovic Courtès:
> Hi,
> 
> Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:
> 
> > Deleting unused links can be a very costly operation, especially on
> > rotative hard drives.  As removing single store items is often used
> > for experimentation rather than for cleaning purposes, this change
> > allows it to run without the links cleanup.
> > 
> > * nix/libstore/gc.cc (LocalStore::collectGarbage): Do not clean up
> > links when
> > the specified action is GCOptions::gcDeleteSpecific.
> > ---
> >  nix/libstore/gc.cc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
> > index e1d0765154..7d872d8cc1 100644
> > --- a/nix/libstore/gc.cc
> > +++ b/nix/libstore/gc.cc
> > @@ -771,7 +771,7 @@ void LocalStore::collectGarbage(const GCOptions
> > & options, GCResults & results)
> >      deleteGarbage(state, state.trashDir);
> >  
> >      /* Clean up the links directory. */
> > -    if (options.action == GCOptions::gcDeleteDead ||
> > options.action == GCOptions::gcDeleteSpecific) {
> > +    if (options.action == GCOptions::gcDeleteDead) {
> 
> I believe the effect is that ‘guix gc -D /gnu/store/…-disk-image’
> would remove nothing: /gnu/store/.links would still contain a copy of
> that big disk image, so as a result, you’ve freed zero bytes.
> 
> Am I right?
I think that might be the point.  As Maxim said, single items are
(likely) not removed for cleaning purposes, so freeing the disk image
has little effect.  Plus, you could invoke it like

  guix gc -D dead-item dead-item live-item dead-item

It would fail at live-item and then not continue to free the links of
the two dead items prior.

So there's a few things we could do here:

1. simply fail and have the user deal with it (including the option of
doing a normal `guix gc' or `guix gc -C 1')
2. remember which paths were live and dead and always clean up the
links, only reporting errors afterwards
3. add an option to explicitly check the .links directory (which
defaults to true for the current things, but could also be used to
clean links after a liveness check or after a do-nothing `guix gc -F').
4. ...

WDYT?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 Oct 2021 14:08:02 +0000
Resent-Message-ID: <handler.51427.B51427.16356892316186 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16356892316186
          (code B ref 51427); Sun, 31 Oct 2021 14:08:02 +0000
Received: (at 51427) by debbugs.gnu.org; 31 Oct 2021 14:07:11 +0000
Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhBUN-0001bg-H9
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 10:07:11 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34206)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1mhBUM-0001bT-25
 for 51427 <at> debbugs.gnu.org; Sun, 31 Oct 2021 10:07:10 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54444)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mhBUG-00041f-HE; Sun, 31 Oct 2021 10:07:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=q3EJYPRgyPjTdmktdbM/sebDxQ0SXOpf+TfNHW5he8w=; b=LwwYCthlVC3YExgjMVmI
 2vuSCTkxcrhw9pOXaCGCM2H9hYfHOwZSJtsVDxalaHhJfJF7zr+VpdKWv2vq9zch5azajw6mdaLL3
 I+1vu2+dX0/7/LgwSXogY9Q78zI5a1AaFgAx1uvelaCDNoDLrq45V73WK81FhxkUdnPgsOVEoS54h
 66Xy1bgrJQo8mpHyovfiyH5WmG/EuTRm7dBLhJGit/jGCjkl8tgC1BzERtxkzNwYDf8afpxG93iNh
 Ll3DnT3TPhlqyRM6gEwj5iKRbLxICJNONlJbETmGTsP4CN0XZcABgR419k+6Jfkm0+dLayj/qUNud
 rerGbuGp4JwWOQ==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55508
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mhBUF-0007JE-Km; Sun, 31 Oct 2021 10:07:03 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 10 Brumaire an 230 de la =?UTF-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sun, 31 Oct 2021 15:07:02 +0100
In-Reply-To: <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 (Liliana Marie Prikler's message of "Sun, 31 Oct 2021 09:50:15 +0100")
Message-ID: <87h7cxp9tl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:

> Am Donnerstag, den 28.10.2021, 16:16 +0200 schrieb Ludovic Court=C3=A8s:
>> Hi,
>>=20
>> Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:
>>=20
>> > Deleting unused links can be a very costly operation, especially on
>> > rotative hard drives.  As removing single store items is often used
>> > for experimentation rather than for cleaning purposes, this change
>> > allows it to run without the links cleanup.
>> >=20
>> > * nix/libstore/gc.cc (LocalStore::collectGarbage): Do not clean up
>> > links when
>> > the specified action is GCOptions::gcDeleteSpecific.
>> > ---
>> >  nix/libstore/gc.cc | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >=20
>> > diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
>> > index e1d0765154..7d872d8cc1 100644
>> > --- a/nix/libstore/gc.cc
>> > +++ b/nix/libstore/gc.cc
>> > @@ -771,7 +771,7 @@ void LocalStore::collectGarbage(const GCOptions
>> > & options, GCResults & results)
>> >      deleteGarbage(state, state.trashDir);
>> >=20=20
>> >      /* Clean up the links directory. */
>> > -    if (options.action =3D=3D GCOptions::gcDeleteDead ||
>> > options.action =3D=3D GCOptions::gcDeleteSpecific) {
>> > +    if (options.action =3D=3D GCOptions::gcDeleteDead) {
>>=20
>> I believe the effect is that =E2=80=98guix gc -D /gnu/store/=E2=80=A6-di=
sk-image=E2=80=99
>> would remove nothing: /gnu/store/.links would still contain a copy of
>> that big disk image, so as a result, you=E2=80=99ve freed zero bytes.
>>=20
>> Am I right?
> I think that might be the point.  As Maxim said, single items are
> (likely) not removed for cleaning purposes, so freeing the disk image
> has little effect.

What do you mean?  When doing VM testing, I regularly do =E2=80=98guix gc -D
/gnu/store/=E2=80=A6-disk-image=E2=80=99 precisely to save space.  Fortunat=
ely it does
have the intended effect of freeing a bunch of GiBs.

> Plus, you could invoke it like
>
>   guix gc -D dead-item dead-item live-item dead-item
>
> It would fail at live-item and then not continue to free the links of
> the two dead items prior.

Yes, and that=E2=80=99s annoying, but it=E2=80=99s unrelated.  :-)

> So there's a few things we could do here:
>
> 1. simply fail and have the user deal with it (including the option of
> doing a normal `guix gc' or `guix gc -C 1')
> 2. remember which paths were live and dead and always clean up the
> links, only reporting errors afterwards
> 3. add an option to explicitly check the .links directory (which
> defaults to true for the current things, but could also be used to
> clean links after a liveness check or after a do-nothing `guix gc -F').
> 4. ...

You seem to be proposing to remove =E2=80=98-D=E2=80=99 altogether.  I agre=
e it has the
shortcomings you write, but I think it=E2=80=99s occasionally useful
nonetheless.

My proposal would be either the status quo, or removing just the one
link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99.

Thoughts?

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 Oct 2021 14:40:01 +0000
Resent-Message-ID: <handler.51427.B51427.163569115417680 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163569115417680
          (code B ref 51427); Sun, 31 Oct 2021 14:40:01 +0000
Received: (at 51427) by debbugs.gnu.org; 31 Oct 2021 14:39:14 +0000
Received: from localhost ([127.0.0.1]:32785 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhBzN-0004b5-Ol
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 10:39:14 -0400
Received: from mail-wr1-f67.google.com ([209.85.221.67]:44808)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1mhBzL-0004at-Tb
 for 51427 <at> debbugs.gnu.org; Sun, 31 Oct 2021 10:39:12 -0400
Received: by mail-wr1-f67.google.com with SMTP id d13so24408018wrf.11
 for <51427 <at> debbugs.gnu.org>; Sun, 31 Oct 2021 07:39:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=F2Dxl6lA7AbP8VyW0XTsyRAmV50iMNc9ISlG/Fh8gEA=;
 b=LDsR3QEcuOflCoO4xuVmzD/+Ahtwrcamt9Zs0PGegEtGUmmWI0BEgyEvR05ave3uJe
 /ZvEnHoYQC6yhJQYrUapp1ALt1g/6nrpxt6qpjGpi/fP6FTB7tVmChOOlohL5QZtma3o
 2fhnRgmUzkzgSYyC/pl368QS6U6FiW8Z9L9v1VjLaU+WvLaBaykGFxh3ghuFkjLrPxz3
 gakTr8w0FRBUltezkfU+AxdJq8ZuLgj6Onz4YPxn6hqat4ci4WW8m1FKC+O9WbFUkcNH
 u3hFLy9BCCDePSiZrOUqUrEl640Pns60By7EQ6ntFX/tIY/300iVSrJmQ/4eULTvuw3p
 p5ug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=F2Dxl6lA7AbP8VyW0XTsyRAmV50iMNc9ISlG/Fh8gEA=;
 b=s0luqigOGYRwU8NDVfRIp1xx9F3OVpqv+0UG4O8Jml7EDnCuJEChxUb8LBhLI4gUD6
 phw3+LolXCqQdxWWvrgmbRwLDkdgGGNXRizxI+m/W1UhATITi5wUe4Nj7ThBQZCpT04d
 H4D4VHYjgYe7CaOBqBallR0dDxZcZnDPhQjV9GkN49D+PQX+TjJ+W/FWmjiirVBVUMu2
 s8rWjwTZN0I6Lg/8Kn7ideVRdvzZscwcsXj6rJZndaXHvYzHyclFUDdg+FrMctfuSg5x
 CUemvG8RUn7oU+DT3oMOZTh3NTmWbgDpHi+p592ao6I66WZ0ytkzluwuSZ/N7WcYCibN
 fY4Q==
X-Gm-Message-State: AOAM530ut9XM/SSSfUx1zWw1pY4IJIsWr+xasTZewYExvOP+8eyyIHRV
 KPXtUW0hemxOAi0II/T0Zhg=
X-Google-Smtp-Source: ABdhPJyGMjbXEhmUBYyGWO76D4vLcyxVOiaJ2xVF9qKvzg6bOoS12ja2bPxlolH+uUep2zakh+Unaw==
X-Received: by 2002:adf:9bdb:: with SMTP id e27mr28279411wrc.417.1635691146044; 
 Sun, 31 Oct 2021 07:39:06 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id y6sm11372365wrh.18.2021.10.31.07.39.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Oct 2021 07:39:05 -0700 (PDT)
Message-ID: <9f9a708f8ecbb49464e3d939be89638a53dc0d30.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sun, 31 Oct 2021 15:39:04 +0100
In-Reply-To: <87h7cxp9tl.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Am Sonntag, den 31.10.2021, 15:07 +0100 schrieb Ludovic Courtès:
> What do you mean?  When doing VM testing, I regularly do ‘guix gc -D
> /gnu/store/…-disk-image’ precisely to save space.  Fortunately it
> does have the intended effect of freeing a bunch of GiBs.
Fair enough, different strokes and all.

> > Plus, you could invoke it like
> > 
> >   guix gc -D dead-item dead-item live-item dead-item
> > 
> > It would fail at live-item and then not continue to free the links
> > of the two dead items prior.
> 
> Yes, and that’s annoying, but it’s unrelated.  :-)
> 
> > So there's a few things we could do here:
> > 
> > 1. simply fail and have the user deal with it (including the option
> > of doing a normal `guix gc' or `guix gc -C 1')
> > 2. remember which paths were live and dead and always clean up the
> > links, only reporting errors afterwards
> > 3. add an option to explicitly check the .links directory (which
> > defaults to true for the current things, but could also be used to
> > clean links after a liveness check or after a do-nothing `guix gc
> > -F').
> > 4. ...
> 
> You seem to be proposing to remove ‘-D’ altogether.  
I wrote no such thing.  Obviously there needs to be a way of removing
single items from the store, but what else to do is not so clear.  It
is only obvious that traversing all of .links is too expensive.

> I agree it has the shortcomings you write, but I think it’s
> occasionally useful nonetheless.
> 
> My proposal would be either the status quo, or removing just the one
> link that matters from /gnu/store/.links upon ‘-D’.
> 
> Thoughts?
There isn't "just the one link that matters" when it comes to removing
multiple items -- heck, even if tasked to free up just 5MB rather than
all of the garbage, traversing all .links is probably too expensive.

Accepting that we might want to always delete links at the end, I think
`guix gc' needs a way to record which links had their count go to 1
during garbage deletion, so that when it comes to deleting links only
those are tried (and of course checked again to make sure their count
is indeed still 1).  This should be the preferred mode if less than
some arbitrary large number of store items are affected (let's say 1024
or some multiple of it) or a total cleaning of .links has been forced.

Though perhaps there's a way to do this without manual recording. 
Let's say we notice a link count going to one as we clear the trash. 
We could just add the link behind it to the trash right away to ensure
that it is not reused by something else and then clean the trash a
second time (we would have to check for potential race conditions in
this case).

WDYT?

Liliana

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 31 Oct 2021 20:52:01 +0000
Resent-Message-ID: <handler.51427.B51427.163571350513640 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163571350513640
          (code B ref 51427); Sun, 31 Oct 2021 20:52:01 +0000
Received: (at 51427) by debbugs.gnu.org; 31 Oct 2021 20:51:45 +0000
Received: from localhost ([127.0.0.1]:33175 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhHnt-0003Xw-H4
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 16:51:45 -0400
Received: from mail-qk1-f170.google.com ([209.85.222.170]:33313)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1mhHnr-0003Xh-CH
 for 51427 <at> debbugs.gnu.org; Sun, 31 Oct 2021 16:51:43 -0400
Received: by mail-qk1-f170.google.com with SMTP id a132so13747627qkg.0
 for <51427 <at> debbugs.gnu.org>; Sun, 31 Oct 2021 13:51:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=Ko6H/BV6WE/WlkVC1GO1AiW9LXIPfe5A07BwQ9NXRIE=;
 b=QATU9+qXOR/E20yiHOkIn0t3QCv2cUfYpiRmTr4WAjd+fyhgebK6MRi2x90ycNOeGE
 GvVzOjrT/hivkjEth4UJbqOnIZbmBwjq2SrugHngF0xgI32UNaN4p9Pf8PByHPn1GN7L
 E13rpqiqSEeHDlo7P50mFMaGydgJcCut58Xw69jjaTOz2GXLWwQmTX8prGchXGGZHuzk
 m3p/VfhAkR2wlb2hxoNTKIuaOWUx7SFAXcr2xChHtHVPL+9C/D8J9chrzsnVtjIRdqp5
 VamVl4A0fShRDkFv2N8qD3laBp+q4sa4GJ0Hk+B6NDDZ6baqGoFm1UwwtORQUESLCmxM
 R8dw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=Ko6H/BV6WE/WlkVC1GO1AiW9LXIPfe5A07BwQ9NXRIE=;
 b=er9eHTwmhwgr7Ln6Rz6aRyHocCZ+uMfuPa5kr6ZEzY3bRH7IoS1YPl22aEJcyDkMfV
 v9oGAXkBRAWxsV7aB8F6pQwEyZGRfSd6bJz3Np/pxisrUpb7JL+Xaw7mI+1vP5zUz4xj
 OGthbmz9YR9ZsmcxmbDL67L39uQf/Z6xT9cONG+ReYTmPDUENecWYyKPn1ib8DSRUJgE
 /me3qSKhg6oIgmut53eTR+nCB5juyTy/R8RZ6ZSuF+XwlbhUw/FziTLy2VY8Fd+1AuFN
 mXEoAE/Yc/pm5JkpWtjQtmwALKBgWMI71HtbF0GGpD6GFBniByKPmGBhD9o/BSWfSN4O
 HKnw==
X-Gm-Message-State: AOAM531QKBJkc7ZZuwE0vMmbsOlaeHylo50MS3wpBsTNWMVVtN6VA2m7
 rP6TRmVicm4/JNQA7iValDU2PN+XM6k=
X-Google-Smtp-Source: ABdhPJxb5+AXAuk/CspT199mBdNuTTl2Sh4pIu578vkUnE2uI+oOEDxUgWO9YyD2dMnm8lniO3QbBg==
X-Received: by 2002:a05:620a:178b:: with SMTP id
 ay11mr20500299qkb.287.1635713497455; 
 Sun, 31 Oct 2021 13:51:37 -0700 (PDT)
Received: from hurd (dsl-153-210.b2b2c.ca. [66.158.153.210])
 by smtp.gmail.com with ESMTPSA id e18sm6132720qtw.12.2021.10.31.13.51.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Oct 2021 13:51:37 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN>
Date: Sun, 31 Oct 2021 16:51:36 -0400
In-Reply-To: <87h7cxp9tl.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 31 Oct 2021 15:07:02 +0100")
Message-ID: <87sfwg7w9z.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Hi,
>
> Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:
>
>> Am Donnerstag, den 28.10.2021, 16:16 +0200 schrieb Ludovic Court=C3=A8s:
>>> Hi,
>>>=20
>>> Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:
>>>=20
>>> > Deleting unused links can be a very costly operation, especially on
>>> > rotative hard drives.  As removing single store items is often used
>>> > for experimentation rather than for cleaning purposes, this change
>>> > allows it to run without the links cleanup.
>>> >=20
>>> > * nix/libstore/gc.cc (LocalStore::collectGarbage): Do not clean up
>>> > links when
>>> > the specified action is GCOptions::gcDeleteSpecific.
>>> > ---
>>> >  nix/libstore/gc.cc | 2 +-
>>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >=20
>>> > diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
>>> > index e1d0765154..7d872d8cc1 100644
>>> > --- a/nix/libstore/gc.cc
>>> > +++ b/nix/libstore/gc.cc
>>> > @@ -771,7 +771,7 @@ void LocalStore::collectGarbage(const GCOptions
>>> > & options, GCResults & results)
>>> >      deleteGarbage(state, state.trashDir);
>>> >=20=20
>>> >      /* Clean up the links directory. */
>>> > -    if (options.action =3D=3D GCOptions::gcDeleteDead ||
>>> > options.action =3D=3D GCOptions::gcDeleteSpecific) {
>>> > +    if (options.action =3D=3D GCOptions::gcDeleteDead) {
>>>=20
>>> I believe the effect is that =E2=80=98guix gc -D /gnu/store/=E2=80=A6-d=
isk-image=E2=80=99
>>> would remove nothing: /gnu/store/.links would still contain a copy of
>>> that big disk image, so as a result, you=E2=80=99ve freed zero bytes.
>>>=20
>>> Am I right?
>> I think that might be the point.  As Maxim said, single items are
>> (likely) not removed for cleaning purposes, so freeing the disk image
>> has little effect.
>
> What do you mean?  When doing VM testing, I regularly do =E2=80=98guix gc=
 -D
> /gnu/store/=E2=80=A6-disk-image=E2=80=99 precisely to save space.  Fortun=
ately it does
> have the intended effect of freeing a bunch of GiBs.
>
>> Plus, you could invoke it like
>>
>>   guix gc -D dead-item dead-item live-item dead-item
>>
>> It would fail at live-item and then not continue to free the links of
>> the two dead items prior.
>
> Yes, and that=E2=80=99s annoying, but it=E2=80=99s unrelated.  :-)
>
>> So there's a few things we could do here:
>>
>> 1. simply fail and have the user deal with it (including the option of
>> doing a normal `guix gc' or `guix gc -C 1')
>> 2. remember which paths were live and dead and always clean up the
>> links, only reporting errors afterwards
>> 3. add an option to explicitly check the .links directory (which
>> defaults to true for the current things, but could also be used to
>> clean links after a liveness check or after a do-nothing `guix gc -F').
>> 4. ...
>
> You seem to be proposing to remove =E2=80=98-D=E2=80=99 altogether.  I ag=
ree it has the
> shortcomings you write, but I think it=E2=80=99s occasionally useful
> nonetheless.
>
> My proposal would be either the status quo, or removing just the one
> link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99.

The second proposal makes sense.  I didn't care about freeing space, as
my use case was getting around corrupting an item in my store due to
https://issues.guix.gnu.org/51400, which the patch proposed here allowed
me to do without wasting hours of cleaning up links (nearly 1 GiB of
store on spinning drives).

Thanks,

Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 03 Nov 2021 10:46:01 +0000
Resent-Message-ID: <handler.51427.B51427.16359363577513 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16359363577513
          (code B ref 51427); Wed, 03 Nov 2021 10:46:01 +0000
Received: (at 51427) by debbugs.gnu.org; 3 Nov 2021 10:45:57 +0000
Received: from localhost ([127.0.0.1]:39162 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1miDmH-0001x7-Gv
	for submit <at> debbugs.gnu.org; Wed, 03 Nov 2021 06:45:57 -0400
Received: from mail-qt1-f174.google.com ([209.85.160.174]:39935)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1miDmF-0001wu-IB
 for 51427 <at> debbugs.gnu.org; Wed, 03 Nov 2021 06:45:55 -0400
Received: by mail-qt1-f174.google.com with SMTP id x10so65538qta.6
 for <51427 <at> debbugs.gnu.org>; Wed, 03 Nov 2021 03:45:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=pbolAUOeDapWsysQBp2EKyUNiY/24M0/tTBAMTPTsYs=;
 b=J1kppa/DVhbUVBLVMIblWces6LQI7etfz78EpPYeN+6gzUjW+KVK0inWialfss70bg
 gHq85ffPgdN2zp0/kf5HV+hkeNXsZK+2pdsX/D/4lI6V4xF1X4YetJlzvGqhEQFQfRqW
 YsqSkTcMSWJYN6j9kw42xs+75ON9F/Xd70Iib9jTuf/yeRnN4B+4KtznpaepWo0ktHck
 mONdHIIvVxchsEWL9aAxksmF2GDYRfWhjbfQjbW/mXO64Mibz0qp7rZTVNKSYR1RvoPL
 04d8F5Sn4td9hDS1rbf1WayHBduB5ynKQdrk1ND/rJLbG+D3/Sia9KqZK5BESEeQ0sx8
 x10A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=pbolAUOeDapWsysQBp2EKyUNiY/24M0/tTBAMTPTsYs=;
 b=ueiSvj4MRrMN0SDZORJDVx6hAk2IWEBdYF0oDFBj3hL2o8IpryXMF4J1VY+DpMkEDz
 gKDzz1bio9dVsEs1i8MP2v+6WPvKIpwbIXPucHDYPE0ilMZX2gvJ0KxdxVoeA8kG5W4T
 sp7/s0pbOj4xHmCyIKs9m5bBXUfzwJ22FdEX0RRUFEBZVLzYQjTmVrpPOFZkl7I/6LAk
 RGSiGbB6qTiNX/8jqZmbUQ+KzFe8CHadbD8NeI1Yan3AZVyQ0i9e4vQNkNAiZIGmyEym
 S5AlECerScHIkl/i/30ufHfAl9I/CGnGklPCinPm5U1BnE+qbO+Frdt3SRCno6eBk1xI
 XS8w==
X-Gm-Message-State: AOAM533Porl6V1KLWZTC1z1disexZzABPofTuOPy6sPuTalVbxW802O6
 EL4SRj7v5nzxPCl15MadFfH/tzYbNVtuZR7gntE=
X-Google-Smtp-Source: ABdhPJy6npCzdgT+H20xxwZkoFxJp5LhysiXgaOvEWq5DbeiAIGPlqPQOyBMzeGKWLLGpfmIwII8JzBQdUchUOpC+8s=
X-Received: by 2002:a05:622a:58e:: with SMTP id
 c14mr41100617qtb.225.1635936349983; 
 Wed, 03 Nov 2021 03:45:49 -0700 (PDT)
MIME-Version: 1.0
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
In-Reply-To: <87sfwg7w9z.fsf@HIDDEN>
From: zimoun <zimon.toutoune@HIDDEN>
Date: Wed, 3 Nov 2021 11:45:39 +0100
Message-ID: <CAJ3okZ1=0MZpUq7jk3F46mWfikNa1snj+uERXGgVMRWKviSmhA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Sun, 31 Oct 2021 at 21:53, Maxim Cournoyer <maxim.cournoyer@HIDDEN> w=
rote:

> > My proposal would be either the status quo, or removing just the one
> > link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99.
>
> The second proposal makes sense.  I didn't care about freeing space, as
> my use case was getting around corrupting an item in my store due to
> https://issues.guix.gnu.org/51400, which the patch proposed here allowed
> me to do without wasting hours of cleaning up links (nearly 1 GiB of
> store on spinning drives).

I often use "guix gc -D" for being able to launch again a command and
then check against SWH or other upstream.  Because the "deleting
links" is too much long, I am doing ^C at this step.  Therefore, be
able to skip this step when running "guix gc -D" appears to me the
thing to do.  Well, if "guix gc -D" is not doing it, then I am forcing
it by interrupting it; which appears to me worse than status quo.
BTW, if I need space, then I do not use "guix gc -D" on few items but
instead I use the options -F or -d or -C; here I am fine it takes the
time it takes. :-)

Well, =C2=AB"deleting unused links" GC phase is too slow=C2=BB is not new
because it is bug#24937 [1].  Therefore, status quo is really annoying
and I would prefer to skip this GC phase when using option -D although
it is not optimal.  Or remove just the one link that matters.

1: <http://issues.guix.gnu.org/issue/24937>


Cheers,
simon

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 06 Nov 2021 16:59:02 +0000
Resent-Message-ID: <handler.51427.B51427.16362178906774 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16362178906774
          (code B ref 51427); Sat, 06 Nov 2021 16:59:02 +0000
Received: (at 51427) by debbugs.gnu.org; 6 Nov 2021 16:58:10 +0000
Received: from localhost ([127.0.0.1]:50332 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mjP18-0001lC-Ep
	for submit <at> debbugs.gnu.org; Sat, 06 Nov 2021 12:58:10 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60500)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1mjP15-0001ks-Hs
 for 51427 <at> debbugs.gnu.org; Sat, 06 Nov 2021 12:58:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48256)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mjP10-00051x-5X; Sat, 06 Nov 2021 12:58:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=jbMs4djboZuqX00vdbhfXz8rynzURTtBKoaK3vkZk74=; b=A0GH6QTfRm5zaEc/UUVe
 zLrsSLmm4UkYOectXp/E3UIJ1m5X+yUOhHylULhgYHnrT8uJKA3yopkm/Y03uPy+eftdf7R4hSkrb
 hs0QJpU8sq5rjzlfRO8MZbNDvWCxDBVdYRpJzxwtfzLOjdPhMLM0vW7oA79ekJvjRheR5g3SuChht
 mtHvyFLPzBST4f6lueccmcS8foX4rPu1NcNYnbaMkKiZRyaforI73jgDwiNLU9AsVifASrL/hZbMy
 JqphHBVt8HwnayaNTR3AtLnyNM+E5MgcpdF6X92ihTBklgkM+P+MdFnEeqc/30O7hJRaqEkj+UGgs
 wbU/XgSklKO3Wg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55518
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mjP0y-0007uJ-RE; Sat, 06 Nov 2021 12:58:01 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 16 Brumaire an 230 de la =?UTF-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sat, 06 Nov 2021 17:57:58 +0100
In-Reply-To: <87sfwg7w9z.fsf@HIDDEN> (Maxim Cournoyer's message of "Sun, 31
 Oct 2021 16:51:36 -0400")
Message-ID: <87ee7tmdbd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Maxim and all,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

[...]

>> You seem to be proposing to remove =E2=80=98-D=E2=80=99 altogether.  I a=
gree it has the
>> shortcomings you write, but I think it=E2=80=99s occasionally useful
>> nonetheless.
>>
>> My proposal would be either the status quo, or removing just the one
>> link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99.
>
> The second proposal makes sense.

Maybe that proposal is bogus though because you=E2=80=99d need to know the =
hash
of the files being removed, which means reading them=E2=80=A6

> I didn't care about freeing space, as my use case was getting around
> corrupting an item in my store due to
> https://issues.guix.gnu.org/51400, which the patch proposed here
> allowed me to do without wasting hours of cleaning up links (nearly 1
> GiB of store on spinning drives).

The ideal solution as zimoun writes would be to address
<https://issues.guix.gnu.org/24937>.

Perhaps that phase needs to be implemented using a different strategy,
say an sqlite database that records the current link count (hoping that
=E2=80=98SELECT * FROM links WHERE NLINKS =3D 1=E2=80=99 would be faster th=
an traversing
all of =E2=80=98.links=E2=80=99) as well as a mapping from store item to fi=
le hashes.

BTW, those using Btrfs can probably use =E2=80=98--disable-deduplication=E2=
=80=99 and be
done with it.

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 09 Nov 2021 04:12:01 +0000
Resent-Message-ID: <handler.51427.B51427.163643109418585 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163643109418585
          (code B ref 51427); Tue, 09 Nov 2021 04:12:01 +0000
Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 04:11:34 +0000
Received: from localhost ([127.0.0.1]:60238 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mkITu-0004ph-5R
	for submit <at> debbugs.gnu.org; Mon, 08 Nov 2021 23:11:34 -0500
Received: from mail-qk1-f182.google.com ([209.85.222.182]:45010)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1mkITs-0004pO-M0
 for 51427 <at> debbugs.gnu.org; Mon, 08 Nov 2021 23:11:33 -0500
Received: by mail-qk1-f182.google.com with SMTP id bj27so16003306qkb.11
 for <51427 <at> debbugs.gnu.org>; Mon, 08 Nov 2021 20:11:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=kLECGrFl2ZF+KKyKoR9Z1g+7lY0MK3HG1Htt0LGjF44=;
 b=jJjWWla3QSN0VxxI2EmfXpc+Sdlk3spcDX6WRhoBWsyDp+KF0e+daCgfFKc96QUmMy
 1GURApm32tSrdLy6Y1UpLeEjBFc8ZO0mG5udqfNgW1IpDDs8plAy/8udffulU35K8fGm
 bVhxBqsw7CClyCUK7bdtS20/kzTN0ryqlpUSbYdxn0zz1vV7SUCM0/1gSmTpblVLUQWz
 Ok6KN80wIM4iqyk+522yUAfm7XaGB68WkAHsTdfi2Pylohus4wFfspEaYO61N/HJ4PdE
 hEw4RfoYA4rbNHctD0V0uul4LUZ0qBXPhkvdsUQpI/GGgLuaSAWMgLKpgwv9G6+xNHko
 YmAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=kLECGrFl2ZF+KKyKoR9Z1g+7lY0MK3HG1Htt0LGjF44=;
 b=LUVbZhB6e3boLZg+3ayWNf5fiXw45gYCyjN2hMpwXPpFinDX1tb3NoN5nDuHH5+VG+
 ds3AWhCFyIw9g1Oj26hMefeO02fwwH+BRuCIXMO9HO+2ejEtzyhtHsP1n/KR8l4qV/xy
 jGYwSPPHzgMjzbmaQ6IZgy1qPTzZI19ZXkal1BSOSC7w2IyQ1FdhtibcvkKMONQsWnJF
 /nCeqNxxAsIZjZUwy3OyqXcfH24w9Pl+UxzvDtD5IhWPGAjdvMw1MTPLmHjc+OCPEK6l
 lf5w+QFdwyPkYW/xJPdhgER7zXDyOU0Q1EJt8gNDzy94aGIEY5l4cJhneY+vbitG3502
 Npzw==
X-Gm-Message-State: AOAM531DcA1Dh0vFESEaHmIqc+2hcqL71vIxkZQg7wBUwTN1KiVReQGH
 3EqsZA2GGK4svTsWn8FgJa4f5YdseAU6Bg==
X-Google-Smtp-Source: ABdhPJxt6hJIZhrPAeuCxsi2vOtr0t0WV3ZUO4ZdmtozGrzRPf/lzx+vABCcs4j8sDoROTEgfE/ykA==
X-Received: by 2002:a37:b4b:: with SMTP id 72mr3473478qkl.79.1636431086096;
 Mon, 08 Nov 2021 20:11:26 -0800 (PST)
Received: from hurd (dsl-236-125-16.b2b2c.ca. [207.236.125.16])
 by smtp.gmail.com with ESMTPSA id h16sm897497qtx.20.2021.11.08.20.11.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 08 Nov 2021 20:11:25 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN>
Date: Mon, 08 Nov 2021 23:11:22 -0500
In-Reply-To: <87ee7tmdbd.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 06 Nov 2021 17:57:58 +0100")
Message-ID: <87k0hi0xzp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Hi Maxim and all,
>
> Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:
>
>> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
> [...]
>
>>> You seem to be proposing to remove =E2=80=98-D=E2=80=99 altogether.  I =
agree it has the
>>> shortcomings you write, but I think it=E2=80=99s occasionally useful
>>> nonetheless.
>>>
>>> My proposal would be either the status quo, or removing just the one
>>> link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99.
>>
>> The second proposal makes sense.
>
> Maybe that proposal is bogus though because you=E2=80=99d need to know th=
e hash
> of the files being removed, which means reading them=E2=80=A6

Oops :-).

>> I didn't care about freeing space, as my use case was getting around
>> corrupting an item in my store due to
>> https://issues.guix.gnu.org/51400, which the patch proposed here
>> allowed me to do without wasting hours of cleaning up links (nearly 1
>> GiB of store on spinning drives).
>
> The ideal solution as zimoun writes would be to address
> <https://issues.guix.gnu.org/24937>.

Seems there's some improvement ready, but which needs more
testing/measurements?  I'd suggest simply invoking GNU sort; if it has
many pages of program for doing what it does, it's probably doing
something fancier/faster than we can (are ready to) emulate -- for free!

> Perhaps that phase needs to be implemented using a different strategy,
> say an sqlite database that records the current link count (hoping that
> =E2=80=98SELECT * FROM links WHERE NLINKS =3D 1=E2=80=99 would be faster =
than traversing
> all of =E2=80=98.links=E2=80=99) as well as a mapping from store item to =
file hashes.

Hmm.  I'll need to dive in the problem a bit more before I can comment
on this.

> BTW, those using Btrfs can probably use =E2=80=98--disable-deduplication=
=E2=80=99 and be
> done with it.

I erroneously used to think that Btrfs could do live deduplication, but
it doesn't.  There are external tools to do out of band / batch
deduplication though [0]; so if they perform better than the guix daemon's
own dedup, perhaps we could document this way out for our Btrfs users.

[0]  https://btrfs.wiki.kernel.org/index.php/Deduplication

Thank you,

Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Jack Hill <jackhill@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 09 Nov 2021 04:58:01 +0000
Resent-Message-ID: <handler.51427.B51427.163643385015770 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163643385015770
          (code B ref 51427); Tue, 09 Nov 2021 04:58:01 +0000
Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 04:57:30 +0000
Received: from localhost ([127.0.0.1]:60305 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mkJCM-00046H-93
	for submit <at> debbugs.gnu.org; Mon, 08 Nov 2021 23:57:30 -0500
Received: from minsky.hcoop.net ([104.248.1.95]:43350)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jackhill@HIDDEN>) id 1mkJCK-000464-FM
 for 51427 <at> debbugs.gnu.org; Mon, 08 Nov 2021 23:57:28 -0500
Received: from marsh.hcoop.net ([45.55.52.66])
 by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <jackhill@HIDDEN>)
 id 1mkJCF-0006PO-6E; Mon, 08 Nov 2021 23:57:23 -0500
Date: Mon, 8 Nov 2021 23:57:23 -0500 (EST)
From: Jack Hill <jackhill@HIDDEN>
X-X-Sender: jackhill@HIDDEN
In-Reply-To: <87k0hi0xzp.fsf@HIDDEN>
Message-ID: <alpine.DEB.2.21.2111082329280.4243@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN> <87ee7tmdbd.fsf@HIDDEN>
 <87k0hi0xzp.fsf@HIDDEN>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="925712948-286994475-1636433843=:4243"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--925712948-286994475-1636433843=:4243
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Mon, 8 Nov 2021, Maxim Cournoyer wrote:

> Ludovic Courtès <ludo@HIDDEN> writes:
>
>> BTW, those using Btrfs can probably use ‘--disable-deduplication’ and be
>> done with it.
>
> I erroneously used to think that Btrfs could do live deduplication, but
> it doesn't.  There are external tools to do out of band / batch
> deduplication though [0]; so if they perform better than the guix daemon's
> own dedup, perhaps we could document this way out for our Btrfs users.
>
> [0]  https://btrfs.wiki.kernel.org/index.php/Deduplication

A little while ago I had hoped to test btrfs with --disable-deduplication 
and bees [1] as the deduplication agent, but wasn't able to successfully 
run a system with --disable-deduplication because I needed the 
deduplication to cover up problem with grafts [2]. Until we resolve the 
second issue, I don't think we should recommend folks run the daemon with 
--disable-deduplication.

[1] https://issues.guix.gnu.org/47983 (still missing a service)
[2] https://issues.guix.gnu.org/47115

Best,
Jack
--925712948-286994475-1636433843=:4243--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 09 Nov 2021 12:57:02 +0000
Resent-Message-ID: <handler.51427.B51427.163646260527771 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Jack Hill <jackhill@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163646260527771
          (code B ref 51427); Tue, 09 Nov 2021 12:57:02 +0000
Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 12:56:45 +0000
Received: from localhost ([127.0.0.1]:32895 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mkQg9-0007Dq-Hd
	for submit <at> debbugs.gnu.org; Tue, 09 Nov 2021 07:56:45 -0500
Received: from eggs.gnu.org ([209.51.188.92]:47746)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1mkQg7-0007Dc-GV
 for 51427 <at> debbugs.gnu.org; Tue, 09 Nov 2021 07:56:44 -0500
Received: from [2001:470:142:3::e] (port=36972 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mkQg1-0000dx-V5; Tue, 09 Nov 2021 07:56:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=DtO+krCApB3Tnz0Sz/oaGQ7fBcgQ0i8zH446J5TEnsQ=; b=dkITqtRNItK6dw+Ry73v
 Br+KwRa/9BNPdNT/AjbMmX9yH31nnjCllCXYYoc+QJ+K/GOumrEqehgyqhagsTa4JxXWSvimhh4Ly
 TAfLxvdZjI8jU+2q3Vnlec/rsgVgeV6lAHVg+nZ6gOQsxHx1YoOV/J+JSYyjlr43pcYii+Lqx5csb
 9Pin/XNVCzoGmJNTGZCPd9IW0i9O8PsQagK/+sXuy7vU48fPuQpcFuaD8NrUg98I5XkVsdJIslPCH
 XE5Qc0wTlCbHl4sVYWoYoSDgaItWAM2j2PlomYaagZEiffXLjzC+TAPCG8unWdUcjecSAdWEcPK3a
 lpfKXquvG1qQeg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54411
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mkQg1-00027y-Kx; Tue, 09 Nov 2021 07:56:37 -0500
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <87k0hi0xzp.fsf@HIDDEN>
 <alpine.DEB.2.21.2111082329280.4243@HIDDEN>
Date: Tue, 09 Nov 2021 13:56:35 +0100
In-Reply-To: <alpine.DEB.2.21.2111082329280.4243@HIDDEN> (Jack Hill's
 message of "Mon, 8 Nov 2021 23:57:23 -0500 (EST)")
Message-ID: <87lf1xmqrg.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Jack Hill <jackhill@HIDDEN> skribis:

> On Mon, 8 Nov 2021, Maxim Cournoyer wrote:
>
>> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>>
>>> BTW, those using Btrfs can probably use =E2=80=98--disable-deduplicatio=
n=E2=80=99 and be
>>> done with it.
>>
>> I erroneously used to think that Btrfs could do live deduplication, but
>> it doesn't.  There are external tools to do out of band / batch
>> deduplication though [0]; so if they perform better than the guix daemon=
's
>> own dedup, perhaps we could document this way out for our Btrfs users.
>>
>> [0]  https://btrfs.wiki.kernel.org/index.php/Deduplication
>
> A little while ago I had hoped to test btrfs with
> --disable-deduplication and bees [1] as the deduplication agent, but
> wasn't able to successfully run a system with --disable-deduplication
> because I needed the deduplication to cover up problem with grafts
> [2]. Until we resolve the second issue, I don't think we should
> recommend folks run the daemon with --disable-deduplication.
>
> [1] https://issues.guix.gnu.org/47983 (still missing a service)
> [2] https://issues.guix.gnu.org/47115

Oh, right.  We didn=E2=80=99t quite get to the bottom of #2.  Is it still an
issue?  Some questions remained opened.

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 09 Nov 2021 18:13:01 +0000
Resent-Message-ID: <handler.51427.B51427.163648152731758 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163648152731758
          (code B ref 51427); Tue, 09 Nov 2021 18:13:01 +0000
Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 18:12:07 +0000
Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mkVbK-0008G9-Iw
	for submit <at> debbugs.gnu.org; Tue, 09 Nov 2021 13:12:07 -0500
Received: from mail-wr1-f52.google.com ([209.85.221.52]:35512)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1mkVbG-0008FZ-75
 for 51427 <at> debbugs.gnu.org; Tue, 09 Nov 2021 13:12:06 -0500
Received: by mail-wr1-f52.google.com with SMTP id i5so34550724wrb.2
 for <51427 <at> debbugs.gnu.org>; Tue, 09 Nov 2021 10:12:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-transfer-encoding;
 bh=igOMW7/LxyPhnthkg1r8UsoLFc+ken1DuL708ye5DIw=;
 b=jS7YeWdd3Db2zgA8BmAhUD0Zw3ctHI6cP9wv0ovyJOkd6lvOidwK4GLhGAAaJhw3hx
 kQnlTDPp5RKYp4FsxgpKyo8zmdHRh407rrueptMUkVQx6x9Q5Bv00npUBJT9gW7cxzdn
 BFpMHuufsZ9z/13oNzaj3gpLZ1B+WRaEPsw5ktTeNn1Ip9E1z20nvwntoPjygXwuk48z
 R25H3jENatCNWls+jvoS2U97WxQAYq0gJLJ7bIJlvRjvwKWB1g+x0gwHQMlfltCpLI1T
 Go0ZGTKhfltfUeHnEpMn9GqlHGwg+kExHYLuwUHxk4egiSXepPuHd45gBBaD1KnArfLZ
 Lrtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=igOMW7/LxyPhnthkg1r8UsoLFc+ken1DuL708ye5DIw=;
 b=tHikYwKclcOBbDSXvBqqsf5m1UK2H0Qe4JO0TVmL8XRgCqWTmk5rt/rFu4kd/DIonJ
 3Kiqg/hWFvEwxuHnvKJvfdw1kJRQwPDZzkaLSNPY+/Q1XEpGHxoOI3jQxUwAR+YHde+H
 UPS1EASWYxJV+ArtXEx7N3y9GcHpPJhZfCoL+vl9NOI8A9U+07nqI19s1xKT2eTCG6GU
 5QvHTcjqfng//rd0zcEOdrWiyS+VbRN0Tsh75OP3XiMXkxpH97HtEySbz7rqt77ifaLy
 2lRevbZxwv5FVmdjc/Kj+Ev0q5OuLuYrpGvnyrVc1j5jNhhtvdj6QD4A2ylF20Y3SV3i
 yWrQ==
X-Gm-Message-State: AOAM531BrIFRdKrk0ojLevlEXIYDZbIx/CS7ZeTafD2FP93SAYbK9Z3r
 uCpcA17ojZ1JeGK5UuLUvJ8=
X-Google-Smtp-Source: ABdhPJxsmFCrtbPIXzyVmwB9rmi3X6IgTGcvuzywpZ6ve1RcC+g4nhK77YuGKHJSLPRFzzFUAIrS7g==
X-Received: by 2002:adf:fd4c:: with SMTP id h12mr11569851wrs.429.1636481516268; 
 Tue, 09 Nov 2021 10:11:56 -0800 (PST)
Received: from lili (214.13.23.93.rev.sfr.net. [93.23.13.214])
 by smtp.gmail.com with ESMTPSA id f7sm1463301wmg.6.2021.11.09.10.11.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 09 Nov 2021 10:11:55 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
In-Reply-To: <87ee7tmdbd.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN>
Date: Tue, 09 Nov 2021 19:10:27 +0100
Message-ID: <86k0hhnqss.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,

On Sat, 06 Nov 2021 at 17:57, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:

> The ideal solution as zimoun writes would be to address
> <https://issues.guix.gnu.org/24937>.

Cool for your last reply with a plan for mitigating the issue.

Even if the phase is drastically speed up, it would be probably still
too slow when using the option =E2=80=99-D=E2=80=99 remove only one <item>;=
 or just
some.

I have not checked the code, maybe I should start by that. ;-) Is it not
possible to simply skip the deleting phase when the option =E2=80=99-D=E2=
=80=99 is used?


Cheers,
simon

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 17 Nov 2021 10:03:01 +0000
Resent-Message-ID: <handler.51427.B51427.163714335531128 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: zimoun <zimon.toutoune@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163714335531128
          (code B ref 51427); Wed, 17 Nov 2021 10:03:01 +0000
Received: (at 51427) by debbugs.gnu.org; 17 Nov 2021 10:02:35 +0000
Received: from localhost ([127.0.0.1]:60222 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mnHlz-00085y-An
	for submit <at> debbugs.gnu.org; Wed, 17 Nov 2021 05:02:35 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44780)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1mnHlx-00085T-6G
 for 51427 <at> debbugs.gnu.org; Wed, 17 Nov 2021 05:02:34 -0500
Received: from [2001:470:142:3::e] (port=54330 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mnHlr-0006ma-Uq; Wed, 17 Nov 2021 05:02:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=BBcC67BdbkyRGWVq/E75xxK2tt/tZKlxI8TNwKTzqAA=; b=IvvDLeuthw87u61Rn01L
 AUJ/FeZR61ZVrUIbI9cCgi9BDN6Uo9Io8fUTMJsW+AajzLSlubbAXOOw1u9O929yWPGD5sZ0yP+Ws
 wo4azj5VblIqFXus2/ayX6tvH+/GboH9d0UCIPg0XUdSWZcttBJ1bIbV1GSg9iwGhGMT99uMzfTkK
 n6JakGBoNVe+oSMtEj5uwUJCGLT1FBSv5aS1VbOiZMNPqopE5kV042W79YFyK23n1KCvZcTHolMPN
 8HQICmBhrGsD3KXanE3RX/gLL0cVF8CvxgCrJc4A5yLXlGxiVvXAF+v+fa4WqgjFql1a4/sakpKLX
 PcW6KCFiRB9eeA==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:64340
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1mnHlr-00070V-IN; Wed, 17 Nov 2021 05:02:27 -0500
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 27 Brumaire an 230 de la =?UTF-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Wed, 17 Nov 2021 11:02:25 +0100
In-Reply-To: <86k0hhnqss.fsf@HIDDEN> (zimoun's message of "Tue, 09 Nov 2021
 19:10:27 +0100")
Message-ID: <871r3f2j7y.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

zimoun <zimon.toutoune@HIDDEN> skribis:

> I have not checked the code, maybe I should start by that. ;-) Is it not
> possible to simply skip the deleting phase when the option =E2=80=99-D=E2=
=80=99 is used?

No; like I wrote, it would have the effect of not deleting anything:

  https://issues.guix.gnu.org/51427#1

Needs more thought=E2=80=A6

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 17 Nov 2021 11:59:01 +0000
Resent-Message-ID: <handler.51427.B51427.163715033814895 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.163715033814895
          (code B ref 51427); Wed, 17 Nov 2021 11:59:01 +0000
Received: (at 51427) by debbugs.gnu.org; 17 Nov 2021 11:58:58 +0000
Received: from localhost ([127.0.0.1]:60362 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mnJac-0003sB-JN
	for submit <at> debbugs.gnu.org; Wed, 17 Nov 2021 06:58:58 -0500
Received: from mail-wr1-f53.google.com ([209.85.221.53]:46698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1mnJaa-0003rs-Ng
 for 51427 <at> debbugs.gnu.org; Wed, 17 Nov 2021 06:58:57 -0500
Received: by mail-wr1-f53.google.com with SMTP id u1so4119942wru.13
 for <51427 <at> debbugs.gnu.org>; Wed, 17 Nov 2021 03:58:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-transfer-encoding;
 bh=2jRpBQul3Xzshxmjc1Hg0hj0NgrZmXAOKWVANS+TntQ=;
 b=OWzPFFaC+QOUy0qY7hqcVRUbpks5Cnv7I1/PZxR98/In8kEEk8290jL4Se6D4Hkzyn
 thDqpMeKf3G791I+iaPwta6z5wV311JsgV+xtL2yfvnucZB/w7b5Ngdcp1QoCnNiwgCG
 pL4fkcVlZNTDzo4aqNPuYkHWefDvhvvi7QpnQHJdX49sZljv2cEnA866sjCxh+0NfltA
 OM9c7jbeUfoCv2qu5kYB8/OUbvFjWl8BW73XdCASpwGjHGDGFutNimSrfU/Rf91GgPtJ
 Yuy4kajD4HRvA//V/eClpocEUrvMegr+i5VhiSa7vGSD0WvHfOY8wH1e2coRG/c6OONS
 tcTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=2jRpBQul3Xzshxmjc1Hg0hj0NgrZmXAOKWVANS+TntQ=;
 b=TlRmiajUCajTu6+8BKiuMLQ1648sVLLuAb97UeNDPra9GMP5NGUhXDqrhVq36jG2e8
 EYXznn1kgbkTcugNMmvqlTtsILOEbbMjYPWvlW3DkW0LmEJ/E+HGaB0MIW7A9GCBvM83
 IOTh8b7TTqSHElYDFBsU/1sogITo7nXQhBt54TQaVAVo2/MgmHnhUQZYlceV/w5wLjaV
 ec0Uy7T1B9t5+g4pOU0L8PbbRKaZLJlfWbVzkHJKLAcBf9a0hO4gTB9hO8i9xScuuKbN
 pZMik1V8eetr2wR3f2eSa11BbtUGd+hPmdHTMmhA/SjRze6DjBo3dqG/obPoWG+q2jCl
 Vegg==
X-Gm-Message-State: AOAM531SASHL9oHlI9n62oTp2wt/CAXvIasqQkUdbKaJnLIr/HkZu5uY
 +yzZMDsWg+OLjs9l6Gmoff4=
X-Google-Smtp-Source: ABdhPJxysU9QxIfCVlCAfkPpgIadN43xrEVwc3yqPVAu2w2nAcl6AcTrc35Eboarex3j/yLEeKEZHQ==
X-Received: by 2002:adf:e882:: with SMTP id d2mr19618998wrm.389.1637150330718; 
 Wed, 17 Nov 2021 03:58:50 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id h204sm5753278wmh.33.2021.11.17.03.58.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 17 Nov 2021 03:58:50 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
In-Reply-To: <871r3f2j7y.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN>
Date: Wed, 17 Nov 2021 12:49:09 +0100
Message-ID: <867dd7roi2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,

On Wed, 17 Nov 2021 at 11:02, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
> zimoun <zimon.toutoune@HIDDEN> skribis:
>
>> I have not checked the code, maybe I should start by that. ;-) Is it not
>> possible to simply skip the deleting phase when the option =E2=80=99-D=
=E2=80=99 is used?
>
> No; like I wrote, it would have the effect of not deleting anything:

After giving a look at the code, yeah it is not so simple. :-)


>   https://issues.guix.gnu.org/51427#1
>
> Needs more thought=E2=80=A6

The logic is complicated, thus adding this guard=E2=80=A6

--8<---------------cut here---------------start------------->8---
    if (options.maxFreed > 0) {=20=20=20=20=20=20
      /* Clean up the links directory. */
      if (options.action =3D=3D GCOptions::gcDeleteDead || options.action =
=3D=3D GCOptions::gcDeleteSpecific) {
        printMsg(lvlError, format("deleting unused links..."));
        removeUnusedLinks(state);
      }=20=20=20=20=20=20
    }
--8<---------------cut here---------------end--------------->8---

=E2=80=A6is probably dumb.  From my understanding, it should bypass the pha=
se
=E2=80=99removeUnusedLinks=E2=80=99 when using =E2=80=9Cguix gc -D=E2=80=9D=
.  Well, I have not tested
it.


Cheers,
simon

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 13:58:02 +0000
Resent-Message-ID: <handler.51427.B51427.165815266024832 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: zimoun <zimon.toutoune@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165815266024832
          (code B ref 51427); Mon, 18 Jul 2022 13:58:02 +0000
Received: (at 51427) by debbugs.gnu.org; 18 Jul 2022 13:57:40 +0000
Received: from localhost ([127.0.0.1]:51757 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDRFk-0006SS-A8
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 09:57:40 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38316)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oDRFi-0006SD-Nk
 for 51427 <at> debbugs.gnu.org; Mon, 18 Jul 2022 09:57:39 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37974)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDRFd-00032s-G6; Mon, 18 Jul 2022 09:57:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=Drcue0leagmhwvM0GQ47rUPcz7KrvBGFuuRvSQC7ZEA=; b=hfw/5nRgfCgI+6XEjC3t
 rLH+RdvTg3ZVTJ7YM4RnWYqDaSJVtdjGCGfXOl8PRgZc8Z/k1CsfHPvsu0M/k5M8ozWXH4POAobvZ
 /OPRrzpP8OCgwPFNJPQ7kx7BlhtenfbS4Wl9J37kgqs6OVAtgYqmj6izYsnMTi2txxY/E4McmR8GV
 WYJd+wcUX8f9bD8XOcwAtNgX1RG8A5v5Ph68YSnkhPSJgM8qtNI2LP1kKeZOwGPCB2AyApnTX4bf4
 CB9tzE7dZYw2kG9Q8sWg/t1XnxefcdthUGKjf0bFmqrRO7Kqwz9zgVw5wa/J051PgmftCH+ehF3Tn
 Ox0aWHW2E3ex7w==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=40112 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDRFc-0001Rp-9Y; Mon, 18 Jul 2022 09:57:33 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
Date: Mon, 18 Jul 2022 15:57:30 +0200
In-Reply-To: <867dd7roi2.fsf@HIDDEN> (zimoun's message of "Wed, 17 Nov 2021
 12:49:09 +0100")
Message-ID: <87o7xmy14l.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hello,

With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021),
partially fixing <https://issues.guix.gnu.org/24937>, there is hopefully
less pressure to skip the remove-unused-links phase.

Should we close this issue?

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 17:04:01 +0000
Resent-Message-ID: <handler.51427.B51427.165816382211354 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165816382211354
          (code B ref 51427); Mon, 18 Jul 2022 17:04:01 +0000
Received: (at 51427) by debbugs.gnu.org; 18 Jul 2022 17:03:42 +0000
Received: from localhost ([127.0.0.1]:51950 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDU9m-0002x4-5A
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 13:03:42 -0400
Received: from mail-ej1-f65.google.com ([209.85.218.65]:38647)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oDU9i-0002wp-6z
 for 51427 <at> debbugs.gnu.org; Mon, 18 Jul 2022 13:03:40 -0400
Received: by mail-ej1-f65.google.com with SMTP id l23so22438357ejr.5
 for <51427 <at> debbugs.gnu.org>; Mon, 18 Jul 2022 10:03:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=mfR4lT4ipVVMv7wQ5zhlzQYPqKIu1msEtc46UhVS0/o=;
 b=qM8u6SazPr7UDMB1ZrefblwyG+DKnKFISS5pcK+yMne6ru9JCAKaeFI5Cije4eJSna
 SWSMt2yLfcwLkJH6590EfWYesaLf+KrrWc/pmYfyqfl87+c9wQFGuAUDJf6xKnXdezFh
 tbVTIauWzl6omNnTGmvgGOEnrJE74KXlpjWztLmglzZtftd3q6K4wX7snpg4kest4v5R
 g4I3jnUJl9RjX+la/TEtOC4hwyc1fMTeUxvxPwePgoD0BrljwmYgwA1XhA4UF3g9K+L+
 NBFjDka/1et07EimTtSUJBXEZMOmHBtUYpcCjpTnbsCNfPDCx+sEBpPKOy4wKGnnNy09
 QoSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=mfR4lT4ipVVMv7wQ5zhlzQYPqKIu1msEtc46UhVS0/o=;
 b=DZGurdi0OyJvjZ6tKUyLd8F/sx2ijJ21sqbvk8J8x/dgmNED0BieypvCnXX5jmsw6A
 nuju2hRapfM+porCH1e32oC2CvlptrSwIzdM+IEc1oxD0KN4C/WnTq0Czz73SzfOIpR8
 W0tFbwWTqJ9LsXICB70qUsFd96jrKHspw+3qjAHywlYP6HUXYWFqHo+cZbuaqPNhne8H
 9nWyVD6teHm/Bcpp26qKP33Wm/X2nZcdXRwIyk69DbkNN5hEuUXX4uK9aesuh38yCnk0
 VpwI8GHuxAB/rzGdUguCCKIkgdHLm22VpWMAar6iXrw2Eiqf1yHmEe7XbPKLMJSxmDEf
 ixZQ==
X-Gm-Message-State: AJIora8yRu6aXqxEZQ66UJ6qqH7vgL24K677w83Cw4NtYYbDUG6GmOqS
 SsgNVF/2nlb1Xfz1I1r41zg=
X-Google-Smtp-Source: AGRyM1vawT206Q0A4KtU2pTAgiORMaHPB1ECD6W/3EFP0KYNLGwNiKgjjgU9RbcUEDxCgPszR1w7lQ==
X-Received: by 2002:a17:906:5d04:b0:722:f46c:b891 with SMTP id
 g4-20020a1709065d0400b00722f46cb891mr27105767ejt.4.1658163812406; 
 Mon, 18 Jul 2022 10:03:32 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 j26-20020aa7de9a000000b0043a7293a03dsm8878955edv.7.2022.07.18.10.03.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 18 Jul 2022 10:03:31 -0700 (PDT)
Message-ID: <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Mon, 18 Jul 2022 19:03:30 +0200
In-Reply-To: <87o7xmy14l.fsf_-_@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Courtès:
> Hello,
> 
> With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021),
> partially fixing <https://issues.guix.gnu.org/24937>, there is
> hopefully less pressure to skip the remove-unused-links phase.
> 
> Should we close this issue?
As a hard disk user, I'm leaning towards "no".  In fact, I recently
encountered a case where I think I might want to skip it even if not
deleting "specific items".  For context, my machine has troubles with
sudden power outages during builds (courtesy of a certain graphics card
manufacturer), so if one of those happens during `guix package' or
`guix system' invocation, the sanest thing to do is to run `guix gc'
after reboot and retry whatever command I wanted to run.  However,
since I'm not really deleting much here, I'd probably be fine with
accumulating trash and collecting it at a later date.  Deleting unused
links is also something that can on some machines be postponed to a
time when they'd otherwise be idle, though I don't think it matters too
much in the context of CI since the global lock is no longer held at
that point, while the lack of storage is still blocking builds.

Cheers

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 19 Jul 2022 08:35:01 +0000
Resent-Message-ID: <handler.51427.B51427.16582196822426 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16582196822426
          (code B ref 51427); Tue, 19 Jul 2022 08:35:01 +0000
Received: (at 51427) by debbugs.gnu.org; 19 Jul 2022 08:34:42 +0000
Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDigk-0000d3-9s
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 04:34:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46496)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oDigi-0000cr-Pv
 for 51427 <at> debbugs.gnu.org; Tue, 19 Jul 2022 04:34:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60072)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDigd-0008IN-GA; Tue, 19 Jul 2022 04:34:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=ShdcWf6k2+ajdsyZbkaTC4r3oCuahS6eFR234UdLv4s=; b=TVfIZ9PMBuLAUouZ7LyF
 B1leaGllxzg7NH5sO5JTEaVV+Fly6lPeazzYnFDnyzuCrFZU3X6XEGmilNub+NGvpjzLdQ9rlsj1Z
 3zAL9/3L1RH14LYy2KpGxgQ2+aP9lpO6dZUhJ5B4OBRcP0QUqIn5p9DEO6MhOtPSQeOENCenk+ZJ0
 nwBNdIOIc5eWIq01NPaW00DNTL/3L+2rt9bAeoJCjsDgRvfC3iMebt2ob2F93OhkW4i6Jw/MWydh7
 1JeP4iBs2xTTpwyZJ3LQ+XIZqisDKRNklpKA78GaNFVmM3/bYIWhveh3fJ7kbULwJf/qOFNsy7gqY
 bvVbE0YtINXPnQ==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52028 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDigd-0006Ui-2r; Tue, 19 Jul 2022 04:34:35 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Primidi 1 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de =?UTF-8?Q?l'=C3=89pautre?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 19 Jul 2022 10:34:33 +0200
In-Reply-To: <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 (Liliana Marie Prikler's message of "Mon, 18 Jul 2022 19:03:30 +0200")
Message-ID: <87sfmxv6ue.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:

> Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Court=C3=A8s:
>> Hello,
>>=20
>> With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021),
>> partially fixing <https://issues.guix.gnu.org/24937>, there is
>> hopefully less pressure to skip the remove-unused-links phase.
>>=20
>> Should we close this issue?
> As a hard disk user, I'm leaning towards "no".

At the REPL, could you do:

  ,use(ice-9 ftw)
  ,t (length (scandir "/gnu/store/.links"))

?

On my SSD I get:

  $4 =3D 438356
  ;; 24.613712s real time, 10.195698s run time.  1.805636s spent in GC.

This =E2=80=98scandir=E2=80=99 call is a good approximation of the cost of =
the
remove-unused-links phase.

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 19 Jul 2022 18:43:01 +0000
Resent-Message-ID: <handler.51427.B51427.165825617626465 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165825617626465
          (code B ref 51427); Tue, 19 Jul 2022 18:43:01 +0000
Received: (at 51427) by debbugs.gnu.org; 19 Jul 2022 18:42:56 +0000
Received: from localhost ([127.0.0.1]:55142 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDsBM-0006sm-FV
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 14:42:56 -0400
Received: from mail-ed1-f65.google.com ([209.85.208.65]:38458)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oDsBH-0006sX-2p
 for 51427 <at> debbugs.gnu.org; Tue, 19 Jul 2022 14:42:54 -0400
Received: by mail-ed1-f65.google.com with SMTP id m13so10665296edc.5
 for <51427 <at> debbugs.gnu.org>; Tue, 19 Jul 2022 11:42:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=fQhSnKBuF4ErKEQYGDwBUlwsidGnm3cm59Srzb5POms=;
 b=Dd1ZhRL/gKjvo+Tu6+7xjwUTryMn1K/rT2J1FsQibs2eZcxpzPPOLT2yNvU3ehVQpM
 mk7qa+dgp1r5jyR9IUs8bq6zwvEyLMrH+A0bDoDFNKQ2rDSFlIPC+QyjuqPEqXMZd2tb
 Qgqdj8HzMufE9rUVf1a/soFSHaKdLuhmIOey7zaSzfBAZtcTKa4UtoYFVZl5LfS/ZuY2
 +Ne/LyGkjZMTppriLVeOZJ8VHfwnPEkkbPyyi7OyM6RMzXvnxTq3I87zLi5Ia9KuWME+
 ekigjksdQ3Pezx1GDWNBDgxAiLOz0MLeCdmE68b5GLKObVSZeReLm1+sREiJd+YVOjfI
 l/ow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=fQhSnKBuF4ErKEQYGDwBUlwsidGnm3cm59Srzb5POms=;
 b=F+GJhW0cB69KKQjG5VeM4Pro0TgTUiN6TtOkcM4xJtR3r9AzFwXpz0Zb9XaQIBV00x
 Ly2Ga2GXf8IDEba417vJrGeUtYfluuVSsW84/J2mMul2ynWTfsx9CEJ3M2MmLbuA+Z65
 qW7vaXMke/bl73kkMoKg2B2f9RD6LRSjzHInfCBb25dw4dOcTnSIDQ0mWx+FL5CUm1yn
 W8yGDCDjtzC9juBOxiwOwvaYgUsl3TkBWtZas9hnDsJCtoNlg+PcXPyG8YaaLwHkmwsm
 V7rJl55zPAvjTl6TzK1qZvFNGG2ohwU7DFAm9oa9K49gQ6nCqNgFPhUJtYUmcPNbqBR5
 WqMA==
X-Gm-Message-State: AJIora+JiXtYMxgZJYTsUShaudF/kLz9QD5Hatp4m1py4yLs7YtdoFAU
 KfSJSCNN87UJMh1pThQinys=
X-Google-Smtp-Source: AGRyM1tZqFRG5LnZyaAeQEqqBoi19Lb1tFAD5hJNy4eTda1YKC8OPNt6TjusGDM7fft2/l/aW2dBow==
X-Received: by 2002:a05:6402:430f:b0:43a:d521:bda with SMTP id
 m15-20020a056402430f00b0043ad5210bdamr46831751edc.69.1658256163731; 
 Tue, 19 Jul 2022 11:42:43 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 b18-20020a1709063cb200b00722f069fd40sm6929200ejh.159.2022.07.19.11.42.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Jul 2022 11:42:43 -0700 (PDT)
Message-ID: <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Tue, 19 Jul 2022 20:42:42 +0200
In-Reply-To: <87sfmxv6ue.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Dienstag, dem 19.07.2022 um 10:34 +0200 schrieb Ludovic Courtès:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:
> 
> > Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Courtès:
> > > Hello,
> > > 
> > > With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021),
> > > partially fixing <https://issues.guix.gnu.org/24937>, there is
> > > hopefully less pressure to skip the remove-unused-links phase.
> > > 
> > > Should we close this issue?
> > As a hard disk user, I'm leaning towards "no".
> 
> At the REPL, could you do:
> 
>   ,use(ice-9 ftw)
>   ,t (length (scandir "/gnu/store/.links"))
> 
> ?
> 
> On my SSD I get:
> 
>   $4 = 438356
>   ;; 24.613712s real time, 10.195698s run time.  1.805636s spent in GC.
scheme@(guile-user)> ,use (ice-9 ftw)
scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
$1 = 213027
;; 1417.872747s real time, 28.514293s run time.  1.284866s spent in GC.
scheme@(guile-user)> (/ 1417.872747 60)
$2 = 23.63121245

So yeah, assuming that scandir scales linearly, if my store was as big
as yours, I could eat lunch and GC still wouldn't be finished (for
context, lunch breaks in my country are only 30 minutes).

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 19 Jul 2022 19:30:02 +0000
Resent-Message-ID: <handler.51427.B.165825898431139 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, ludo@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
X-Debbugs-Original-Cc: 51427 <at> debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, guix-patches@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.165825898431139
          (code B ref -1); Tue, 19 Jul 2022 19:30:02 +0000
Received: (at submit) by debbugs.gnu.org; 19 Jul 2022 19:29:44 +0000
Received: from localhost ([127.0.0.1]:55190 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDsue-00086B-8d
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 15:29:44 -0400
Received: from lists.gnu.org ([209.51.188.17]:48660)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1oDsuc-000863-FA
 for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 15:29:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33514)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1oDsuc-0005bO-Ai
 for guix-patches@HIDDEN; Tue, 19 Jul 2022 15:29:42 -0400
Received: from tobias.gr ([2a02:c205:2020:6054::1]:51356)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>)
 id 1oDsua-0006pd-5i; Tue, 19 Jul 2022 15:29:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=AE6i+HglaYMZ/
 OUpxzWZuelHjgUeWmi56J1QBWM0V4Q=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=aGr42HW4ouUn+0yzJ3d//yRfGAbvt9VYfMSG7J
 reYJQrlzx7r7IcY6rbOER4BwqYsakVTUHimQfTvGuHJCSGgcFTzRhtcj0/AhyabFlSFI/c
 VMvFWZuRa1E4v+sXU7TyJhe0P8Uj7MuE858vrMtZ7TjUA0f/4WwBr8ww5TYv2YqXX3Yd3t
 lktRr5w2oyZVT87mLTzi5b+aGO2cdd/bancvSgFDA5SOsQx9BEt2DDyG8k/o+nRruJJVV3
 KUIN6CRKtPtyBshaguZ9XO9fkFnjamIAZCY9EmJ7gSA/7YJtvLd4e11T0hqqZSH7/V3xRi
 pDIOMFqAd2iRMYN8etjxc0Xw==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d0db2af7
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Tue, 19 Jul 2022 19:29:33 +0000 (UTC)
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
Date: Tue, 19 Jul 2022 21:25:24 +0200
In-reply-to: <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <877d48lx41@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Liliana Marie Prikler =E5=86=99=E9=81=93=EF=BC=9A
> scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
> $1 =3D 213027
> ;; 1417.872747s real time, 28.514293s run time.  1.284866s spent=20
> in GC.

[=E2=80=A6]

> So yeah, assuming that scandir scales linearly

=E2=80=A6your rotational drive is beyond ridiculously slower than mine (an=
=20
ST1000DM010-2EP102):

athena.tobias.gr:~ =CE=BB echo 3 | sudo tee /proc/sys/vm/drop_caches=20
3
athena.tobias.gr:~ =CE=BB guix repl
[=E2=80=A6]
scheme@(guix-user)> ,use (ice-9 ftw)
scheme@(guix-user)> ,t (length (scandir "/gnu/store/.links"))
$1 =3D 164437
;; 7.081361s real time, 2.569773s run time.  0.199963s spent in=20
   GC.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYtcGHg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15jLUA/RUtMKSluKICEiuL0dauuBZAjb6INZhfjlDq6UM9
o0tLAQC/+FGYEsWJ01hyRbU2KcFGoUXEmN8aGlu7s7Uo9658Cw==
=pcnk
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 19 Jul 2022 19:30:02 +0000
Resent-Message-ID: <handler.51427.B51427.165825898031123 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, ludo@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
X-Debbugs-Original-Cc: 51427 <at> debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, guix-patches@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165825898031123
          (code B ref 51427); Tue, 19 Jul 2022 19:30:02 +0000
Received: (at 51427) by debbugs.gnu.org; 19 Jul 2022 19:29:40 +0000
Received: from localhost ([127.0.0.1]:55186 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDsuZ-00085u-VH
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 15:29:40 -0400
Received: from tobias.gr ([80.241.217.52]:34138)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1oDsuX-00085l-E8
 for 51427 <at> debbugs.gnu.org; Tue, 19 Jul 2022 15:29:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=AE6i+HglaYMZ/
 OUpxzWZuelHjgUeWmi56J1QBWM0V4Q=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=aGr42HW4ouUn+0yzJ3d//yRfGAbvt9VYfMSG7J
 reYJQrlzx7r7IcY6rbOER4BwqYsakVTUHimQfTvGuHJCSGgcFTzRhtcj0/AhyabFlSFI/c
 VMvFWZuRa1E4v+sXU7TyJhe0P8Uj7MuE858vrMtZ7TjUA0f/4WwBr8ww5TYv2YqXX3Yd3t
 lktRr5w2oyZVT87mLTzi5b+aGO2cdd/bancvSgFDA5SOsQx9BEt2DDyG8k/o+nRruJJVV3
 KUIN6CRKtPtyBshaguZ9XO9fkFnjamIAZCY9EmJ7gSA/7YJtvLd4e11T0hqqZSH7/V3xRi
 pDIOMFqAd2iRMYN8etjxc0Xw==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d0db2af7
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Tue, 19 Jul 2022 19:29:33 +0000 (UTC)
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
Date: Tue, 19 Jul 2022 21:25:24 +0200
In-reply-to: <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <877d48lx41@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Liliana Marie Prikler =E5=86=99=E9=81=93=EF=BC=9A
> scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
> $1 =3D 213027
> ;; 1417.872747s real time, 28.514293s run time.  1.284866s spent=20
> in GC.

[=E2=80=A6]

> So yeah, assuming that scandir scales linearly

=E2=80=A6your rotational drive is beyond ridiculously slower than mine (an=
=20
ST1000DM010-2EP102):

athena.tobias.gr:~ =CE=BB echo 3 | sudo tee /proc/sys/vm/drop_caches=20
3
athena.tobias.gr:~ =CE=BB guix repl
[=E2=80=A6]
scheme@(guix-user)> ,use (ice-9 ftw)
scheme@(guix-user)> ,t (length (scandir "/gnu/store/.links"))
$1 =3D 164437
;; 7.081361s real time, 2.569773s run time.  0.199963s spent in=20
   GC.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYtcGHg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15jLUA/RUtMKSluKICEiuL0dauuBZAjb6INZhfjlDq6UM9
o0tLAQC/+FGYEsWJ01hyRbU2KcFGoUXEmN8aGlu7s7Uo9658Cw==
=pcnk
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 21 Jul 2022 09:22:02 +0000
Resent-Message-ID: <handler.51427.B51427.16583952895663 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16583952895663
          (code B ref 51427); Thu, 21 Jul 2022 09:22:02 +0000
Received: (at 51427) by debbugs.gnu.org; 21 Jul 2022 09:21:29 +0000
Received: from localhost ([127.0.0.1]:36724 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oESN6-0001TF-Js
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 05:21:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43332)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oESN5-0001T3-4H
 for 51427 <at> debbugs.gnu.org; Thu, 21 Jul 2022 05:21:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48790)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oESMz-0006Bw-IG; Thu, 21 Jul 2022 05:21:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=OaQQrXxACRGNms3AcH8ZwKaPML6jyNvTEcS1PA4HG4M=; b=cO5T0mgDpXgrg/fpcpUm
 AWPxKurjUbFzw0y1hUzn7o3inbh/207ZHcejjGvJKGKwdAHVD4z+YsFL3XZa0l3IaXuFxtIorEMgq
 PE1Duzk3NpXMHokAyt4JpH6BbKdPOZhR0W1DwLlhxVooekUHJncnNbitnB2+io8MMaSNTOp7rqIXP
 YTvlR+wcmOC5cHK0NIkP/foz0/n4J+RqS0q9c0/7ejtmBhKeCmaLNrhAPwVSn0ncHB3MszMcupmdT
 Kn3PXXZx8OKdaTbaLXKo2yCFdM3Mk2/Z9GYtU27pnTlKD3zKuLK2shRntHeG68GB41kdeke84/uKH
 j9yRYyIMAu9YAQ==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33322 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oESMy-0003yd-Ai; Thu, 21 Jul 2022 05:21:20 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
 <877d48lx41@nckx>
Date: Thu, 21 Jul 2022 11:21:18 +0200
In-Reply-To: <877d48lx41@nckx> (Tobias Geerinckx-Rice's message of "Tue, 19
 Jul 2022 21:25:24 +0200")
Message-ID: <877d46n7n5.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Tobias Geerinckx-Rice <me@HIDDEN> skribis:

> Liliana Marie Prikler =E5=86=99=E9=81=93=EF=BC=9A
>> scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
>> $1 =3D 213027
>> ;; 1417.872747s real time, 28.514293s run time.  1.284866s spent in
>> GC.
>
> [=E2=80=A6]
>
>> So yeah, assuming that scandir scales linearly
>
> =E2=80=A6your rotational drive is beyond ridiculously slower than mine (an
> ST1000DM010-2EP102):
>
> athena.tobias.gr:~ =CE=BB echo 3 | sudo tee /proc/sys/vm/drop_caches 3
> athena.tobias.gr:~ =CE=BB guix repl
> [=E2=80=A6]
> scheme@(guix-user)> ,use (ice-9 ftw)
> scheme@(guix-user)> ,t (length (scandir "/gnu/store/.links"))
> $1 =3D 164437
> ;; 7.081361s real time, 2.569773s run time.  0.199963s spent in    GC.

It=E2=80=99s crazy that there are two orders of magnitude of difference bet=
ween
these two hard disks.

Liliana, is your hard disk old or low-end?

I agree that we should strive to have good performance on that kind of
hardware too, but I don=E2=80=99t know how to get there.

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 21 Jul 2022 18:03:01 +0000
Resent-Message-ID: <handler.51427.B51427.165842657317779 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165842657317779
          (code B ref 51427); Thu, 21 Jul 2022 18:03:01 +0000
Received: (at 51427) by debbugs.gnu.org; 21 Jul 2022 18:02:53 +0000
Received: from localhost ([127.0.0.1]:39040 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEaVg-0004cg-Kv
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 14:02:52 -0400
Received: from mail-ej1-f67.google.com ([209.85.218.67]:45803)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oEaVd-0004cT-I4
 for 51427 <at> debbugs.gnu.org; Thu, 21 Jul 2022 14:02:51 -0400
Received: by mail-ej1-f67.google.com with SMTP id fy29so4409051ejc.12
 for <51427 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 11:02:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=6f2xLilpCIQKj6BENsbs7R8ZpoaGrlcSX2lav9J5Cas=;
 b=aSCGK1FvNV/zc/7MmLGFJwq+ewGZw9I+AxkJNQPv+s9X4xc874e1lBWODz1LzZk//M
 m6szATD/NW+SKYB1fxXMkKtPNmoeSNY6dGC0TKEuTSMeXXCsbZLXkwlN0wu4AUftpsGx
 KgSaYFPUsKf8lLkWnoLIRH+2wnkKDDnk8sFEkUH6wjdw2vNDEmdo4ygNjQhFFjHkwJKY
 lKCvvOnQuu4ArHm/9ZAQ9i/nvIAXEZl78mkcZu8e6jHJWQjrBbGmjnTph8D7RcYvim4A
 GcBrKxY/6S4iPPVp6J1saH+EVhq3Vz9EQy2n5C4hwSVDCEdyGCIO08RJx+y+YOfYfgiK
 6+7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=6f2xLilpCIQKj6BENsbs7R8ZpoaGrlcSX2lav9J5Cas=;
 b=kOEcTwqLm5iI9jR0cenFspKU+k0OM7QLQGNYw1Q8a9SXTWC5Q/Dr9OZaGte9MYJpsd
 uhLixhdVN8ksHQzlRoxCsOwAifV4A1La40R7hThHo+eM2/KhD3t9bc5EsOtwcos0L34s
 cel1JDfM/kWVdyHK7QwyxUZKz1j6gp+ew8QF4FkfGtiScqjKGu2OkQpE1DNOUR1pMMlL
 18QCdMmLKditXCj//HfSdeg2xuIB75TAQmkf2uHCm2zp7peDk5V7mRsE/OlBasVjMn0m
 N+1NpXzx2fpU9CfXcElynH0ktMykjFUMLeL1fZ9PJ7gITLlnTfg1x5uP7w1w5vVuB2f1
 ZKVQ==
X-Gm-Message-State: AJIora8I8WtGHwr/9E3CiyTh9L9ipafRwdEA2flHIDIC3BB/xLc6ulVm
 ZhASl91qauPW0ritMgM38bI=
X-Google-Smtp-Source: AGRyM1vYMODW3+DFiYr/NdNJQqnyRwFLYBW0+GCnrvvV0uE7NctSHv91XDbOSGgeut/wyqAUo/mRmQ==
X-Received: by 2002:a17:907:2dab:b0:72f:f7:bdd6 with SMTP id
 gt43-20020a1709072dab00b0072f00f7bdd6mr30834465ejc.330.1658426562574; 
 Thu, 21 Jul 2022 11:02:42 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 c6-20020a056402100600b00435651c4a01sm1365336edu.56.2022.07.21.11.02.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 11:02:42 -0700 (PDT)
Message-ID: <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Thu, 21 Jul 2022 20:02:41 +0200
In-Reply-To: <877d46n7n5.fsf_-_@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
 <877d48lx41@nckx> <877d46n7n5.fsf_-_@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Donnerstag, dem 21.07.2022 um 11:21 +0200 schrieb Ludovic Courtès:
> Hi,
> 
> Tobias Geerinckx-Rice <me@HIDDEN> skribis:
> 
> > Liliana Marie Prikler 写道：
> > > scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
> > > $1 = 213027
> > > ;; 1417.872747s real time, 28.514293s run time.  1.284866s spent
> > > in
> > > GC.
> > 
> > […]
> > 
> > > So yeah, assuming that scandir scales linearly
> > 
> > …your rotational drive is beyond ridiculously slower than mine (an
> > ST1000DM010-2EP102):
> > 
> > athena.tobias.gr:~ λ echo 3 | sudo tee /proc/sys/vm/drop_caches 3
> > athena.tobias.gr:~ λ guix repl
> > […]
> > scheme@(guix-user)> ,use (ice-9 ftw)
> > scheme@(guix-user)> ,t (length (scandir "/gnu/store/.links"))
> > $1 = 164437
> > ;; 7.081361s real time, 2.569773s run time.  0.199963s spent in   
> > GC.
> 
> It’s crazy that there are two orders of magnitude of difference
> between these two hard disks.
> 
> Liliana, is your hard disk old or low-end?
I'm not too sure about age, but it's probably low-end in terms of
speed.  There's room for 2TB data after all.

> I agree that we should strive to have good performance on that kind
> of hardware too, but I don’t know how to get there.
I don't think deleting links will ever be fast on that disk.  But what
I've been saying the whole time is that I don't always need the links
deleted.  I think adding "expert" switches to skip these phases might
actually be enough – after all, if I ever do want to run a full GC, the
information ought to be the same, no?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 Jul 2022 12:15:02 +0000
Resent-Message-ID: <handler.51427.B51427.16584920684838 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.16584920684838
          (code B ref 51427); Fri, 22 Jul 2022 12:15:02 +0000
Received: (at 51427) by debbugs.gnu.org; 22 Jul 2022 12:14:28 +0000
Received: from localhost ([127.0.0.1]:40335 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oErY4-0001Fy-1C
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 08:14:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40340)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oErY1-0001Fi-H6
 for 51427 <at> debbugs.gnu.org; Fri, 22 Jul 2022 08:14:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37264)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oErXt-0002h2-Va; Fri, 22 Jul 2022 08:14:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=qmrou6Z7bEzXjlHwPEFWsZOTexZ0JarxZb3WbsVTZNE=; b=hnffnU3Hz3WgV3urnTUi
 joGO5qH3h5LxNNhumNagSviyHkc7j3S7oJujos1tTEZckMQsLbmskNMoC3YWcop2H2Op1jTjhYJ6l
 NSdU5J/I/yIT2Nx0Q1b5orSa9SP5pjXzXbDIalJHH9GuLM5qjRfvosQiGfYyOzUz8WmfXcr9pFRh3
 0VDydm/9mGOoRHrgMlAJOH3Y+j2mtyRnduXL0MqZuQG5TkrhdhCQzTd7z2rbb6Jm/79TjezSU3V6R
 XHC1WX8tVhJNTfOlmdHa5fQ1qMoJar0VDxQaoanzxe0Qu+/NPFFhz1f7VKHvCJZIZgn6wo91GEhK5
 LwQRd54NZMPi7g==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38506 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oErXt-0008Sw-HY; Fri, 22 Jul 2022 08:14:17 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
 <877d48lx41@nckx> <877d46n7n5.fsf_-_@HIDDEN>
 <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Quartidi 4 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Ivraie
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 22 Jul 2022 14:14:14 +0200
In-Reply-To: <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
 (Liliana Marie Prikler's message of "Thu, 21 Jul 2022 20:02:41 +0200")
Message-ID: <87ilnpibu1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:

> I don't think deleting links will ever be fast on that disk.  But what
> I've been saying the whole time is that I don't always need the links
> deleted.  I think adding "expert" switches to skip these phases might
> actually be enough =E2=80=93 after all, if I ever do want to run a full G=
C, the
> information ought to be the same, no?=20

The expert will have to know that skipping that phase will have the
effect of *not* freeing space on the device, so=E2=80=A6

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 Jul 2022 13:40:02 +0000
Resent-Message-ID: <handler.51427.B51427.165849716014412 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165849716014412
          (code B ref 51427); Fri, 22 Jul 2022 13:40:02 +0000
Received: (at 51427) by debbugs.gnu.org; 22 Jul 2022 13:39:20 +0000
Received: from localhost ([127.0.0.1]:40446 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEssC-0003kO-4l
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:39:20 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:34510)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1oEss9-0003kC-J9
 for 51427 <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:39:18 -0400
Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]
 ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16])
 by laurent.telenet-ops.be with bizsmtp
 id yDfD2700120ykKC01DfEmG; Fri, 22 Jul 2022 15:39:15 +0200
Message-ID: <4b81f06f-3e89-5a33-ae30-1710e447f849@HIDDEN>
Date: Fri, 22 Jul 2022 15:39:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN> <87ee7tmdbd.fsf@HIDDEN>
 <86k0hhnqss.fsf@HIDDEN> <871r3f2j7y.fsf@HIDDEN>
 <867dd7roi2.fsf@HIDDEN> <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN> <877d48lx41@nckx>
 <877d46n7n5.fsf_-_@HIDDEN>
 <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
 <87ilnpibu1.fsf@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
In-Reply-To: <87ilnpibu1.fsf@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ACUVo004QgkJizK09nIr3V1Y"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1658497155; bh=5HT3YYZ4BRqneo6N3NByGVuu18swYsyZB2wRq3/73e0=;
 h=Date:To:Cc:References:From:Subject:In-Reply-To;
 b=X08e7jMMcEffCtA7ssbH8TuocMLW0xLZ7zsRbw9xMvgzdpmUnQ12QnQ1V6FtNq6ih
 5UiExaRPeZbfJoGLGhAVhgq4TxOkvoNuNmJB5eMIQ3XNSpO5lI91N5zbY8wMyNtzEx
 HvKPBf9ZB92C6BMSQl8B51RahdfIdikIoyA5FysUVJYcJiDYIVTeuiul0fIVs59D4l
 iubH1hGpIjzUFpXsBFug+UqDYssm+6T9MjVac6Y7Po9LbDygHGmdvhYgtru1dm+zCV
 a1r7wiJlEk7XDBK/Nns640Q7yjw6dty2VwogTJtC84GLRHSqFW+O9rTwbIeY3U/hg0
 KpkTBZ+4yVfww==
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ACUVo004QgkJizK09nIr3V1Y
Content-Type: multipart/mixed; boundary="------------OvQG20pyzt0HL7SMs0kZ52xg";
 protected-headers="v1"
From: Maxime Devos <maximedevos@HIDDEN>
To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= <ludo@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>,
 maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Message-ID: <4b81f06f-3e89-5a33-ae30-1710e447f849@HIDDEN>
Subject: Re: [bug#51427] [PATCH] nix: libstore: Do not remove unused links
 when deleting specific items.
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN> <87ee7tmdbd.fsf@HIDDEN>
 <86k0hhnqss.fsf@HIDDEN> <871r3f2j7y.fsf@HIDDEN>
 <867dd7roi2.fsf@HIDDEN> <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN> <877d48lx41@nckx>
 <877d46n7n5.fsf_-_@HIDDEN>
 <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
 <87ilnpibu1.fsf@HIDDEN>
In-Reply-To: <87ilnpibu1.fsf@HIDDEN>

--------------OvQG20pyzt0HL7SMs0kZ52xg
Content-Type: multipart/mixed; boundary="------------SfdoER7oWCxvW92wZ0mqTahK"

--------------SfdoER7oWCxvW92wZ0mqTahK
Content-Type: multipart/alternative;
 boundary="------------0b4sugD09ohCYJ8CicKZrorY"

--------------0b4sugD09ohCYJ8CicKZrorY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

DQpPbiAyMi0wNy0yMDIyIDE0OjE0LCBMdWRvdmljIENvdXJ0w6hzIHdyb3RlOg0KPiBIaSwN
Cj4NCj4gTGlsaWFuYSBNYXJpZSBQcmlrbGVyPGxpbGlhbmEucHJpa2xlckBnbWFpbC5jb20+
ICBza3JpYmlzOg0KPg0KPj4gSSBkb24ndCB0aGluayBkZWxldGluZyBsaW5rcyB3aWxsIGV2
ZXIgYmUgZmFzdCBvbiB0aGF0IGRpc2suICBCdXQgd2hhdA0KPj4gSSd2ZSBiZWVuIHNheWlu
ZyB0aGUgd2hvbGUgdGltZSBpcyB0aGF0IEkgZG9uJ3QgYWx3YXlzIG5lZWQgdGhlIGxpbmtz
DQo+PiBkZWxldGVkLiAgSSB0aGluayBhZGRpbmcgImV4cGVydCIgc3dpdGNoZXMgdG8gc2tp
cCB0aGVzZSBwaGFzZXMgbWlnaHQNCj4+IGFjdHVhbGx5IGJlIGVub3VnaCDigJMgYWZ0ZXIg
YWxsLCBpZiBJIGV2ZXIgZG8gd2FudCB0byBydW4gYSBmdWxsIEdDLCB0aGUNCj4+IGluZm9y
bWF0aW9uIG91Z2h0IHRvIGJlIHRoZSBzYW1lLCBubz8NCj4gVGhlIGV4cGVydCB3aWxsIGhh
dmUgdG8ga25vdyB0aGF0IHNraXBwaW5nIHRoYXQgcGhhc2Ugd2lsbCBoYXZlIHRoZQ0KPiBl
ZmZlY3Qgb2YgKm5vdCogZnJlZWluZyBzcGFjZSBvbiB0aGUgZGV2aWNlLCBzb+KApg0KDQpJ
IGJlbGlldmUgdGhlIHdvcmQgImV4cGVydCIgaW1wbGllcyB0aGF0IHRoZSBleHBlcnQga25v
d3MgdGhhdCwgDQpvdGhlcndpc2UgdGhleSBhcmUsIGJ5IGRlZmluaXRpb24sIG5vdCBhbiBl
eHBlcnQsIHNvIEkgZG9uJ3Qgc2VlIHlvdXIgDQpwb2ludC4gU28gLi4uIHdoYXQgZG9lcyB0
aGUgLi4uIGFmdGVyIHRoZSAnc28nIGhpZGUgaGVyZT8gSSBkb24ndCANCnVuZGVyc3RhbmQg
d2hhdCBwb2ludCB5b3UgYXJlIHRyeWluZyB0byBtYWtlIGhlcmUuDQoNClRoZSBpZGVhIGlz
IHRvLCB3aGVuIGRlbGV0aW5nIHNwZWNpZmljIGl0ZW1zLCBqdXN0IGRvIHRoYXQsIGFuZCBu
b3QgDQpzdGFydCBpdGVyYXRpbmcgb3ZlciBhbGwgKCopIHRoZSBvdGhlciB0aGluZ3MgaW4g
dGhlIHN0b3JlLg0KDQpUaGlzIGlzIGltcG9ydGFudCBmb3IsIHNheSwgdGVzdGluZyBzdWJz
dGl0dXRpb24gY29kZSBlZmZpY2llbnRseSAob3IgDQpTV0ggY29kZSBhcyBtZW50aW9uZWQg
cHJldmlvdXNseSwgZXRjKS4NCg0KVGhlcmUsIHRoZSBsYWNrIG9mIGZyZWVpbmcgc3BhY2Ug
aXMgbm90IGEgY29uY2Vybi7CoCBUaGlzIGFwcGVhcnMsIGFmdGVyIA0KcmVhZGluZyBkZWJi
dWdzLCB0byBiZSBhbHJlYWR5IG1lbnRpb25lZCBhdCANCmh0dHBzOi8vZGViYnVncy5nbnUu
b3JnL2NnaS9idWdyZXBvcnQuY2dpP2J1Zz01MTQyNyMyMC4NCg0KTWF5YmUgc29tZXRoaW5n
IHRoYXQgd291bGQgYmUgYWNjZXB0YWJsZSB0byBhbGwgcGFydGllczogV2hlbiBkZWxldGlu
ZyANCnNwZWNpZmljIHN0b3JlIGl0ZW1zLCBkb24ndCByZW1vdmUgX2FsbF8gdGhlIHVudXNl
ZCBsaW5rcywgYnV0IG9ubHkgDQpyZW1vdmUgdGhlIHVudXNlZCBsaW5rcyB0aGF0IGNvcnJl
c3BvbmQgdG8gZGVsZXRlZCBmaWxlcy4gV2hpY2ggYWZ0ZXIgDQpyZWFkaW5nIDUxNDI3IGFw
cGVhcnMgdG8gYWxyZWFkeSBoYXZlIGJlZW4gcHJvcG9zZWQuDQoNCj4gTWF5YmUgdGhhdCBw
cm9wb3NhbCBpcyBib2d1cyB0aG91Z2ggYmVjYXVzZSB5b3XigJlkIG5lZWQgdG8ga25vdyB0
aGUgaGFzaA0KPiBvZiB0aGUgZmlsZXMgYmVpbmcgcmVtb3ZlZCwgd2hpY2ggbWVhbnMgcmVh
ZGluZyB0aGVt4oCmDQpJIGRvbid0IHNlZSB0aGUgcHJvYmxlbSAtLSB3aGVuIGRlbGV0aW5n
IGEgc3BlY2lmaWMgc3RvcmUgaXRlbSwgcmVhZCB0aGUgDQpmaWxlcyBvbmUtYnktb25lLCBo
YXNoIHRoZW0gb25lLWJ5LW9uZSwgYW5kIGRlbGV0ZSB0aGUgbGluayBpZiBhcHByb3ByaWF0
ZS4NCg0KID4gVGhpbmdzIGFib3V0IGh0dHBzOi8vZGViYnVncy5nbnUub3JnL2NnaS9idWdy
ZXBvcnQuY2dpP2J1Zz0yNDkzNyANCmxlc3NlbmluZyB0aGUgbmVlZA0KDQpTdXJlLCBidXQg
YXMgaW5mb3JtYWxseSBtZW50aW9uZWQgYnksIHNheSwgTGlsaWFuYSwgZXZlbiBhZnRlciB0
aGF0IA0KdGhpbmdzIHJlbWFpbiB+IE8obikgKG9yIHByb2JhYmx5IE8obiBsZyBuKSBpZiB0
aGUgZmlsZSBzeXN0ZW0gdXNlcyBzb21lIA0KdHJlZSBzdHJ1Y3R1cmUpIHdoZXJlIG49c2l6
ZSBvZiB0aGUgc3RvcmUsIHdoaWNoIGluIGFueSByZWFsaXN0aWMgDQpzaXR1YXRpb24gaXMg
Z29pbmcgdG8gYmUgd2F5IHNsb3dlciB0aGFuIE8obSksIHdoZXJlIG0gPSB0aGUgbnVtYmVy
IG9mIA0KaW5kaXZpZHVhbCBzdG9yZSBpdGVtcyB0byBkZWxldGUsIGZvciByZWFzb25hYmxl
IGltcGxlbWVudGF0aW9ucyBvZiANCiJkZWxldGUgaW5kaXZpZHVhbCBzdG9yZSBpdGVtIi4g
KCopDQoNClRoZSBwb2ludCBpc24ndCB0byB3b3JrLWFyb3VuZCBzbG93ICJkZWxldGluZyB1
bnVzZWQgbGlua3MiIA0KaW1wbGVtZW50YXRpb24sIGJ1dCByYXRoZXIgdG8gYXZvaWQgaW5o
ZXJpdCBzbG93bmVzcyBvZiBkZWxldGluZyANCmV2ZXJ5dGhpbmcgd2hlbiBkZWxldGluZyBh
IGZldyB0aGluZ3Mgc3VmZmljZS4NCg0KU3VtbWFyaXNlZCwgSSBkb24ndCB1bmRlcnN0YW5k
IHRoZSByZWx1Y3RhbmNlIHRvIG1lcmdlIGFuIGltcGxlbWVudGF0aW9uIA0Kb2YgImRlbGV0
ZSBpbmRpdmlkdWFsIHN0b3JlIGl0ZW0iIC0tIHllcywgdGhlIGRlbGV0ZSBsaW5rIHBoYXNl
IGlzIHNsb3cgDQphbmQgY291bGQgcG9zc2libHkgYmUgaW1wcm92ZWQsIHllcyB3aGVuIHVz
aW5nIGNlcnRhaW4gaW1wbGVtZW50YXRpb25zIA0KdmVyeSBsaXR0bGUgZGlzayBpcyBmcmVl
ZCwgYnV0IHRob3NlIGFyZW4ndCB0aGUgcG9pbnQgb2YgdGhlIHBhdGNoIA0KQUZBSUNULCB0
aGV5IGFyZSBvcnRob2dvbmFsIGNvbmNlcm5zLg0KDQpHcmVldGluZ3MsDQpNYXhpbWUuDQoN
CigqKSBZZXMsIEknbSBuZWdsZWN0aW5nIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gbnVtYmVy
IG9mIHN0b3JlIGl0ZW1zIGFuZCANCmxpbmtzIGFuZCBzaXplIG9mIHN0b3JlIGl0ZW1zIGhl
cmUsIGJ1dCB0aG9zZSBkb24ndCBtYWtlIGEgZGlmZmVyZW5jZSB0byANCnRoZSBjb25jbHVz
aW9uIGhlcmUuDQoNCg==
--------------0b4sugD09ohCYJ8CicKZrorY
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html>
  <head>
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF=
-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class=3D"moz-cite-prefix">On 22-07-2022 14:14, Ludovic Court=C3=A8=
s
      wrote:<br>
    </div>
    <blockquote type=3D"cite" cite=3D"mid:87ilnpibu1.fsf@HIDDEN">
      <pre class=3D"moz-quote-pre" wrap=3D"">Hi,

Liliana Marie Prikler <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:l=
iliana.prikler@HIDDEN">&lt;liliana.prikler@HIDDEN&gt;</a> skribis:

</pre>
      <blockquote type=3D"cite">
        <pre class=3D"moz-quote-pre" wrap=3D"">I don't think deleting lin=
ks will ever be fast on that disk.  But what
I've been saying the whole time is that I don't always need the links
deleted.  I think adding "expert" switches to skip these phases might
actually be enough =E2=80=93 after all, if I ever do want to run a full G=
C, the
information ought to be the same, no?=20
</pre>
      </blockquote>
      <pre class=3D"moz-quote-pre" wrap=3D"">
The expert will have to know that skipping that phase will have the
effect of *not* freeing space on the device, so=E2=80=A6
</pre>
    </blockquote>
    <p>I believe the word "expert" implies that the expert knows that,
      otherwise they are, by definition, not an expert, so I don't see
      your point. So ... what does the ... after the 'so' hide here? I
      don't understand what point you are trying to make here.<br>
    </p>
    <p>The idea is to, when deleting specific items, just do that, and
      not start iterating over all (*) the other things in the store.</p>=

    <p>This is important for, say, testing substitution code efficiently
      (or SWH code as mentioned previously, etc).</p>
    <p>There, the lack of freeing space is not a concern.=C2=A0 This appe=
ars,
      after reading debbugs, to be already mentioned at
      <a class=3D"moz-txt-link-freetext" href=3D"https://debbugs.gnu.org/=
cgi/bugreport.cgi?bug=3D51427#20">https://debbugs.gnu.org/cgi/bugreport.c=
gi?bug=3D51427#20</a>.<br>
    </p>
    <p>Maybe something that would be acceptable to all parties: When
      deleting specific store items, don't remove _all_ the unused
      links, but only remove the unused links that correspond to deleted
      files. Which after reading 51427 appears to already have been
      proposed.</p>
    <p>
      <blockquote type=3D"cite">
        <pre class=3D"message">Maybe that proposal is bogus though becaus=
e you=E2=80=99d need to know the hash
of the files being removed, which means reading them=E2=80=A6</pre>
      </blockquote>
      I don't see the problem -- when deleting a specific store item,
      read the files one-by-one, hash them one-by-one, and delete the
      link if appropriate.</p>
    <p>&gt; Things about
      <a class=3D"moz-txt-link-freetext" href=3D"https://debbugs.gnu.org/=
cgi/bugreport.cgi?bug=3D24937">https://debbugs.gnu.org/cgi/bugreport.cgi?=
bug=3D24937</a> lessening the
      need</p>
    <p>Sure, but as informally mentioned by, say, Liliana, even after
      that things remain ~ O(n) (or probably O(n lg n) if the file
      system uses some tree structure) where n=3Dsize of the store, which=

      in any realistic situation is going to be way slower than O(m),
      where m =3D the number of individual store items to delete, for
      reasonable implementations of "delete individual store item". (*)<b=
r>
    </p>
    <p>The point isn't to work-around slow "deleting unused links"
      implementation, but rather to avoid inherit slowness of deleting
      everything when deleting a few things suffice.</p>
    <p>Summarised, I don't understand the reluctance to merge an
      implementation of "delete individual store item" -- yes, the
      delete link phase is slow and could possibly be improved, yes when
      using certain implementations very little disk is freed, but those
      aren't the point of the patch AFAICT, they are orthogonal
      concerns.<br>
    </p>
    <p>Greetings,<br>
      Maxime.</p>
    <p>(*) Yes, I'm neglecting the difference between number of store
      items and links and size of store items here, but those don't make
      a difference to the conclusion here.<br>
    </p>
  </body>
</html>

--------------0b4sugD09ohCYJ8CicKZrorY--

--------------SfdoER7oWCxvW92wZ0mqTahK
Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc"
Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m
xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2
ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL
CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc
/gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4
LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C
kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK
CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W
ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ
Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0
k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo
AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE
fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D
=3DOVqp
-----END PGP PUBLIC KEY BLOCK-----

--------------SfdoER7oWCxvW92wZ0mqTahK--

--------------OvQG20pyzt0HL7SMs0kZ52xg--

--------------ACUVo004QgkJizK09nIr3V1Y
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYtqogAUDAAAAAAAKCRBJ4+4iGRcl7jFU
AP9e6n9FHLvCAs98yaJhJFIJfPYLLxFDzKjx+1vgecY7fAD9G0EiPA0ZM3YBDznFPQvMeskZxUqB
VJHIZLlO0ApenQQ=
=fDe6
-----END PGP SIGNATURE-----

--------------ACUVo004QgkJizK09nIr3V1Y--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 22 Jul 2022 23:08:02 +0000
Resent-Message-ID: <handler.51427.B51427.165853124320269 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165853124320269
          (code B ref 51427); Fri, 22 Jul 2022 23:08:02 +0000
Received: (at 51427) by debbugs.gnu.org; 22 Jul 2022 23:07:23 +0000
Received: from localhost ([127.0.0.1]:42708 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oF1jv-0005Gq-9T
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 19:07:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:42768)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oF1jr-0005Gd-W6
 for 51427 <at> debbugs.gnu.org; Fri, 22 Jul 2022 19:07:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54878)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oF1jl-0002MY-3K; Fri, 22 Jul 2022 19:07:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=cAE+f0Ta7GtB99ohwfiqcNLupYAgryi3fdHTd7hPma0=; b=gCfGskav3I5rm2OXRltd
 aoVcwiLFt7ks2gMSRNHZvh9J5eOHJi7B3Lq7wj3wUTEw0/NKgfyCj1f4/EqCP6CXqp+C0LdEFmrWn
 TEh4dUPU+1Wz4beCYNMNSfc9+6vrgG6FoUwoIGXd+j/aecwa501WcyNnxK3kjyJaS5/V8I0TLQU2R
 Nl12TXcwJKMO1+C1O1HOWg33R7nhArH2Y3GEpYxie+HItkFJxuDr/xEGxS24F4E0qFrIQxZprvrUU
 88FwkUhU1pJCfoGjI0l9Vx9IFhT0vbOAQTIhAxzsfvRoVSOBC8GzKvAgVOFos2h11ATzCjFxhelZd
 RcXBjvaihaLcFQ==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53610
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oF1jk-0005Xs-NA; Fri, 22 Jul 2022 19:07:12 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
 <877d48lx41@nckx> <877d46n7n5.fsf_-_@HIDDEN>
 <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
 <87ilnpibu1.fsf@HIDDEN>
 <4b81f06f-3e89-5a33-ae30-1710e447f849@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Quintidi 5 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour du =?UTF-8?Q?B=C3=A9lier?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sat, 23 Jul 2022 01:07:10 +0200
In-Reply-To: <4b81f06f-3e89-5a33-ae30-1710e447f849@HIDDEN> (Maxime Devos's
 message of "Fri, 22 Jul 2022 15:39:12 +0200")
Message-ID: <874jz8eogx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Maxime Devos <maximedevos@HIDDEN> skribis:

> On 22-07-2022 14:14, Ludovic Court=C3=A8s wrote:
>> Hi,
>>
>> Liliana Marie Prikler<liliana.prikler@HIDDEN>  skribis:
>>
>>> I don't think deleting links will ever be fast on that disk.  But what
>>> I've been saying the whole time is that I don't always need the links
>>> deleted.  I think adding "expert" switches to skip these phases might
>>> actually be enough =E2=80=93 after all, if I ever do want to run a full=
 GC, the
>>> information ought to be the same, no?
>> The expert will have to know that skipping that phase will have the
>> effect of *not* freeing space on the device, so=E2=80=A6
>
> I believe the word "expert" implies that the expert knows that,

Apologies for being elliptic.  My point here, as has been discussed
earlier in this thread, is that we can=E2=80=99t just skip that phase or we=
=E2=80=99d
simply leave files around without actually deleting them.

Thus, a command-line switch to skip the phase doesn=E2=80=99t seem valuable=
 to
me because it=E2=80=99d let users run the GC in a way that doesn=E2=80=99t =
actually
collect garbage.

I hope this is clearer!

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 23 Jul 2022 06:53:01 +0000
Resent-Message-ID: <handler.51427.B51427.165855917031947 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>
Cc: 51427 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me@HIDDEN>, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN
Received: via spool by 51427-submit <at> debbugs.gnu.org id=B51427.165855917031947
          (code B ref 51427); Sat, 23 Jul 2022 06:53:01 +0000
Received: (at 51427) by debbugs.gnu.org; 23 Jul 2022 06:52:50 +0000
Received: from localhost ([127.0.0.1]:43042 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oF90M-0008JA-6G
	for submit <at> debbugs.gnu.org; Sat, 23 Jul 2022 02:52:50 -0400
Received: from mail-ed1-f66.google.com ([209.85.208.66]:35803)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oF90K-0008It-8z
 for 51427 <at> debbugs.gnu.org; Sat, 23 Jul 2022 02:52:48 -0400
Received: by mail-ed1-f66.google.com with SMTP id e15so8096193edj.2
 for <51427 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 23:52:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=YiBjDBznBy6nkk17IcnxVdxzcg2FqeIAB/dAu2g/zlY=;
 b=nIHj7dHiRxnHzcc5tXhivJuvgdBPFlt2kGY/DBNJ+HcjWUGussioApIPW2odNh3XVQ
 /NUpdTD1iqX7eLRAsTdXtgcNSAU5uFSfDqWH9yLKKqTK//lSePtihbFz6JQNUILW2TZz
 1l4Qdt9aUszgixW38iGqWUAY0Q2LcYt7fNShxmWdMUSj93ziKhaJsIiJyDWyDkts4yoB
 RloKS5QRvp8zy2dbcU7z18+iaJyUd7XYhhxWi5cSAxxJEBNOGxuAk9MxCO76nmANq0uX
 RJxOpDZ9z0i4GlVrKyXuCp/xfhzkTylayVbZX8RnkhDIx9OiMHcXWuRGsERtAbvI8w2E
 rSaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=YiBjDBznBy6nkk17IcnxVdxzcg2FqeIAB/dAu2g/zlY=;
 b=2P8IrCvsvivezj+wVcrwjCjmLFOSFpQYXICHkhP5WjZXuMBpgcoFZL5H16Wu91c8FH
 tfhg7cQbhasuyf0u90HVCmEPsjHR7RgdtIbc4kgFvW65ucBHewjEFQBtcc3xpAMb8spV
 s0X54KUVI1HyGrYCJL8MzCa0ZLhoj0CsbsSJtQ9W+PrbWrSFMRj6Yqz8/vato2l/omHO
 gwEQm7VYdLhdbkRZt8C9c2OdZI10miFnpvKb3lqqmZMDQsR7Pmo4upt5AGK7tM6/z+YL
 dnuN4nKb25IKJJwnkwrq9afExkHvxOsMAPpkki/HS7WbmhbVZ/8nLzoM4UyS7uxWw0fQ
 16YA==
X-Gm-Message-State: AJIora8tyfr4T1lwIWAh3hQ1GtuQiaBkN2nXuas5f/yUPfWNw6Yd385w
 O8a9iqTF3I2ZgQEodGBpTqU=
X-Google-Smtp-Source: AGRyM1uf4q9aojWUXBYi+5Ls9D1R2dZUKR+r3P9tJkXtFdSHP6ovpEoA7XcDpUA2EqNAYDg5/IDJsw==
X-Received: by 2002:a05:6402:1767:b0:43b:a844:14f with SMTP id
 da7-20020a056402176700b0043ba844014fmr3214075edb.131.1658559162233; 
 Fri, 22 Jul 2022 23:52:42 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 ga2-20020a170906b84200b00724261b592esm2798272ejb.186.2022.07.22.23.52.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 23:52:41 -0700 (PDT)
Message-ID: <dc0a9584b5248816ccd7d146b9d6b12417a1b688.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sat, 23 Jul 2022 08:52:40 +0200
In-Reply-To: <874jz8eogx.fsf@HIDDEN>
References: <20211027034918.4591-1-maxim.cournoyer@HIDDEN>
 <87o8795j61.fsf@HIDDEN>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@HIDDEN>
 <87h7cxp9tl.fsf@HIDDEN> <87sfwg7w9z.fsf@HIDDEN>
 <87ee7tmdbd.fsf@HIDDEN> <86k0hhnqss.fsf@HIDDEN>
 <871r3f2j7y.fsf@HIDDEN> <867dd7roi2.fsf@HIDDEN>
 <87o7xmy14l.fsf_-_@HIDDEN>
 <2441c768fea8faee800947a17aef896c35173845.camel@HIDDEN>
 <87sfmxv6ue.fsf@HIDDEN>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@HIDDEN>
 <877d48lx41@nckx> <877d46n7n5.fsf_-_@HIDDEN>
 <12c768df412e23b4d69e87631cd805f741c38ce3.camel@HIDDEN>
 <87ilnpibu1.fsf@HIDDEN> <4b81f06f-3e89-5a33-ae30-1710e447f849@HIDDEN>
 <874jz8eogx.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Samstag, dem 23.07.2022 um 01:07 +0200 schrieb Ludovic Courtès:
> Hi,
> 
> Maxime Devos <maximedevos@HIDDEN> skribis:
> 
> > On 22-07-2022 14:14, Ludovic Courtès wrote:
> > > Hi,
> > > 
> > > Liliana Marie Prikler<liliana.prikler@HIDDEN>  skribis:
> > > 
> > > > I don't think deleting links will ever be fast on that disk. 
> > > > But what I've been saying the whole time is that I don't always
> > > > need the links deleted.  I think adding "expert" switches to
> > > > skip these phases might actually be enough – after all, if I
> > > > ever do want to run a full GC, the information ought to be the
> > > > same, no?
> > > The expert will have to know that skipping that phase will have
> > > the effect of *not* freeing space on the device, so…
> > 
> > I believe the word "expert" implies that the expert knows that,
> 
> Apologies for being elliptic.  My point here, as has been discussed
> earlier in this thread, is that we can’t just skip that phase or we’d
> simply leave files around without actually deleting them.
> 
> Thus, a command-line switch to skip the phase doesn’t seem valuable
> to me because it’d let users run the GC in a way that doesn’t
> actually collect garbage.
> 
> I hope this is clearer!
As noted before, I don't always run GC to free up X amount of space. 
Even if I did, link deletion is greedy and frees up whatever it can. 
So the initial suggestion to only look at what might have been freed in
this gc already makes sense.  However, it was ruled complicated because
the GC is implemented in C++.  

My personal motivation to just skip the phase entirely comes from the
hypothesis that the store is in a sane state even if the links are not
deleted.  Particularly, if I `guix gc broken-item' and `guix build
broken-item', even without deleting links, the broken-item should now
be fixed.  This has practical advantages over `guix build --repair': if
the last `guix package' or `guix system' failed mid-way, any user, not
just root, can simply `guix gc' the broken items.

Now, I understand that as a default, you never want to skip this phase,
because it doesn't actually free up disk space.  But if you have a slow
disk with large space, do you really need to free all that much space,
or would it be fine to delay freeing it until a later date?

Cheers

Last modified: Sat, 23 Jul 2022 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.