Received: (at 51437) by debbugs.gnu.org; 10 Sep 2022 04:53:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 10 00:53:55 2022
Received: from localhost ([127.0.0.1]:36141 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oWsV5-00044O-JF
for submit <at> debbugs.gnu.org; Sat, 10 Sep 2022 00:53:55 -0400
Received: from quimby.gnus.org ([95.216.78.240]:53934)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1oWsV4-000448-Ce
for 51437 <at> debbugs.gnu.org; Sat, 10 Sep 2022 00:53:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=VHEzfimO2M/CMnZmaMFGLwT0Z8vz7fvye5a0mSvEGMo=; b=ddit5glRDUubkORbEUJZB0c1+w
QJLzHFOZSNnAj5eCByntf7/sluTrA9Hfl9UYDG8uuIKQJSrhRoISzQ47crDCIJfX4XoJ4P86w+t+Y
qZeg7vngU0GixyEUF8uoDy7p5GUsYcTPMed6vZlL5DmhEHTMzE7YWQwO6ylTxW9ZMWhM=;
Received: from [84.212.220.105] (helo=joga)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1oWsUw-0006Q2-HO; Sat, 10 Sep 2022 06:53:44 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= <salutis@HIDDEN>
Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working
Flymake backend does not work with narrowed buffers
In-Reply-To: <m25yteqknx.fsf@HIDDEN> ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?=
=?utf-8?Q?s?= message of "Sat, 30 Oct 2021 23:15:14 +0200")
References: <m235ompqp4.fsf@HIDDEN> <871r44ymw6.fsf@HIDDEN>
<CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN>
<m25yteqknx.fsf@HIDDEN>
X-Now-Playing: Peter Gabriel's _Peter Gabriel 3_: "And Through The Wire"
Date: Sat, 10 Sep 2022 06:53:42 +0200
Message-ID: <878rmrrfs9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Rudolf Adamkovič <salutis@HIDDEN> writes: >> I can't test
right now, but maybe Rudolf can. If it works then >> I'd say commit it. >
> The patch fixes the errors, So I've applied the patch to Emacs 29...
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 51437
Cc: 51437 <at> debbugs.gnu.org,
=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Rudolf Adamkovi=C4=8D <salutis@HIDDEN> writes:
>> I can't test right now, but maybe Rudolf can. If it works then
>> I'd say commit it.
>
> The patch fixes the errors,
So I've applied the patch to Emacs 29...
> but it also causes troubles. Say I use
> Flymake to check on my English grammar, [...]
But leaving the bug report open to handle the problem more generally.
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 51437) by debbugs.gnu.org; 4 Nov 2021 22:41:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 04 18:41:20 2021 Received: from localhost ([127.0.0.1]:43842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1milQ8-0005XN-F4 for submit <at> debbugs.gnu.org; Thu, 04 Nov 2021 18:41:20 -0400 Received: from mr85p00im-zteg06022001.me.com ([17.58.23.193]:59793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <salutis@HIDDEN>) id 1milQ6-0005XA-Rm for 51437 <at> debbugs.gnu.org; Thu, 04 Nov 2021 18:41:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1636065673; bh=9swoIVs/Th791zv92CKgtUX3av7s/KFqpsjNPK4zAVE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=bXmxkqm7DDnVUGfPHe5wSQ8Gzcs7lFHOEe3XQRB/YjcnDK2p9dHs6nVopiRegHZVc rq1Tp4CFyCMuNxK+gJ9fyWItrsjk7sX7kHmSt8iIL59Bna0vwbDVwvFTQVjO83C4Vn aJc1V3VR8QsdQEhGXphp9nbMOEJ2+CL9Akgatw2dT4QQhxEcKV29+xPEqHutc8vBXf HYB5+CYl5ECDQqvYOsHegCxxkd+J7MPjILkRa/siNw8+fehr9e8ztiKnmUBVbjz9b3 eKN5WhJWe24i5FWqe3vy74RZPs8eq8iGM0bbUF+bydPeNFsw6O3dqEE5D4P4L2uafA 9AyDwjD5dgSmw== Received: from Workstation.local (78-141-116-131.dynamic.orange.sk [78.141.116.131]) by mr85p00im-zteg06022001.me.com (Postfix) with ESMTPSA id 46B90380370; Thu, 4 Nov 2021 22:41:12 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= <salutis@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers In-Reply-To: <CALDnm52hqwZPPpZRPcEs3L+brDF=nj+qs2iKunWD9nrOr6sLCg@HIDDEN> References: <m235ompqp4.fsf@HIDDEN> <871r44ymw6.fsf@HIDDEN> <CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN> <m25yteqknx.fsf@HIDDEN> <CALDnm52hqwZPPpZRPcEs3L+brDF=nj+qs2iKunWD9nrOr6sLCg@HIDDEN> Date: Thu, 04 Nov 2021 23:41:08 +0100 Message-ID: <m2ilx78ry3.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.790,17.0.607.475.0000000_definitions?= =?UTF-8?Q?=3D2021-11-04=5F07:2021-11-03=5F01,2021-11-04=5F07,2020-04-07?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2111040088 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51437 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 51437 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > This is starting to sound like a more generic Flymake limitation/bug > than a documentation bug. I'll have a look when I get home. True. > Have you experimented with the 'region' arg when reporting back > diagnostics? Also you can have a look at how the Elisp backend does > it? I think, though I am not sure, that it works with narrowed > buffers. I did not dig that deep yet. :) > By the way, Flymake for spell checking is a great idea. Is your > backend available somewhere? I use Vale to check on my writing (style and spelling) as follows: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 (with-eval-after-load 'flymake =E2=94=82 (my-define-flymake-backend =E2=94=82 my-flymake-vale =E2=94=82 (lambda (file) (list "vale" "--output" "line" "--ext" ".md" "-= -no-wrap")) =E2=94=82 "^stdin.md:\\([0-9]+\\):\\([0-9]+\\):\\(.*\\)$" =E2=94=82 (lambda (msg) t))) =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 I dislike the idea of unnecessary "backend packages", and I think Flymake s= hould empower the user to plug in any CLI tool in a couple of minutes. No p= ackages, no complicated functions with `make-process', and so on. Instead, = make simple asynchronous live buffer checking simple. Then, everyone will p= lug in their linters, unit test runners, style/spell-checkers, and the like= . As of now, Flymake fights such a user. For instance, I use the same macro= for everything else, including programming: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 (with-eval-after-load 'flymake =E2=94=82 (my-define-flymake-backend =E2=94=82 my-flymake-swiftlint =E2=94=82 'my-flymake-swiftlint-command =E2=94=82 "^<nopath>:\\([0-9]+\\):\\([0-9]+\\): \\(.*\\)$" =E2=94=82 (lambda (msg) (string-match "^warning" msg)))) =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 TL;DR Vanilla Flymake makes it unnecesserily hard to plug in a simple CLI u= tility for buffer checking. Rudy --=20 "I love deadlines. I love the whooshing noise they make as they go by." -- = Douglas Adams, The Salmon of Doubt Rudolf Adamkovi=C4=8D <salutis@HIDDEN> Studenohorsk=C3=A1 25 84103 Bratislava Slovakia [he/him]
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Received: (at 51437) by debbugs.gnu.org; 31 Oct 2021 09:26:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 31 05:26:35 2021 Received: from localhost ([127.0.0.1]:58988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mh76o-0000CT-VN for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 05:26:35 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:33640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1mh76n-0000CG-BC for 51437 <at> debbugs.gnu.org; Sun, 31 Oct 2021 05:26:33 -0400 Received: by mail-pf1-f178.google.com with SMTP id t184so13625373pfd.0 for <51437 <at> debbugs.gnu.org>; Sun, 31 Oct 2021 02:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hSihxBS5B2s6ul+yv0lObuWDS5rlBVTEY8bLWCxkVE4=; b=RyGIPOiX3uY/9K1GIZP9hDfQ76gDYVH2uEiSBVgJf8caMOc1Cms0xMUoERye6W3Teb 243B9Lo6CAyzuj/WxRaeKACHOsaVhvTuVdWt2kI16o0/fozmtYrF0f2YAWf/5fxjdleX 0i6xity0nPC1NH1/aDo1CjtSzuaaS8TdE3rc2mNYFz6C5WDOOEKotZdK+ZK2mHNgdvI9 phV+uUNKIO5u+anzELJdLYV6ZjRuPXPUF7UWSKxkvOg8+TPq+4vftDbl8n5+9ZBdkRLu BXdyiOBQQ/DrzErfCyJQxF3kyFYPhR9yxL327wPEqR8JKqvSayxdauWpgRmqECnePJUq /J0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hSihxBS5B2s6ul+yv0lObuWDS5rlBVTEY8bLWCxkVE4=; b=CdpFNgDUKIuApuZNUoKbDOEFS9/H5ykrDVc+txu1Edhxg8cGyUcmIoQESPwUWiOH8S 2fF0Xt/GqU4/Ds+Dsj5JFpI6l9dY4utGUOWyuY7an/nTeUm/3BI9rBL61gO+bxB7sKKj Wh0cwk4TmVfz7U+JlYab00FfPPG3tLAHrMYlLDSkE3nHdJnQmlskhdGRuPUr01SR/18o ke2Mz0AfRH4rAOLYcilgf5U+8XCMAIPSPJib2B5La0d3nduXT1EGUZTDK/nIxjb8INSC A6/Qbm3GJl/RzSJk2hLsfp13/bWZ3jbqwyv8y8jsNTIKI2iFLPtmWnCm3MsQLjTospom rPwQ== X-Gm-Message-State: AOAM5326qlINmJHD7eXVzUQ99l6dtBVsYnxJi27pHOVAQzySH6eek0NG dM5coqST5tVGmEk/ca7erZeSRM4winAfHr/1aFk= X-Google-Smtp-Source: ABdhPJyjztqujnKjgsuLyv1LV/g9siGUmlHx7tbn1U8CmPx6C917R/r/HIjYSQbDUt7WOwjWCUK1PLDKKvlp6DMJMlo= X-Received: by 2002:a63:7e19:: with SMTP id z25mr16287610pgc.295.1635672387488; Sun, 31 Oct 2021 02:26:27 -0700 (PDT) MIME-Version: 1.0 References: <m235ompqp4.fsf@HIDDEN> <871r44ymw6.fsf@HIDDEN> <CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN> <m25yteqknx.fsf@HIDDEN> In-Reply-To: <m25yteqknx.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sun, 31 Oct 2021 09:26:16 +0000 Message-ID: <CALDnm52hqwZPPpZRPcEs3L+brDF=nj+qs2iKunWD9nrOr6sLCg@HIDDEN> Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers To: =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= <salutis@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000a0108e05cfa2a709" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51437 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 51437 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000a0108e05cfa2a709 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This is starting to sound like a more generic Flymake limitation/bug than a documentation bug. I'll have a look when I get home. Have you experimented with the 'region' arg when reporting back diagnostics? Also you can have a look at how the Elisp backend does it? I think, though I am not sure, that it works with narrowed buffers. By the way, Flymake for spell checking is a great idea. Is your backend available somewhere? Jo=C3=A3o On Sat, Oct 30, 2021, 22:15 Rudolf Adamkovi=C4=8D <salutis@HIDDEN> wrote: > Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > > > I can't test right now, but maybe Rudolf can. If it works then > > I'd say commit it. > > The patch fixes the errors, but it also causes troubles. Say I use Flymak= e > to check on my English grammar, and say I have 10 errors in my text. I > narrow down to a part with 5 errors, fix them, write some new text, and > after a while, I widen the buffer. I look through my final text, see that > Flymake reports 0 errors, and submit my work to someone. Well, I submitte= d > 5 errors, because Flymake did not re-check when I widened the buffer. > Further, Flymake might report incorrect data on narrow. In the example > above, it would have said 10 errors after narrowing and then 5 for the sa= me > narrowed content on the next re-check. Thus, we should either always chec= k > the entire content of the buffer, or we should recheck on narrow and wide= n, > potentially wasting bandwidth for online checks and the like. > > Rudy > > -- > "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if > it were so, it would be; but as it isn't, it ain't. That's logic.'" -- > Lewis Carroll, Through the Looking Glass > > Rudolf Adamkovi=C4=8D <salutis@HIDDEN> > Studenohorsk=C3=A1 25 > 84103 Bratislava > Slovakia > > [he/him] > --000000000000a0108e05cfa2a709 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">This is starting to sound like a more generic Flymake lim= itation/bug than a documentation bug. I'll have a look when I=C2=A0get = home.<div dir=3D"auto"><br></div><div dir=3D"auto">Have you experimented wi= th the 'region' arg when reporting back diagnostics?=C2=A0 Also you= can have a look at how the Elisp backend does it?=C2=A0 I think, though I = am not sure, that it works with narrowed buffers.</div><div dir=3D"auto"><b= r></div><div dir=3D"auto">By the way, Flymake for spell checking is a great= idea. Is your backend available somewhere?</div><div dir=3D"auto"><br></di= v><div dir=3D"auto">Jo=C3=A3o</div></div><br><div class=3D"gmail_quote"><di= v dir=3D"ltr" class=3D"gmail_attr">On Sat, Oct 30, 2021, 22:15 Rudolf Adamk= ovi=C4=8D <<a href=3D"mailto:salutis@HIDDEN">salutis@HIDDEN</a>> wrot= e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo= rder-left:1px #ccc solid;padding-left:1ex">Jo=C3=A3o T=C3=A1vora <<a hre= f=3D"mailto:joaotavora@HIDDEN" target=3D"_blank" rel=3D"noreferrer">joao= tavora@HIDDEN</a>> writes:<br> <br> > I can't test right now, but maybe Rudolf can. If it works then<br> > I'd say commit it.<br> <br> The patch fixes the errors, but it also causes troubles. Say I use Flymake = to check on my English grammar, and say I have 10 errors in my text. I narr= ow down to a part with 5 errors, fix them, write some new text, and after a= while, I widen the buffer. I look through my final text, see that Flymake = reports 0 errors, and submit my work to someone. Well, I submitted 5 errors= , because Flymake did not re-check when I widened the buffer. Further, Flym= ake might report incorrect data on narrow. In the example above, it would h= ave said 10 errors after narrowing and then 5 for the same narrowed content= on the next re-check. Thus, we should either always check the entire conte= nt of the buffer, or we should recheck on narrow and widen, potentially was= ting bandwidth for online checks and the like.<br> <br> Rudy<br> <br> -- <br> "'Contrariwise,' continued Tweedledee, 'if it was so, it m= ight be; and if it were so, it would be; but as it isn't, it ain't.= That's logic.'" -- Lewis Carroll, Through the Looking Glass<b= r> <br> Rudolf Adamkovi=C4=8D <<a href=3D"mailto:salutis@HIDDEN" target=3D"_blan= k" rel=3D"noreferrer">salutis@HIDDEN</a>><br> Studenohorsk=C3=A1 25<br> 84103 Bratislava<br> Slovakia<br> <br> [he/him]<br> </blockquote></div> --000000000000a0108e05cfa2a709--
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Received: (at 51437) by debbugs.gnu.org; 30 Oct 2021 21:15:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 30 17:15:27 2021 Received: from localhost ([127.0.0.1]:58543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mgvhG-0002Sg-Ui for submit <at> debbugs.gnu.org; Sat, 30 Oct 2021 17:15:27 -0400 Received: from mr85p00im-hyfv06021301.me.com ([17.58.23.188]:42312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <salutis@HIDDEN>) id 1mgvhF-0002ST-Jg for 51437 <at> debbugs.gnu.org; Sat, 30 Oct 2021 17:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1635628519; bh=BDrc0kztl7SnZT2LvOXsLipsW9mU1pgNyYWHDKBdIiU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=lmD6FSXDsLJZMj3cSGrx6o/hwqwjqgVqHwyawFPrr+B9eOCRwFJT1X02nD/woC46R x5gPyFWm0JNru5ZTGHpQVLXHq7/x7Twkeq89n5i/DThz/cKJLIUnBMX3NeY0B1V/Ua U90bpdElmO89avTolVL1GMltyESrhmETH2Nie+KzQ9OIIOkTXms/Pd0YUqsEpMCvm2 0EaOVyReOkg4tEjf/1vQINwUAUaeo/dAOr4IiFO1FOwaitoEtGT7Tg+gyGztjVQ9D5 DoL8v0KpJEXt94btThwNOmS1bMz9mU2lnYkK4OsypVozlpJjmIiKXm0c9BXNMo61zz gKVY6sqhScoxQ== Received: from Workstation.local (78-141-116-131.dynamic.orange.sk [78.141.116.131]) by mr85p00im-hyfv06021301.me.com (Postfix) with ESMTPSA id F242E403E3; Sat, 30 Oct 2021 21:15:17 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= <salutis@HIDDEN> To: 51437 <at> debbugs.gnu.org Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers In-Reply-To: <CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN> References: <m235ompqp4.fsf@HIDDEN> <871r44ymw6.fsf@HIDDEN> <CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN> Date: Sat, 30 Oct 2021 23:15:14 +0200 Message-ID: <m25yteqknx.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.790,17.0.607.475.0000000_definitions?= =?UTF-8?Q?=3D2021-10-30=5F05:2021-10-26=5F01,2021-10-30=5F05,2020-04-07?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=722 spamscore=0 bulkscore=0 phishscore=0 mlxscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2110300125 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51437 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > I can't test right now, but maybe Rudolf can. If it works then > I'd say commit it. The patch fixes the errors, but it also causes troubles. Say I use Flymake = to check on my English grammar, and say I have 10 errors in my text. I narr= ow down to a part with 5 errors, fix them, write some new text, and after a= while, I widen the buffer. I look through my final text, see that Flymake = reports 0 errors, and submit my work to someone. Well, I submitted 5 errors= , because Flymake did not re-check when I widened the buffer. Further, Flym= ake might report incorrect data on narrow. In the example above, it would h= ave said 10 errors after narrowing and then 5 for the same narrowed content= on the next re-check. Thus, we should either always check the entire conte= nt of the buffer, or we should recheck on narrow and widen, potentially was= ting bandwidth for online checks and the like. Rudy --=20 "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if i= t were so, it would be; but as it isn't, it ain't. That's logic.'" -- Lewis= Carroll, Through the Looking Glass Rudolf Adamkovi=C4=8D <salutis@HIDDEN> Studenohorsk=C3=A1 25 84103 Bratislava Slovakia [he/him]
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Received: (at 51437) by debbugs.gnu.org; 29 Oct 2021 18:07:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 29 14:07:35 2021 Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mgWHv-00069Y-Ih for submit <at> debbugs.gnu.org; Fri, 29 Oct 2021 14:07:35 -0400 Received: from mail-pf1-f177.google.com ([209.85.210.177]:42783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1mgWHs-00069H-WD for 51437 <at> debbugs.gnu.org; Fri, 29 Oct 2021 14:07:34 -0400 Received: by mail-pf1-f177.google.com with SMTP id m14so9927355pfc.9 for <51437 <at> debbugs.gnu.org>; Fri, 29 Oct 2021 11:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q1im/QYg5ZhD5Ay30ueXaa/wQl8+BtUuGdaC1e+t8Fg=; b=ikgioSAs1rvRbk9quU+qHXhXOjVE3AZIGyorfaIfNMHk7ybfkvQIdxsMmWse7r47yy lbCHccqEqUoabDS8D/N8GbwUNqeoQHfmVjKpm2SZWQ8iuLPZDaHBihkNfUhLtuh4qLnP SmMiCc5M+E5NRfGoIV3SHaVCl2d8gUeFAnEIFkEml6RJQwMJMbOPI2w5HyWr79zSnE7x sO2+X++NdATG+xiPt8RDn26eVHsqOvmw/pgReIMZn2KVr10P+9DBV6Pe+I2bCPl0sMPX /4ommuY4T/kIz4tGCTXnagXbP4iR9LFylkfAatdmRV9IwaYp2q95kuWIK6gwiFni0B3U QCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q1im/QYg5ZhD5Ay30ueXaa/wQl8+BtUuGdaC1e+t8Fg=; b=q17cWLxm12nsvhbIRLosDYeVJNbppiKGBthvxOd1G+c689uBVVICOA9tetSXGYEVPL jAXciEYGc86ARR7xRsZNJi48MAScJTww8tooVWCd7QAjaD2YHsJYbmUdIN6K0++hyNhX g2I3XYyFSFtou47to/NzmC+Qo+erUtY5QpM6CmcAozuozzexAABc1aXEuJLaLWz3t3t8 1kMx4ATS5nTbeq8WPfRDEZVwh64DWJO7FOaJs6BvUSie/4mxU27j/Cds3kEy0xjpqBel IEn+v4nUFkCmzXfMwaxqYJ0H+uXvYFapxS2SrDr+zpF5EQ7thR93oZAvVALx/7D1zxnh A14w== X-Gm-Message-State: AOAM533r57vmtR1s5G4gK/25E9/80oR9ujHS4KJgyziLPubxIg1moHcz VY8VZf2YXuIlf8lpwsd6uLj03v7YIfeH45JlNBM= X-Google-Smtp-Source: ABdhPJyICBP4NXx0Wul8+Y3NkNZ5MJhh4szqcX1dJkG3seGSi7yNn8oqSZj1lDZ+H6d512UMgg7u94JVnitnBc6ltsU= X-Received: by 2002:aa7:8a0e:0:b0:47c:1116:3ce with SMTP id m14-20020aa78a0e000000b0047c111603cemr12343794pfa.76.1635530847164; Fri, 29 Oct 2021 11:07:27 -0700 (PDT) MIME-Version: 1.0 References: <m235ompqp4.fsf@HIDDEN> <871r44ymw6.fsf@HIDDEN> In-Reply-To: <871r44ymw6.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Fri, 29 Oct 2021 19:07:09 +0100 Message-ID: <CALDnm50JpKSKvyF9z80zhkQS8CAgq_5oTJaw6tqmCpyr51eBBA@HIDDEN> Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers To: Lars Ingebrigtsen <larsi@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000002a205805cf81b37c" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51437 Cc: 51437 <at> debbugs.gnu.org, =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= <salutis@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000002a205805cf81b37c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Might be. I can't test right now, but maybe Rudolf can. If it works then I'd say commit it. Jo=C3=A3o On Fri, Oct 29, 2021, 14:35 Lars Ingebrigtsen <larsi@HIDDEN> wrote: > Rudolf Adamkovi=C4=8D <salutis@HIDDEN> writes: > > > When checking a narrowed buffer with errors outside of the narrowed > region, I get: > > > > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > > =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong typ= e > argument: integer-or-marker-p, nil > > =E2=94=82 error in process sentinel: Wrong type argument: integer-or-ma= rker-p, > nil > > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > > > > Looks like `flymake-diag-region' returns `(nil . nil)' and > `flymake-make-diagnostic' does not like that. > > Perhaps this is the correct fix? (Jo=C3=A3o added to the CCs.) > > diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi > index 309bed7760..1d99342060 100644 > --- a/doc/misc/flymake.texi > +++ b/doc/misc/flymake.texi > @@ -798,6 +798,7 @@ An annotated example backend > for type =3D (if (string-match "^warning" msg) > :warning > :error) > + when (and beg end) > collect (flymake-make-diagnostic source > beg > end > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --0000000000002a205805cf81b37c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">Might be. I can't test right now, but maybe Rudolf ca= n. If it works then I'd say commit it.<div dir=3D"auto"><div dir=3D"aut= o"><br></div><div dir=3D"auto">Jo=C3=A3o</div></div></div><br><div class=3D= "gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 29, 2021, 1= 4:35 Lars Ingebrigtsen <<a href=3D"mailto:larsi@HIDDEN">larsi@HIDDEN= </a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:= 0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Rudolf Adamkovi=C4= =8D <<a href=3D"mailto:salutis@HIDDEN" target=3D"_blank" rel=3D"noreferr= er">salutis@HIDDEN</a>> writes:<br> <br> > When checking a narrowed buffer with errors outside of the narrowed re= gion, I get:<br> ><br> > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80<br> > =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong ty= pe argument: integer-or-marker-p, nil<br> > =E2=94=82 error in process sentinel: Wrong type argument: integer-or-m= arker-p, nil<br> > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80<br> ><br> > Looks like `flymake-diag-region' returns `(nil . nil)' and `fl= ymake-make-diagnostic' does not like that.<br> <br> Perhaps this is the correct fix?=C2=A0 (Jo=C3=A3o added to the CCs.)<br> <br> diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi<br> index 309bed7760..1d99342060 100644<br> --- a/doc/misc/flymake.texi<br> +++ b/doc/misc/flymake.texi<br> @@ -798,6 +798,7 @@ An annotated example backend<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 for type =3D (if (string-match "^warning" msg)<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:warning<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:error)<br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0when (and beg end)<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 collect (flymake-make-diagnostic source<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0beg<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0end<br> <br> <br> -- <br> (domestic pets only, the antidote for overdose, milk.)<br> =C2=A0 =C2=A0bloggy blog: <a href=3D"http://lars.ingebrigtsen.no" rel=3D"no= referrer noreferrer" target=3D"_blank">http://lars.ingebrigtsen.no</a><br> </blockquote></div> --0000000000002a205805cf81b37c--
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 51437) by debbugs.gnu.org; 29 Oct 2021 13:35:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 29 09:35:32 2021
Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mgS2e-0001Hx-1g
for submit <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:35:32 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46446)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1mgS2c-0001Hi-1f
for 51437 <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:35:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=jtQWjY7Bfmo3NnfL9oj4GY5rYjEq/+OLrbnKbprSNSg=; b=ONs5tO7XNBjo9bLYLU6n9P/x27
PEpCDyXQEbOsiDgX7neNbux+1fNHal/lxll2oGoAvdSh6ZDUeBezJ2dfyi31qji6CROGMXW9Ey4e7
zOOdWbfh+pVVcPVAeUtUiX4yzbJT6lVVqZgh47zMsKhv6jyJd3P0uY6w73dGSLKi9GY8=;
Received: from [84.212.220.105] (helo=elva)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1mgS2T-0000AF-Ot; Fri, 29 Oct 2021 15:35:24 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= <salutis@HIDDEN>
Subject: Re: bug#51437: 29.0.50; The annotated example of a complete working
Flymake backend does not work with narrowed buffers
References: <m235ompqp4.fsf@HIDDEN>
X-Now-Playing: Namasenda's _Unlimited Ammo - Infinity_: =?utf-8?Q?=22?=
=?utf-8?Q?=E2=98=86?= (Feat. Oklou)"
Date: Fri, 29 Oct 2021 15:35:21 +0200
In-Reply-To: <m235ompqp4.fsf@HIDDEN> ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?=
=?utf-8?Q?s?= message of "Wed, 27 Oct 2021 15:01:11 +0200")
Message-ID: <871r44ymw6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Rudolf Adamkovič <salutis@HIDDEN> writes: > When checking
a narrowed buffer with errors outside of the narrowed region, I get: > >
┌──── > │ error in process sentinel: flymake--highlight-line:
Wrong type argument: integer-or-marke [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 51437
Cc: 51437 <at> debbugs.gnu.org,
=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Rudolf Adamkovi=C4=8D <salutis@HIDDEN> writes:
> When checking a narrowed buffer with errors outside of the narrowed regio=
n, I get:
>
> =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80
> =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong type =
argument: integer-or-marker-p, nil
> =E2=94=82 error in process sentinel: Wrong type argument: integer-or-mark=
er-p, nil
> =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80
>
> Looks like `flymake-diag-region' returns `(nil . nil)' and `flymake-make-=
diagnostic' does not like that.
Perhaps this is the correct fix? (Jo=C3=A3o added to the CCs.)
diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
index 309bed7760..1d99342060 100644
--- a/doc/misc/flymake.texi
+++ b/doc/misc/flymake.texi
@@ -798,6 +798,7 @@ An annotated example backend
for type =3D (if (string-match "^warning" msg)
:warning
:error)
+ when (and beg end)
collect (flymake-make-diagnostic source
beg
end
--=20
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 27 Oct 2021 13:01:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 27 09:01:32 2021 Received: from localhost ([127.0.0.1]:48655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mfiYe-00047m-CK for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 09:01:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:49812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <salutis@HIDDEN>) id 1mfiYc-00047d-2C for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 09:01:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <salutis@HIDDEN>) id 1mfiYb-0004BX-B2 for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 09:01:29 -0400 Received: from mr85p00im-zteg06011601.me.com ([17.58.23.186]:46326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <salutis@HIDDEN>) id 1mfiYW-0000Vy-7I for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 09:01:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1635339679; bh=dSc9hbMMoepY8sjbf5XcYmEicl79y2hRrI0NDv7zZdU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=RYQXqtJTCNJIXItWv/gPsaRT2zR25+zbdjYPj8THg3X0SiYxBeheJh7YHyJ5Dlsaz M/3L3QBfBymss0wd+GzNizaorMdYUcT7szm79Y5LKj9A0JX3u5XjEQQSL2OSEVPJA3 d8jnC5IAGEslb0rhxjYenZKxMiXZhjhhj5UpdjW2u1K4ib4+KwyqZdDanFTpJAwOme qLeGxc6ryWnRFs5e9YL3MMgORIXKUyZgpYPU+5VpT9VsaaK4fh7pyfl+zLhnRj3m/Z 6RdIzll54MZeyel/iFVUjuh/Ov3kGs0P3E6qssC86A3MS/hUjk8TCelfl09xdSUoMF bXyPfbxsoNFOg== Received: from Workstation.local (78-141-116-131.dynamic.orange.sk [78.141.116.131]) by mr85p00im-zteg06011601.me.com (Postfix) with ESMTPSA id C43FC9205BC for <bug-gnu-emacs@HIDDEN>; Wed, 27 Oct 2021 13:01:18 +0000 (UTC) From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= <salutis@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers Date: Wed, 27 Oct 2021 15:01:11 +0200 Message-ID: <m235ompqp4.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.790,17.0.607.475.0000000_definitions?= =?UTF-8?Q?=3D2021-10-27=5F03:2021-10-26=5F01,2021-10-27=5F03,2020-04-07?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2110270080 Received-SPF: pass client-ip=17.58.23.186; envelope-from=salutis@HIDDEN; helo=mr85p00im-zteg06011601.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) I have found (yet another) problem with the annotated example of a complete= "working" Flymake backend. When checking a narrowed buffer with errors outside of the narrowed region,= I get: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong type ar= gument: integer-or-marker-p, nil =E2=94=82 error in process sentinel: Wrong type argument: integer-or-marker= -p, nil =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Looks like `flymake-diag-region' returns `(nil . nil)' and `flymake-make-di= agnostic' does not like that. TL;DR The official example does not work correctly with narrowed buffers. Rudy In GNU Emacs 29.0.50 (build 6, x86_64-apple-darwin20.6.0, NS appkit-2022.60= Version 11.5.1 (Build 20G80)) of 2021-10-24 built on Workstation.local Repository revision: aea4af5119fdf130f1df7190478a23c6777f92a2 Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.5.1 Configured using: 'configure --with-json PKG_CONFIG_PATH=3D/usr/local/Cellar/zlib/1.2.11/lib/pkgconfig:/usr/local/l= ib/pkgconfig:/opt/X11/lib/pkgconfig' Configured features: ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Message[Notmuch] Minor modes in effect: flymake-mode: t which-key-mode: t corfu-global-mode: t corfu-mode: t vertico-mode: t marginalia-mode: t global-diff-hl-mode: t diff-hl-mode: t yas-global-mode: t yas-minor-mode: t global-hl-todo-mode: t hl-todo-mode: t savehist-mode: t global-subword-mode: t subword-mode: t save-place-mode: t global-auto-revert-mode: t delete-selection-mode: t mml-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t auto-fill-function: yas--auto-fill global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t abbrev-mode: t Load-path shadows: /Users/salutis/.emacs.d/elpa/transient-20211025.1800/transient hides /Users= /salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/transient Features: (shadow emacsbug ox-md ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda org-refile ox-html table ox-ascii ox-publish ox sort bbdb-message sendmail fortune mail-extr notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs notmuch-tag crm notmuch-lib notmuch-version notmuch-compat pcase hl-line vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs sh-script smie executable flymake-proc flymake project warnings org-indent image-file image-converter disp-table char-fold cursor-sensor paredit edmacro bbdb bbdb-site timezone modus-vivendi-theme modus-operandi-theme modus-themes which-key corfu orderless consult-vertico vertico marginalia consult recentf tree-widget kmacro pdf-loader diff-hl log-view pcvs-util vc-dir ewoc vc diminish yasnippet hl-todo finder-inf org-clock oc-csl citeproc citeproc-itemgetters citeproc-biblatex citeproc-bibtex parsebib citeproc-cite citeproc-subbibs citeproc-sort citeproc-name citeproc-formatters citeproc-number rst compile citeproc-proc citeproc-disamb citeproc-itemdata citeproc-generic-elements citeproc-macro citeproc-choose citeproc-date citeproc-context citeproc-prange citeproc-style citeproc-locale citeproc-term f citeproc-rt citeproc-lib citeproc-s s let-alist queue dash savehist ls-lisp cap-words superword subword saveplace autorevert filenotify delsel elfeed-link elfeed-show elfeed-search elfeed-csv elfeed elfeed-curl elfeed-log xml-query bookmark pp elfeed-db elfeed-lib vc-git diff-mode vc-dispatcher org-element avl-tree generator ol-eww eww xdg url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search mail-utils mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi cl-extra help-mode org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color ring org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol rx org-keys oc org-compat advice org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs tex-site slime-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 743594 65968) (symbols 48 42843 9) (strings 32 222286 7052) (string-bytes 1 6344437) (vectors 16 82119) (vector-slots 8 1722047 63625) (floats 8 399 286) (intervals 56 15568 1600) (buffers 992 26)) --=20 "Logic is a science of the necessary laws of thought, without which no empl= oyment of the understanding and the reason takes place." -- Immanuel Kant, = 1785 Rudolf Adamkovi=C4=8D <salutis@HIDDEN> Studenohorsk=C3=A1 25 84103 Bratislava Slovakia [he/him]
Rudolf Adamkovič <salutis@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#51437; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.