GNU bug report logs - #51451
image-transform-original has a misleading name

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Stefan Kangas <stefan@HIDDEN>; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 14 Sep 2022 23:06:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 14 19:06:49 2022
Received: from localhost ([127.0.0.1]:56505 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oYbSz-0003Pb-Da
	for submit <at> debbugs.gnu.org; Wed, 14 Sep 2022 19:06:49 -0400
Received: from mail-ot1-f47.google.com ([209.85.210.47]:43608)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1oYbSv-0003PD-LK
 for 51451 <at> debbugs.gnu.org; Wed, 14 Sep 2022 19:06:48 -0400
Received: by mail-ot1-f47.google.com with SMTP id
 cm7-20020a056830650700b006587fe87d1aso880718otb.10
 for <51451 <at> debbugs.gnu.org>; Wed, 14 Sep 2022 16:06:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date;
 bh=TgmMv6isHERHgSBWCzfLu7keiGKPHOCJYdgAyW6vGQA=;
 b=fA0k2MYxl/dVSKLY5Wq6wzauf6E2y0YcxINmlJSv6mv0cYwV1mQfDccksijkqwpZyI
 NdVD4/ryszKeLkwxvp5+xShjczulYMUmxBR51RFmXfophvotEFrR3Nz5SbJJdbyrNFgM
 +kTcuvj3cy/dRSz4HnFLGcsTua5JzBNaLkxUOMwtH4au/1LqT6be+zlmtZCOQtjVzrDB
 H2PXLnnIa1DqCK4zRTN5vDcwuBK6XUVGFSsaXO1lajTAUPt6NJAQ6+275s6Hq2EzRvWy
 EWHVZq+K8mcFbIdhIeVrY6BEGzVKXwmj1/xaBdOFEnTAsR0OQMHT6E+sGTj0YllLC6uB
 /dTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date;
 bh=TgmMv6isHERHgSBWCzfLu7keiGKPHOCJYdgAyW6vGQA=;
 b=DMVidWDY3AkmXLl/3gsaXLf6AUKLzhiNCJHzNuIlt2DogQXfKxitz+scy9lUUR9YvT
 evdn3TKFopwEJOB2V2xJCtWiSSIYJV/eGOkaxwQo1bLV/HexhpcdY2J94RXkmx/GG/yH
 ioULnXE0gVmgGHAQWJZbyCurIDtklN/pdqSQO8GGxnoxQxuPhHkttZW2xlzpzRNyIZYJ
 Flzh0bU4Z3v1bOr+R1Om/wxpZyGPyWhaanD7NmPZ2D6YH6Z/Mvnl4HxtP8/XteSCl4gh
 mLmGl5+kJLRE/0nuXimmnyu6eCGrjWz3qScaVlz+qpQfFjqK+GH2vd3diMx44jpaDzzN
 czvA==
X-Gm-Message-State: ACgBeo0s/dHO5ojxA7ZpQCPbA/yW29oRE+ej5ZcAr4ofRMPeETZsBbBP
 OFwVyLwJz23KREmiSwM7t0mqXejQ0h60c11ZBpVmJ7/K
X-Google-Smtp-Source: AA6agR7cQPdsFu1T6+I+FhgrEoIkpSpYFyBAJ1bnJVUrKcNUNoOhqgxTgpPXM/FBX2edcLPIBLb0z6t/B7LwaEwrZj8=
X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id
 p1-20020a05683003c100b0063728be7920mr15514900otc.105.1663196799876; Wed, 14
 Sep 2022 16:06:39 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 14 Sep 2022 16:06:39 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86zgf1oljk.fsf@HIDDEN>
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
 <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
 <86ee7xvzwi.fsf@HIDDEN>
 <CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@HIDDEN>
 <86zgf1oljk.fsf@HIDDEN>
X-Hashcash: 1:20:220914:51451 <at> debbugs.gnu.org::h2sX6qy4URE7t3q4:TpF5
MIME-Version: 1.0
Date: Wed, 14 Sep 2022 16:06:39 -0700
Message-ID: <CADwFkmmfuAkpC+zE0E-8kxFhS6CRYK7CDtT7=9gZUYqVQMK+dg@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Juri Linkov <juri@HIDDEN> writes:

>  I noticed that the manual mentions only
> 'image-transform-reset-to-initial'.  Shouldn't it also mention
> 'image-transform-reset-to-original' briefly, after a comma, e.g.:
>
>   To reset all transformations to the initial state, use
>   =E2=80=98image-transform-reset-to-initial=E2=80=99 bound to =E2=80=98s =
0=E2=80=99, and to the
>   original state, use =E2=80=98image-transform-reset-to-original=E2=80=99=
 bound to =E2=80=98s o=E2=80=99.

OK, now done (commit 8c73ed0ec3).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 14 Sep 2022 19:30:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 14 15:30:39 2022
Received: from localhost ([127.0.0.1]:56293 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oYY5n-00043N-2F
	for submit <at> debbugs.gnu.org; Wed, 14 Sep 2022 15:30:39 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38479)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1oYY5j-000435-K7
 for 51451 <at> debbugs.gnu.org; Wed, 14 Sep 2022 15:30:37 -0400
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 4A88F40005;
 Wed, 14 Sep 2022 19:30:25 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
In-Reply-To: <CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@HIDDEN>
 (Stefan Kangas's message of "Wed, 14 Sep 2022 09:52:43 -0400")
Organization: LINKOV.NET
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
 <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
 <86ee7xvzwi.fsf@HIDDEN>
 <CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@HIDDEN>
Date: Wed, 14 Sep 2022 22:11:11 +0300
Message-ID: <86zgf1oljk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> PS: renaming to image-transform-reset-to-original will also require
>> renaming image-transform-reset to image-transform-reset-to-initial.
>
> Thanks.  I've now changed this as you suggest (commit 37fe0cd358).

Thanks, I noticed that the manual mentions only
'image-transform-reset-to-initial'.  Shouldn't it also mention
'image-transform-reset-to-original' briefly, after a comma, e.g.:

  To reset all transformations to the initial state, use
  ‘image-transform-reset-to-initial’ bound to ‘s 0’, and to the
  original state, use ‘image-transform-reset-to-original’ bound to ‘s o’.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.
bug marked as fixed in version 29.1, send any further explanations to 51451 <at> debbugs.gnu.org and Stefan Kangas <stefan@HIDDEN> Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 14 Sep 2022 13:52:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 14 09:52:51 2022
Received: from localhost ([127.0.0.1]:54194 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oYSot-0006Wo-AP
	for submit <at> debbugs.gnu.org; Wed, 14 Sep 2022 09:52:51 -0400
Received: from mail-ot1-f48.google.com ([209.85.210.48]:33478)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1oYSor-0006WT-OT
 for 51451 <at> debbugs.gnu.org; Wed, 14 Sep 2022 09:52:50 -0400
Received: by mail-ot1-f48.google.com with SMTP id
 l7-20020a056830154700b0065563d564dfso10341680otp.0
 for <51451 <at> debbugs.gnu.org>; Wed, 14 Sep 2022 06:52:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=cc:to:subject:message-id:date:mime-version:user-agent:references
 :in-reply-to:from:from:to:cc:subject:date;
 bh=tWtR1mV0TmwHtvbJg9D+/zUt8esXt34BFq1lHAYLRRs=;
 b=A1loSo8s7MGBLxPN61w/GcsqS42eHlCVir+ab20SqA8Yjarw2T9ZV9FyF35mvngi0z
 LD7no7J/3iXq1qJFqe+gcPUdEDJXLfuXOj39vRXbeWwSl6YfEm5bwQj6pZ7cIBKuPzU0
 dwge/+RuUrmhMo/zeOLnCgD3MMPHzGFV8C+K76KFz/nJO3Py7SnINe2lBEhtZTa4LxW3
 flT51/VTUE3g4yO4BmgslTy0KiP+ivpPFS8OU1gkIOvG+W9q1KuHVe/5O550uEtKPgYZ
 RTyD7C2e+vDtVbSoRcQl41+i0fcShqPA6WuxoyLodLJdoUYr/wFIrN2ctGfHAyNqmIMt
 4LAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:mime-version:user-agent:references
 :in-reply-to:from:x-gm-message-state:from:to:cc:subject:date;
 bh=tWtR1mV0TmwHtvbJg9D+/zUt8esXt34BFq1lHAYLRRs=;
 b=JJoe0F34t5SL27hG9NlQIPeqHbqQy43TSY6vC9+7YXiA5hB17dXvFivYiCc7vjjR2N
 U8wkv+LKvasxsLcutd0h5WNBH1rUTHYTwYXTDFzCZoVU7nICOiTbn6UgDvHzFHEia5+v
 eUo67G2j4rHEG47b5TRrHtpINnqBWxhWIuiq0MN4WwvEZpkd7jcZ1HmQwWqn6KJsW7JK
 8Kh/x6Tjq1142pDGrlmADQLpLpZB9obJxbPBzesKJ3CCMgryqduoUYD7ZPFEK8fGLysa
 SOSnFoO9bp5n14th/SkFGc3T8JiIBElxQwBRePFwjMWMYMukqaCxC+5rGlb5KhdcPlVY
 g9FA==
X-Gm-Message-State: ACgBeo29OJzIOg590pi/KbWB72BcwJDzArtOcTK6Xm9X+QJjZ3+PiwzQ
 EiRxdaS/o/MH6O9UBOQKqqRjiBUT8hZAeDYFIV8=
X-Google-Smtp-Source: AA6agR4o0KfoZ5UCHDmCLaUgAIRJFdVuGFmSK43KSlD7wum4ntDb13Ed7M8pI0MovTrdfVep6c5M6MiNYImAdwrtd24=
X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id
 q9-20020a9d7c89000000b00655dfb1331cmr6065096otn.224.1663163564135; Wed, 14
 Sep 2022 06:52:44 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 14 Sep 2022 09:52:43 -0400
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86ee7xvzwi.fsf@HIDDEN> (Juri Linkov's message of "Wed, 
 03 Nov 2021 20:48:29 +0200")
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
 <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
 <86ee7xvzwi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
X-Hashcash: 1:20:220914:51451 <at> debbugs.gnu.org::+PtuFA8U/EtbU2Qf:5oGC
MIME-Version: 1.0
Date: Wed, 14 Sep 2022 09:52:43 -0400
Message-ID: <CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 51451 29.1
thanks

Juri Linkov <juri@HIDDEN> writes:

>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should.  Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.  Whether
> selecting such a prefix was a good choice is another question.
>
> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.
>
> PS: renaming to image-transform-reset-to-original will also require
> renaming image-transform-reset to image-transform-reset-to-initial.

Thanks.  I've now changed this as you suggest (commit 37fe0cd358).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 3 Nov 2021 20:17:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 03 16:17:04 2021
Received: from localhost ([127.0.0.1]:41361 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1miMgy-0006lX-J5
	for submit <at> debbugs.gnu.org; Wed, 03 Nov 2021 16:17:04 -0400
Received: from mail-pf1-f181.google.com ([209.85.210.181]:34425)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1miMgv-0006ks-TK
 for 51451 <at> debbugs.gnu.org; Wed, 03 Nov 2021 16:17:02 -0400
Received: by mail-pf1-f181.google.com with SMTP id 127so3574707pfu.1
 for <51451 <at> debbugs.gnu.org>; Wed, 03 Nov 2021 13:17:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:mime-version:date
 :message-id:subject:to:cc;
 bh=KSo80kRUxmMm+a5kAI684bd39CtdBQn5+YjWZ1QVC3Y=;
 b=IDseEnYBZm4jpZ4lvrHVdwQnUH0sGOUeBLRZkGkj1y/0MTk/X857NnndFaitT2NmTw
 As40E5K6Dg15ZuwNG+Xc+6WBpf26foaqZJ1BSdALnlNVqpfRkiCxukB55tJA2Zm15V45
 w7u86DzLaVMk4YuS2NtfLXrNHq43UgHBTRPHXJEl4dbj2DkysNNs0CiTw6gYutjGNk7E
 zx0sEQqMstAhJAdeLesBQdgqu2s14qbrKrJb7MWO1aRaFDgsNP9YqhIYgag327Jck6TK
 ms5iSQvtiHX3/fJzE+q1LaHTAh7W7RzOlRj6gE82ZLvaIHGpT89GCwN2qCC9xEKmm4gG
 3kTg==
X-Gm-Message-State: AOAM532NnTTFqjSQhxO/0Pfk/4i7lj3f7TpkuFkKkMTpPdY9XYCoqioI
 qfnTsB/iqmpB4iCMTYxRXlF8LMf/MlPXQFntkBU=
X-Google-Smtp-Source: ABdhPJwoScW1bV84hcszwsMIoGg9zwlcg3wV7+AQacAQ0OuXYi50WMftukilJn4pzB+dAzxwO3HCpRXmclQof6kB1nA=
X-Received: by 2002:a63:330f:: with SMTP id z15mr35367681pgz.42.1635970616018; 
 Wed, 03 Nov 2021 13:16:56 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 3 Nov 2021 13:16:55 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <86ee7xvzwi.fsf@HIDDEN>
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
 <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
 <86ee7xvzwi.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 3 Nov 2021 13:16:55 -0700
Message-ID: <CADwFkmkFpaA468jz4r30THACyhGxn+taTvb_kjbgUb5zF2zE7g@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Juri Linkov <juri@HIDDEN> writes:

>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should.  Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.

That's true.

> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.

I see a problem with all of them, especially in combination with
`image-save'.  :-(

But the most confusing one by far is `image-transform-original', indeed.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 3 Nov 2021 18:49:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 03 14:49:30 2021
Received: from localhost ([127.0.0.1]:41245 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1miLKE-0004EB-EL
	for submit <at> debbugs.gnu.org; Wed, 03 Nov 2021 14:49:30 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39153)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1miLKC-0004Dy-Ux
 for 51451 <at> debbugs.gnu.org; Wed, 03 Nov 2021 14:49:29 -0400
Received: (Authenticated sender: juri@HIDDEN)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5A3B3FF80F;
 Wed,  3 Nov 2021 18:49:19 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
Organization: LINKOV.NET
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
 <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
Date: Wed, 03 Nov 2021 20:48:29 +0200
In-Reply-To: <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
 (Stefan Kangas's message of "Sun, 31 Oct 2021 13:24:21 -0700")
Message-ID: <86ee7xvzwi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> image-transform-* commands are modifying the values of
>> image-transform-* variables.
>> Would you propose to rename variables as well?
>
> I didn't think about that, as the commands are what the user will see.
> Maybe we should.  Do you think it would be a good idea?

At least, currently there is consistency in naming of
image-transform-* functions and variables.  Whether
selecting such a prefix was a good choice is another question.

But if you see a problem only in the name of image-transform-original,
then it could be renamed to image-transform-set-original or maybe
better to image-transform-reset-to-original, i.e. to something more
descriptive, while keeping the existing name prefix.

PS: renaming to image-transform-reset-to-original will also require
renaming image-transform-reset to image-transform-reset-to-initial.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 31 Oct 2021 20:24:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 31 16:24:29 2021
Received: from localhost ([127.0.0.1]:33163 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhHNV-0002sH-4U
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 16:24:29 -0400
Received: from mail-pj1-f46.google.com ([209.85.216.46]:35554)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mhHNT-0002s4-En
 for 51451 <at> debbugs.gnu.org; Sun, 31 Oct 2021 16:24:27 -0400
Received: by mail-pj1-f46.google.com with SMTP id
 n11-20020a17090a2bcb00b001a1e7a0a6a6so14622856pje.0
 for <51451 <at> debbugs.gnu.org>; Sun, 31 Oct 2021 13:24:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:mime-version:date
 :message-id:subject:to:cc;
 bh=vZKRAuVtAPcCAiJSlbTd0LU8Mt6iWWO6vw10jAjUYi8=;
 b=Cv8cECGhFODsxlslp3O1qDkWseeZzyYLl3I9UQXHmZ4uzhBrg1PrgKQYSQpP+qTAMR
 uwKwGG6tH4SrtpfFc4wH2kMIH1kkzqLT05TEHU72eW9sJn779VDdmO+PMheq7VdCotJL
 oh0I7xSW8zZOg7LChfoPoecYu7OXvFvQihImRfSxXsoTkEiN3r8y5TqyU7zZStKLX2lG
 LdAoOXCgcjAbH/Tz6VrizppdZ0oruYs9/FijYXX5+jsn05r0x77ErsXCTA7zURFTWrgk
 zmDfWyRVZZlQRgmwXfOphA+Pb2r1b3AYO1a5VACxYxoX1ZLaJMIJ22R2xfdwdOfdSrxL
 xhkA==
X-Gm-Message-State: AOAM531kmdfB2VmzjL3KbVHOAQqnGJnpOR3zaVkn88yFQbg2jQZm9HZ1
 eq4ooejHmNHIGmwGjLkWpbdCzBfeO5jdGhRRiUex/DzT
X-Google-Smtp-Source: ABdhPJy53nPmzY+nny9Gg9xakDh9DX6AkDgyf5ulu4Djgjt/0taFhmoegCHEDfI0AGly4pFOKmTnXyFFDO8sorrE4kA=
X-Received: by 2002:a17:902:8c93:b0:141:5442:e608 with SMTP id
 t19-20020a1709028c9300b001415442e608mr21352398plo.32.1635711861642; Sun, 31
 Oct 2021 13:24:21 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 31 Oct 2021 13:24:21 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <87ilxdnsbu.fsf@HIDDEN>
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 <87ilxdnsbu.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 31 Oct 2021 13:24:21 -0700
Message-ID: <CADwFkmnea4p8+vaCieobO=jSvxHwJczwmeMUZ1Y14GFB=Y=Daw@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Juri Linkov <juri@HIDDEN> writes:

> image-transform-* commands are modifying the values of
> image-transform-* variables.
> Would you propose to rename variables as well?

I didn't think about that, as the commands are what the user will see.
Maybe we should.  Do you think it would be a good idea?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 31 Oct 2021 19:52:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 31 15:52:18 2021
Received: from localhost ([127.0.0.1]:33143 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhGsM-00027P-N5
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 15:52:18 -0400
Received: from relay12.mail.gandi.net ([217.70.178.232]:58191)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1mhGsK-00027A-86
 for 51451 <at> debbugs.gnu.org; Sun, 31 Oct 2021 15:52:16 -0400
Received: (Authenticated sender: juri@HIDDEN)
 by relay12.mail.gandi.net (Postfix) with ESMTPSA id 2FA2A200004;
 Sun, 31 Oct 2021 19:52:08 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
Organization: LINKOV.NET
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
Date: Sun, 31 Oct 2021 21:46:17 +0200
In-Reply-To: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 (Stefan Kangas's message of "Wed, 27 Oct 2021 17:31:48 -0700")
Message-ID: <87ilxdnsbu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> These are the commands under the "s" key in image-mode:
>
>     s 0             image-transform-reset
>     s b             image-transform-fit-both
>     s f             image-mode-fit-frame
>     s h             image-transform-fit-to-height
>     s m             image-transform-set-smoothing
>     s o             image-transform-original
>     s r             image-transform-set-rotation
>     s s             image-transform-set-scale
>     s w             image-transform-fit-to-width
>
> Perhaps this would be less confusing if these commands were named
> `image-display-*' instead of `image-transform-*'?
>
>     s 0             image-display-reset-size
>     s b             image-display-fit-both
>     s f             image-mode-fit-frame
>     s h             image-display-fit-to-height
>     s m             image-display-set-smoothing
>     s o             image-display-original-size
>     s r             image-display-set-rotation
>     s s             image-display-set-scale
>     s w             image-display-fit-to-width
>
> Doesn't that make more sense?

image-transform-* commands are modifying the values of
image-transform-* variables.
Would you propose to rename variables as well?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 29 Oct 2021 13:14:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 29 09:14:17 2021
Received: from localhost ([127.0.0.1]:54156 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mgRi4-0006oL-Ut
	for submit <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:14:17 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46176)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1mgRi2-0006o3-Uu
 for 51451 <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:14:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=N7Mt6ckjB6G9sdzdxh9CcMSAoicDujFAoqKzqRL2p3w=; b=gxCimO/bqoB1xrsqVEeCNlbtth
 PtM5c8RH79tQZDE+hXxuyojges6I3vP5ejAsImuXy3aaZlsGXG4tyCugyx4XYvzZrEM9BBSeoLG6U
 7SEA09VRYUQvUxCTkOKJvge5CnHVBfgnKQGEZVCGbThQ9POUprIDgZZXm2xwk+W/ZPMY=;
Received: from [84.212.220.105] (helo=elva)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1mgRhu-0008Sm-ET; Fri, 29 Oct 2021 15:14:09 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
X-Now-Playing: Joni Mitchell's _Shine_: "Shine"
Date: Fri, 29 Oct 2021 15:14:05 +0200
In-Reply-To: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 (Stefan Kangas's message of "Wed, 27 Oct 2021 17:31:48 -0700")
Message-ID: <87bl38ynvm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stefan Kangas <stefan@HIDDEN> writes: > Perhaps this
 would
 be less confusing if these commands were named > `image-display-*' instead
 of `image-transform-*'? > > s 0 image-display-reset-size > s b
 image-display-fit-both > s f image-mode-f [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefan@HIDDEN> writes:

> Perhaps this would be less confusing if these commands were named
> `image-display-*' instead of `image-transform-*'?
>
>     s 0             image-display-reset-size
>     s b             image-display-fit-both
>     s f             image-mode-fit-frame
>     s h             image-display-fit-to-height
>     s m             image-display-set-smoothing
>     s o             image-display-original-size
>     s r             image-display-set-rotation
>     s s             image-display-set-scale
>     s w             image-display-fit-to-width
>
> Doesn't that make more sense?

It makes sense to me -- I've been confused by these commands myself.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Oct 2021 00:32:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 27 20:32:00 2021
Received: from localhost ([127.0.0.1]:50874 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mftKq-0000K2-5E
	for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 20:32:00 -0400
Received: from lists.gnu.org ([209.51.188.17]:38698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mftKo-0000Ju-HK
 for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 20:31:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39584)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1mftKk-0005Yq-BV
 for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 20:31:55 -0400
Received: from mail-pf1-f178.google.com ([209.85.210.178]:43676)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1mftKg-0003Hl-OJ
 for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 20:31:52 -0400
Received: by mail-pf1-f178.google.com with SMTP id 187so4288619pfc.10
 for <bug-gnu-emacs@HIDDEN>; Wed, 27 Oct 2021 17:31:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:mime-version:date:message-id:subject:to;
 bh=oyzcj9018cK/IfLNvBG48ikJzUMBvZZWBycJbtzJT28=;
 b=0fRPMxzKu+Go5b9XIdk/99K6cTqTXBGDyx/HiGMZr6KPvujIX31JU3voANN38qtWT4
 KaDeNqs9xFiZqcBwKWRsTT6B924hEP6P6AtM9gV/kKe4Y3XZokybYAJUAKb75xzNFgRf
 IYsIP8PuJQDHq488tcn/69CY3qimiP5AI6WR05nT+DoLFROgraf/dBsmNj1AoX4WVUUt
 kCv/UXa9ZpiBjnXfB44QM3lfHA/o1F2ByZFqhHoVRc/oKYnJE1a3bB9bV5aTB95lahgn
 hSTT6vBHEb0RywzFXMPXkgwtGnMVXX5PTELfr41iuSorCjElA5m033ytcVwPlvJHpVo+
 i7uA==
X-Gm-Message-State: AOAM530+8LszO+KqbVtYT85oP+jSFXUjfgM1DL3Z7LkaN5NZTjpeKvF3
 Wmvv2y/tvNd5eJyAsWWxztc6502Fm1DTus5l+cG/jOtP
X-Google-Smtp-Source: ABdhPJwYOEaonybgUakde9LMpp8tLHdrqg6VHlktsj2JA/erjE4CYJNgqYKVIrgHUpnfErGEWO2pqzBP9OqtMBKYTZw=
X-Received: by 2002:a63:370c:: with SMTP id e12mr753897pga.359.1635381109451; 
 Wed, 27 Oct 2021 17:31:49 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 27 Oct 2021 17:31:48 -0700
From: Stefan Kangas <stefan@HIDDEN>
MIME-Version: 1.0
Date: Wed, 27 Oct 2021 17:31:48 -0700
Message-ID: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
Subject: image-transform-original has a misleading name
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.210.178;
 envelope-from=stefankangas@HIDDEN; helo=mail-pf1-f178.google.com
X-Spam_score_int: 13
X-Spam_score: 1.3
X-Spam_bar: +
X-Spam_report: (1.3 / 5.0 requ) BAYES_50=0.8, FREEMAIL_FORGED_FROMDOMAIN=0.249,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Severity: minor

This is the docstring of `image-transform-original'.

    (image-transform-original)

    Display the current image with the original (actual) size and
    rotation.

From reading this it is clear what it does, but the command name makes
it sound like it will transform the original image.

These are the commands under the "s" key in image-mode:

    s 0             image-transform-reset
    s b             image-transform-fit-both
    s f             image-mode-fit-frame
    s h             image-transform-fit-to-height
    s m             image-transform-set-smoothing
    s o             image-transform-original
    s r             image-transform-set-rotation
    s s             image-transform-set-scale
    s w             image-transform-fit-to-width

Perhaps this would be less confusing if these commands were named
`image-display-*' instead of `image-transform-*'?

    s 0             image-display-reset-size
    s b             image-display-fit-both
    s f             image-mode-fit-frame
    s h             image-display-fit-to-height
    s m             image-display-set-smoothing
    s o             image-display-original-size
    s r             image-display-set-rotation
    s s             image-display-set-scale
    s w             image-display-fit-to-width

Doesn't that make more sense?




Acknowledgement sent to Stefan Kangas <stefan@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 14 Sep 2022 23:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.