GNU bug report logs - #51451
image-transform-original has a misleading name

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Stefan Kangas <stefan@HIDDEN>; dated Thu, 28 Oct 2021 00:32:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 51451 <at> debbugs.gnu.org:


Received: (at 51451) by debbugs.gnu.org; 29 Oct 2021 13:14:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 29 09:14:17 2021
Received: from localhost ([127.0.0.1]:54156 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mgRi4-0006oL-Ut
	for submit <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:14:17 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46176)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1mgRi2-0006o3-Uu
 for 51451 <at> debbugs.gnu.org; Fri, 29 Oct 2021 09:14:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=N7Mt6ckjB6G9sdzdxh9CcMSAoicDujFAoqKzqRL2p3w=; b=gxCimO/bqoB1xrsqVEeCNlbtth
 PtM5c8RH79tQZDE+hXxuyojges6I3vP5ejAsImuXy3aaZlsGXG4tyCugyx4XYvzZrEM9BBSeoLG6U
 7SEA09VRYUQvUxCTkOKJvge5CnHVBfgnKQGEZVCGbThQ9POUprIDgZZXm2xwk+W/ZPMY=;
Received: from [84.212.220.105] (helo=elva)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1mgRhu-0008Sm-ET; Fri, 29 Oct 2021 15:14:09 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#51451: image-transform-original has a misleading name
References: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
X-Now-Playing: Joni Mitchell's _Shine_: "Shine"
Date: Fri, 29 Oct 2021 15:14:05 +0200
In-Reply-To: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
 (Stefan Kangas's message of "Wed, 27 Oct 2021 17:31:48 -0700")
Message-ID: <87bl38ynvm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stefan Kangas <stefan@HIDDEN> writes: > Perhaps this
 would
 be less confusing if these commands were named > `image-display-*' instead
 of `image-transform-*'? > > s 0 image-display-reset-size > s b
 image-display-fit-both > s f image-mode-f [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 51451
Cc: 51451 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefan@HIDDEN> writes:

> Perhaps this would be less confusing if these commands were named
> `image-display-*' instead of `image-transform-*'?
>
>     s 0             image-display-reset-size
>     s b             image-display-fit-both
>     s f             image-mode-fit-frame
>     s h             image-display-fit-to-height
>     s m             image-display-set-smoothing
>     s o             image-display-original-size
>     s r             image-display-set-rotation
>     s s             image-display-set-scale
>     s w             image-display-fit-to-width
>
> Doesn't that make more sense?

It makes sense to me -- I've been confused by these commands myself.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Oct 2021 00:32:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 27 20:32:00 2021
Received: from localhost ([127.0.0.1]:50874 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mftKq-0000K2-5E
	for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 20:32:00 -0400
Received: from lists.gnu.org ([209.51.188.17]:38698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mftKo-0000Ju-HK
 for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 20:31:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39584)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1mftKk-0005Yq-BV
 for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 20:31:55 -0400
Received: from mail-pf1-f178.google.com ([209.85.210.178]:43676)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1mftKg-0003Hl-OJ
 for bug-gnu-emacs@HIDDEN; Wed, 27 Oct 2021 20:31:52 -0400
Received: by mail-pf1-f178.google.com with SMTP id 187so4288619pfc.10
 for <bug-gnu-emacs@HIDDEN>; Wed, 27 Oct 2021 17:31:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:mime-version:date:message-id:subject:to;
 bh=oyzcj9018cK/IfLNvBG48ikJzUMBvZZWBycJbtzJT28=;
 b=0fRPMxzKu+Go5b9XIdk/99K6cTqTXBGDyx/HiGMZr6KPvujIX31JU3voANN38qtWT4
 KaDeNqs9xFiZqcBwKWRsTT6B924hEP6P6AtM9gV/kKe4Y3XZokybYAJUAKb75xzNFgRf
 IYsIP8PuJQDHq488tcn/69CY3qimiP5AI6WR05nT+DoLFROgraf/dBsmNj1AoX4WVUUt
 kCv/UXa9ZpiBjnXfB44QM3lfHA/o1F2ByZFqhHoVRc/oKYnJE1a3bB9bV5aTB95lahgn
 hSTT6vBHEb0RywzFXMPXkgwtGnMVXX5PTELfr41iuSorCjElA5m033ytcVwPlvJHpVo+
 i7uA==
X-Gm-Message-State: AOAM530+8LszO+KqbVtYT85oP+jSFXUjfgM1DL3Z7LkaN5NZTjpeKvF3
 Wmvv2y/tvNd5eJyAsWWxztc6502Fm1DTus5l+cG/jOtP
X-Google-Smtp-Source: ABdhPJwYOEaonybgUakde9LMpp8tLHdrqg6VHlktsj2JA/erjE4CYJNgqYKVIrgHUpnfErGEWO2pqzBP9OqtMBKYTZw=
X-Received: by 2002:a63:370c:: with SMTP id e12mr753897pga.359.1635381109451; 
 Wed, 27 Oct 2021 17:31:49 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 27 Oct 2021 17:31:48 -0700
From: Stefan Kangas <stefan@HIDDEN>
MIME-Version: 1.0
Date: Wed, 27 Oct 2021 17:31:48 -0700
Message-ID: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@HIDDEN>
Subject: image-transform-original has a misleading name
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.210.178;
 envelope-from=stefankangas@HIDDEN; helo=mail-pf1-f178.google.com
X-Spam_score_int: 13
X-Spam_score: 1.3
X-Spam_bar: +
X-Spam_report: (1.3 / 5.0 requ) BAYES_50=0.8, FREEMAIL_FORGED_FROMDOMAIN=0.249,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Severity: minor

This is the docstring of `image-transform-original'.

    (image-transform-original)

    Display the current image with the original (actual) size and
    rotation.

From reading this it is clear what it does, but the command name makes
it sound like it will transform the original image.

These are the commands under the "s" key in image-mode:

    s 0             image-transform-reset
    s b             image-transform-fit-both
    s f             image-mode-fit-frame
    s h             image-transform-fit-to-height
    s m             image-transform-set-smoothing
    s o             image-transform-original
    s r             image-transform-set-rotation
    s s             image-transform-set-scale
    s w             image-transform-fit-to-width

Perhaps this would be less confusing if these commands were named
`image-display-*' instead of `image-transform-*'?

    s 0             image-display-reset-size
    s b             image-display-fit-both
    s f             image-mode-fit-frame
    s h             image-display-fit-to-height
    s m             image-display-set-smoothing
    s o             image-display-original-size
    s r             image-display-set-rotation
    s s             image-display-set-scale
    s w             image-display-fit-to-width

Doesn't that make more sense?




Acknowledgement sent to Stefan Kangas <stefan@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#51451; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 29 Oct 2021 13:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.