GNU bug report logs - #51467
[PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms.

Previous Next

Package: guix-patches;

Reported by: Thiago Jung Bauermann <bauermann <at> kolabnow.com>

Date: Thu, 28 Oct 2021 19:44:02 UTC

Severity: normal

Tags: patch

Done: Thiago Jung Bauermann <bauermann <at> kolabnow.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51467 in the body.
You can then email your comments to 51467 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51467; Package guix-patches. (Thu, 28 Oct 2021 19:44:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 28 Oct 2021 19:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: guix-patches <at> gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on
 non-x86_64 platforms.
Date: Thu, 28 Oct 2021 16:43:23 -0300
On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that
doesn’t support SVG.  This causes the ‘tree-relationships’ test to fail
because it tries to fetch SVG icons in some of the tests.

Therefore, we need to disable the test when SVG support isn’t available.

* gnu/packages/gtk.scm (gtk+)[arguments]<#:phases>{disable-failing-tests}:
Disable ‘tree-relationships’ test on non-x86_64 platforms.
---

Hello,

Considering that the core-updates-frozen-batched-changes branch will
soon make GTK+ depend on Rust (via an updated mozjs package), perhaps
this patch is somewhat pointless. But I thought it would be at least a
bit useful to have this information recorded.

Also, there's a good change that polkit will switch from mozjs to duktape
as its Javascript engine. In that case it will be useful again to have
this patch in.

With this patch, GTK+ builds again on core-updates-frozen on
powerpc64le-linux. This patch doesn't change the package derivation
on x86_64-linux

Thanks,
Thiago.

 gnu/packages/gtk.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index fadd0794c5dd..40fc2c93d681 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1106,7 +1106,12 @@ (define-public gtk+
                      '()))
              (substitute* "testsuite/a11y/Makefile.in"
                (("accessibility-dump tree-performance text children derive")
-                "tree-performance text children derive"))
+                "tree-performance text children derive")
+               ;; The ‘tree-relationships’ test needs SVG support.
+               ,@(if (not (target-x86-64?))
+                     '((("value misc tree-relationships util")
+                        "value misc util"))
+                     '()))
              (substitute* "testsuite/reftests/Makefile.in"
                (("TEST_PROGS = gtk-reftest")
                 "TEST_PROGS = "))




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Fri, 12 Nov 2021 06:06:02 GMT) Full text and rfc822 format available.

Notification sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
bug acknowledged by developer. (Fri, 12 Nov 2021 06:06:02 GMT) Full text and rfc822 format available.

Message #10 received at 51467-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Cc: 51467-done <at> debbugs.gnu.org
Subject: Re: bug#51467: [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite
 failure on non-x86_64 platforms.
Date: Fri, 12 Nov 2021 01:05:27 -0500
Thiago Jung Bauermann <bauermann <at> kolabnow.com> writes:

> On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that
> doesn’t support SVG.  This causes the ‘tree-relationships’ test to fail
> because it tries to fetch SVG icons in some of the tests.
>
> Therefore, we need to disable the test when SVG support isn’t available.
>
> * gnu/packages/gtk.scm (gtk+)[arguments]<#:phases>{disable-failing-tests}:
> Disable ‘tree-relationships’ test on non-x86_64 platforms.

Mathieu applied it on core-updates(-frozen) with commit
b452fe87e0c6e7634a2cb44274fa46832c763b40.

Closing.

Thank you!

Maxim




Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 12 Nov 2021 14:47:02 GMT) Full text and rfc822 format available.

Reply sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
You have taken responsibility. (Wed, 17 Nov 2021 00:57:01 GMT) Full text and rfc822 format available.

Notification sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
bug acknowledged by developer. (Wed, 17 Nov 2021 00:57:01 GMT) Full text and rfc822 format available.

Message #17 received at 51467-done <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 51467-done <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#51467: [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite
 failure on non-x86_64 platforms.
Date: Tue, 16 Nov 2021 21:56:38 -0300
Hello again,

Em sexta-feira, 12 de novembro de 2021, às 11:45:43 -03, Thiago Jung 
Bauermann escreveu:
> This patch disables the ‘tree-relationships’ test, and it’s not yet
> applied on core-updates-frozen so I’m reopening the bug report.

Strange, I recently built gtk+ on core-updates-frozen (commit ef77c3b3f120) 
on powerpc64le-linux and  the ‘tree-relationships’ test passed!

I don’t understand what is different this time, but it looks like this patch 
isn’t necessary anymore.

Closing again.

-- 
Thanks,
Thiago






bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 15 Dec 2021 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.