GNU bug report logs - #51477
[PATCH] gnu: Add nsxiv

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51477 in the body.
You can then email your comments to 51477 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add nsxiv
Date: Fri, 29 Oct 2021 09:30:52 +0000

* gnu/packages/image-viewers.scm (nsxiv): New variable.
---
 gnu/packages/image-viewers.scm | 55 ++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 4f87b63ca1..1799642cbb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -417,6 +418,60 @@ base should be kept small and clean to make it easy for you to dig into
 it and customize it for your needs.")
     (license license:gpl2+)))
 
+(define-public nsxiv
+  (package
+    (name "nsxiv")
+    (version "27.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/nsxiv/nsxiv")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1na7f0hpc9g04nm7991gzaqr5gkj08n2azx833hgxcm2w1pnn1bk"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ; no check target
+       #:make-flags
+       (list (string-append "PREFIX=" %output)
+             (string-append "CC=" ,(cc-for-target)))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)            ; no configure script
+         (add-after 'unpack 'fix-libXft-path
+           (lambda _
+             ;; Xft.h #includes <ft2build.h> without ‘freetype2/’. The Makefile
+             ;; works around this by hard-coding /usr/include & $PREFIX.
+             (substitute* "Makefile"
+               (("-I/usr/include/freetype2 -I\\$\\(PREFIX\\)/include/freetype2")
+                (string-append "-I" (assoc-ref %build-inputs "freetype")
+                               "/include/freetype2")))))
+         (add-after 'install 'install-desktop-file
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "nsxiv.desktop"
+                           (string-append (assoc-ref outputs "out")
+                                          "/share/applications"))))
+         (add-after 'install 'install-icons
+           (lambda* (#:key make-flags #:allow-other-keys)
+             (apply invoke "make" "-C" "icon" "install" make-flags))))))
+    (inputs
+     `(("freetype" ,freetype)
+       ("giflib" ,giflib)
+       ("imlib2" ,imlib2)
+       ("libexif" ,libexif)
+       ("libx11" ,libx11)
+       ("libxft" ,libxft)))
+    (home-page "https://github.com/nsxiv/nsxiv")
+    (synopsis "Neo Simple X Image Viewer")
+    (description
+     "nsxiv is a fork of sxiv.  Its primary goal is to provide the most basic
+features required for fast image viewing.  It has vi key bindings and works
+nicely with tiling window managers.  Its code base should be kept small an
+clean to make it easy for you to dig into it and customize it for your needs.")
+    (license license:gpl2+)))
+
 (define-public viewnior
   (package
     (name "viewnior")

base-commit: ad39268cdf075f4c4eeb87ed78ce46ca6f817675
-- 
2.25.1

Message #8 received at 51477 <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: 51477 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add nsxiv.
Date: Sun, 31 Oct 2021 09:11:29 +0000

* gnu/packages/image-viewers.scm (nsxiv): New variable.
---
 gnu/packages/image-viewers.scm | 54 ++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 4f87b63ca1..8e34ce1608 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -417,6 +417,60 @@ base should be kept small and clean to make it easy for you to dig into
 it and customize it for your needs.")
     (license license:gpl2+)))
 
+(define-public nsxiv
+  (package
+    (name "nsxiv")
+    (version "27.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/nsxiv/nsxiv")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1na7f0hpc9g04nm7991gzaqr5gkj08n2azx833hgxcm2w1pnn1bk"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ; no check target
+       #:make-flags
+       (list (string-append "PREFIX=" %output)
+             (string-append "CC=" ,(cc-for-target)))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)            ; no configure script
+         (add-after 'unpack 'fix-paths
+           (lambda _
+             ;; Xft.h #includes <ft2build.h> without ‘freetype2/’. The Makefile
+             ;; works around this by hard-coding /usr/include & $PREFIX.
+             (substitute* "Makefile"
+               (("-I/usr/include/freetype2 -I\\$\\(PREFIX\\)/include/freetype2")
+                (string-append "-I" (assoc-ref %build-inputs "freetype")
+                               "/include/freetype2")))))
+         (add-after 'install 'install-desktop-file
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "nsxiv.desktop"
+                           (string-append (assoc-ref outputs "out")
+                                          "/share/applications"))))
+         (add-after 'install 'install-icons
+           (lambda* (#:key make-flags #:allow-other-keys)
+             (apply invoke "make" "-C" "icon" "install" make-flags))))))
+    (inputs
+     `(("freetype" ,freetype)
+       ("giflib" ,giflib)
+       ("imlib2" ,imlib2)
+       ("libexif" ,libexif)
+       ("libx11" ,libx11)
+       ("libxft" ,libxft)))
+    (home-page "https://github.com/nsxiv/nsxiv")
+    (synopsis "Neo Simple X Image Viewer")
+    (description
+     "nsxiv is a fork of sxiv. Its primary goal is to provide the most basic
+features required for fast image viewing. It has vi key bindings and works
+nicely with tiling window managers. Its code base should be kept small and
+clean to make it easy for you to dig into it and customize it for your needs.")
+    (license license:gpl2+)))
+
 (define-public viewnior
   (package
     (name "viewnior")

base-commit: 9f2c5e901e988b575d487629976d2d14be4ed61d
-- 
2.25.1

Message #13 received at 51477-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
Cc: 51477-done <at> debbugs.gnu.org
Subject: Re: [bug#51477] [PATCH v2] gnu: Add nsxiv.
Date: Sun, 14 Nov 2021 15:22:19 +0100

Hello,

Foo Chuan Wei <chuanwei.foo <at> hotmail.com> writes:

> * gnu/packages/image-viewers.scm (nsxiv): New variable.

Thank you. Applied with the following changes:

> +         (add-after 'unpack 'fix-paths
> +           (lambda _
> +             ;; Xft.h #includes <ft2build.h> without ‘freetype2/’. The Makefile
> +             ;; works around this by hard-coding /usr/include & $PREFIX.
> +             (substitute* "Makefile"
> +               (("-I/usr/include/freetype2 -I\\$\\(PREFIX\\)/include/freetype2")
> +                (string-append "-I" (assoc-ref %build-inputs "freetype")
> +                               "/include/freetype2")))))

I used the code below instead:

  (lambda* (#:key inputs #:allow-other-keys)
    (let ((freetype (string-append (assoc-ref inputs "freetype")
                                   "/include/freetype2")))
      (substitute* "Makefile"
        (("-I/usr/include/freetype2 -I\\$\\(PREFIX\\)/include/freetype2")
         (string-append "-I" freetype)))))

> +    (description
> +     "nsxiv is a fork of sxiv. Its primary goal is to provide the most basic
> +features required for fast image viewing. It has vi key bindings and works
> +nicely with tiling window managers. Its code base should be kept small and
> +clean to make it easy for you to dig into it and customize it for
> your needs.")

I added two spaces at the end of sentences, per Texinfo syntax.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.