GNU bug report logs - #51510
[PATCH 0/4] Update piper to 0.6, libratbag to 0.16.

Previous Next

Package: guix-patches;

Reported by: Brendan Tildesley <mail <at> brendan.scot>

Date: Sat, 30 Oct 2021 12:41:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51510 in the body.
You can then email your comments to 51510 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Sat, 30 Oct 2021 12:41:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brendan Tildesley <mail <at> brendan.scot>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 30 Oct 2021 12:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH 0/4] Update piper to 0.6, libratbag to 0.16.
Date: Sat, 30 Oct 2021 14:40:28 +0200 (CEST)



Information forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Sat, 30 Oct 2021 12:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 51510 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 51510 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: libratbag: Update to 0.16.
Date: Sat, 30 Oct 2021 23:41:27 +1100
* gnu/packages/gnome.scm (libratbag): Update to 0.16.
---
 gnu/packages/gnome.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index b138ff228b..650c4e0305 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -27,7 +27,7 @@
 ;;; Copyright © 2017, 2018 nee <nee-git <at> hidamari.blue>
 ;;; Copyright © 2017 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2017 Mohammed Sadiq <sadiq <at> sadiqpk.org>
-;;; Copyright © 2017, 2020 Brendan Tildesley <mail <at> brendan.scot>
+;;; Copyright © 2017, 2020, 2021 Brendan Tildesley <mail <at> brendan.scot>
 ;;; Copyright © 2017, 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2018 Jovany Leandro G.C <bit4bit <at> riseup.net>
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e <at> yahoo.com>
@@ -11706,7 +11706,7 @@ (define-public apostrophe
 (define-public libratbag
   (package
     (name "libratbag")
-    (version "0.14")
+    (version "0.16")
     (source
      (origin
        (method git-fetch)
@@ -11715,7 +11715,7 @@ (define-public libratbag
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1fpwp2sj8mf98bqasq2h8qwgprxi7k3iw33gcfid3d1lbyiacw0x"))))
+        (base32 "0jjf6xc3a37icp5dvbxla3ai9is2ns31m0llbfq1bmb6dk8cd4n0"))))
     (build-system meson-build-system)
     (arguments
      `(#:configure-flags
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Sat, 30 Oct 2021 12:43:02 GMT) Full text and rfc822 format available.

Message #11 received at 51510 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 51510 <at> debbugs.gnu.org
Subject: [PATCH 2/4] gnu: piper: Update to 0.6.
Date: Sat, 30 Oct 2021 23:41:28 +1100
* gnu/packages/gnome.scm (piper): Update to 0.6.
[inputs]: Add libratbag.
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 650c4e0305..c8ec3fe248 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11773,7 +11773,7 @@ (define-public libratbag
 (define-public piper
   (package
     (name "piper")
-    (version "0.5.1")
+    (version "0.6")
     (source
      (origin
        (method git-fetch)
@@ -11781,7 +11781,7 @@ (define-public piper
              (url "https://github.com/libratbag/piper")
              (commit version)))
        (sha256
-        (base32 "1nfjnsiwg2rs6gkjsxzhr2708i6di149dgwq3cf6l12rxqpb8arj"))
+        (base32 "02x4d4n0078slj2pl0rvgayrrxvna6y6vj8fxfamvazsh5xyfzwk"))
        (file-name (git-file-name name version))))
     (build-system meson-build-system)
     (native-inputs
@@ -11794,6 +11794,7 @@ (define-public piper
      `(("adwaita-icon-theme" ,adwaita-icon-theme)
        ("gtk" ,gtk+)
        ("gtk:bin" ,gtk+ "bin")
+       ("libratbag" ,libratbag)
        ("librsvg" ,librsvg)
        ("python-evdev" ,python-evdev)
        ("python-lxml" ,python-lxml)
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Sat, 30 Oct 2021 12:43:02 GMT) Full text and rfc822 format available.

Message #14 received at 51510 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 51510 <at> debbugs.gnu.org
Subject: [PATCH 3/4] gnu: services: Add ratbag-dbus-service.
Date: Sat, 30 Oct 2021 23:41:29 +1100
* gnu/services/desktop.scm (ratbag-dbus-service): New variable. Export
it.
---
 gnu/services/desktop.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 64d0e85301..101344aced 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -150,6 +150,8 @@ (define-module (gnu services desktop)
 
             polkit-wheel-service
 
+            ratbag-dbus-service
+
             gnome-keyring-configuration
             gnome-keyring-configuration?
             gnome-keyring-service-type
@@ -1182,6 +1184,11 @@ (define polkit-wheel
 (define polkit-wheel-service
   (simple-service 'polkit-wheel polkit-service-type (list polkit-wheel)))
 
+
+
+(define ratbag-dbus-service
+  (simple-service 'ratbag dbus-root-service-type (list libratbag)))
+
 
 ;;;
 ;;; The default set of desktop services.
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Sat, 30 Oct 2021 12:43:02 GMT) Full text and rfc822 format available.

Message #17 received at 51510 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 51510 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: libratbag, piper: Adjust descriptions.
Date: Sat, 30 Oct 2021 23:41:30 +1100
* gnu/packages/gnome.scm
(libratbag): [description]: Don't bother mentioning the service here.
(piper): [description]: Mention the new ratbag-dbus-service
instead. Simplify.
---
 gnu/packages/gnome.scm | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c8ec3fe248..1ef78dfedf 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11762,12 +11762,7 @@ (define-public libratbag
 @command{ratbagctl} command line interface for configuring devices.
 
 libratbag currently supports devices from Logitech, Etekcity, GSkill, Roccat,
-Steelseries.
-
-The ratbagd DBus service can be enabled by adding the following service to
-your operating-system definition:
-
-  (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
+and Steelseries.")
     (license license:expat)))
 
 (define-public piper
@@ -11826,13 +11821,9 @@ (define-public piper
     (home-page "https://github.com/libratbag/piper/")
     (synopsis "Configure bindings and LEDs on gaming mice")
     (description "Piper is a GTK+ application for configuring gaming mice with
-onboard configuration for key bindings via libratbag.  Piper requires
-a @command{ratbagd} daemon running with root privileges.  It can be run
-manually as root, but is preferably configured as a DBus service that can
-launch on demand.  This can be configured by enabling the following service,
-provided there is a DBus service present:
+onboard configuration for key bindings via libratbag.
 
-  (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
+Configure the ratbag-dbus-service to enable Piper's functionality.")
     (license license:gpl2)))
 
 (define-public parlatype
-- 
2.33.1





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 23 Nov 2021 08:50:01 GMT) Full text and rfc822 format available.

Notification sent to Brendan Tildesley <mail <at> brendan.scot>:
bug acknowledged by developer. (Tue, 23 Nov 2021 08:50:01 GMT) Full text and rfc822 format available.

Message #22 received at 51510-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 51510-done <at> debbugs.gnu.org
Subject: Re: bug#51510: [PATCH 0/4] Update piper to 0.6, libratbag to 0.16.
Date: Tue, 23 Nov 2021 09:49:08 +0100
Hi,

Brendan Tildesley <mail <at> brendan.scot> skribis:

> * gnu/packages/gnome.scm (libratbag): Update to 0.16.

[...]

> * gnu/packages/gnome.scm (piper): Update to 0.6.
> [inputs]: Add libratbag.

Applied, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#51510; Package guix-patches. (Tue, 23 Nov 2021 08:52:02 GMT) Full text and rfc822 format available.

Message #25 received at 51510 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 51510 <at> debbugs.gnu.org
Subject: Re: bug#51510: [PATCH 0/4] Update piper to 0.6, libratbag to 0.16.
Date: Tue, 23 Nov 2021 09:51:44 +0100
Brendan Tildesley <mail <at> brendan.scot> skribis:

> * gnu/services/desktop.scm (ratbag-dbus-service): New variable. Export
> it.

[...]

> +(define ratbag-dbus-service
> +  (simple-service 'ratbag dbus-root-service-type (list libratbag)))

I did not apply this and the next one because we would need
documentation in doc/guix.texi.

Could you make these changes and submit separately?

Thanks in advance, and apologies for the delay!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 21 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.