GNU bug report logs - #51524
[PATCH] ; * doc/misc/org.org: fix capture context example

Previous Next

Package: emacs;

Reported by: Hanno Perrey <hanno <at> hoowl.se>

Date: Sun, 31 Oct 2021 07:49:01 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51524 in the body.
You can then email your comments to 51524 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 31 Oct 2021 07:49:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Hanno Perrey <hanno <at> hoowl.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 31 Oct 2021 07:49:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hanno Perrey <hanno <at> hoowl.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * doc/misc/org.org: fix capture context example
Date: Sat, 30 Oct 2021 21:51:02 +0200
[Message part 1 (text/plain, inline)]
Hej,

the attached patch fixes a typo in the org-mode info pages: the examples
for org-capture contexts are each missing a pair of parenthesis as
detailed in the doc string for org-capture-templates-contexts, leading
to a "Wrong type argument: listp, in-mode" error when invoking org-capture.

Thanks for the great work on Emacs and best wishes,
Hanno

[0001-doc-misc-org.org-fix-capture-context-example.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 31 Oct 2021 15:24:01 GMT) Full text and rfc822 format available.

Message #8 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Hanno Perrey <hanno <at> hoowl.se>
Cc: 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 31 Oct 2021 16:23:23 +0100
Hanno Perrey <hanno <at> hoowl.se> writes:

> the attached patch fixes a typo in the org-mode info pages: the examples
> for org-capture contexts are each missing a pair of parenthesis as
> detailed in the doc string for org-capture-templates-contexts, leading
> to a "Wrong type argument: listp, in-mode" error when invoking org-capture.

Thanks for the patch; I've now pushed it to emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 28.1, send any further explanations to 51524 <at> debbugs.gnu.org and Hanno Perrey <hanno <at> hoowl.se> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 31 Oct 2021 15:24:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 31 Oct 2021 15:33:01 GMT) Full text and rfc822 format available.

Message #13 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: hanno <at> hoowl.se, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ;
 * doc/misc/org.org: fix capture context example
Date: Sun, 31 Oct 2021 17:32:14 +0200
> Resent-From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs <at> gnu.org
> Resent-Sender: help-debbugs <at> gnu.org
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 31 Oct 2021 16:23:23 +0100
> Cc: 51524 <at> debbugs.gnu.org
> 
> Hanno Perrey <hanno <at> hoowl.se> writes:
> 
> > the attached patch fixes a typo in the org-mode info pages: the examples
> > for org-capture contexts are each missing a pair of parenthesis as
> > detailed in the doc string for org-capture-templates-contexts, leading
> > to a "Wrong type argument: listp, in-mode" error when invoking org-capture.
> 
> Thanks for the patch; I've now pushed it to emacs-28.

Aren't Org changes supposed to come from merges of the Org repository?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 31 Oct 2021 15:37:01 GMT) Full text and rfc822 format available.

Message #16 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: hanno <at> hoowl.se, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 31 Oct 2021 16:36:10 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> Aren't Org changes supposed to come from merges of the Org repository?

I thought they merged back changes from Emacs?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 21 Nov 2021 09:05:01 GMT) Full text and rfc822 format available.

Message #19 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: hanno <at> hoowl.se, Lars Ingebrigtsen <larsi <at> gnus.org>, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 21 Nov 2021 10:04:48 +0100
Hi Eli,

Eli Zaretskii <eliz <at> gnu.org> writes:

> Aren't Org changes supposed to come from merges of the Org
> repository?

Yes, they are, see for example:

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 21 Nov 2021 09:07:02 GMT) Full text and rfc822 format available.

Message #22 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: hanno <at> hoowl.se, Eli Zaretskii <eliz <at> gnu.org>, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 21 Nov 2021 10:06:07 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Aren't Org changes supposed to come from merges of the Org repository?
>
> I thought they merged back changes from Emacs?

Yes, changes from Emacs are backported to Org upstream:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563

(Sorry, my previous reply to Eli was meant as a reply to you.)

-- 
 Bastien




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 21 Nov 2021 09:11:01 GMT) Full text and rfc822 format available.

Message #25 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Bastien <bzg <at> gnu.org>
Cc: hanno <at> hoowl.se, larsi <at> gnus.org, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 21 Nov 2021 11:10:55 +0200
> From: Bastien <bzg <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  hanno <at> hoowl.se,  51524 <at> debbugs.gnu.org
> Date: Sun, 21 Nov 2021 10:06:07 +0100
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >> Aren't Org changes supposed to come from merges of the Org repository?
> >
> > I thought they merged back changes from Emacs?
> 
> Yes, changes from Emacs are backported to Org upstream:
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563

So it's okay with you if we make changes in Org on our branches?  I
worried that doing so might make merging more difficult for you guys.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51524; Package emacs. (Sun, 21 Nov 2021 21:53:01 GMT) Full text and rfc822 format available.

Message #28 received at 51524 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: hanno <at> hoowl.se, larsi <at> gnus.org, 51524 <at> debbugs.gnu.org
Subject: Re: bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context
 example
Date: Sun, 21 Nov 2021 22:52:40 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Yes, changes from Emacs are backported to Org upstream:
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563
>
> So it's okay with you if we make changes in Org on our branches?  I
> worried that doing so might make merging more difficult for you guys.

Yes, it is okay.

Of course, we prefer bug reports and patches to be sent to the
emacs-orgmode <at> gnu.org list and committed upstream, but since we
have someone volunteering for backporting commits from Emacs,
it's fine.

-- 
 Bastien




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Dec 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.