GNU bug report logs - #51534
[PATCH] gnu: Add smplayer.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Attila Lendvai <attila@HIDDEN>; Keywords: patch; dated Mon, 1 Nov 2021 01:00:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 51534 <at> debbugs.gnu.org:


Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 12:39:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 07:39:15 2021
Received: from localhost ([127.0.0.1]:35082 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrJSd-0001Ui-0x
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 07:39:15 -0500
Received: from mail-wm1-f68.google.com ([209.85.128.68]:37729)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1mrJSY-0001UO-TO
 for 51534 <at> debbugs.gnu.org; Sun, 28 Nov 2021 07:39:13 -0500
Received: by mail-wm1-f68.google.com with SMTP id
 k37-20020a05600c1ca500b00330cb84834fso14565860wms.2
 for <51534 <at> debbugs.gnu.org>; Sun, 28 Nov 2021 04:39:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=c8GfOsZ5Qe0JuGn02zDJgm7XPk1NZULNFaF8oTY4ayU=;
 b=IVTZfTUqz9R9cSS+HmPu6a5ku1c9WEvITYDV6Z/wUjvvTv9XUXlifz8Aqb7v4f1Zym
 IjinJmhF8LcvqFOiMg40+d2J4apkPiaB5Kv/lWFcXXz4Sl3lQWPW+Zrr+ue7cyYLE/04
 OOtntlNkanbYEphOH77UQ3ZtANKYrCt3CVhFfW1zSm9WsMGkDa6P8+gF5LWcOvoj4VLA
 NQsMaY5txnLMiowZajZ1lGq7njaWU6nxvqdgyo2Rz1wKSVByIRVgPzShAcExQQNqdF60
 HBTgA6miY3daLFXOYUbtg6D1qyX9xkR4dWhYgcSvPlkCQrzpcDVr8RptfEAo4Ln+xhvs
 ex8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=c8GfOsZ5Qe0JuGn02zDJgm7XPk1NZULNFaF8oTY4ayU=;
 b=RF92e/2oDTRgqdA3w2qBD3hJR3523GUnTHCbSWkBbcoFMsA6yqtRTb2oVRYqH0gCwR
 BA6ste6CZ6UcgRWh5t1YU9LJ+vsQAuGFFxcXH54lphH7f4+nd3qs2RHPCyDkIWf6sxPe
 +RpZxmxJHONMRcJGtr6GdJ2MW3eK9P8l8djkcoA8jN5l5L3NocFI/ZGgEj0fwuhDKXN7
 pnADk7Ci8yu0Zn1dndjd80NfAHl7i3ylIhqYGBSoqy4fghiJPrgdRvfZybgjd0HcO/vg
 sQxWHvrfHe2IInn9qhFgeGFRq8YjlNlFnOcRWjQbEuvFef1mvrG7zNvy4wXoZqjHY736
 gYdA==
X-Gm-Message-State: AOAM531kG0zyGJSHSkrsgGDePymGm7XvxzpYf7TXwKVkY4DB5941DA5x
 C+n6SDaq3LrdT3T8vYu63Ho=
X-Google-Smtp-Source: ABdhPJyrBfuBLcoDGIRdZ0PkmkOFHyEs9mPzvPnCQFK3+EFjxhvgPRisjUjSna/0BYvVsIRhNP0ZDg==
X-Received: by 2002:a7b:c008:: with SMTP id c8mr28418940wmb.87.1638103145034; 
 Sun, 28 Nov 2021 04:39:05 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id n4sm12346419wri.41.2021.11.28.04.39.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 28 Nov 2021 04:39:04 -0800 (PST)
Message-ID: <12afd3fddf83742682611dd468827f64d1d1e5b7.camel@HIDDEN>
Subject: Re: [PATCH v4] gnu: Add smplayer v21.10.0.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Attila Lendvai <attila@HIDDEN>, 51534 <at> debbugs.gnu.org
Date: Sun, 28 Nov 2021 13:39:02 +0100
In-Reply-To: <20211128121204.3348-1-attila@HIDDEN>
References: <20211128121204.3348-1-attila@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51534
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Sonntag, den 28.11.2021, 13:12 +0100 schrieb Attila Lendvai:
> * gnu/packages/video.scm (smplayer): New variable.
> ---
> 
> v4 adds bash-minimal to the inputs as per guix lint. sorry for the
> miss!
> 
> there's another lint warning that i can't fix:
> 
> "smplayer@HIDDEN: source not archived on Software Heritage and
> missing from the Disarchive database"
This one ought to disappear magically, as it's now queued for archival.
> and forgot to mention that v3 switched to the qt-build-system.
Don't worry too much about that; I'm the one who mentioned it first
after all.
>  gnu/packages/video.scm | 60
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index ff1abb308f..5cb645baac 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -100,6 +100,7 @@ (define-module (gnu packages video)
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages backup)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages cdrom)
> @@ -2119,6 +2120,65 @@ (define-public mplayer
>  SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
>      (license license:gpl2)))
>  
> +(define-public smplayer
> +  (package
> +    (name "smplayer")
> +    (version "21.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/smplayer/SMPlayer/"
> version
> +                    "/smplayer-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r
> c"))))
> +    (build-system qt-build-system)
> +    (native-inputs
> +     `(("qttools" ,qttools)))
> +    (inputs
> +     `(("bash-minimal" ,bash-minimal)
> +       ("qtbase" ,qtbase-5)
> +       ("zlib" ,zlib)
> +       ("mpv" ,mpv)))
> +    (arguments
> +     `(#:tests? #false             ; no tests
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out"))
> +                          (string-append "CC=" ,(cc-for-target))
> +                          ;; A KLUDGE to turn off invoking lrelease
> on the
> +                          ;; project for now, because it fails
> consistently
> +                          ;; with "WARNING: Could not find qmake
> spec
> +                          ;; 'default'". See below.
> +                          "LRELEASE=true")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         ;; Due to the above, we must run lrelease separately on
> each .ts file
> +         ;; (as opposed to running `lrelease-pro smplayer.pro` for
> the entire
> +         ;; project, as the Makefile does normally without the above
> kludge).
> +         (add-after 'build 'compile-ts-files
> +           (lambda _
> +             (for-each (lambda (file)
> +                         (invoke "lrelease" file))
> +                       (find-files "./" "\\.ts$"))
> +             #true))
> +         (add-after 'install 'wrap-executable
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (mpv (assoc-ref inputs "mpv")))
> +               (wrap-program (string-append out "/bin/smplayer")
> +                 `("PATH" ":" prefix
> +                   ,(list (string-append mpv "/bin")))))
> +             #true)))))
Rather than patching PATH, you ought to rewrite the calls to exec or
whatever is used to spawn mpv.
> +    (home-page "https://www.smplayer.info")
> +    (synopsis "Complete front-end for MPlayer, a media player")
> +    (description "SMPlayer is a graphical user interface (GUI) for
> +MPlayer, which is capable of playing almost all known video and
> audio
> +formats.  Apart from providing access for the most common and useful
> +options of MPlayer, SMPlayer adds other interesting features like
> the
> +possibility to play Youtube videos, download subtitles, remember
> +the last played position, etc.")
> +    (license license:gpl2+)))
Description LGTM now, but perhaps you ought to move the program itself
below mpv.

Cheers





Information forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.

Message received at 51534 <at> debbugs.gnu.org:


Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 12:15:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 07:15:11 2021
Received: from localhost ([127.0.0.1]:35063 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrJ5L-00078Y-0Y
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 07:15:11 -0500
Received: from mail-ed1-f43.google.com ([209.85.208.43]:40671)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1mrJ5G-00077e-7k
 for 51534 <at> debbugs.gnu.org; Sun, 28 Nov 2021 07:15:08 -0500
Received: by mail-ed1-f43.google.com with SMTP id r25so59551783edq.7
 for <51534 <at> debbugs.gnu.org>; Sun, 28 Nov 2021 04:15:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=m7+ay4OnlWtr9n93FKNbipusSUGB/S0B1FoKhzOtEXs=;
 b=dbT+vvm9OB0hy1X9B8jzaHWH5fkxIK5kFmBC+h+mJMV8GlhGeRDSnB/P9wDFpjsO30
 RBTWyb+AOWOF4qrfueZ1kIyCuIRbDf+EYMRpVQRi4ymPMVhH44Y2OuxEmCsxcyVINwyZ
 tTik43qtzfU7Y1hjQRQ5IqDveIr7Z+ngxMhYx5aosPG7x8SCYdE7ns17mZVlsGBxrsSI
 BemZabMj81QCj1BQcYZeLnYpROPI5IrHPkTfGP6Jk7bmVGep4dCwdPYRPgTs+3DlEcK+
 NdTkgnrfCal8ArudREX52OVznRxPGhmTXGj88OICVbni5Q/OmdwaIsypKWvqyLsaVDnt
 Y58A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :mime-version:content-transfer-encoding;
 bh=m7+ay4OnlWtr9n93FKNbipusSUGB/S0B1FoKhzOtEXs=;
 b=Ymi5d/1HW9FvPbreq2or+0Lk0RXBTr9IgPIWdvnn4Q8RC0ssHbwz0+JfqMptyORyDi
 UkoC5LvQFoKT7NuJdTdBm4SqZ/biR5qrolCQMr/LHet0q//CpkYGkZ9Be6TXWbi1Zech
 xLxBFQA7irk1dT8XbHULGqXG9PKPQzHI/UiCRMszSF2GvIpjoOqva7ILEEsR/Zv67EKg
 QuW6Ztp+Iar19qK5cgxymc7lL6MEC+iqJS/GgNfYoBFnJ4/iWKKRzL24KaVab0KuEBUk
 msEs1zV124bfv/rtiW6E//7rVVmrHyxrV7By0HKVsItVVkWKXHnfT1/fZhrVK57lvtgf
 VsYA==
X-Gm-Message-State: AOAM531kSBiu9b0K2ifB3puuzylU8sQMXXZO/LrIvXQB3iKnq/WMRyVu
 Oq5dc+bwx9FbEPeZH7dze33/+ElYjic=
X-Google-Smtp-Source: ABdhPJyBh09jziH1fE67ziYkorZwoHw1ZvZ0IPCELEN6GhQJU0A+SeI8rozN2yKMPi9wVxw+sUcUaQ==
X-Received: by 2002:a05:6402:90c:: with SMTP id
 g12mr64650986edz.217.1638101700247; 
 Sun, 28 Nov 2021 04:15:00 -0800 (PST)
Received: from localhost.localdomain
 ([2a02:ab88:3700:b180:6072:12a9:8472:9a8f])
 by smtp.gmail.com with ESMTPSA id f7sm7127212edw.44.2021.11.28.04.14.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 28 Nov 2021 04:14:59 -0800 (PST)
From: Attila Lendvai <attila@HIDDEN>
To: 51534 <at> debbugs.gnu.org
Subject: [PATCH v4] gnu: Add smplayer v21.10.0.
Date: Sun, 28 Nov 2021 13:12:05 +0100
Message-Id: <20211128121204.3348-1-attila@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 51534
Cc: Attila Lendvai <attila@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* gnu/packages/video.scm (smplayer): New variable.
---

v4 adds bash-minimal to the inputs as per guix lint. sorry for the miss!

there's another lint warning that i can't fix:

"smplayer@HIDDEN: source not archived on Software Heritage and missing
from the Disarchive database"

and forgot to mention that v3 switched to the qt-build-system.

 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff1abb308f..5cb645baac 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -100,6 +100,7 @@ (define-module (gnu packages video)
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
@@ -2119,6 +2120,65 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("bash-minimal" ,bash-minimal)
+       ("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mpv" ,mpv)))
+    (arguments
+     `(#:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (lambda (file)
+                         (invoke "lrelease" file))
+                       (find-files "./" "\\.ts$"))
+             #true))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (mpv (assoc-ref inputs "mpv")))
+               (wrap-program (string-append out "/bin/smplayer")
+                 `("PATH" ":" prefix
+                   ,(list (string-append mpv "/bin")))))
+             #true)))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a graphical user interface (GUI) for
+MPlayer, which is capable of playing almost all known video and audio
+formats.  Apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos, download subtitles, remember
+the last played position, etc.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0





Information forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.

Message received at 51534 <at> debbugs.gnu.org:


Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 11:34:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 06:34:15 2021
Received: from localhost ([127.0.0.1]:35052 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrIRj-0006Ae-CH
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 06:34:15 -0500
Received: from mail-ed1-f48.google.com ([209.85.208.48]:36698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1mrIRh-0006AS-GW
 for 51534 <at> debbugs.gnu.org; Sun, 28 Nov 2021 06:34:14 -0500
Received: by mail-ed1-f48.google.com with SMTP id z5so59579571edd.3
 for <51534 <at> debbugs.gnu.org>; Sun, 28 Nov 2021 03:34:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=mdv8E2IiPdnlJRf8DO6qo6xpF3FbdA5ZHkn3FoDaxIs=;
 b=jsf+HWXacjJC6+EytQKiSZoEKaU8aElaG4fpCg18bqjvwU0QxGxCF4tdJOEoQkBnyo
 3p5bumapoTNY+l6YbYSbiSKdHTj3iuaRAWNqvkvVoJG3HOCGKIW9j5MCBQavKWEnRbe0
 tAfhvL7B7QhvpTpNaIdZ0i6AX6DVcRrHlIEYEWcSfQbGfSo4Mr70X84qU5Kde45JaIST
 G6pXxdO5VgXz6Ev5W3qwps00eVy0jZeMRLwAIkEXcxsKX9AtHqsqCWKH9uxz9Zc4LiSV
 uVugJoLnyD762tA4rYO2o8x+eDdsZ3C1hBKGfNlX3y2wMThaSbAhrVHH3J8xbKbMHmDx
 Z/qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :mime-version:content-transfer-encoding;
 bh=mdv8E2IiPdnlJRf8DO6qo6xpF3FbdA5ZHkn3FoDaxIs=;
 b=wSl/DNvnpJOWNcrjipYrhwUi5LDzNuVJ+KR2ylejBeMaAtO/USD+wsYpZd3If2SjUr
 rlART8L6gQG/c5PyjKpaswce6PhH1AwAuLjszqD0ef947vUMZov7wM3IZSt59yqHjFYg
 eWAf3LjfmGlIGp2vJ1o7Vu4sgctxQOeyPlt8mjvDFyan7nIQkDZZUt1IVBWTmCi15EDA
 O11D9AbRQOBkMLcJjQOcqbjTTpZgkphI4bK8D6R+TS56/a/gspjWE6B8Nva+CKh/uGEN
 paatriXbrs0TfMXW89o9rk/44nVtHIeM6bbnrmZfdk6Yg39QISZ071b332MVUnb//yDD
 IiEQ==
X-Gm-Message-State: AOAM530AZ0ELmcMNjoAILvNtW0eK4LBh5aQp9liWavc8CxbMbxkrTexv
 lQW/5jfkCQv8kH+VNRsvJfrZ+MxbitE=
X-Google-Smtp-Source: ABdhPJymtrKC02EAlstcvhnpfGFm0+OpofUc+m6Pj/ptzqkszB6PRAA+3kM7qnruXcNTAQTsXrxZ3g==
X-Received: by 2002:a05:6402:2756:: with SMTP id
 z22mr65290912edd.200.1638099247494; 
 Sun, 28 Nov 2021 03:34:07 -0800 (PST)
Received: from localhost.localdomain
 ([2a02:ab88:3700:b180:6072:12a9:8472:9a8f])
 by smtp.gmail.com with ESMTPSA id k16sm7029753edq.77.2021.11.28.03.34.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 28 Nov 2021 03:34:06 -0800 (PST)
From: Attila Lendvai <attila@HIDDEN>
To: 51534 <at> debbugs.gnu.org
Subject: [PATCH v3] gnu: Add smplayer v21.10.0.
Date: Sun, 28 Nov 2021 12:30:04 +0100
Message-Id: <20211128113003.15627-1-attila@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 51534
Cc: Attila Lendvai <attila@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* gnu/packages/video.scm (smplayer): New variable.
---

thank you for the feedback Liliana!

i have edited the copy-pasted description to be shorter.

i've also done some more thourough testing, and indeed wrapping the executable
was necessary to add mpv (the media player backend) to the PATH. previously i
had it installed in my profile and SMPlayer found it from there.

 gnu/packages/video.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff1abb308f..debc608694 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2119,6 +2119,64 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mpv" ,mpv)))
+    (arguments
+     `(#:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (lambda (file)
+                         (invoke "lrelease" file))
+                       (find-files "./" "\\.ts$"))
+             #true))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (mpv (assoc-ref inputs "mpv")))
+               (wrap-program (string-append out "/bin/smplayer")
+                 `("PATH" ":" prefix
+                   ,(list (string-append mpv "/bin")))))
+             #true)))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a graphical user interface (GUI) for
+MPlayer, which is capable of playing almost all known video and audio
+formats.  Apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos, download subtitles, remember
+the last played position, etc.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0





Information forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.

Message received at 51534 <at> debbugs.gnu.org:


Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 09:17:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 04:17:59 2021
Received: from localhost ([127.0.0.1]:34932 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrGJr-0002G1-Dh
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 04:17:59 -0500
Received: from mail-wr1-f66.google.com ([209.85.221.66]:46949)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1mrGJl-0002Fk-Gl
 for 51534 <at> debbugs.gnu.org; Sun, 28 Nov 2021 04:17:56 -0500
Received: by mail-wr1-f66.google.com with SMTP id u1so29449195wru.13
 for <51534 <at> debbugs.gnu.org>; Sun, 28 Nov 2021 01:17:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=iCktzbjh6c3sL4qtl77nVD3Q4vNFmIJFac/AO0SS4To=;
 b=RC9LYOjrDONxhfgiPXo80cjONbPNMYOUWvvODYK5wqleYLqxgXr/Qm+LBQK87QcK0l
 4jjiPOXFWKiIN4z9QogRsMA4MgzMx68XhlschYE0kpEZWy0Xy1DJyE1vEkFr2fxkvJKt
 l20SW9+xTJW8oelcLy6yuiR/PSawd0VsFmgsA+IBovPZb2IXjZrkVTXQXKqU+9dh4l9P
 GEsEMbtvUUi+myqF65+FbKtct0pwaz6Vf9g4z+vBbMxreKBmnaVlds5rRBqsvhNHvKkO
 /iRov5H11Kxt5CHwAZLUL91U+ISvjB99jaVGbZh1mxFTyVPZcg3gFov8D8mbj0iTALFd
 ZjyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=iCktzbjh6c3sL4qtl77nVD3Q4vNFmIJFac/AO0SS4To=;
 b=AJWd1ij1kAfm1FQUpf7MZBOZdNEkZFbxK7O/Z+/DhlUdZRzkWlROJOObxOqwstMlh6
 NkQLV6miDawcs3SFTO3qLkocCa3oj9OWrn7ecXOrc3bKh7S6hEqelcLbGKfJEjNtxmQM
 G1ipaSN6v2v6vxLZyw2oAMSkdL44vUzdp+ElO9+y5lkGAtmqd+Sp3B0KijrwCFFZwn2S
 aafzLo2aTa002gzKvOjfyNIZxzNpxGa5m3vhsQKuzFHIdbTuh3Mr1MTZGYy12OdWO3Q3
 H8fVLGEUvTEPeS5w+sYTgVnmGjbkOt7g9uxzzldgXrb0w917cTgx31cQsBBcB4Vjhq+3
 oa5g==
X-Gm-Message-State: AOAM533dWcVRfmezRWUPmgmYCA+BnGPCvBIMvGt4Y+Emb5beOO0O0iQx
 2T0UsSQw+54mV6t+AnvfiM4=
X-Google-Smtp-Source: ABdhPJxihsoqfP8MeVUfzac0wr0zL88VzBtRnBlJbGv9HFDUxOUurSukFTn7bEytJ6rAogefPjwY4A==
X-Received: by 2002:adf:f352:: with SMTP id e18mr26537072wrp.39.1638091067713; 
 Sun, 28 Nov 2021 01:17:47 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id l5sm12728467wrs.59.2021.11.28.01.17.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 28 Nov 2021 01:17:47 -0800 (PST)
Message-ID: <fbbad1d6e7563a1f80ff82e83d55913c4ffe71b8.camel@HIDDEN>
Subject: Re: [PATCH v2] gnu: Add smplayer.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Attila Lendvai <attila@HIDDEN>, 51534 <at> debbugs.gnu.org
Date: Sun, 28 Nov 2021 10:17:45 +0100
In-Reply-To: <20211101010411.10306-1-attila@HIDDEN>
References: <20211101010411.10306-1-attila@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi, Am Montag, den 01.11.2021, 02:04 +0100 schrieb Attila
 Lendvai: > * gnu/packages/video.scm (smplayer): New variable. > --- > > i
 forgot to double check the licence, it's gpl2+, not gpl3+. > otherwise, [...]
 Content analysis details:   (1.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (liliana.prikler[at]gmail.com)
 0.0 T_PDS_PRO_TLD          .pro TLD [URI: smplayer.pro (pro)]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 1.3 RCVD_IN_VALIDITY_RPBL  RBL: Relay in Validity RPBL,
 https://senderscore.org/blocklistlookup/
 [209.85.221.66 listed in bl.score.senderscore.com]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.221.66 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.221.66 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 51534
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

Hi,

Am Montag, den 01.11.2021, 02:04 +0100 schrieb Attila Lendvai:
> * gnu/packages/video.scm (smplayer): New variable.
> ---
> 
> i forgot to double check the licence, it's gpl2+, not gpl3+.
> otherwise, it's the same as the previous patch.
> 
>  gnu/packages/video.scm | 60
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 245007f294..2915f85352 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2092,6 +2092,66 @@ (define-public mplayer
>  SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
>      (license license:gpl2)))
>  
> +(define-public smplayer
> +  (package
> +    (name "smplayer")
> +    (version "21.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/smplayer/SMPlayer/"
> version
> +                    "/smplayer-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r
> c"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("qttools" ,qttools)))
> +    (inputs
> +     `(("qtbase" ,qtbase-5)
> +       ("zlib" ,zlib)
> +       ("mplayer" ,mplayer)))
> +    (arguments
> +     `(#:modules (,@%gnu-build-system-modules
> +                  (srfi srfi-26))
> +       #:tests? #false             ; no tests
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out"))
> +                          (string-append "CC=" ,(cc-for-target))
> +                          ;; A KLUDGE to turn off invoking lrelease
> on the
> +                          ;; project for now, because it fails
> consistently
> +                          ;; with "WARNING: Could not find qmake
> spec
> +                          ;; 'default'". See below.
> +                          "LRELEASE=true")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         ;; Due to the above, we must run lrelease separately on
> each .ts file
> +         ;; (as opposed to running `lrelease-pro smplayer.pro` for
> the entire
> +         ;; project, as the Makefile does normally without the above
> kludge).
> +         (add-after 'build 'compile-ts-files
> +           (lambda _
> +             (for-each (cut invoke "lrelease" <>)
You might want to spell out that cut to avoid needing SRFI 26.  If you
do want to use SRFI 26 I'm pretty sure that cute is the more efficient
variant here.
> +                       (find-files "./" "\\.ts$")))))))
> +    (home-page "https://www.smplayer.info")
> +    (synopsis "Complete front-end for MPlayer, a media player")
> +    (description "SMPlayer is a free media player for Windows and
> Linux
> +with built-in codecs that can play virtually all video and audio
> formats.
> +It doesn't need any external codecs.  Just install SMPlayer and
> you'll be
> +able to play all formats without the hassle to find and install
> codec packs.
> +
> +One of the most interesting features of SMPlayer: it remembers the
> +settings of all files you play.  So you start to watch a movie but
> you have
> +to leave... don't worry, when you open that movie again it will be
> resumed
> +at the same point you left it, and with the same settings: audio
> track,
> +subtitles, volume...
> +
> +SMPlayer is a graphical user interface (GUI) for the award-winning
> +MPlayer, which is capable of playing almost all known video and
> audio
> +formats.  But apart from providing access for the most common and
> useful
> +options of MPlayer, SMPlayer adds other interesting features like
> the
> +possibility to play Youtube videos or download subtitles.")
Descriptions are for describing, not for advertising.  Please cut it
down to the meaningful bits.
> +    (license license:gpl2+)))
> +
I haven't built or ran the package, but from my lexical analysis I did
infer it was a more or less standard Qt thing.  I'm not sure if you
need to wrap some Qt-specific variables here similar to how it's done
in qt-build-system.  Otherwise LGTM.

Cheers





Information forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.

Message received at 51534 <at> debbugs.gnu.org:


Received: (at 51534) by debbugs.gnu.org; 1 Nov 2021 01:05:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 31 21:05:47 2021
Received: from localhost ([127.0.0.1]:33353 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhLli-0001LO-TT
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 21:05:47 -0400
Received: from mail-wr1-f42.google.com ([209.85.221.42]:36403)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1mhLlg-0001LB-Tq
 for 51534 <at> debbugs.gnu.org; Sun, 31 Oct 2021 21:05:46 -0400
Received: by mail-wr1-f42.google.com with SMTP id s13so18744454wrb.3
 for <51534 <at> debbugs.gnu.org>; Sun, 31 Oct 2021 18:05:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=ECxynfLL1b7kuxq342GCn1m+8vGPhE2IqD5xWn7pVno=;
 b=YSCDNNiEx7/hW/771cClvH9DNkVxDJHQDw545yuYOOA+psezdJObVjFzo4M/76aHTX
 myrlVpPLng16Mgg41gpcEY9c7zlVpCQ6mgEKoeGKPbTvkfnR3GlV2/yLg2sKexu6GkcO
 Vj4QQJkKEGZwsdriG6yEx7kk/I1Edq/3AHPjL7atDaXrX3AFKU+tmXsrHlwCSj7rwmr3
 Cov7iqGt2tPM8OZzT2m0JXHegzhpG6gQuCaOOC6amJnmoX4Gzqv5mPXMm+sMkycM9DeW
 63umI0VhtUvEkeR6ZL67owjGjyLDBPXkKEml4KILG7fh6rqRSkqaCe00Hf4ePGeJpPLj
 UNug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :mime-version:content-transfer-encoding;
 bh=ECxynfLL1b7kuxq342GCn1m+8vGPhE2IqD5xWn7pVno=;
 b=TxVKcjp4R30QZgosO+LZ+2mjNL3r5KJxL066h6XrGlv7W/wn7I8GKQOTODDuD5bhLM
 ZCofxvGtmS4SVzDS3kusBiO+1UnUqd8141NKYb8GGQDgkbjJLHXDvLLX+u0x4MKv6/SO
 D0wgoSONjUgJ1W/eXysTO5xtQiiBdw04i7k6u45MqREkS9jC2JPiIg1xGEohQjrcpeBo
 P3q2ggw32SZUIxLXuYOlCrlwvB9Nk5XDdfVdqi9hWBYAfoDEbqDkGfZLoXNCdArIOWUX
 6R/llp6EuQz8ZO19IQwGZxOnTVIjQTlCDAEFKERfA+YcMzdBOL8dofKFhn02cuX7hQUx
 3BkA==
X-Gm-Message-State: AOAM5321U2pBlSS4MCTb94qKY18d5P64bl35aPI9k+xjtwrmri+pKaYw
 BnwHT5b+WcLQoHr8p+tpP0cNQ38nb/g=
X-Google-Smtp-Source: ABdhPJzG0QfKqpBEfm2VxuzrwRp6+6CHEcG2p8/kxR5dtyP6e476tC4ZIK9HM5bHnzUx/+wUoarw8g==
X-Received: by 2002:adf:e50b:: with SMTP id j11mr26811495wrm.430.1635728739036; 
 Sun, 31 Oct 2021 18:05:39 -0700 (PDT)
Received: from lelap.lan (catv-89-132-208-37.catv.broadband.hu.
 [89.132.208.37])
 by smtp.gmail.com with ESMTPSA id a9sm8854364wrt.66.2021.10.31.18.05.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Oct 2021 18:05:38 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
To: 51534 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add smplayer.
Date: Mon,  1 Nov 2021 02:04:12 +0100
Message-Id: <20211101010411.10306-1-attila@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 51534
Cc: Attila Lendvai <attila@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* gnu/packages/video.scm (smplayer): New variable.
---

i forgot to double check the licence, it's gpl2+, not gpl3+. otherwise,
it's the same as the previous patch.

 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 245007f294..2915f85352 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2092,6 +2092,66 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mplayer" ,mplayer)))
+    (arguments
+     `(#:modules (,@%gnu-build-system-modules
+                  (srfi srfi-26))
+       #:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (cut invoke "lrelease" <>)
+                       (find-files "./" "\\.ts$")))))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a free media player for Windows and Linux
+with built-in codecs that can play virtually all video and audio formats.
+It doesn't need any external codecs.  Just install SMPlayer and you'll be
+able to play all formats without the hassle to find and install codec packs.
+
+One of the most interesting features of SMPlayer: it remembers the
+settings of all files you play.  So you start to watch a movie but you have
+to leave... don't worry, when you open that movie again it will be resumed
+at the same point you left it, and with the same settings: audio track,
+subtitles, volume...
+
+SMPlayer is a graphical user interface (GUI) for the award-winning
+MPlayer, which is capable of playing almost all known video and audio
+formats.  But apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos or download subtitles.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0





Information forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 1 Nov 2021 00:59:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 31 20:59:58 2021
Received: from localhost ([127.0.0.1]:33348 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mhLg6-0001BH-4P
	for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 20:59:58 -0400
Received: from lists.gnu.org ([209.51.188.17]:53024)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1mhLg3-0001B9-P2
 for submit <at> debbugs.gnu.org; Sun, 31 Oct 2021 20:59:56 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40432)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <attila.lendvai@HIDDEN>)
 id 1mhLg3-0001Qb-HU
 for guix-patches@HIDDEN; Sun, 31 Oct 2021 20:59:55 -0400
Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:36749)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <attila.lendvai@HIDDEN>)
 id 1mhLg1-0000Pt-7j
 for guix-patches@HIDDEN; Sun, 31 Oct 2021 20:59:55 -0400
Received: by mail-wr1-x432.google.com with SMTP id s13so18730021wrb.3
 for <guix-patches@HIDDEN>; Sun, 31 Oct 2021 17:59:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=GOvF/TRfgMLyuvfAwKSTqed9Oe6OyoY6ya+ViCvyZFo=;
 b=mcC/ot3OOh5CA81hl74obze10c+jPofpHFF8QkBdP9GTCweAKMoAe1z2Z158HOJ5KL
 wOjn48KgvwrGuVSlHh4onkx1kDltjwgmptYxfQaDRNXCwa8xCdNubSLNPREO+EmeQKv4
 CSmYBthTuJJXq6qhM13rGasMOUBOeymR+YOq99wyginMStvePs1gXqw65Wq2jO+W1JAo
 F90v1Ny4tGd/D8LArbtF7PbY35HuXr46jpiViQNRNG6NLBgwfIgI9bsqRfXqx+6A+mZF
 PAx3mLJ3KDVCbpA3SG16/eaj7cVDNY11GhdJ2TC+rK0Lo+ZzVODWj/n1T4aGf8GM7tzU
 s0Jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :mime-version:content-transfer-encoding;
 bh=GOvF/TRfgMLyuvfAwKSTqed9Oe6OyoY6ya+ViCvyZFo=;
 b=XdwK6ZUUCMSeOw5s/4VW0IBr83kK0mzfjEN+WEMqHmLCWDGDqPN68m3QeCT0jXvP+j
 ccK0ShJ61HKdQNINYhcqb0BuSbifC4k6SuSXpUE+Sd1PnsaC3WvK5iGqOBzYFmAlSS+W
 6e05AhYF9ZLDQ1qEn3VBcV6rOYYcLK8cSMrc45IhurnTKO6Q8gnd+LJEmq+9J9cDfKOd
 UjC6V03kAlN4OYbJ5TJJvcYlZBJIYemy0xI/bEFBkOh/oLGlIozCbf9q9/eqRj5znvDm
 t5p/ZO3gm/IQVFiA9DzO0KHWeJFPEVCJzfgTx2vq7Mhw0nQngGwUofDlUKvL8mN61ojJ
 n1Dw==
X-Gm-Message-State: AOAM531bdLKXdcty0UE04JA/T6SLqtG+mRmn6VFycWgMEASDaLU5eoIv
 MVEHnDKsW30huB3/DwcexVGpkTUlNyg=
X-Google-Smtp-Source: ABdhPJyDfAEcLfh/CCNEGTqSczh99F/iwD026NUbEAC0P2DtfQ8vIhrOp6/qRyLmklg7yF/dMJd5IA==
X-Received: by 2002:a05:6000:156e:: with SMTP id
 14mr34412195wrz.358.1635728390517; 
 Sun, 31 Oct 2021 17:59:50 -0700 (PDT)
Received: from lelap.lan (catv-89-132-208-37.catv.broadband.hu.
 [89.132.208.37])
 by smtp.gmail.com with ESMTPSA id e18sm10921188wrs.48.2021.10.31.17.59.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 31 Oct 2021 17:59:50 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add smplayer.
Date: Mon,  1 Nov 2021 01:59:36 +0100
Message-Id: <20211101005935.8731-1-attila@HIDDEN>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::432;
 envelope-from=attila.lendvai@HIDDEN; helo=mail-wr1-x432.google.com
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_PDS_PRO_TLD=0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-Debbugs-Envelope-To: submit
Cc: Attila Lendvai <attila@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

* gnu/packages/video.scm (smplayer): New variable.
---
 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 245007f294..ecd5ab8728 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2092,6 +2092,66 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mplayer" ,mplayer)))
+    (arguments
+     `(#:modules (,@%gnu-build-system-modules
+                  (srfi srfi-26))
+       #:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (cut invoke "lrelease" <>)
+                       (find-files "./" "\\.ts$")))))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a free media player for Windows and Linux
+with built-in codecs that can play virtually all video and audio formats.
+It doesn't need any external codecs. Just install SMPlayer and you'll be
+able to play all formats without the hassle to find and install codec packs.
+
+One of the most interesting features of SMPlayer: it remembers the
+settings of all files you play. So you start to watch a movie but you have
+to leave... don't worry, when you open that movie again it will be resumed
+at the same point you left it, and with the same settings: audio track,
+subtitles, volume...
+
+SMPlayer is a graphical user interface (GUI) for the award-winning
+MPlayer, which is capable of playing almost all known video and audio
+formats. But apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos or download subtitles.")
+    (license license:gpl3+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0





Acknowledgement sent to Attila Lendvai <attila@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#51534; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 28 Nov 2021 12:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.