GNU bug report logs - #51557
27.2; `mouse-1' with `cua-rectangle-mark-mode'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51557 in the body.
You can then email your comments to 51557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 27.2; `mouse-1' with `cua-rectangle-mark-mode'
Date: Mon, 1 Nov 2021 19:14:04 +0000

I don't use `cua-rectangle-mark-mode'.  I just happened upon this
behavior, and found it odd (bugged?).  Feel free to close if you
think this isn't problematic.

emacs -Q

M-x cua-rectangle-mark-mode ; (after selecting a region or not)

Click `mouse-1' somewhere.  No effect, it seems.  The mode remains in
effect (same key help is displayed).

Click `mouse-1' again (anywhere).  It seems that that exits
`cua-rectangle-mode'.

Should `mouse-1' do something for this mode?  (`mouse-3' apparently
extends the rectangle.)  Should it exit on first click?  Should you get
some feedback of whatever it does?

`rectangle-mark-mode' also lets `mouse-3' extend the rectangle.  But for
it, `mouse-1' apparently exits the mode.

That seems more reasonable.  But perhaps the mode should be continued
and `mouse-1' should just reinitialize it (set its starting point).
(The normal behavior of `mouse-1' is, after all, to set point.)

In GNU Emacs 27.2 (build 1, x86_64-w64-mingw32)
 of 2021-03-26 built on CIRROCUMULUS
Repository revision: deef5efafb70f4b171265b896505b92b6eef24e6
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.19042
System Description: Microsoft Windows 10 Pro (v10.0.2009.19042.1288)

Message #8 received at 51557 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 51557 <at> debbugs.gnu.org
Subject: Re: bug#51557: 27.2; `mouse-1' with `cua-rectangle-mark-mode'
Date: Thu, 04 Nov 2021 19:35:49 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

> M-x cua-rectangle-mark-mode ; (after selecting a region or not)
>
> Click `mouse-1' somewhere.  No effect, it seems.  The mode remains in
> effect (same key help is displayed).
>
> Click `mouse-1' again (anywhere).  It seems that that exits
> `cua-rectangle-mode'.

It seems like the intention is to re-start the rectangle on mouse-1?  I
don't use the mode either, but that does seem to make sense to me.

(defun cua-mouse-set-rectangle-mark (event)
  "Start rectangle at mouse click position."
  (interactive "e")
  (when cua--rectangle
    (cua--deactivate-rectangle)
    (cua--deactivate t))
  (setq cua--last-rectangle nil)
  (mouse-set-point event)
  ;; FIX ME -- need to calculate virtual column.
  (cua-set-rectangle-mark)
  (setq cua--buffer-and-point-before-command nil)
  (setq cua--mouse-last-pos nil))

And I guess the "FIX ME" is part of the problem here.  Anybody else got
any insights here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 51557 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "51557 <at> debbugs.gnu.org" <51557 <at> debbugs.gnu.org>
Subject: RE: [External] : Re: bug#51557: 27.2; `mouse-1' with
 `cua-rectangle-mark-mode'
Date: Thu, 4 Nov 2021 18:47:14 +0000

> > M-x cua-rectangle-mark-mode ; (after selecting a region or not)
> >
> > Click `mouse-1' somewhere.  No effect, it seems.  The mode remains in
> > effect (same key help is displayed).
> >
> > Click `mouse-1' again (anywhere).  It seems that that exits
> > `cua-rectangle-mode'.
> 
> It seems like the intention is to re-start the rectangle on mouse-1?  I
> don't use the mode either, but that does seem to make sense to me.
> 
> (defun cua-mouse-set-rectangle-mark (event)
>   "Start rectangle at mouse click position."
>   (interactive "e")
>   (when cua--rectangle
>     (cua--deactivate-rectangle)
>     (cua--deactivate t))
>   (setq cua--last-rectangle nil)
>   (mouse-set-point event)
>   ;; FIX ME -- need to calculate virtual column.
>   (cua-set-rectangle-mark)
>   (setq cua--buffer-and-point-before-command nil)
>   (setq cua--mouse-last-pos nil))
> 
> And I guess the "FIX ME" is part of the problem here.  Anybody else got
> any insights here?

Whatever you decide, I suggest that (other things being
equal), the same behavior be added to `rectangle-mark-mode'.

(It seems to me that mouse-1 could do something useful
here.  Maybe that would be a simple as exiting (as in
`rectangle-mark-mode' or as simple as restarting a
rectangle.  Or maybe it could be something more helpful
or more interesting (I don't have any suggestion, off
the top of my head.).

Message #16 received at 51557 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 51557 <at> debbugs.gnu.org
Subject: Re: bug#51557: 27.2; `mouse-1' with `cua-rectangle-mark-mode'
Date: Sat, 04 Dec 2021 04:06:50 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It seems like the intention is to re-start the rectangle on mouse-1?  I
> don't use the mode either, but that does seem to make sense to me.

So I've now made it do this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.