GNU bug report logs - #51559
Webkit fails to build

Previous Next

Package: guix;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Mon, 1 Nov 2021 21:03:02 UTC

Severity: normal

Merged with 51555, 51564

Done: Mark H Weaver <mhw <at> netris.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51559 in the body.
You can then email your comments to 51559 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Mon, 01 Nov 2021 21:03:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 01 Nov 2021 21:03:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: Webkit fails to build
Date: Mon, 01 Nov 2021 22:02:51 +0100
Copypasta of the relevant log
(/var/log/guix/drvs/pr/nl8g1ky1z3l3dfp4llh50w5qzd2qz4-webkitgtk-
2.34.1.drv.bz2):

-- Checking for module 'egl'
--   Found egl, version 20.2.4
-- Found EGL: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
20.2.4/include  
-- Checking for module 'gl'
--   Found gl, version 20.2.4
-- Found OpenGL: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
20.2.4/include  
-- Looking for include file GL/glx.h
-- Looking for include file GL/glx.h - found
-- Checking for module 'glesv2'
--   Found glesv2, version 20.2.4
-- Found OpenGLES2: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
20.2.4/lib/libGLESv2.so (found version "3.2") 
-- Checking for module 'gtk+-3.0'
--   Found gtk+-3.0, version 3.24.24
-- Checking for module 'gtk+-unix-print-3.0'
--   Found gtk+-unix-print-3.0, version 3.24.24
-- Found GTK: 3.24.24 (Required is at least version "3.22.0") 
-- Could NOT find LibSoup: Found unsuitable version "", but required is
at least "2.99.9" (found LIBSOUP_INCLUDE_DIRS-NOTFOUND)
CMake Error at Source/cmake/OptionsGTK.cmake:212 (message):
  libsoup 3 is required.  Enable USE_SOUP2 to use libsoup 2 (disables
HTTP/2)
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:220 (include)
  CMakeLists.txt:20 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/guix-build-webkitgtk-2.34.1.drv-
0/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/guix-build-webkitgtk-2.34.1.drv-
0/build/CMakeFiles/CMakeError.log".
command "cmake" "../webkitgtk-2.34.1" "-DCMAKE_BUILD_TYPE=Release" "-
DCMAKE_INSTALL_PREFIX=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-
webkitgtk-2.34.1" "-DCMAKE_INSTALL_LIBDIR=lib" "-
DCMAKE_INSTALL_RPATH_USE_LINK_PATH=TRUE" "-
DCMAKE_INSTALL_RPATH=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-
webkitgtk-2.34.1/lib" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DPORT=GTK" "-
DENABLE_GTKDOC=ON" "-DENABLE_GAMEPAD=OFF" "-DUSE_SYSTEMD=OFF" "-
DLIB_INSTALL_DIR=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-webkitgtk-
2.34.1/lib" "-DUSE_GSTREAMER_GL=OFF" failed with status 1





Merged 51555 51559. Request was from Tobias Geerinckx-Rice <me <at> tobias.gr> to control <at> debbugs.gnu.org. (Tue, 02 Nov 2021 00:31:01 GMT) Full text and rfc822 format available.

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Tue, 02 Nov 2021 03:15:02 GMT) Full text and rfc822 format available.

Notification sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
bug acknowledged by developer. (Tue, 02 Nov 2021 03:15:02 GMT) Full text and rfc822 format available.

Message #12 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51559-done <at> debbugs.gnu.org
Subject: Re: bug#51559: Webkit fails to build
Date: Mon, 01 Nov 2021 23:14:37 -0400
Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Copypasta of the relevant log
> (/var/log/guix/drvs/pr/nl8g1ky1z3l3dfp4llh50w5qzd2qz4-webkitgtk-
> 2.34.1.drv.bz2):
>
> -- Checking for module 'egl'
> --   Found egl, version 20.2.4
> -- Found EGL: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
> 20.2.4/include  
> -- Checking for module 'gl'
> --   Found gl, version 20.2.4
> -- Found OpenGL: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
> 20.2.4/include  
> -- Looking for include file GL/glx.h
> -- Looking for include file GL/glx.h - found
> -- Checking for module 'glesv2'
> --   Found glesv2, version 20.2.4
> -- Found OpenGLES2: /gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-
> 20.2.4/lib/libGLESv2.so (found version "3.2") 
> -- Checking for module 'gtk+-3.0'
> --   Found gtk+-3.0, version 3.24.24
> -- Checking for module 'gtk+-unix-print-3.0'
> --   Found gtk+-unix-print-3.0, version 3.24.24
> -- Found GTK: 3.24.24 (Required is at least version "3.22.0") 
> -- Could NOT find LibSoup: Found unsuitable version "", but required is
> at least "2.99.9" (found LIBSOUP_INCLUDE_DIRS-NOTFOUND)
> CMake Error at Source/cmake/OptionsGTK.cmake:212 (message):
>   libsoup 3 is required.  Enable USE_SOUP2 to use libsoup 2 (disables
> HTTP/2)
> Call Stack (most recent call first):
>   Source/cmake/WebKitCommon.cmake:220 (include)
>   CMakeLists.txt:20 (include)
>
>
> -- Configuring incomplete, errors occurred!
> See also "/tmp/guix-build-webkitgtk-2.34.1.drv-
> 0/build/CMakeFiles/CMakeOutput.log".
> See also "/tmp/guix-build-webkitgtk-2.34.1.drv-
> 0/build/CMakeFiles/CMakeError.log".
> command "cmake" "../webkitgtk-2.34.1" "-DCMAKE_BUILD_TYPE=Release" "-
> DCMAKE_INSTALL_PREFIX=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-
> webkitgtk-2.34.1" "-DCMAKE_INSTALL_LIBDIR=lib" "-
> DCMAKE_INSTALL_RPATH_USE_LINK_PATH=TRUE" "-
> DCMAKE_INSTALL_RPATH=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-
> webkitgtk-2.34.1/lib" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DPORT=GTK" "-
> DENABLE_GTKDOC=ON" "-DENABLE_GAMEPAD=OFF" "-DUSE_SYSTEMD=OFF" "-
> DLIB_INSTALL_DIR=/gnu/store/4vchdgd2c3kvgyf8s9z54985vf80gsaa-webkitgtk-
> 2.34.1/lib" "-DUSE_GSTREAMER_GL=OFF" failed with status 1

That's fixed on core-updates-frozen-batched-changes, having upgraded
webkitgtk to 2.34.4 and libsoup to 3.0.1.

Closing.

Maxim




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Tue, 02 Nov 2021 03:15:02 GMT) Full text and rfc822 format available.

Notification sent to zachary rothenberg <zrothenberg1 <at> gmail.com>:
bug acknowledged by developer. (Tue, 02 Nov 2021 03:15:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Tue, 02 Nov 2021 05:46:01 GMT) Full text and rfc822 format available.

Message #20 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Liliana Marie Prikler
 <liliana.prikler <at> gmail.com>
Cc: 51559 <at> debbugs.gnu.org
Subject: Re: bug#51559: Webkit fails to build
Date: Tue, 02 Nov 2021 01:43:30 -0400
reopen 51559
thanks

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
> That's fixed on core-updates-frozen-batched-changes, having upgraded
> webkitgtk to 2.34.4 and libsoup to 3.0.1.
>
> Closing.

Unless I'm mistaken, there still remains the problem that 'webkitgtk'
and all of its dependents are currently broken on 'master', so I'm
reopening the bug.

      Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 Nov 2021 05:46:02 GMT) Full text and rfc822 format available.

Merged 51555 51559 51564. Request was from Tobias Geerinckx-Rice <me <at> tobias.gr> to control <at> debbugs.gnu.org. (Tue, 02 Nov 2021 08:26:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Wed, 03 Nov 2021 18:12:03 GMT) Full text and rfc822 format available.

Message #27 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: 51564-done <at> debbugs.gnu.org, 51559-done <at> debbugs.gnu.org,
 51555-done <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Wed, 03 Nov 2021 14:09:19 -0400
FYI, I pushed commit 9d3a5ddc2700aa099bb1bf9c5e8b3062445b907a to
'master', which fixes the webkitgtk-2.34.1 build on x86_64-linux.  In
addition to the fixes already shown in Liliana's proposed patch,
9d3a5ddc27 also arranges to use clang-11 for compilation.

Unfortunately, the build fails on i686-linux, which is the only system
other than x86_64-linux where webkitgtk-2.32.4 was successfully built.

Note that I tried clang-11 first, because upstream WebKit surely uses
clang for compilation, and it works for building IceCat on Guix, so I
had it hunch that it was a good bet.  However, it would be good to now
try compiling webkitgtk-2.34.1 with a newer version of GCC.  It's
possible that might fix the build on i686-linux.

Anyway, I'm closing this bug.  I'll open another bug to track the
i686-linux issue.

     Thanks,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Wed, 03 Nov 2021 19:22:02 GMT) Full text and rfc822 format available.

Message #30 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>, 51564-done <at> debbugs.gnu.org, 
 51559-done <at> debbugs.gnu.org, 51555-done <at> debbugs.gnu.org
Cc: Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Wed, 03 Nov 2021 20:21:33 +0100
Am Mittwoch, den 03.11.2021, 14:09 -0400 schrieb Mark H Weaver:
> [...]
> 
> Note that I tried clang-11 first, because upstream WebKit surely uses
> clang for compilation, and it works for building IceCat on Guix, so I
> had it hunch that it was a good bet.  However, it would be good to
> now try compiling webkitgtk-2.34.1 with a newer version of GCC.  It's
> possible that might fix the build on i686-linux.
I'm currently building webkitgtk on x86_64 locally with GCC 11.  If
that succeeds, I'll push to master and have CI take it from there.

Cheers,
Liliana





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Wed, 03 Nov 2021 21:49:02 GMT) Full text and rfc822 format available.

Message #33 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 51564-done <at> debbugs.gnu.org, 51559-done <at> debbugs.gnu.org,
 51555-done <at> debbugs.gnu.org
Cc: Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Wed, 03 Nov 2021 17:46:31 -0400
Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Mittwoch, den 03.11.2021, 14:09 -0400 schrieb Mark H Weaver:
>> [...]
>> 
>> Note that I tried clang-11 first, because upstream WebKit surely uses
>> clang for compilation, and it works for building IceCat on Guix, so I
>> had it hunch that it was a good bet.  However, it would be good to
>> now try compiling webkitgtk-2.34.1 with a newer version of GCC.  It's
>> possible that might fix the build on i686-linux.
> I'm currently building webkitgtk on x86_64 locally with GCC 11.  If
> that succeeds, I'll push to master and have CI take it from there.

Sounds good.  Thank you, Liliana!

     Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 08:32:02 GMT) Full text and rfc822 format available.

Message #36 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51591-done <at> debbugs.gnu.org, 51564-done <at> debbugs.gnu.org,
 51555-done <at> debbugs.gnu.org, 51559-done <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Thu, 04 Nov 2021 04:29:08 -0400
Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Mittwoch, den 03.11.2021, 14:09 -0400 schrieb Mark H Weaver:
>> [...]
>> 
>> Note that I tried clang-11 first, because upstream WebKit surely uses
>> clang for compilation, and it works for building IceCat on Guix, so I
>> had it hunch that it was a good bet.  However, it would be good to
>> now try compiling webkitgtk-2.34.1 with a newer version of GCC.  It's
>> possible that might fix the build on i686-linux.
> I'm currently building webkitgtk on x86_64 locally with GCC 11.  If
> that succeeds, I'll push to master and have CI take it from there.

For the record, it's commit 63f78f6a6ea0d33f3b1fa68c7285cfb865677211 on
the 'master' branch, and it did indeed fix the build on i686-linux.

    Thanks again,
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 13:00:03 GMT) Full text and rfc822 format available.

Message #39 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51564 <at> debbugs.gnu.org, 51591 <at> debbugs.gnu.org, 51555 <at> debbugs.gnu.org,
 51559 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Thu, 04 Nov 2021 08:57:18 -0400
reopen 51591
thanks

Hi Liliana,

Mark H Weaver <mhw <at> netris.org> writes:

> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>
>> Am Mittwoch, den 03.11.2021, 14:09 -0400 schrieb Mark H Weaver:
>>> [...]
>>> 
>>> Note that I tried clang-11 first, because upstream WebKit surely uses
>>> clang for compilation, and it works for building IceCat on Guix, so I
>>> had it hunch that it was a good bet.  However, it would be good to
>>> now try compiling webkitgtk-2.34.1 with a newer version of GCC.  It's
>>> possible that might fix the build on i686-linux.
>> I'm currently building webkitgtk on x86_64 locally with GCC 11.  If
>> that succeeds, I'll push to master and have CI take it from there.
>
> For the record, it's commit 63f78f6a6ea0d33f3b1fa68c7285cfb865677211 on
> the 'master' branch, and it did indeed fix the build on i686-linux.

I spoke too soon.

Although the WebKitGTK package itself built successfully using GCC 11,
the switch to GCC 11 caused many failures in programs that use
WebKitGTK.  For example:

  https://ci.guix.gnu.org/build/1530462/details (epiphany)
  https://ci.guix.gnu.org/build/1530484/details (gnome-online-accounts)
  https://ci.guix.gnu.org/build/1530479/details (yelp)
  https://ci.guix.gnu.org/build/1530407/details (surf)
  https://ci.guix.gnu.org/build/1530465/details (zenity)

See below for an illustrative excerpt from the failed epiphany log.

I've pushed commit 1007eb4874b7d3d2e0ecda07157f5794a0591ea2 to 'master',
which reverts commit 63f78f6a6e.

I've also reopened <https://bugs.gnu.org/51591>, to track progress on
fixing the webkitgtk build on i686 using clang-11.  I have a couple of
ideas of how to fix it.  To be continued...

       Mark

--8<---------------cut here---------------start------------->8---
[274/292] Linking target src/epiphany.
FAILED: src/epiphany 
gcc  -o src/epiphany 'src/25a6634@@epiphany <at> exe/meson-generated_.._epiphany-resources.c.o' 'src/25a6634@@epiphany <at> exe/meson-generated_.._ephy-type-builtins.c.o' 'src/25a6634@@epiphany <at> exe/meson-generated_.._.._embed_ephy-embed-type-builtins.c.o' 'src/25a6634@@epiphany <at> exe/meson-generated_.._.._lib_ephy-lib-type-builtins.c.o' 'src/25a6634@@epiphany <at> exe/meson-generated_.._.._lib_widgets_ephy-widgets-type-builtins.c.o' 'src/25a6634@@epiphany <at> exe/ephy-main.c.o' -Wl,--as-needed -Wl,--no-undefined -Wl,-rpath=/gnu/store/qaia05dz19yc8p1lmf6jnrlmlwzw45iv-epiphany-3.34.4/lib/epiphany -Wl,--start-group src/libephymain.so embed/libephyembed.a lib/libephymisc.so subprojects/libhandy/src/libhandy-0.0.a lib/sync/libephysync.so lib/widgets/libephywidgets.a /gnu/store/arza64g68736x20dmh786d3vrlnp5zq2-libdazzle-3.37.1/lib/libdazzle-1.0.so /gnu/store/rcjh2gisni3jzkld0d7883kzsmmj0kwg-gtk+-3.24.24/lib/libgtk-3.so /gnu/store/rcjh2gisni3jzkld0d7883kzsmmj0kwg-gtk+-3.24.24/lib/libgdk-3.so /gnu/store/66crnfykciiip52fjlawxd4aa62yx7kc-pango-1.44.7/lib/libpangocairo-1.0.so /gnu/store/66crnfykciiip52fjlawxd4aa62yx7kc-pango-1.44.7/lib/libpango-1.0.so /gnu/store/7n014z63svmbih0wbq15hanilmjnzl41-harfbuzz-2.6.4/lib/libharfbuzz.so /gnu/store/hd946pyi5lwqa980fzglqb8299k9518w-atk-2.34.1/lib/libatk-1.0.so /gnu/store/kakspf0hkf7pnyq581bh0pq3r3bjfrvx-cairo-1.16.0/lib/libcairo-gobject.so /gnu/store/kakspf0hkf7pnyq581bh0pq3r3bjfrvx-cairo-1.16.0/lib/libcairo.so /gnu/store/gj6q6rs9aprwkk4x67y8nv45hai5fq2v-gdk-pixbuf+svg-2.40.0/lib/libgdk_pixbuf-2.0.so /gnu/store/qzj0j8lv58fyr7dbsjj4fzjcqvgmkwzb-glib-2.62.6/lib/libgio-2.0.so /gnu/store/qzj0j8lv58fyr7dbsjj4fzjcqvgmkwzb-glib-2.62.6/lib/libgobject-2.0.so /gnu/store/qzj0j8lv58fyr7dbsjj4fzjcqvgmkwzb-glib-2.62.6/lib/libglib-2.0.so /gnu/store/3jqq5m8j8vbawm8bgirhwrsywpdmgmnv-json-glib-1.4.4/lib/libjson-glib-1.0.so /gnu/store/338yvdb6jr0nnscbb30zfa6xm1sdf0mr-libsecret-0.20.4/lib/libsecret-1.so /gnu/store/b5lfjmd8wgdvc9050870xianfz7isvna-libsoup-2.72.0/lib/libsoup-2.4.so /gnu/store/c8w9z48vvx2a3q3k44ch9yn00wk1qwhb-libxml2-2.9.10/lib/libxml2.so -lm /gnu/store/807c6g9xqrxdjyhm8wm1r6jjjmc8q4vs-sqlite-3.31.1/lib/libsqlite3.so /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libwebkit2gtk-4.0.so /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so -Wl,--export-dynamic /gnu/store/qzj0j8lv58fyr7dbsjj4fzjcqvgmkwzb-glib-2.62.6/lib/libgmodule-2.0.so -pthread -lrt -lgmp /gnu/store/mz5fvdfks10rmwxf29n95bp9bim6wq7g-nettle-3.5.1/lib/libhogweed.so /gnu/store/mz5fvdfks10rmwxf29n95bp9bim6wq7g-nettle-3.5.1/lib/libnettle.so /gnu/store/j0d13s4j72nvmzdg7v0k529qyas7x2wk-gcr-3.34.0/lib/libgcr-ui-3.so /gnu/store/j0d13s4j72nvmzdg7v0k529qyas7x2wk-gcr-3.34.0/lib/libgcr-base-3.so /gnu/store/j0d13s4j72nvmzdg7v0k529qyas7x2wk-gcr-3.34.0/lib/libgck-1.so /gnu/store/p0p3p28cc5n220cikqvq1r6xgf7qx066-p11-kit-0.23.22/lib/libp11-kit.so /gnu/store/li61ai11bbayiqsz0ab4wawxifdd5wza-libnotify-0.7.9/lib/libnotify.so -Wl,--end-group '-Wl,-rpath,$ORIGIN/:$ORIGIN/../embed:$ORIGIN/../lib:$ORIGIN/../subprojects/libhandy/src:$ORIGIN/../lib/sync:$ORIGIN/../lib/widgets' -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/src -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/embed -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/lib -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/subprojects/libhandy/src -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/lib/sync -Wl,-rpath-link,/tmp/guix-build-epiphany-3.34.4.drv-0/build/lib/widgets
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::symlink_status(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::directory_iterator::operator*() const <at> GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::hard_link_count(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::_List::end() const <at> GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::create_hard_link(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::directory_iterator::increment(std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::status(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::_List::_List(std::filesystem::__cxx11::path::_List const&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::_M_split_cmpts()@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::canonical(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::rename(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::copy(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&, std::filesystem::copy_options, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::_List::_List()@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::remove(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libwebkit2gtk-4.0.so: undefined reference to `std::_Sp_make_shared_tag::_S_eq(std::type_info const&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::remove_all(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::directory_iterator::directory_iterator(std::filesystem::__cxx11::path const&, std::filesystem::directory_options, std::error_code*)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::operator/=(std::filesystem::__cxx11::path const&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::parent_path() const <at> GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::space(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libwebkit2gtk-4.0.so: undefined reference to `std::__throw_bad_array_new_length()@GLIBCXX_3.4.29'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::file_size(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::last_write_time(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::__cxx11::path::_List::_Impl_deleter::operator()(std::filesystem::__cxx11::path::_List::_Impl*) const <at> GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::last_write_time(std::filesystem::__cxx11::path const&, std::chrono::time_point<std::filesystem::__file_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::create_symlink(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::copy_file(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&, std::filesystem::copy_options, std::error_code&)@GLIBCXX_3.4.26'
ld: /gnu/store/4436r43crxcdmz011r7i2c1niz4jvi6g-webkitgtk-2.34.1/lib/libjavascriptcoregtk-4.0.so: undefined reference to `std::filesystem::create_directories(std::filesystem::__cxx11::path const&, std::error_code&)@GLIBCXX_3.4.26'
collect2: error: ld returned 1 exit status
--8<---------------cut here---------------end--------------->8---


-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 15:48:02 GMT) Full text and rfc822 format available.

Message #42 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 51564 <at> debbugs.gnu.org, 51555 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org,
 51591 <at> debbugs.gnu.org
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Thu, 4 Nov 2021 11:47:12 -0400
On Thu, Nov 04, 2021 at 08:57:18AM -0400, Mark H Weaver wrote:
> Although the WebKitGTK package itself built successfully using GCC 11,
> the switch to GCC 11 caused many failures in programs that use
> WebKitGTK.  For example:

Should we just revert the WebKitGTK upgrade for now?




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 16:50:03 GMT) Full text and rfc822 format available.

Message #45 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>, Mark H Weaver <mhw <at> netris.org>
Cc: 51564 <at> debbugs.gnu.org, 51555 <at> debbugs.gnu.org, 51559 <at> debbugs.gnu.org,
 51591 <at> debbugs.gnu.org
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Thu, 04 Nov 2021 17:49:40 +0100
Am Donnerstag, den 04.11.2021, 11:47 -0400 schrieb Leo Famulari:
> On Thu, Nov 04, 2021 at 08:57:18AM -0400, Mark H Weaver wrote:
> > Although the WebKitGTK package itself built successfully using GCC
> > 11,
> > the switch to GCC 11 caused many failures in programs that use
> > WebKitGTK.  For example:
> 
> Should we just revert the WebKitGTK upgrade for now?
SGTM.  Can someone check whether it builds fine with GCC 10 on c-u-
frozen?





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 18:24:02 GMT) Full text and rfc822 format available.

Message #48 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org
Subject: Re: bug#51559: Webkit fails to build
Date: Thu, 04 Nov 2021 14:23:26 -0400
Hello,

Mark H Weaver <mhw <at> netris.org> writes:

> reopen 51559
> thanks
>
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>> That's fixed on core-updates-frozen-batched-changes, having upgraded
>> webkitgtk to 2.34.4 and libsoup to 3.0.1.
>>
>> Closing.
>
> Unless I'm mistaken, there still remains the problem that 'webkitgtk'
> and all of its dependents are currently broken on 'master', so I'm
> reopening the bug.

Thanks Mark (also for the fix) -- I had mistakenly thought the issue was
about core-updates-frozen.

Note that on the core-updates-frozen-batched-changes branch webkitgtk
(with libsoup2 or 3) could still be built with GCC (version 10).

Thanks,

Maxim




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 20:00:02 GMT) Full text and rfc822 format available.

Message #51 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Mark H Weaver <mhw <at> netris.org>
Cc: 51559 <at> debbugs.gnu.org, leo <at> famulari.name
Subject: Re: bug#51559: Webkit fails to build
Date: Thu, 04 Nov 2021 20:59:05 +0100
Hi,

Am Donnerstag, den 04.11.2021, 14:23 -0400 schrieb Maxim Cournoyer:
> Note that on the core-updates-frozen-batched-changes branch webkitgtk
> (with libsoup2 or 3) could still be built with GCC (version 10).
Should we try building webkitgtk and its dependants with GCC 10 on
master or should we rather wait for the core-updates-frozen merge?  Do
we have an ETA?

CC'd lfam due to security relevance

Cheers





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 22:01:01 GMT) Full text and rfc822 format available.

Message #54 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Maxim Cournoyer
 <maxim.cournoyer <at> gmail.com>
Cc: 51559 <at> debbugs.gnu.org, leo <at> famulari.name
Subject: Re: bug#51559: Webkit fails to build
Date: Thu, 04 Nov 2021 17:58:12 -0400
Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Donnerstag, den 04.11.2021, 14:23 -0400 schrieb Maxim Cournoyer:
>> Note that on the core-updates-frozen-batched-changes branch webkitgtk
>> (with libsoup2 or 3) could still be built with GCC (version 10).
> Should we try building webkitgtk and its dependants with GCC 10 on
> master

I've already verified that webkitgtk-2.34.1 can be successfully built
with GCC 10, because I tried it on my private branch (simply because I
already have a built GCC 10 on my system, and I don't use substitutes).
However, I ran into the same problem where programs linked to webkitgtk
failed.

My knowledge of C++ is weak (I avoid it like the plague) but I guess
this might be because GCC 10 and GCC 7 use different versions of the
standard C++ library, which are not ABI compatible with each other.

Since GCC 10 is the default compiler on 'core-updates-frozen', I think
it's quite likely that webkitgtk-2.34.1 and its programs can be built
successfully on 'core-updates-frozen' with its default compiler.  That
would need to be verified, of course.

     Regards,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Thu, 04 Nov 2021 22:26:02 GMT) Full text and rfc822 format available.

Message #57 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 51564 <at> debbugs.gnu.org, 51555 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org,
 51591 <at> debbugs.gnu.org
Subject: Re: bug#51564: [PATCH] gnu: webkitgtk: Fix configure failures.
Date: Thu, 04 Nov 2021 18:23:42 -0400
Hi Leo,

Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Nov 04, 2021 at 08:57:18AM -0400, Mark H Weaver wrote:
>> Although the WebKitGTK package itself built successfully using GCC 11,
>> the switch to GCC 11 caused many failures in programs that use
>> WebKitGTK.  For example:
>
> Should we just revert the WebKitGTK upgrade for now?

I'm reluctant to do that, because it would mean reintroducing
CVE-2021-30846, CVE-2021-30851 and CVE-2021-42762.  According to
<https://www.webkitgtk.org/security/WSA-2021-0006.html>, two of those
CVEs could allow an attacker to execute arbitrary code via maliciously
crafted web content.

For now, I've reverted back to using clang-11 to compile WebKitGTK,
which works correctly on x86_64-linux, but another fix will be needed to
i686-linux users.  I have some ideas on how to fix it.  I'll write about
that soon at 51591 <at> debbugs.gnu.org.

      Regards,
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 04:22:02 GMT) Full text and rfc822 format available.

Message #60 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org,
 leo <at> famulari.name
Subject: Re: bug#51559: Webkit fails to build
Date: Fri, 05 Nov 2021 00:21:44 -0400
Hi Mark,

Mark H Weaver <mhw <at> netris.org> writes:

> Hi,
>
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>
>> Am Donnerstag, den 04.11.2021, 14:23 -0400 schrieb Maxim Cournoyer:
>>> Note that on the core-updates-frozen-batched-changes branch webkitgtk
>>> (with libsoup2 or 3) could still be built with GCC (version 10).
>> Should we try building webkitgtk and its dependants with GCC 10 on
>> master
>
> I've already verified that webkitgtk-2.34.1 can be successfully built
> with GCC 10, because I tried it on my private branch (simply because I
> already have a built GCC 10 on my system, and I don't use substitutes).
> However, I ran into the same problem where programs linked to webkitgtk
> failed.
>
> My knowledge of C++ is weak (I avoid it like the plague) but I guess
> this might be because GCC 10 and GCC 7 use different versions of the
> standard C++ library, which are not ABI compatible with each other.
>
> Since GCC 10 is the default compiler on 'core-updates-frozen', I think
> it's quite likely that webkitgtk-2.34.1 and its programs can be built
> successfully on 'core-updates-frozen' with its default compiler.  That
> would need to be verified, of course.

It's already been verified on the core-updates-frozen-batched-changes
branch (which had webkitgtk-2.34.1 before master).

Thanks,

Maxim




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 05:18:01 GMT) Full text and rfc822 format available.

Message #63 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 51559 <at> debbugs.gnu.org, leo <at> famulari.name
Subject: Re: bug#51559: Webkit fails to build
Date: Fri, 05 Nov 2021 06:17:12 +0100
Hi,

Am Donnerstag, den 04.11.2021, 17:58 -0400 schrieb Mark H Weaver:
> However, I ran into the same problem where programs linked to
> webkitgtk failed.
> 
> My knowledge of C++ is weak (I avoid it like the plague) but I guess
> this might be because GCC 10 and GCC 7 use different versions of the
> standard C++ library, which are not ABI compatible with each other.
Yes, you will have to add GCC 10 to the packages that fail to link. 
Maxim pointed out, that it already woks on core-updates-frozen-batched-
changes, what we need to check is which packages will require GCC 10 on
master.

Cheers





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 20:10:01 GMT) Full text and rfc822 format available.

Message #66 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 51559 <at> debbugs.gnu.org
Cc: mhw <at> netris.org, maxim.cournoyer <at> gmail.com, leo <at> famulari.name
Subject: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64.
Date: Fri, 5 Nov 2021 21:06:34 +0100
* gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’.
---
 gnu/packages/webkit.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index e54b680855..45150e185f 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -295,6 +295,11 @@ (define-public webkitgtk
                  (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
                   (string-append wpebackend-fdo "/lib/" all)))
                #t)))
+         (add-after 'unpack 'disable-sse2
+           (lambda* (#:key system #:allow-other-keys)
+             (unless (string-prefix? "x86_64" system)
+               (substitute* "Source/cmake/DetectSSE2.cmake"
+                 (("CHECK_FOR_SSE2\\(\\)") "")))))
          (add-before 'configure 'prepare-build-environment
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "CC" "clang")
-- 
2.33.1






Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 20:16:01 GMT) Full text and rfc822 format available.

Message #69 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com
Subject: Re: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on
 x86_64.
Date: Fri, 05 Nov 2021 20:15:12 +0000
Liliana Marie Prikler schreef op vr 05-11-2021 om 21:06 [+0100]:
> * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’.
> ---
>  gnu/packages/webkit.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
> index e54b680855..45150e185f 100644
> --- a/gnu/packages/webkit.scm
> +++ b/gnu/packages/webkit.scm
> @@ -295,6 +295,11 @@ (define-public webkitgtk
>                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
>                    (string-append wpebackend-fdo "/lib/" all)))
>                 #t)))
> +         (add-after 'unpack 'disable-sse2
> +           (lambda* (#:key system #:allow-other-keys)
> +             (unless (string-prefix? "x86_64" system)

IIUC, when cross-compiling, you need to look at 'target', not 'system'.
At least, that's the case if %current-system/%current-target-system is
used. Not sure about 'system' and 'target'.

Suggestion:
  (unless ,(target-x86-64?)
    (substitute* ...))

Greetings,
Maxime.





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 22:20:02 GMT) Full text and rfc822 format available.

Message #72 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>, 51559 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com
Subject: Re: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on
 x86_64.
Date: Fri, 05 Nov 2021 23:19:13 +0100
Hi,

Am Freitag, den 05.11.2021, 20:15 +0000 schrieb Maxime Devos:
> Liliana Marie Prikler schreef op vr 05-11-2021 om 21:06 [+0100]:
> > * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-
> > sse2’.
> > ---
> >  gnu/packages/webkit.scm | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
> > index e54b680855..45150e185f 100644
> > --- a/gnu/packages/webkit.scm
> > +++ b/gnu/packages/webkit.scm
> > @@ -295,6 +295,11 @@ (define-public webkitgtk
> >                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all
> > version)
> >                    (string-append wpebackend-fdo "/lib/" all)))
> >                 #t)))
> > +         (add-after 'unpack 'disable-sse2
> > +           (lambda* (#:key system #:allow-other-keys)
> > +             (unless (string-prefix? "x86_64" system)
> 
> IIUC, when cross-compiling, you need to look at 'target', not
> 'system'.  At least, that's the case if %current-system/%current-
> target-system is used. Not sure about 'system' and 'target'.
Do target and system follow the same rules?  If so, I could write (or
target system), no?  Packages on master sadly follow wildly different
conventions and I picked one at random.

> Suggestion:
>   (unless ,(target-x86-64?)
>     (substitute* ...))
target-x86-64 does not exist on master yet, but that'd probably work
for c-u-frozen, yeah.

Greetings,
Liliana





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Fri, 05 Nov 2021 22:39:02 GMT) Full text and rfc822 format available.

Message #75 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com
Subject: Re: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on
 x86_64.
Date: Fri, 05 Nov 2021 22:38:26 +0000
Liliana Marie Prikler schreef op vr 05-11-2021 om 23:19 [+0100]:
> > > [...]
> > > +         (add-after 'unpack 'disable-sse2
> > > +           (lambda* (#:key system #:allow-other-keys)
> > > +             (unless (string-prefix? "x86_64" system)
> > 
> > IIUC, when cross-compiling, you need to look at 'target', not
> > 'system'.  At least, that's the case if %current-system/%current-
> > target-system is used. Not sure about 'system' and 'target'.
> Do target and system follow the same rules?  If so, I could write (or
> target system), no?  Packages on master sadly follow wildly different
> conventions and I picked one at random.

Looking at (guix build system gnu), there are three system/target-like
arguments:

a. system, which is set to (%current-system)
b. build, which is set to the GNU triplet equivalent (%current-system) 
c. target, which is set to (%current-target-system) (#f when compiling
natively)

So it appears system and target correspond to (%current-system) and
(%current-target-system), so (or target system) should work, I think.

I prefer ,(target-x86-64?) myself though, because it avoids having
to remember that 'target' is not set when compiling natively. I think
'target' should always be set, because compiling natively is ‘merely’
a special case of cross-compiling, and (or target system)/(or
(%current-target-system) (%current-system)) seems a bit repetitive
to me). That would probably break some package definitions though,
and not really related to webkitgtk.

Also, that the arch comes first in GNU triplets and nix system strings,
seems a bit an implementation detail to me. Not terribly important /
YMMV though.

Greetings,
Maxime.





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 08:03:01 GMT) Full text and rfc822 format available.

Message #78 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Maxime Devos
 <maximedevos <at> telenet.be>, 51559 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com
Subject: Re: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on
 x86_64.
Date: Sat, 06 Nov 2021 04:00:44 -0400
Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Freitag, den 05.11.2021, 20:15 +0000 schrieb Maxime Devos:
>> Liliana Marie Prikler schreef op vr 05-11-2021 om 21:06 [+0100]:
>> > * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-
>> > sse2’.
>> > ---
>> >  gnu/packages/webkit.scm | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> > 
>> > diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
>> > index e54b680855..45150e185f 100644
>> > --- a/gnu/packages/webkit.scm
>> > +++ b/gnu/packages/webkit.scm
>> > @@ -295,6 +295,11 @@ (define-public webkitgtk
>> >                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all
>> > version)
>> >                    (string-append wpebackend-fdo "/lib/" all)))
>> >                 #t)))
>> > +         (add-after 'unpack 'disable-sse2
>> > +           (lambda* (#:key system #:allow-other-keys)
>> > +             (unless (string-prefix? "x86_64" system)
>> 
>> IIUC, when cross-compiling, you need to look at 'target', not
>> 'system'.  At least, that's the case if %current-system/%current-
>> target-system is used. Not sure about 'system' and 'target'.
> Do target and system follow the same rules?

Unfortunately not.  It's a bit of a mess, IMO.

%current-system is a Nix system string, e.g. "x86_64-linux",
"i686-linux", "aarch64-linux", etc.

%current-target-system is either #f (if not cross-compiling) or a GNU
triplet, e.g. "x86_64-unknown-linux-gnu".

It is quite common to write code like:

__ (or %current-target-system
______ %current-system)

but then you must then write code that copes properly with either Nix
system strings or GNU triplets.

> If so, I could write (or target system), no?  Packages on master sadly
> follow wildly different conventions and I picked one at random.

A nice touch would be to use quasiquotation to perform the target checks
in the host-side code, maybe something like this (after adding
'target-x86-32?' from 'core-updates-frozen' to (guix utils)):

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index 358254f23f..439341c222 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -292,6 +292,12 @@ acceleration in mind, leveraging common 3D graphics APIs for best performance.")
                  (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
                   (string-append wpebackend-fdo "/lib/" all)))
                #t)))
+         ,@(if (target-x86-32?)
+               '((add-after 'unpack 'disable-sse2
+                   (lambda _
+                     (substitute* "Source/cmake/DetectSSE2.cmake"
+                       (("CHECK_FOR_SSE2\\(\\)") "")))))
+               '())
          (add-before 'configure 'prepare-build-environment
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "CC" "clang")
--8<---------------cut here---------------end--------------->8---

The nice thing about this approach is that it does not cause rebuilds on
other systems.  This benefit is especially useful for core packages,
where the cost of rebuilds can be prohibitive, but where it is sometimes
necessary to add more target-specific bits like this when Guix is
bootstrapped on a new platform.

What do you think?

Anyway, thanks for working on it.

      Regards,
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 08:30:02 GMT) Full text and rfc822 format available.

Message #81 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 51559 <at> debbugs.gnu.org
Cc: mhw <at> netris.org, maximedevos <at> telenet.be, maxim.cournoyer <at> gmail.com
Subject: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 6 Nov 2021 09:21:02 +0100
* gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’ if the
current (target) system is not an x86_64 one.
---
Hi Maxime,

I tried conditionally disabling SSE2 on the host side, but for some reason this
patch would cause a rebuild for me.  Did I do something wrong?

 gnu/packages/webkit.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index e54b680855..ca50ab37a8 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -241,7 +241,7 @@ (define-public webkitgtk
     (build-system cmake-build-system)
     (outputs '("out" "doc"))
     (arguments
-     '(#:tests? #f ; no tests
+     `(#:tests? #f ; no tests
        #:build-type "Release" ; turn off debugging symbols to save space
        #:configure-flags (list
                           "-DPORT=GTK"
@@ -295,6 +295,13 @@ (define-public webkitgtk
                  (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
                   (string-append wpebackend-fdo "/lib/" all)))
                #t)))
+         ,@(if (string-prefix? "x68_64" (or (%current-target-system)
+                                            (%current-system)))
+               '()
+               '((add-after 'unpack 'disable-sse2
+                   (lambda _
+                     (substitute* "Source/cmake/DetectSSE2.cmake"
+                       (("CHECK_FOR_SSE2\\(\\)") ""))))))
          (add-before 'configure 'prepare-build-environment
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "CC" "clang")
-- 
2.33.1






Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 08:47:01 GMT) Full text and rfc822 format available.

Message #84 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 06 Nov 2021 04:44:32 -0400
Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
> index e54b680855..ca50ab37a8 100644
> --- a/gnu/packages/webkit.scm
> +++ b/gnu/packages/webkit.scm
> @@ -241,7 +241,7 @@ (define-public webkitgtk
>      (build-system cmake-build-system)
>      (outputs '("out" "doc"))
>      (arguments
> -     '(#:tests? #f ; no tests
> +     `(#:tests? #f ; no tests
>         #:build-type "Release" ; turn off debugging symbols to save space
>         #:configure-flags (list
>                            "-DPORT=GTK"
> @@ -295,6 +295,13 @@ (define-public webkitgtk
>                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
>                    (string-append wpebackend-fdo "/lib/" all)))
>                 #t)))
> +         ,@(if (string-prefix? "x68_64" (or (%current-target-system)

The problem is here _______________^^^^^^.
That should be "x86_64", not "x68_64".

It's rebuilding on your system because it's erroneously adding the new
phase.  Otherwise, your commit looks good to me.

     Thank you!
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 08:58:02 GMT) Full text and rfc822 format available.

Message #87 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 51559 <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 06 Nov 2021 04:55:36 -0400
Hi Liliana,

I have one more comment:

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> @@ -241,7 +241,7 @@ (define-public webkitgtk
>      (build-system cmake-build-system)
>      (outputs '("out" "doc"))
>      (arguments
> -     '(#:tests? #f ; no tests
> +     `(#:tests? #f ; no tests
>         #:build-type "Release" ; turn off debugging symbols to save space
>         #:configure-flags (list
>                            "-DPORT=GTK"

You'll need to remove this hunk in order to apply this to 'master',
since I've already made the change above in commit
4fd12fb00d595b6f6a5d5cc734863f4c4bc5f46c.

> @@ -295,6 +295,13 @@ (define-public webkitgtk
>                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
>                    (string-append wpebackend-fdo "/lib/" all)))
>                 #t)))
> +         ,@(if (string-prefix? "x68_64" (or (%current-target-system)
> +                                            (%current-system)))
> +               '()
> +               '((add-after 'unpack 'disable-sse2
> +                   (lambda _
> +                     (substitute* "Source/cmake/DetectSSE2.cmake"
> +                       (("CHECK_FOR_SSE2\\(\\)") ""))))))

As a general recommendation, it would be preferable to add the phase
only on the systems that need it (32-bit x86), instead of adding it on
every system except x86_64.  The code above will force rebuilds on every
system other than x86_64, whereas if the test was done as I suggested,
rebuilds would only happen on 32-bit x86 systems.

However, in this particular case it hardly matters, since our libsoup
package currently fails to build on any system that's not x86-based.

      Thanks,
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 09:43:02 GMT) Full text and rfc822 format available.

Message #90 received at 51559 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>, 51559 <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 06 Nov 2021 10:42:25 +0100
Hi,

Am Samstag, den 06.11.2021, 04:55 -0400 schrieb Mark H Weaver:
> Hi Liliana,
> 
> I have one more comment:
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> > @@ -241,7 +241,7 @@ (define-public webkitgtk
> >      (build-system cmake-build-system)
> >      (outputs '("out" "doc"))
> >      (arguments
> > -     '(#:tests? #f ; no tests
> > +     `(#:tests? #f ; no tests
> >         #:build-type "Release" ; turn off debugging symbols to save
> > space
> >         #:configure-flags (list
> >                            "-DPORT=GTK"
> 
> You'll need to remove this hunk in order to apply this to 'master',
> since I've already made the change above in commit
> 4fd12fb00d595b6f6a5d5cc734863f4c4bc5f46c.
git pull did that automatically (I love rebasing pulls).

> > @@ -295,6 +295,13 @@ (define-public webkitgtk
> >                   (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all
> > version)
> >                    (string-append wpebackend-fdo "/lib/" all)))
> >                 #t)))
> > +         ,@(if (string-prefix? "x68_64" (or (%current-target-
> > system)
> > +                                            (%current-system)))
> > +               '()
> > +               '((add-after 'unpack 'disable-sse2
> > +                   (lambda _
> > +                     (substitute* "Source/cmake/DetectSSE2.cmake"
> > +                       (("CHECK_FOR_SSE2\\(\\)") ""))))))
> 
> As a general recommendation, it would be preferable to add the phase
> only on the systems that need it (32-bit x86), instead of adding it
> on every system except x86_64.  The code above will force rebuilds on
> every system other than x86_64, whereas if the test was done as I
> suggested, rebuilds would only happen on 32-bit x86 systems.
I chose this variant, because x86_64 is the only architecture in which
we allow sse2 as of right now.  Better be safe than allowing for a
potential "i786" in the future :P

> However, in this particular case it hardly matters, since our libsoup
> package currently fails to build on any system that's not x86-based.
That sounds awful.  Is there a related bug?

I've pushed my patch with the spelling error corrected.  This is the
last webkitgtk-related issue for now, right?

Thanks,
Liliana





Information forwarded to bug-guix <at> gnu.org:
bug#51559; Package guix. (Sat, 06 Nov 2021 18:09:01 GMT) Full text and rfc822 format available.

Message #93 received at 51559-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 51559-done <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 06 Nov 2021 14:06:32 -0400
Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Samstag, den 06.11.2021, 04:55 -0400 schrieb Mark H Weaver:
>> However, in this particular case it hardly matters, since our libsoup
>> package currently fails to build on any system that's not x86-based.
> That sounds awful.  Is there a related bug?

I don't know of one off-hand, but I haven't looked.

> I've pushed my patch with the spelling error corrected.  This is the
> last webkitgtk-related issue for now, right?

I believe so.  Thanks again for pushing these issues toward resolution.

     Regards,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 05 Dec 2021 12:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 113 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.