GNU bug report logs - #51565
PATCH: Update Yggdrasil to new protocol (important breaking changes)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51565 in the body.
You can then email your comments to 51565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: PATCH: Update Yggdrasil to new protocol (important breaking changes)
Date: Tue, 2 Nov 2021 06:59:17 +0000

[Message part 1 (text/plain, inline)]

This is way overdue.

Credit for the packaging work:
https://github.com/bqv/rc/blob/live/rc/packages/yggdrasil.scm

It did need some more work though. The Go importer leaves a few things
to be desired, but that's for another thread.

Anyways, I tested it and it works. System service could be restarted
after a reconfigure without any issues.

Please apply this soon, because nodes running the outdated versions
can't connect to ones running this new version, due to breaking
protocol changes.

[0001-gnu-Add-go-github-com-vividcortex-ewma.patch (text/x-patch, attachment)]

[0002-gnu-Add-go-github-com-rivo-uniseg.patch (text/x-patch, attachment)]

[0003-gnu-Add-go-github-com-mattn-go-runewidth.patch (text/x-patch, attachment)]

[0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch (text/x-patch, attachment)]

[0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch (text/x-patch, attachment)]

[0006-gnu-Add-go-github-com-arceliar-ironwood.patch (text/x-patch, attachment)]

[0007-gnu-yggdrasil-Update-to-0.4.0.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: raingloom <raingloom <at> riseup.net>
Cc: 51565 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#51565] PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Mon, 15 Nov 2021 14:10:46 +0000

Thanks for this!

Some minor changes may be needed to make the linter happy:

raingloom <raingloom <at> riseup.net> writes:

[..]

> [3. text/x-patch; 0002-gnu-Add-go-github-com-rivo-uniseg.patch]...

Linter complains that a line is too long:

gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg <at> 0.2.0: line 8885 is way too long (93 characters)

>
> [4. text/x-patch; 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]...

Linter complains about the synopsis. Maybe: "Go functions for getting
fixed width of characters or strings"?

Does seem like a bit of a duplication of the description...

> [5. text/x-patch; 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]...
>
> [6. text/x-patch; 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]...
>
> [7. text/x-patch; 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]...

Lines in descriptions are too long and should be wrapped.

A synopsis is required. Maybe: "Ironwood is a Go network routing library
using cryptographic keys as addresses"?

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 51565 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#51565] PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Mon, 22 Nov 2021 22:13:08 +0100

[Message part 1 (text/plain, inline)]

On Mon, 15 Nov 2021 14:10:46 +0000
pukkamustard <pukkamustard <at> posteo.net> wrote:

> Thanks for this!
> 
> Some minor changes may be needed to make the linter happy:
> 
> raingloom <raingloom <at> riseup.net> writes:
> 
> [..]
> 
> > [3. text/x-patch; 0002-gnu-Add-go-github-com-rivo-uniseg.patch]...  
> 
> Linter complains that a line is too long:
> 
> gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg <at> 0.2.0: line
> 8885 is way too long (93 characters)
> 
> >
> > [4. text/x-patch;
> > 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]...  
> 
> Linter complains about the synopsis. Maybe: "Go functions for getting
> fixed width of characters or strings"?
> 
> Does seem like a bit of a duplication of the description...
> 
> > [5. text/x-patch;
> > 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]...
> >
> > [6. text/x-patch;
> > 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]...
> >
> > [7. text/x-patch;
> > 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]...  
> 
> Lines in descriptions are too long and should be wrapped.
> 
> A synopsis is required. Maybe: "Ironwood is a Go network routing
> library using cryptographic keys as addresses"?

Heck, I think I meant to run the linter but it was getting late and I
just wanted to be done with the patch. Well, here is an updated patch
list.

[0008-gnu-yggdrasil-Update-to-0.4.1.patch (text/x-patch, attachment)]

[0007-gnu-yggdrasil-Update-to-0.4.0.patch (text/x-patch, attachment)]

[0006-gnu-Add-go-github-com-arceliar-ironwood.patch (text/x-patch, attachment)]

[0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch (text/x-patch, attachment)]

[0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch (text/x-patch, attachment)]

[0003-gnu-Add-go-github-com-mattn-go-runewidth.patch (text/x-patch, attachment)]

[0002-gnu-Add-go-github-com-rivo-uniseg.patch (text/x-patch, attachment)]

[0001-gnu-Add-go-github-com-vividcortex-ewma.patch (text/x-patch, attachment)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 51565 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#51565] PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Sun, 28 Nov 2021 21:47:38 +0100

On Mon, 22 Nov 2021 22:13:08 +0100
raingloom <raingloom <at> riseup.net> wrote:

> On Mon, 15 Nov 2021 14:10:46 +0000
> pukkamustard <pukkamustard <at> posteo.net> wrote:
> 
> > Thanks for this!
> > 
> > Some minor changes may be needed to make the linter happy:
> > 
> > raingloom <raingloom <at> riseup.net> writes:
> > 
> > [..]
> > 
> > > [3. text/x-patch;
> > > 0002-gnu-Add-go-github-com-rivo-uniseg.patch]...  
> > 
> > Linter complains that a line is too long:
> > 
> > gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg <at> 0.2.0:
> > line 8885 is way too long (93 characters)
> > 
> > >
> > > [4. text/x-patch;
> > > 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]...  
> > 
> > Linter complains about the synopsis. Maybe: "Go functions for
> > getting fixed width of characters or strings"?
> > 
> > Does seem like a bit of a duplication of the description...
> > 
> > > [5. text/x-patch;
> > > 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]...
> > >
> > > [6. text/x-patch;
> > > 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]...
> > >
> > > [7. text/x-patch;
> > > 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]...  
> > 
> > Lines in descriptions are too long and should be wrapped.
> > 
> > A synopsis is required. Maybe: "Ironwood is a Go network routing
> > library using cryptographic keys as addresses"?
> 
> Heck, I think I meant to run the linter but it was getting late and I
> just wanted to be done with the patch. Well, here is an updated patch
> list.

Bump. Could someome merge this if everything is in order?

Message #26 received at 51565 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: pukkamustard <pukkamustard <at> posteo.net>, 51565 <at> debbugs.gnu.org
Subject: Re: bug#51565: PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Wed, 01 Dec 2021 16:27:23 +0100

Hi raingloom,

Apologies for the delay.

raingloom <raingloom <at> riseup.net> skribis:

>>From 776202eb2d0610e51f5168d108ce80a4096b10d4 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Wed, 3 Nov 2021 21:40:37 +0100
> Subject: [PATCH 8/8] gnu: yggdrasil: Update to 0.4.1.
>
> * gnu/packages/networking.scm (yggdrasil): Update to 0.4.1.
> * gnu/packages/patches/yggdrasil-extra-config.patch: Update for new version.

OK.

>>From ce6e34a490816fd9c093fec3b9124bff26620e1f Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:50:36 +0000
> Subject: [PATCH 6/8] gnu: Add go-github-com-arceliar-ironwood.
>
> * gnu/packages/golang.scm (go-github-com-arceliar-ironwood): New variable.

OK.

>>From 1b4bfd5a947902f453e47a510ab058ff459412f5 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:46:57 +0000
> Subject: [PATCH 5/8] gnu: Rename go-github-com-cheggaaa-pb to
>  go-github-com-cheggaaa-pb-v3.
>
> * gnu/packages/golang.scm:
>   (go-github-com-cheggaaa-pb): Rename variable.
>   (go-github-com-cheggaaa-pb-v3): New variable.
> ---
>  gnu/packages/golang.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 4033806c7f..d0435b5469 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -7945,9 +7945,9 @@ (define-public go-github-com-arceliar-phony
>  inspired by the causal messaging system in the Pony programming language.")
>        (license license:expat))))
>  
> -(define-public go-github-com-cheggaaa-pb
> +(define-public go-github-com-cheggaaa-pb-v3
>    (package
> -    (name "go-github-com-cheggaaa-pb")
> +    (name "go-github-com-cheggaaa-pb-v3")

Why rename?  If we do need to rename, let’s add a ‘deprecated-package’
definition to allow users to notice and get a smooth upgrade.

>>From 6a4220dbb3cbb56cc818bd2f2714484e5f8682e4 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:45:47 +0000
> Subject: [PATCH 4/8] gnu: go-github-com-cheggaaa-pb: Update to 3.0.8.
>
> * gnu/packages/golang.scm (go-github-com-cheggaaa-pb): Update to 3.0.8.

Could you mention input changes?

>>From a234dd530900d0914a9972ad5a22a1fe303c1bc5 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:37:17 +0000
> Subject: [PATCH 3/8] gnu: Add go-github-com-mattn-go-runewidth.
>
> * gnu/packages/golang.scm (go-github-com-mattn-go-runewidth): New variable.

[...]

> +    (home-page "https://github.com/mattn/go-runewidth")
> +    (synopsis "Rune width implementation for Go")
> +    (description
> +      "Provides functions to get fixed width of the character or string.")

Please write a full sentence:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

>>From 4732bee7bdbea38292afe9f6b1149986dbfabcb7 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:37:11 +0000
> Subject: [PATCH 2/8] gnu: Add go-github-com-rivo-uniseg.
>
> * gnu/packages/golang.scm (go-github-com-rivo-uniseg): New variable.

[...]

> +    (synopsis "Unicode Text Segmentation for Go")
> +    (description
> +      "Package uniseg implements Unicode Text Segmentation according to Unicode
> +Standard Annex #29
> +(@url{http://unicode.org/reports/tr29/,http://unicode.org/reports/tr29/}).
> +")

Ditto.

>>From c11a2cf43ddd6108b57c24ef9669655b677ce276 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom <at> riseup.net>
> Date: Tue, 2 Nov 2021 06:36:37 +0000
> Subject: [PATCH 1/8] gnu: Add go-github-com-vividcortex-ewma.
>
> * gnu/packages/golang.scm (go-github-com-vividcortex-ewma): New variable.

[...]

> +    (home-page "https://github.com/VividCortex/ewma")
> +    (synopsis "EWMA")
> +    (description
> +      "Package ewma implements exponentially weighted moving averages.")

Ditto.

Could you send updated patches?

TIA,
Ludo’.

Message #29 received at 51565 <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: pukkamustard <pukkamustard <at> posteo.net>, 51565 <at> debbugs.gnu.org
Subject: Re: bug#51565: PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Wed, 1 Dec 2021 17:03:10 +0100

On Wed, 01 Dec 2021 16:27:23 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi raingloom,
> 
> Apologies for the delay.
> 
> raingloom <raingloom <at> riseup.net> skribis:
> 
> >>From 776202eb2d0610e51f5168d108ce80a4096b10d4 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Wed, 3 Nov 2021 21:40:37 +0100
> > Subject: [PATCH 8/8] gnu: yggdrasil: Update to 0.4.1.
> >
> > * gnu/packages/networking.scm (yggdrasil): Update to 0.4.1.
> > * gnu/packages/patches/yggdrasil-extra-config.patch: Update for new
> > version.  
> 
> OK.
> 
> >>From ce6e34a490816fd9c093fec3b9124bff26620e1f Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:50:36 +0000
> > Subject: [PATCH 6/8] gnu: Add go-github-com-arceliar-ironwood.
> >
> > * gnu/packages/golang.scm (go-github-com-arceliar-ironwood): New
> > variable.  
> 
> OK.
> 
> >>From 1b4bfd5a947902f453e47a510ab058ff459412f5 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:46:57 +0000
> > Subject: [PATCH 5/8] gnu: Rename go-github-com-cheggaaa-pb to
> >  go-github-com-cheggaaa-pb-v3.
> >
> > * gnu/packages/golang.scm:
> >   (go-github-com-cheggaaa-pb): Rename variable.
> >   (go-github-com-cheggaaa-pb-v3): New variable.
> > ---
> >  gnu/packages/golang.scm | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> > index 4033806c7f..d0435b5469 100644
> > --- a/gnu/packages/golang.scm
> > +++ b/gnu/packages/golang.scm
> > @@ -7945,9 +7945,9 @@ (define-public go-github-com-arceliar-phony
> >  inspired by the causal messaging system in the Pony programming
> > language.") (license license:expat))))
> >  
> > -(define-public go-github-com-cheggaaa-pb
> > +(define-public go-github-com-cheggaaa-pb-v3
> >    (package
> > -    (name "go-github-com-cheggaaa-pb")
> > +    (name "go-github-com-cheggaaa-pb-v3")  
> 
> Why rename?  If we do need to rename, let’s add a ‘deprecated-package’
> definition to allow users to notice and get a smooth upgrade.

Without a rename guix import go gets confused and imports it again
under that name. It didn't seem like anything was using it so I went
with a rename, but I guess someone's channel might be depending on it.
(although I doubt it)
What would proper deprecation look like? Just inheriting from the new
package, changing the name field, and marking it as deprecated?

> >>From 6a4220dbb3cbb56cc818bd2f2714484e5f8682e4 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:45:47 +0000
> > Subject: [PATCH 4/8] gnu: go-github-com-cheggaaa-pb: Update to
> > 3.0.8.
> >
> > * gnu/packages/golang.scm (go-github-com-cheggaaa-pb): Update to
> > 3.0.8.  
> 
> Could you mention input changes?
> 
> >>From a234dd530900d0914a9972ad5a22a1fe303c1bc5 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:37:17 +0000
> > Subject: [PATCH 3/8] gnu: Add go-github-com-mattn-go-runewidth.
> >
> > * gnu/packages/golang.scm (go-github-com-mattn-go-runewidth): New
> > variable.  
> 
> [...]
> 
> > +    (home-page "https://github.com/mattn/go-runewidth")
> > +    (synopsis "Rune width implementation for Go")
> > +    (description
> > +      "Provides functions to get fixed width of the character or
> > string.")  
> 
> Please write a full sentence:
> 
>   https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
> 
> >>From 4732bee7bdbea38292afe9f6b1149986dbfabcb7 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:37:11 +0000
> > Subject: [PATCH 2/8] gnu: Add go-github-com-rivo-uniseg.
> >
> > * gnu/packages/golang.scm (go-github-com-rivo-uniseg): New
> > variable.  
> 
> [...]
> 
> > +    (synopsis "Unicode Text Segmentation for Go")
> > +    (description
> > +      "Package uniseg implements Unicode Text Segmentation
> > according to Unicode +Standard Annex #29
> > +(@url{http://unicode.org/reports/tr29/,http://unicode.org/reports/tr29/}).
> > +")  
> 
> Ditto.
> 
> >>From c11a2cf43ddd6108b57c24ef9669655b677ce276 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <raingloom <at> riseup.net>
> > Date: Tue, 2 Nov 2021 06:36:37 +0000
> > Subject: [PATCH 1/8] gnu: Add go-github-com-vividcortex-ewma.
> >
> > * gnu/packages/golang.scm (go-github-com-vividcortex-ewma): New
> > variable.  
> 
> [...]
> 
> > +    (home-page "https://github.com/VividCortex/ewma")
> > +    (synopsis "EWMA")
> > +    (description
> > +      "Package ewma implements exponentially weighted moving
> > averages.")  
> 
> Ditto.
> 
> Could you send updated patches?
> 
> TIA,
> Ludo’.

Message #34 received at 51565-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 51565-done <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, raingloom <at> riseup.net
Subject: PATCH: Update Yggdrasil to new protocol (important breaking changes)
Date: Wed, 01 Dec 2021 17:04:33 +0100

Ludo’s review overlapped my review.  I’ve already made all the 
changes that Ludo requested.

+ changed the descriptions
+ recorded all changes in the commit
+ added a deprecated-package in the rename commit
+ fixed indentation

Commit d9956e938343c7637647ad10b977fdb0f3b8b138 updates yggdrasil 
to 0.4.1.

-- 
Ricardo

Message #37 received at 51565 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: pukkamustard <pukkamustard <at> posteo.net>, 51565 <at> debbugs.gnu.org
Subject: Re: bug#51565: PATCH: Update Yggdrasil to new protocol (important
 breaking changes)
Date: Thu, 02 Dec 2021 10:15:56 +0100

Hi,

raingloom <raingloom <at> riseup.net> skribis:

>> > -(define-public go-github-com-cheggaaa-pb
>> > +(define-public go-github-com-cheggaaa-pb-v3
>> >    (package
>> > -    (name "go-github-com-cheggaaa-pb")
>> > +    (name "go-github-com-cheggaaa-pb-v3")  
>> 
>> Why rename?  If we do need to rename, let’s add a ‘deprecated-package’
>> definition to allow users to notice and get a smooth upgrade.
>
> Without a rename guix import go gets confused and imports it again
> under that name.

Ah that makes sense; would be worth adding a comment above.

> It didn't seem like anything was using it so I went with a rename, but
> I guess someone's channel might be depending on it.  (although I doubt
> it) What would proper deprecation look like? Just inheriting from the
> new package, changing the name field, and marking it as deprecated?

Yes, you can grep for ‘deprecated-package’ in gnu/packages/*.scm.

Thanks,
Ludo’.

Message #40 received at 51565-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 51565-done <at> debbugs.gnu.org, raingloom <at> riseup.net
Subject: Re: PATCH: Update Yggdrasil to new protocol (important breaking
 changes)
Date: Thu, 02 Dec 2021 10:16:22 +0100

Hi,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Ludo’s review overlapped my review.  I’ve already made all the changes
> that Ludo requested.
>
> + changed the descriptions
> + recorded all changes in the commit
> + added a deprecated-package in the rename commit
> + fixed indentation
>
> Commit d9956e938343c7637647ad10b977fdb0f3b8b138 updates yggdrasil to
> 0.4.1.

Ah wonderful, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.