GNU bug report logs - #51576
27.2; Bad error message for `defface' with no doc string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51576 in the body.
You can then email your comments to 51576 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 27.2; Bad error message for `defface' with no doc string
Date: Wed, 3 Nov 2021 02:30:09 +0000

emacs -Q

Eval this:

(defface foo '((t :background "gray70" :inherit region))
  :group 'faces :type 'sexp)

Instead of telling you the doc string is missing, the error message says
this:

Debugger entered--Lisp error: (error "Unknown keyword faces")
  signal(error ("Unknown keyword faces"))
  error("Unknown keyword %s" faces)
  custom-handle-keyword(foo faces :type custom-face)
  custom-handle-all-keywords(foo (faces :type sexp) custom-face)
  custom-declare-face(foo ((t :background "gray70" :inherit region)) :group faces :type sexp)
  eval-region(146 231 t #f(compiled-function (ignore) #<bytecode 0x2293dd9>))  ; Reading at buffer position 151
  elisp--eval-defun()
  eval-defun(nil)
  funcall-interactively(eval-defun nil)
  call-interactively(eval-defun nil nil)
  command-execute(eval-defun)


In GNU Emacs 27.2 (build 1, x86_64-w64-mingw32)
 of 2021-03-26 built on CIRROCUMULUS
Repository revision: deef5efafb70f4b171265b896505b92b6eef24e6
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.19042
System Description: Microsoft Windows 10 Pro (v10.0.2009.19042.1288)

Message #8 received at 51576 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Drew Adams <drew.adams <at> oracle.com>, "51576 <at> debbugs.gnu.org"
 <51576 <at> debbugs.gnu.org>
Subject: RE: 27.2; Bad error message for `defface' with no doc string
Date: Wed, 3 Nov 2021 02:36:03 +0000

> (defface foo '((t :background "gray70" :inherit region))
>   :group 'faces :type 'sexp)

Typo (doesn't matter for the report though).
Remove the :type 'sexp.

Message #11 received at 51576 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 51576 <at> debbugs.gnu.org
Subject: Re: bug#51576: 27.2;
 Bad error message for `defface' with no doc string
Date: Wed, 3 Nov 2021 15:29:44 -0700

tags 51576 + confirmed easy
found 51576 29.0.50
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

> emacs -Q
>
> Eval this:
>
> (defface foo '((t :background "gray70" :inherit region))
>   :group 'faces :type 'sexp)
>
> Instead of telling you the doc string is missing, the error message says
> this:
>
> Debugger entered--Lisp error: (error "Unknown keyword faces")
>   signal(error ("Unknown keyword faces"))
>   error("Unknown keyword %s" faces)
>   custom-handle-keyword(foo faces :type custom-face)
>   custom-handle-all-keywords(foo (faces :type sexp) custom-face)
>   custom-declare-face(foo ((t :background "gray70" :inherit region)) :group faces :type sexp)
>   eval-region(146 231 t #f(compiled-function (ignore) #<bytecode 0x2293dd9>))  ; Reading at buffer position 151
>   elisp--eval-defun()
>   eval-defun(nil)
>   funcall-interactively(eval-defun nil)
>   call-interactively(eval-defun nil nil)
>   command-execute(eval-defun)

I can reproduce this on current master.  I agree that it would be better
to say that the docstring is missing here.

Message #18 received at 51576 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Drew Adams <drew.adams <at> oracle.com>, 51576 <at> debbugs.gnu.org
Subject: Re: bug#51576: 27.2; Bad error message for `defface' with no doc
 string
Date: Thu, 04 Nov 2021 19:23:23 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> I can reproduce this on current master.  I agree that it would be better
> to say that the docstring is missing here.

I've now done this on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.