GNU bug report logs - #51587
[PATCH 0/3] Add rss2email.

Previous Next

Package: guix-patches;

Reported by: Morgan.J.Smith <at> outlook.com

Date: Wed, 3 Nov 2021 16:34:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51587 in the body.
You can then email your comments to 51587 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Wed, 03 Nov 2021 16:34:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Morgan.J.Smith <at> outlook.com:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 03 Nov 2021 16:34:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Add rss2email.
Date: Wed,  3 Nov 2021 12:27:54 -0400
[PATCH 1/3] gnu: Add python-sgmllib3k.
[PATCH 2/3] gnu: python-feedparser: Add input
[PATCH 3/3] gnu: Add rss2email.





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Wed, 03 Nov 2021 16:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 1/3] gnu: Add python-sgmllib3k.
Date: Wed,  3 Nov 2021 12:37:25 -0400
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 32d6b403d4..d2aca67aca 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -27643,3 +27643,26 @@ (define-public python-ijson
      "Ijson is an iterative JSON parser with standard Python iterator
 interfaces.")
     (license license:bsd-3)))
+
+(define-public python-sgmllib3k
+  (package
+    (name "python-sgmllib3k")
+    (version "1.0.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "sgmllib3k" version))
+        (sha256
+          (base32 "1s8jm3dgqabgf8x96931scji679qkhvczlv3qld4qxpsicfgns3q"))))
+    (build-system python-build-system)
+    ;; Requires a test.html input that is not supplied
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://pypi.org/project/sgmllib3k/")
+    ;; Actual homepage seems to be down
+    ;; (home-page "https://hg.hardcoded.net/sgmllib")
+    (synopsis "Python 3 port of sgmllib")
+    (description "A quick, dirty, unmaintained port of sgmllib to Python 3.
+It is used parse text files formatted in @acronym{SGML,Standard Generalized
+Mark-up Language}.")
+    (license license:bsd-3)))
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Wed, 03 Nov 2021 16:38:02 GMT) Full text and rfc822 format available.

Message #11 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 2/3] gnu: python-feedparser: Add input
Date: Wed,  3 Nov 2021 12:37:26 -0400
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/web.scm (python-feedparser) [propagated-inputs]: Add
python-sgmllib3k
---
 gnu/packages/web.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 8e865b7658..33ad874385 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -4773,6 +4773,8 @@ (define-public python-feedparser
         (base32
          "0x0hm9brh3j71645pydvlkrwxaaca9dnwd7xahwjyjaz882s200v"))))
     (build-system python-build-system)
+    (propagated-inputs
+     `(("python-sgmllib3k" ,python-sgmllib3k)))
     (arguments
      '(#:tests? #f))
     (home-page
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Wed, 03 Nov 2021 16:38:03 GMT) Full text and rfc822 format available.

Message #14 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 3/3] gnu: Add rss2email.
Date: Wed,  3 Nov 2021 12:37:27 -0400
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/mail.scm (rss2email): New variable.
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index c5d8cf04ff..04d27d0337 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -4614,3 +4614,41 @@ (define-public crm114
 Bigrams, WINNOW, Correlation, KNN/Hyperspace, or Bit Entropy (or by other
 means--it's all programmable).")
     (license license:gpl3)))
+
+(define-public rss2email
+  (package
+    (name "rss2email")
+    (version "3.13.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/rss2email/rss2email")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0g1yr3v3ibdh2jqil64fbdbplx5m2yzxr893fqfkwcc5c7fbwl4d"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+             (when tests?
+               (with-directory-excursion "test"
+                 ;; Skip networking tests
+                 (substitute* "test.py"
+                   (("( *)class (:?TestSend|TestFetch).*" match indent)
+                    (string-append indent "@unittest.skip(\"Networking stuff skipped\")\n"
+                                   indent match)))
+                 (invoke "python" "-m" "unittest"))))))))
+    (propagated-inputs
+     `(("python-feedparser" ,python-feedparser)
+       ("python-html2text" ,python-html2text)))
+    (home-page "https://github.com/rss2email/rss2email")
+    (synopsis "Converts RSS/Atom newsfeeds to email")
+    (description "When run it fetches RSS/Atom newsfeeds, converts them into an email, and
+emails them.")
+    ;; GPL version 2 or 3. NOT 2+.
+    (license (list license:gpl2
+                   license:gpl3))))
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Fri, 05 Nov 2021 15:37:01 GMT) Full text and rfc822 format available.

Message #17 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Morgan.J.Smith <at> outlook.com, 51587 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/3] gnu: Add python-sgmllib3k.
Date: Fri, 05 Nov 2021 15:35:26 +0000
Hi,

I added this patch in 51314, and now I also noticed that it was
submitted even earlier in 50853. Maybe we should review that one first?

Em qua, 2021-11-03 às 12:37 -0400, Morgan.J.Smith <at> outlook.com escreveu:
> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
> 
> * gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.
> ---
>  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 32d6b403d4..d2aca67aca 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -27643,3 +27643,26 @@ (define-public python-ijson
>       "Ijson is an iterative JSON parser with standard Python
> iterator
>  interfaces.")
>      (license license:bsd-3)))
> +
> +(define-public python-sgmllib3k
> +  (package
> +    (name "python-sgmllib3k")
> +    (version "1.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "sgmllib3k" version))
> +        (sha256
> +          (base32
> "1s8jm3dgqabgf8x96931scji679qkhvczlv3qld4qxpsicfgns3q"))))

Indentation nitpick here in the source.

> +    (build-system python-build-system)
> +    ;; Requires a test.html input that is not supplied
> +    (arguments
> +     `(#:tests? #f))
> +    (home-page "https://pypi.org/project/sgmllib3k/")
> +    ;; Actual homepage seems to be down
> +    ;; (home-page "https://hg.hardcoded.net/sgmllib")
> +    (synopsis "Python 3 port of sgmllib")
> +    (description "A quick, dirty, unmaintained port of sgmllib to
> Python 3.
> +It is used parse text files formatted in @acronym{SGML,Standard
> Generalized
> +Mark-up Language}.")

I think this description doesn't qualify as a full sentence.

> +    (license license:bsd-3)))






Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Fri, 05 Nov 2021 15:57:02 GMT) Full text and rfc822 format available.

Message #20 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Morgan.J.Smith <at> outlook.com, 51587 <at> debbugs.gnu.org
Subject: Re: [PATCH 3/3] gnu: Add rss2email.
Date: Fri, 05 Nov 2021 15:55:43 +0000
Em qua, 2021-11-03 às 12:37 -0400, Morgan.J.Smith <at> outlook.com escreveu:
> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
> 
> * gnu/packages/mail.scm (rss2email): New variable.
> ---
>  gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++

Please add your copyright line in this file.

>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index c5d8cf04ff..04d27d0337 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -4614,3 +4614,41 @@ (define-public crm114
>  Bigrams, WINNOW, Correlation, KNN/Hyperspace, or Bit Entropy (or by
> other
>  means--it's all programmable).")
>      (license license:gpl3)))
> +
> +(define-public rss2email
> +  (package
> +    (name "rss2email")
> +    (version "3.13.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/rss2email/rss2email")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0g1yr3v3ibdh2jqil64fbdbplx5m2yzxr893fqfkwcc5c7fbwl4d"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda* (#:key tests? inputs outputs #:allow-other-keys)

Inputs and outputs are not being used in the body.

> +             (when tests?
> +               (with-directory-excursion "test"
> +                 ;; Skip networking tests
> +                 (substitute* "test.py"
> +                   (("( *)class (:?TestSend|TestFetch).*" match
> indent)
> +                    (string-append indent
> "@unittest.skip(\"Networking stuff skipped\")\n"
> +                                   indent match)))
> +                 (invoke "python" "-m" "unittest"))))))))
> +    (propagated-inputs
> +     `(("python-feedparser" ,python-feedparser)
> +       ("python-html2text" ,python-html2text)))

Is this package used only as executable? Inputs can probably be normal
inputs here.

> +    (home-page "https://github.com/rss2email/rss2email")
> +    (synopsis "Converts RSS/Atom newsfeeds to email")
> +    (description "When run it fetches RSS/Atom newsfeeds, converts
> them into an email, and
> +emails them.")

Full sentence.

> +    ;; GPL version 2 or 3. NOT 2+.

Comments should also follow double spaces when starting a new sentence
in the same line.

> +    (license (list license:gpl2
> +                   license:gpl3))))







Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Thu, 11 Nov 2021 15:31:02 GMT) Full text and rfc822 format available.

Message #23 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: monego <at> posteo.net,
	51587 <at> debbugs.gnu.org
Subject: [PATCH v2 0/3] gnu: Add rss2email.
Date: Thu, 11 Nov 2021 10:30:02 -0500
Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue is. I'll admit I'm not very good at english so if you could just change it how you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Thu, 11 Nov 2021 15:31:02 GMT) Full text and rfc822 format available.

Message #26 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: monego <at> posteo.net,
	51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH v2 1/3] gnu: Add python-sgmllib3k.
Date: Thu, 11 Nov 2021 10:30:03 -0500
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 495d7faa87..5fcb513d78 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -27786,3 +27786,26 @@ (define-public python-ijson
      "Ijson is an iterative JSON parser with standard Python iterator
 interfaces.")
     (license license:bsd-3)))
+
+(define-public python-sgmllib3k
+  (package
+    (name "python-sgmllib3k")
+    (version "1.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "sgmllib3k" version))
+       (sha256
+        (base32 "1s8jm3dgqabgf8x96931scji679qkhvczlv3qld4qxpsicfgns3q"))))
+    (build-system python-build-system)
+    ;; Requires a test.html input that is not supplied
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://pypi.org/project/sgmllib3k/")
+    ;; Actual homepage seems to be down
+    ;; (home-page "https://hg.hardcoded.net/sgmllib")
+    (synopsis "Python 3 port of sgmllib")
+    (description "A quick, dirty, unmaintained port of sgmllib to Python 3.
+It is used to parse text files formatted in @acronym{SGML,Standard Generalized
+Mark-up Language}.")
+    (license license:bsd-3)))
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Thu, 11 Nov 2021 15:31:02 GMT) Full text and rfc822 format available.

Message #29 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: monego <at> posteo.net,
	51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH v2 2/3] gnu: python-feedparser: Add input
Date: Thu, 11 Nov 2021 10:30:04 -0500
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/web.scm (python-feedparser) [propagated-inputs]: Add
python-sgmllib3k
---
 gnu/packages/web.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index a08440887f..20bb86ccf6 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -4773,6 +4773,8 @@ (define-public python-feedparser
         (base32
          "0x0hm9brh3j71645pydvlkrwxaaca9dnwd7xahwjyjaz882s200v"))))
     (build-system python-build-system)
+    (propagated-inputs
+     `(("python-sgmllib3k" ,python-sgmllib3k)))
     (arguments
      '(#:tests? #f))
     (home-page
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51587; Package guix-patches. (Thu, 11 Nov 2021 15:31:03 GMT) Full text and rfc822 format available.

Message #32 received at 51587 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: monego <at> posteo.net,
	51587 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH v2 3/3] gnu: Add rss2email.
Date: Thu, 11 Nov 2021 10:30:05 -0500
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/mail.scm (rss2email): New variable.
---
 gnu/packages/mail.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 31cf4ec6b0..1d9f361b80 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -42,6 +42,7 @@
 ;;; Copyright © 2020 divoplade <d <at> divoplade.fr>
 ;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
 ;;; Copyright © 2021 Benoit Joly <benoit <at> benoitj.ca>
+;;; Copyright © 2021 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4612,3 +4613,41 @@ (define-public crm114
 Bigrams, WINNOW, Correlation, KNN/Hyperspace, or Bit Entropy (or by other
 means--it's all programmable).")
     (license license:gpl3)))
+
+(define-public rss2email
+  (package
+    (name "rss2email")
+    (version "3.13.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/rss2email/rss2email")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0g1yr3v3ibdh2jqil64fbdbplx5m2yzxr893fqfkwcc5c7fbwl4d"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (with-directory-excursion "test"
+                 ;; Skip networking tests
+                 (substitute* "test.py"
+                   (("( *)class (:?TestSend|TestFetch).*" match indent)
+                    (string-append indent "@unittest.skip(\"Networking stuff skipped\")\n"
+                                   indent match)))
+                 (invoke "python" "-m" "unittest"))))))))
+    (inputs
+     `(("python-feedparser" ,python-feedparser)
+       ("python-html2text" ,python-html2text)))
+    (home-page "https://github.com/rss2email/rss2email")
+    (synopsis "Converts RSS/Atom newsfeeds to email")
+    (description "Fetches RSS/Atom newsfeeds, converts them into emails, and
+emails them.")
+    ;; GPL version 2 or 3.  NOT 2+.
+    (license (list license:gpl2
+                   license:gpl3))))
-- 
2.33.1





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Fri, 12 Nov 2021 23:01:02 GMT) Full text and rfc822 format available.

Notification sent to Morgan.J.Smith <at> outlook.com:
bug acknowledged by developer. (Fri, 12 Nov 2021 23:01:02 GMT) Full text and rfc822 format available.

Message #37 received at 51587-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Morgan.J.Smith <at> outlook.com
Cc: 51587-done <at> debbugs.gnu.org, monego <at> posteo.net
Subject: Re: bug#51587: [PATCH 0/3] Add rss2email.
Date: Fri, 12 Nov 2021 23:59:55 +0100
Hi Morgan,

Morgan.J.Smith <at> outlook.com skribis:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.

[...]

> * gnu/packages/web.scm (python-feedparser) [propagated-inputs]: Add
> python-sgmllib3k

[...]

> * gnu/packages/mail.scm (rss2email): New variable.

I turned descriptions into full sentences and applied.

Thank you, and thanks Vinicius for reviewing!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 11 Dec 2021 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 98 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.