GNU bug report logs - #51592
[PATCH 0/2] gnu: Add bloomberg-bde.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51592 in the body.
You can then email your comments to 51592 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: Add bloomberg-bde.
Date: Wed, 3 Nov 2021 15:12:31 -0400

[Message part 1 (text/plain, inline)]

This patchset adds Bloomberg's BDE C++ library as well as the bde-tools
dependency.

[Message part 2 (text/html, inline)]

[0002-gnu-Add-bloomberg-bde.patch (application/octet-stream, attachment)]

[0001-gnu-Add-bloomberg-bde-tools.patch (application/octet-stream, attachment)]

Message #8 received at 51592 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 51592 <at> debbugs.gnu.org
Subject: Re: bug#51592: [PATCH 0/2] gnu: Add bloomberg-bde.
Date: Wed, 01 Dec 2021 16:50:22 +0100

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> From 9fc2c247d937d587c54b634ec6fcca2b77e22f37 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Wed, 3 Nov 2021 15:22:19 +0000
> Subject: [PATCH 2/2] gnu: Add bloomberg-bde.
>
> * gnu/packages/cpp.scm (bloomberg-bde): New variable.

[...]

> +      (name "bloomberg-bde")
> +      ; Recent releases are not tagged so commit must be used for checkout.
> +      (version "3.93.0.0")
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/bloomberg/bde")
> +                      (commit commit)))

There are several bundled code bases, including pcre2, which is already
packaged.

Could you look into unbundling at least pcre2, and ideally all of these?
You can remove ‘thirdparty/’ subdirectories from the snippet.

If some of them are too hard to unbundle, we can leave a FIXME and
address them later.

Nitpick: Please use two semicolons to introduce comments that are on a
line of their own.  :-)

Thanks in advance, and apologies for the delay!

Ludo’.

Message #11 received at 51592 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 51592 <at> debbugs.gnu.org
Subject: Re: bug#51592: [PATCH 0/2] gnu: Add bloomberg-bde.
Date: Mon, 20 Dec 2021 20:26:17 -0500

[Message part 1 (text/plain, inline)]

On Wed, Dec 1, 2021 at 10:50 AM Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi,
>
> Greg Hogan <code <at> greghogan.com> skribis:
>
> > From 9fc2c247d937d587c54b634ec6fcca2b77e22f37 Mon Sep 17 00:00:00 2001
> > From: Greg Hogan <code <at> greghogan.com>
> > Date: Wed, 3 Nov 2021 15:22:19 +0000
> > Subject: [PATCH 2/2] gnu: Add bloomberg-bde.
> >
> > * gnu/packages/cpp.scm (bloomberg-bde): New variable.
>
> [...]
>
> > +      (name "bloomberg-bde")
> > +      ; Recent releases are not tagged so commit must be used for
> checkout.
> > +      (version "3.93.0.0")
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url "https://github.com/bloomberg/bde")
> > +                      (commit commit)))
>
> There are several bundled code bases, including pcre2, which is already
> packaged.
>
> Could you look into unbundling at least pcre2, and ideally all of these?
> You can remove ‘thirdparty/’ subdirectories from the snippet.
>
> If some of them are too hard to unbundle, we can leave a FIXME and
> address them later.
>

I added a FIXME. It is noted that the third-party sources are modified.


> Nitpick: Please use two semicolons to introduce comments that are on a
> line of their own.  :-)
>

Fixed. Thanks for the reminder.


> Thanks in advance, and apologies for the delay!
>

In addition to rebasing against master and updating the inputs formatting,
I was able to switch the native-input dependency from python2 to python
since my simple patch was accepted upstream. Always nice to see that.


> Ludo’.
>

Greg

[Message part 2 (text/html, inline)]

[0001-gnu-Add-bloomberg-bde-tools.patch (application/octet-stream, attachment)]

[0002-gnu-Add-bloomberg-bde.patch (application/octet-stream, attachment)]

Message #14 received at 51592 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 51592 <at> debbugs.gnu.org
Subject: Re: [bug#51592] [PATCH 0/2] gnu: Add bloomberg-bde.
Date: Fri, 4 Feb 2022 16:23:29 -0500

[Message part 1 (text/plain, inline)]

I have updated the attached patches to the latest versioned commits. I
believe the recommended fixes are all in place.

Thanks,
Greg

>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-bloomberg-bde-tools.patch (text/x-patch, attachment)]

[0002-gnu-Add-bloomberg-bde.patch (text/x-patch, attachment)]

Message #19 received at 51592-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 51592-done <at> debbugs.gnu.org
Subject: Re: [bug#51592] [PATCH 0/2] gnu: Add bloomberg-bde.
Date: Tue, 08 Feb 2022 18:19:12 +0100

Hi Greg,

Greg Hogan <code <at> greghogan.com> skribis:

> From fa9d62133973705b08f4f0952cf55189ff9cdb7b Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Wed, 3 Nov 2021 15:20:51 +0000
> Subject: [PATCH 1/2] gnu: Add bloomberg-bde-tools.
>
> * gnu/packages/cpp.scm (bloomberg-bde-tools): New variable.

> From 5b6114f4ee2c3801858d2984d706a490cd34f50e Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Wed, 3 Nov 2021 15:22:19 +0000
> Subject: [PATCH 2/2] gnu: Add bloomberg-bde.
>
> * gnu/packages/cpp.scm (bloomberg-bde): New variable.

Applied both, sorry for the delay!

However, I hit a test failure in one case:

--8<---------------cut here---------------start------------->8---
513/950 Test #513: bslh_defaultseededhashalgorithm.t ..................   Passed    0.05 sec
        Start 514: bslh_fibonaccibadhashwrapper.t
514/950 Test #514: bslh_fibonaccibadhashwrapper.t .....................   Passed    0.05 sec
        Start 515: bslh_hash.t
515/950 Test #515: bslh_hash.t ........................................***Failed    0.05 sec
[11:23:07] TEST START
[11:23:07] CASE  1: SUCCESS
[11:23:07] CASE  2: SUCCESS
[11:23:07] CASE  3: FAILURE (rc 1)
TEST /tmp/guix-build-bloomberg-bde-3.98.0.0.drv-0/source/groups/bsl/bslh/bslh_hash.t.cpp CASE 3
1463: 1463      alg.getLength(): 10     size: 16
Error, non-zero test status = 1.
Error /tmp/guix-build-bloomberg-bde-3.98.0.0.drv-0/source/groups/bsl/bslh/bslh_hash.t.cpp(1463): alg.getLength() == size    (failed)

[11:23:07] CASE  4: SUCCESS
[11:23:07] CASE  5: SUCCESS
[11:23:07] CASE  6: SUCCESS
[11:23:07] CASE  7: SUCCESS
[11:23:07] CASE  8: SUCCESS

        Start 516: bslh_hashoptional.t
516/950 Test #516: bslh_hashoptional.t ................................   Passed    0.05 sec
        Start 517: bslh_hashtuple.t
517/950 Test #517: bslh_hashtuple.t ...................................   Passed    0.05 sec
        Start 518: bslh_hashvariant.t
518/950 Test #518: bslh_hashvariant.t .................................   Passed    0.05 sec
--8<---------------cut here---------------end--------------->8---

It’d be worth monitoring ci.guix to see if it happens reproducibly.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.