GNU bug report logs - #51623
[PATCH] gnu: Add python-ta-lib.

Previous Next

Package: guix-patches;

Reported by: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>

Date: Sat, 6 Nov 2021 04:36:01 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51623 in the body.
You can then email your comments to 51623 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51623; Package guix-patches. (Sat, 06 Nov 2021 04:36:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Foo Chuan Wei <chuanwei.foo <at> hotmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 06 Nov 2021 04:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-ta-lib.
Date: Sat, 6 Nov 2021 04:30:18 +0000
* gnu/packages/python-xyz.scm (python-ta-lib): New variable.
---
 gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8ba72170c0..e2e51db25f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -111,6 +111,7 @@
 ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
 ;;; Copyright © 2021 Sébastien Lerique <sl <at> eauchat.org>
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
+;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -146,6 +147,7 @@
   #:use-module (gnu packages docker)
   #:use-module (gnu packages enchant)
   #:use-module (gnu packages file)
+  #:use-module (gnu packages finance)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages geo)
@@ -27684,3 +27686,29 @@ simple mock/record and a complete capture/replay framework.")
      "Ijson is an iterative JSON parser with standard Python iterator
 interfaces.")
     (license license:bsd-3)))
+
+(define-public python-ta-lib
+  (package
+    (name "python-ta-lib")
+    (version "0.4.21")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "TA-Lib" version))
+       (sha256
+        (base32 "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
+    (build-system python-build-system)
+    (inputs
+     `(("ta-lib" ,ta-lib)))
+    (propagated-inputs
+     `(("python-numpy" ,python-numpy)))
+    (native-inputs
+     `(("python-nose" ,python-nose)
+       ("python-pandas" ,python-pandas)))
+    (home-page "https://github.com/mrjbq7/ta-lib")
+    (synopsis "Python wrapper for TA-Lib")
+    (description
+      "Python wrapper for TA-Lib based on Cython.  TA-Lib is a library
+providing common functions for the technical analysis of financial market
+data.")
+    (license license:bsd-2)))

base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#51623; Package guix-patches. (Thu, 11 Nov 2021 06:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 51623 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>, 51623 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add python-ta-lib.
Date: Thu, 11 Nov 2021 06:07:37 +0000
Hi,

Em sáb, 2021-11-06 às 04:30 +0000, Foo Chuan Wei escreveu:
> * gnu/packages/python-xyz.scm (python-ta-lib): New variable.

Thanks for your contribution. Patch looks good overall, I have only a
few nitpicks.

> ---
>  gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

IMO this package would make more sense in finance.scm.

> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 8ba72170c0..e2e51db25f 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -111,6 +111,7 @@
>  ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
>  ;;; Copyright © 2021 Sébastien Lerique <sl <at> eauchat.org>
>  ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
> +;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -146,6 +147,7 @@
>    #:use-module (gnu packages docker)
>    #:use-module (gnu packages enchant)
>    #:use-module (gnu packages file)
> +  #:use-module (gnu packages finance)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages gcc)
>    #:use-module (gnu packages geo)
> @@ -27684,3 +27686,29 @@ simple mock/record and a complete
> capture/replay framework.")
>       "Ijson is an iterative JSON parser with standard Python
> iterator
>  interfaces.")
>      (license license:bsd-3)))
> +
> +(define-public python-ta-lib
> +  (package
> +    (name "python-ta-lib")
> +    (version "0.4.21")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "TA-Lib" version))
> +       (sha256
> +        (base32
> "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("ta-lib" ,ta-lib)))
> +    (propagated-inputs
> +     `(("python-numpy" ,python-numpy)))

Description says it's based on Cython, so python-cython should be a
native input.

> +    (native-inputs
> +     `(("python-nose" ,python-nose)
> +       ("python-pandas" ,python-pandas)))
> +    (home-page "https://github.com/mrjbq7/ta-lib")
> +    (synopsis "Python wrapper for TA-Lib")

There's one extra space in the description. The double quote should be
aligned with the "d" in description.

The description must also be a full sentence. It can be "This package
provides a [...]" or something along these lines.

> +    (description
> +      "Python wrapper for TA-Lib based on Cython.  TA-Lib is a
> library
> +providing common functions for the technical analysis of financial
> market
> +data.")
> +    (license license:bsd-2)))

It is also recommended to declare packages somewhere in the middle, not
at the end of the file, to avoid merge conflicts.

> 
> base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e

Vinicius





Information forwarded to guix-patches <at> gnu.org:
bug#51623; Package guix-patches. (Mon, 15 Nov 2021 05:44:01 GMT) Full text and rfc822 format available.

Message #11 received at 51623 <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 51623 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add python-ta-lib.
Date: Mon, 15 Nov 2021 05:25:33 +0000
* gnu/packages/finance.scm (python-ta-lib): New variable.
---
 gnu/packages/finance.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index c9732f936e..b35ef6be75 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -98,6 +98,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-crypto)
+  #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-web)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
@@ -1755,6 +1756,32 @@ local, single-user UI, or as a multi-user UI for viewing, adding, and
 editing on the Web.")
     (license license:gpl3)))
 
+(define-public python-ta-lib
+  (package
+    (name "python-ta-lib")
+    (version "0.4.21")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "TA-Lib" version))
+       (sha256
+        (base32 "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
+    (build-system python-build-system)
+    (inputs
+     `(("ta-lib" ,ta-lib)))
+    (propagated-inputs
+     `(("python-numpy" ,python-numpy)))
+    (native-inputs
+     `(("python-cython" ,python-cython)
+       ("python-nose" ,python-nose)
+       ("python-pandas" ,python-pandas)))
+    (home-page "https://github.com/mrjbq7/ta-lib")
+    (synopsis "Python wrapper for TA-Lib")
+    (description
+     "This is a Python wrapper for TA-Lib based on Cython.  TA-Lib is a library
+providing common functions for the technical analysis of financial market data.")
+    (license license:bsd-2)))
+
 (define-public ta-lib
   (package
     (name "ta-lib")

base-commit: 272e8f50511a551ce1c0a941c949c8ffafd849ff
-- 
2.25.1





Reply sent to Guillaume Le Vaillant <glv <at> posteo.net>:
You have taken responsibility. (Mon, 15 Nov 2021 16:56:02 GMT) Full text and rfc822 format available.

Notification sent to Foo Chuan Wei <chuanwei.foo <at> hotmail.com>:
bug acknowledged by developer. (Mon, 15 Nov 2021 16:56:02 GMT) Full text and rfc822 format available.

Message #16 received at 51623-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
Cc: Vinicius Monego <monego <at> posteo.net>, 51623-done <at> debbugs.gnu.org
Subject: Re: [bug#51623] [PATCH v2] gnu: Add python-ta-lib.
Date: Mon, 15 Nov 2021 16:54:13 +0000
[Message part 1 (text/plain, inline)]
Patch pushed as 386db367c9ad8633252cea8727de9f09b3a552db.
Thanks.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Dec 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.