GNU bug report logs - #51640
[PATCH guix 0/1] [PATCH] Adds libphonenumber

Previous Next

Package: guix-patches;

Reported by: ~rdesfo <rdesfo <at> protonmail.com>

Date: Sat, 6 Nov 2021 16:36:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51640 in the body.
You can then email your comments to 51640 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51640; Package guix-patches. (Sat, 06 Nov 2021 16:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to ~rdesfo <rdesfo <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 06 Nov 2021 16:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ~rdesfo <rdesfo <at> git.sr.ht>
To: guix-patches <at> gnu.org
Cc: rdes <at> protonmail.com
Subject: [PATCH guix 0/1] [PATCH] Adds libphonenumber
Date: Sat, 06 Nov 2021 16:25:59 +0000
Hello,

The attached patch adds libphonenumber.

Ryan Desfosses (1):
  gnu: Add libphonenumber

 gnu/packages/messaging.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

-- 
2.32.0




Information forwarded to guix-patches <at> gnu.org:
bug#51640; Package guix-patches. (Sat, 06 Nov 2021 16:43:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ~rdesfo <rdesfo <at> git.sr.ht>
To: guix-patches <at> gnu.org
Cc: rdes <at> protonmail.com
Subject: [PATCH guix 1/1] gnu: Add libphonenumber
Date: Sun, 12 Sep 2021 16:24:01 -0400
From: Ryan Desfosses <rdes <at> protonmail.com>

* gnu/package/messaging.scm (libphonenumber): New variable
---
 gnu/packages/messaging.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index a7fed957a3..b6a1ba2981 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2616,6 +2616,39 @@ support for high performance Telegram Bot creation.")
     (home-page "https://source.puri.sm/Librem5/purple-mm-sms")
     (license license:gpl2+)))
 
+(define-public libphonenumber
+  (package
+   (name "libphonenumber")
+   (version "8.11.3")
+   (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/libphonenumber")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "06y3mh1d1mks6d0ynxp3980g712nkf8l5nyljpybsk326b246hg9"))))
+   (arguments
+    `(#:tests? #f ; no tests
+      #:phases
+      (modify-phases %standard-phases
+        (add-after 'unpack 'change-directory
+          (lambda _ (chdir "cpp") #t)))))
+   (build-system cmake-build-system)
+   (native-inputs
+    `(("googletest" ,googletest)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("boost" ,boost)
+      ("protobuf" ,protobuf)
+      ("icu4c" ,icu4c)))
+   (synopsis "Google's i18n library for parsing and using phone numbers")
+   (description "Google's i18n library for parsing and using phone numbers")
+   (home-page "https://github.com/google/libphonenumber")
+   (license license:asl2.0)))
+
+
 (define-public chatty
  (package
    (name "chatty")
-- 
2.32.0




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 04 Dec 2021 22:04:02 GMT) Full text and rfc822 format available.

Notification sent to ~rdesfo <rdesfo <at> protonmail.com>:
bug acknowledged by developer. (Sat, 04 Dec 2021 22:04:02 GMT) Full text and rfc822 format available.

Message #13 received at 51640-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ~rdesfo <rdesfo <at> git.sr.ht>
Cc: 51640-done <at> debbugs.gnu.org, ~rdesfo <rdesfo <at> protonmail.com>,
 rdes <at> protonmail.com
Subject: Re: bug#51640: [PATCH guix 0/1] [PATCH] Adds libphonenumber
Date: Sat, 04 Dec 2021 23:03:31 +0100
[Message part 1 (text/plain, inline)]
Hi,

~rdesfo <rdesfo <at> git.sr.ht> skribis:

> From: Ryan Desfosses <rdes <at> protonmail.com>
>
> * gnu/package/messaging.scm (libphonenumber): New variable

Applied with the changes below, thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 93f469a968..2e3afb510e 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2791,11 +2791,11 @@ (define-public libphonenumber
                (base32
                 "06y3mh1d1mks6d0ynxp3980g712nkf8l5nyljpybsk326b246hg9"))))
    (arguments
-    `(#:tests? #f ; no tests
+    `(#:test-target "tests"
       #:phases
       (modify-phases %standard-phases
         (add-after 'unpack 'change-directory
-          (lambda _ (chdir "cpp") #t)))))
+          (lambda _ (chdir "cpp"))))))
    (build-system cmake-build-system)
    (native-inputs
     `(("googletest" ,googletest)
@@ -2804,8 +2804,10 @@ (define-public libphonenumber
     `(("boost" ,boost)
       ("protobuf" ,protobuf)
       ("icu4c" ,icu4c)))
-   (synopsis "Google's i18n library for parsing and using phone numbers")
-   (description "Google's i18n library for parsing and using phone numbers")
+   (synopsis "Library for parsing and using phone numbers")
+   (description
+    "This package provides a C++ library for parsing, formatting, and
+validating international phone numbers.")
    (home-page "https://github.com/google/libphonenumber")
    (license license:asl2.0)))
 

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 02 Jan 2022 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 76 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.