GNU bug report logs - #51653
[PATCH] Fix dumping stretch glyph when drawing s->next in NS port

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51653 in the body.
You can then email your comments to 51653 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port
Date: Sun, 07 Nov 2021 16:00:52 +0800

[Message part 1 (text/plain, inline)]

Otherwise, scrolling in a document with stretch glyphs can cause them to
overwrite parts of the mode line, in some cases.

[0001-Set-clipping-when-dumping-stretch-glyphs-in-some-cas.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks.

Message #8 received at 51653 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: alan <at> idiocy.org, 51653 <at> debbugs.gnu.org
Subject: Re: bug#51653: [PATCH] Fix dumping stretch glyph when drawing
 s->next in NS port
Date: Sun, 07 Nov 2021 21:43:24 +0100

Po Lu <luangruo <at> yahoo.com> writes:

> * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping
> stretch glyphs in s->next.

Alan, do you have any comments here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 51653 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Po Lu <luangruo <at> yahoo.com>, 51653 <at> debbugs.gnu.org
Subject: Re: bug#51653: [PATCH] Fix dumping stretch glyph when drawing
 s->next in NS port
Date: Sun, 7 Nov 2021 23:40:22 +0000

On Sun, Nov 07, 2021 at 09:43:24PM +0100, Lars Ingebrigtsen wrote:
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping
> > stretch glyphs in s->next.
> 
> Alan, do you have any comments here?

I asked Po Lu to move the focus call out of ns_dumpglyphs_stretch and
into ns_draw_glyph_string as it's the only caller (in two places) and
it meant we didn't have to handle nested ns_focus calls further down.

I forgot to check this call had been fixed in subsequent patch sets.

So yeah, it's good.
-- 
Alan Third

Message #14 received at 51653 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alan Third <alan <at> idiocy.org>
Cc: Po Lu <luangruo <at> yahoo.com>, 51653 <at> debbugs.gnu.org
Subject: Re: bug#51653: [PATCH] Fix dumping stretch glyph when drawing
 s->next in NS port
Date: Mon, 08 Nov 2021 01:16:53 +0100

Alan Third <alan <at> idiocy.org> writes:

> So yeah, it's good.

Thanks; I've pushed the patch to Emacs 29 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.