GNU bug report logs - #51666
28.0.60; comint-password-prompt-regexp too restrictive (again)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51666 in the body.
You can then email your comments to 51666 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.60; comint-password-prompt-regexp too restrictive (again)
Date: Sun, 07 Nov 2021 17:32:50 +0100

On one of my systems, when using ssh in shell-mode (M-x shell), the
password prompt does not appear in the minibuffer but only in the
*shell* buffer directly under the ssh invocation, and the password is
not hidden when it's entered.  The password prompt has this form:

(user <at> host) Password:

and comint-password-prompt-regexp fails to match it.  By contrast,
eshell-password-prompt-regexp does match this prompt.  This is with
openssh-8.6p1.  The fix in bug#43003 doesn't help here.


In GNU Emacs 28.0.60 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, cairo version 1.17.4)
 of 2021-11-06 built on strobelfs
Repository revision: 0d6b2b0b9dcb958193f21bd5bd3bd389a42b3de2
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Linux From Scratch 10.2-rc1

Configured using:
 'configure --with-native-compilation 'CFLAGS=-Og -g3'
 PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 51666 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 51666 <at> debbugs.gnu.org
Subject: Re: bug#51666: 28.0.60; comint-password-prompt-regexp too
 restrictive (again)
Date: Sun, 07 Nov 2021 21:33:33 +0100

Stephen Berman <stephen.berman <at> gmx.net> writes:

> On one of my systems, when using ssh in shell-mode (M-x shell), the
> password prompt does not appear in the minibuffer but only in the
> *shell* buffer directly under the ssh invocation, and the password is
> not hidden when it's entered.  The password prompt has this form:
>
> (user <at> host) Password:
>
> and comint-password-prompt-regexp fails to match it.  By contrast,
> eshell-password-prompt-regexp does match this prompt.  This is with
> openssh-8.6p1.  The fix in bug#43003 doesn't help here.

The following patch should fix the problem, but I'm a bit wary about
pushing it to Emacs 28, since these things may have unintended side
effects.

So I've pushed it to Emacs 29 instead.

diff --git a/lisp/comint.el b/lisp/comint.el
index c114bdf758..94e8e3b84b 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -385,7 +385,9 @@ comint-password-prompt-regexp
    "\\(?: [[:alpha:]]+ .+\\)?[[:blank:]]*[:：៖][[:space:]]*\\'"
    ;; The ccrypt encryption dialogue doesn't end with a colon, so
    ;; treat it specially.
-   "\\|^Enter encryption key: (repeat) *\\'")
+   "\\|^Enter encryption key: (repeat) *\\'"
+   ;; openssh-8.6p1 format: "(user <at> host) Password:".
+   "\\|^([^)@ \t\n]+@[^)@ \t\n]+) Password: *\\'")
   "Regexp matching prompts for passwords in the inferior process.
 This is used by `comint-watch-for-password-prompt'."
   :version "28.1"


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 51666 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51666 <at> debbugs.gnu.org
Subject: Re: bug#51666: 28.0.60; comint-password-prompt-regexp too
 restrictive (again)
Date: Mon, 08 Nov 2021 11:22:28 +0100

On Sun, 07 Nov 2021 21:33:33 +0100 Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> On one of my systems, when using ssh in shell-mode (M-x shell), the
>> password prompt does not appear in the minibuffer but only in the
>> *shell* buffer directly under the ssh invocation, and the password is
>> not hidden when it's entered.  The password prompt has this form:
>>
>> (user <at> host) Password:
>>
>> and comint-password-prompt-regexp fails to match it.  By contrast,
>> eshell-password-prompt-regexp does match this prompt.  This is with
>> openssh-8.6p1.  The fix in bug#43003 doesn't help here.
>
> The following patch should fix the problem, but I'm a bit wary about
> pushing it to Emacs 28, since these things may have unintended side
> effects.
>
> So I've pushed it to Emacs 29 instead.

FTR, I confirm that this patch fixes the problem for me.  Thanks!

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.