GNU bug report logs -
#51677
[PATCH] gnu: libavif: Restrict dependency on rav1e to x86_64.
Previous Next
Reported by: Vinicius Monego <monego <at> posteo.net>
Date: Mon, 8 Nov 2021 04:27:02 UTC
Severity: normal
Tags: patch
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51677 in the body.
You can then email your comments to 51677 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#51677
; Package
guix-patches
.
(Mon, 08 Nov 2021 04:27:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Vinicius Monego <monego <at> posteo.net>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 08 Nov 2021 04:27:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/image.scm (libavif)[arguments]<#:configure-flags>: Pass
"-DAVIF_CODEC_RAV1E=ON" only on x84_64.
<#:phases>: Don't return #t.
[inputs]: Add rav1e only on x86_64.
---
gnu/packages/image.scm | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index fc021dd2db..ff3963e6f5 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -2182,7 +2182,11 @@ This package can be used to create @code{favicon.ico} files for web sites.")
(build-system cmake-build-system)
(arguments
`(#:configure-flags '("-DAVIF_CODEC_AOM=ON" "-DAVIF_CODEC_DAV1D=ON"
- "-DAVIF_CODEC_RAV1E=ON"
+ ,@(if (string-prefix? "x86_64"
+ (or (%current-target-system)
+ (%current-system)))
+ '("-DAVIF_CODEC_RAV1E=ON")
+ '())
"-DAVIF_BUILD_TESTS=ON")
#:phases
(modify-phases %standard-phases
@@ -2193,12 +2197,16 @@ This package can be used to create @code{favicon.ico} files for web sites.")
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(doc (string-append out "/share/doc/libavif-" ,version)))
- (install-file "../source/README.md" doc)
- #t))))))
+ (install-file "../source/README.md" doc)))))))
(inputs
`(("dav1d" ,dav1d)
("libaom" ,libaom)
- ("rav1e" ,rav1e)))
+ ;; XXX: rav1e depends on rust, which currently only works on x86_64.
+ ;; See also the related configure flag when changing this.
+ ,@(if (string-prefix? "x86_64" (or (%current-target-system)
+ (%current-system)))
+ `(("rav1e" ,rav1e))
+ '())))
(synopsis "Encode and decode AVIF files")
(description "Libavif is a C implementation of @acronym{AVIF, the AV1 Image
File Format}. It can encode and decode all YUV formats and bit depths supported
base-commit: b96ae47bb08f315be8c22f0ee4248dc36c0d6d29
--
2.30.2
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51677
; Package
guix-patches
.
(Mon, 08 Nov 2021 17:34:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 51677 <at> debbugs.gnu.org (full text, mbox):
On Mon, Nov 08, 2021 at 04:26:04AM +0000, Vinicius Monego wrote:
> * gnu/packages/image.scm (libavif)[arguments]<#:configure-flags>: Pass
> "-DAVIF_CODEC_RAV1E=ON" only on x84_64.
> <#:phases>: Don't return #t.
> [inputs]: Add rav1e only on x86_64.
Thanks! Pushed as b6e1ba61042c14c9391514472e436e29b2a5167d
bug closed, send any further explanations to
51677 <at> debbugs.gnu.org and Vinicius Monego <monego <at> posteo.net>
Request was from
Leo Famulari <leo <at> famulari.name>
to
control <at> debbugs.gnu.org
.
(Mon, 08 Nov 2021 17:34:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 07 Dec 2021 12:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 132 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.